3711 2005-06-25 12:58:57 -0700 Displayed PDF have limited options in contextual menu 2011-04-28 12:46:37 -0700 1 1 1 Unclassified WebKit WebKit API 412 Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 59727 1 Hanspeterschaub sullivan c.petersen87 sullivan oldest_to_newest 13148 0 Hanspeterschaub 2005-06-25 12:58:57 -0700 When viewing PDF in the latest builds (6/25/05), there are only very few options available in the contextual menu. In particular, the "View in Preview" option has been removed? I'm running Safari 2.0 with the lastest nightly webkit build. 13243 1 c.petersen87 2005-06-26 09:49:28 -0700 Confirming this issue with TOT Webkit (6/26). The contextual menu that is normally used for viewing PDF is not displayed. I get a generic contextual menu that contains Back, Reload, Save Page as, and Print Page. 13244 2 c.petersen87 2005-06-26 09:51:52 -0700 John: Can you confirm this on TOT ? 13245 3 sullivan 2005-06-26 11:12:26 -0700 When I changed WebKit to use the standard context menu delegate mechanism for the PDF context menu, this changed what appears in the context menu for Safari. The next Safari release will take advantage of this change in the way the PDF context menu works, but the current Safari release ends up not showing the PDF-specific items. Darin, do you think we need to do something about this? I can imagine some hideous hack where WebKit somehow determines that it is running under Safari and that Safari isn't putting the PDF-specific items into the context menu, and forcing them in somehow. I'd rather not implement such a hack though. 13274 4 darin 2005-06-26 21:53:25 -0700 I don't think a Safari-specific hack is a great idea, but if there's anything we can do to help the old Safari do the right thing that might also help other applications, that would be great. Also, there's going to be a long time where WebKit developers outside Apple are going to be using that old Safari with new WebKit, so if there's something straightforward we can do, we should, even if we ultimately don't ship it. If necessary we could even add a preprocessor define that generates a WebKit for better compatibility with old Safari. 13624 5 2738 sullivan 2005-07-01 14:10:08 -0700 Created attachment 2738 patch to always include PDF items for older executables 13626 6 2738 darin 2005-07-01 14:38:12 -0700 Comment on attachment 2738 patch to always include PDF items for older executables Looks cool, r=me. 13627 7 sullivan 2005-07-01 14:47:37 -0700 I found a non-Safari-specific solution that isn't *too* hacky. Hanspeter, please verify that this works for you. 13635 8 Hanspeterschaub 2005-07-01 16:17:05 -0700 Seems to work find in the "old" version of Safari in Tiger. I see the previous contextual menu added after the default items. (In reply to comment #7) > I found a non-Safari-specific solution that isn't *too* hacky. Hanspeter, please verify that this works for > you. 13636 9 sullivan 2005-07-01 16:28:38 -0700 Since the originator has agreed that the problem is fixed, I'm changing this to VERIFIED. 2738 2005-07-01 14:10:08 -0700 2005-07-01 14:38:12 -0700 patch to always include PDF items for older executables 3711_patch.txt text/plain 4627 sullivan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjA5CmRpZmYgLXUgLXAgLXIxLjMyMDkg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMSBKdWwgMjAwNSAwNToyMDo0MyAtMDAwMAkxLjMyMDkK KysrIENoYW5nZUxvZwkxIEp1bCAyMDA1IDIwOjUzOjE3IC0wMDAwCkBAIC0xLDMgKzEsMTkgQEAK KzIwMDUtMDctMDEgIEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICAtIGZpeGVk IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxMTogRGlz cGxheWVkIFBERiBoYXZlIGxpbWl0ZWQgb3B0aW9ucyBpbiBjb250ZXh0dWFsIG1lbnUKKyAgICAg ICAgCisgICAgICAgIFRoaXMgd2FzIGEgcHJvYmxlbSB3aXRoIHVzaW5nIFRpZ2VyJ3MgdmVyc2lv biBvZiBTYWZhcmkgd2l0aCB0aXAgb2YgdHJlZSBXZWJLaXQuCisKKyAgICAgICAgKiBXZWJWaWV3 LnN1YnByb2ovV2ViUERGVmlldy5tOgorICAgICAgICAoLVtXZWJQREZWaWV3IF9hbnlQREZUYWdz Rm91bmRJbk1lbnU6XSk6CisgICAgICAgIG5ldyBtZXRob2QsIHJldHVybnMgWUVTIGlmIHRoZSBt ZW51IGNvbnRhaW5zIGFueSBpdGVtcyB3aXRoIGFueSBvZiB0aGUgbmV3IFBERi1yZWxhdGVkIHRh Z3MuCisgICAgICAgICgtW1dlYlBERlZpZXcgbWVudUZvckV2ZW50Ol0pOgorICAgICAgICBJZiB0 aGUgZXhlY3V0YWJsZSB3YXMgbGlua2VkIG9uIFRpZ2VyIG9yIG9sZGVyIChidXQgaXQgd2lsbCBu ZXZlciBiZSBvbGRlciwgc2luY2UgdGhpcyBjb2RlIGlzCisgICAgICAgIG5ldyB0byBUaWdlciks IGZvcmNlIGFsbCBvZiB0aGUgUERGLXJlbGF0ZWQgaXRlbXMgaW50byB0aGUgbWVudSBpZiBub25l IG9mIHRoZW0gd2VyZSB0aGVyZSAKKyAgICAgICAgYWZ0ZXIgcHJvY2Vzc2luZyBieSB0aGUgZGVs ZWdhdGUuCisKIDIwMDUtMDYtMzAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBXZWJWaWV3LnN1YnByb2ov V2ViUERGVmlldy5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmll dy5zdWJwcm9qL1dlYlBERlZpZXcubSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNApkaWZmIC11 IC1wIC1yMS4xNCBXZWJWaWV3LnN1YnByb2ovV2ViUERGVmlldy5tCi0tLSBXZWJWaWV3LnN1YnBy b2ovV2ViUERGVmlldy5tCTIyIEp1biAyMDA1IDIxOjMyOjA5IC0wMDAwCTEuMTQKKysrIFdlYlZp ZXcuc3VicHJvai9XZWJQREZWaWV3Lm0JMSBKdWwgMjAwNSAyMDo1MzoxNyAtMDAwMApAQCAtMzks NiArMzksNyBAQAogI2ltcG9ydCA8V2ViS2l0L1dlYlZpZXcuaD4KICNpbXBvcnQgPFdlYktpdC9X ZWJWaWV3UHJpdmF0ZS5oPgogCisjaW1wb3J0IDxXZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaD4KICNp bXBvcnQgPFF1YXJ0ei9RdWFydHouaD4KIAogLy8gUXVhcnR6UHJpdmF0ZS5oIGRvZXNuJ3QgaW5j bHVkZSB0aGUgUERGS2l0IHByaXZhdGUgaGVhZGVycywgc28gd2UgY2FuJ3QgZ2V0IGF0IFBERlZp ZXdQcml2LmguICgzOTU3OTcxKQpAQCAtMjMwLDYgKzIzMSwyOCBAQCBzdGF0aWMgdm9pZCBhcHBs aWNhdGlvbkluZm9Gb3JNSU1FVHlwZShOCiAgICAgcmV0dXJuIGNvcGllZEl0ZW1zOwogfQogCist IChCT09MKV9hbnlQREZUYWdzRm91bmRJbk1lbnU6KE5TTWVudSAqKW1lbnUKK3sKKyAgICBOU0Vu dW1lcmF0b3IgKmUgPSBbW21lbnUgaXRlbUFycmF5XSBvYmplY3RFbnVtZXJhdG9yXTsKKyAgICBO U01lbnVJdGVtICppdGVtOworICAgIHdoaWxlICgoaXRlbSA9IFtlIG5leHRPYmplY3RdKSAhPSBu aWwpIHsKKyAgICAgICAgc3dpdGNoIChbaXRlbSB0YWddKSB7CisgICAgICAgICAgICBjYXNlIFdl Yk1lbnVJdGVtVGFnT3BlbldpdGhEZWZhdWx0QXBwbGljYXRpb246CisgICAgICAgICAgICBjYXNl IFdlYk1lbnVJdGVtUERGQWN0dWFsU2l6ZToKKyAgICAgICAgICAgIGNhc2UgV2ViTWVudUl0ZW1Q REZab29tSW46CisgICAgICAgICAgICBjYXNlIFdlYk1lbnVJdGVtUERGWm9vbU91dDoKKyAgICAg ICAgICAgIGNhc2UgV2ViTWVudUl0ZW1QREZBdXRvU2l6ZToKKyAgICAgICAgICAgIGNhc2UgV2Vi TWVudUl0ZW1QREZTaW5nbGVQYWdlOgorICAgICAgICAgICAgY2FzZSBXZWJNZW51SXRlbVBERkZh Y2luZ1BhZ2VzOgorICAgICAgICAgICAgY2FzZSBXZWJNZW51SXRlbVBERkNvbnRpbnVvdXM6Cisg ICAgICAgICAgICBjYXNlIFdlYk1lbnVJdGVtUERGTmV4dFBhZ2U6CisgICAgICAgICAgICBjYXNl IFdlYk1lbnVJdGVtUERGUHJldmlvdXNQYWdlOgorICAgICAgICAgICAgICAgIHJldHVybiBZRVM7 CisgICAgICAgIH0KKyAgICB9CisgICAgcmV0dXJuIE5POworfQorCiAtIChOU01lbnUgKiltZW51 Rm9yRXZlbnQ6KE5TRXZlbnQgKil0aGVFdmVudAogewogICAgIC8vIFN0YXJ0IHdpdGggdGhlIG1l bnUgaXRlbXMgc3VwcGxpZWQgYnkgUERGS2l0LCB3aXRoIFdlYktpdCB0YWdzIGFwcGxpZWQKQEAg LTI1OCw3ICsyODEsMzAgQEAgc3RhdGljIHZvaWQgYXBwbGljYXRpb25JbmZvRm9yTUlNRVR5cGUo TgogICAgIEFTU0VSVCh3ZWJWaWV3KTsKICAgICAvLyBDdXJyZW50bHkgY2xpY2tzIGFueXdoZXJl IGluIHRoZSBQREYgdmlldyBhcmUgdHJlYXRlZCB0aGUgc2FtZSwgc28gd2UganVzdCBwYXNzIE5T WmVyb1BvaW50OwogICAgIC8vIHdlIGltcGxlbWVudCBlbGVtZW50QXRQb2ludDogaGVyZSBqdXN0 IHRvIGJlIHNsaWdodGx5IGZvcndhcmQtbG9va2luZy4KLSAgICByZXR1cm4gW3dlYlZpZXcgX21l bnVGb3JFbGVtZW50OltzZWxmIGVsZW1lbnRBdFBvaW50Ok5TWmVyb1BvaW50XSBkZWZhdWx0SXRl bXM6aXRlbXNdOworICAgIE5TTWVudSAqbWVudSA9IFt3ZWJWaWV3IF9tZW51Rm9yRWxlbWVudDpb c2VsZiBlbGVtZW50QXRQb2ludDpOU1plcm9Qb2ludF0gZGVmYXVsdEl0ZW1zOml0ZW1zXTsKKyAg ICAKKyAgICAvLyBUaGUgZGVsZWdhdGUgaGFzIG5vdyBoYWQgdGhlIG9wcG9ydHVuaXR5IHRvIGFk ZCBpdGVtcyB0byB0aGUgc3RhbmRhcmQgUERGLXJlbGF0ZWQgaXRlbXMsIG9yIHRvCisgICAgLy8g cmVtb3ZlIG9yIG1vZGlmeSBzb21lIG9mIHRoZSBQREYtcmVsYXRlZCBpdGVtcy4gSW4gMTAuNCwg dGhlIFBERiBjb250ZXh0IG1lbnUgZGlkIG5vdCBnbyB0aHJvdWdoIAorICAgIC8vIHRoZSBzdGFu ZGFyZCBXZWJLaXQgZGVsZWdhdGUgcGF0aCwgYW5kIHNvIHRoZSBzdGFuZGFyZCBQREYtcmVsYXRl ZCBpdGVtcyBhbHdheXMgYXBwZWFyZWQuIEZvcgorICAgIC8vIGNsaWVudHMgdGhhdCBjcmVhdGUg dGhlaXIgb3duIGNvbnRleHQgbWVudSBieSBoYW5kLXBpY2tpbmcgc3BlY2lmaWMgaXRlbXMgZnJv bSB0aGUgZGVmYXVsdCBsaXN0LCBzdWNoIGFzCisgICAgLy8gU2FmYXJpLCBub25lIG9mIHRoZSBQ REYtcmVsYXRlZCBpdGVtcyB3aWxsIGFwcGVhciB1bnRpbCB0aGUgY2xpZW50IGlzIHJld3JpdHRl biB0byBleHBsaWNpdGx5CisgICAgLy8gaW5jbHVkZSB0aGVzZSBpdGVtcy4gU28gZm9yIGJhY2t3 YXJkcyBjb21wYXRpYmlsaXR5IHdlJ3JlIGdvaW5nIHRvIGluY2x1ZGUgdGhlIGVudGlyZSBzZXQg b2YgUERGLXJlbGF0ZWQKKyAgICAvLyBpdGVtcyBpZiB0aGUgZXhlY3V0YWJsZSB3YXMgbGlua2Vk IGluIDEwLjQgb3IgZWFybGllciBhbmQgdGhlIG1lbnUgcmV0dXJuZWQgZnJvbSB0aGUgZGVsZWdh dGUgbWVjaGFuaXNtCisgICAgLy8gY29udGFpbnMgbm9uZSBvZiB0aGUgUERGLXJlbGF0ZWQgaXRl bXMuCisgICAgaWYgKFdLRXhlY3V0YWJsZUxpbmtlZEluVGlnZXJPckVhcmxpZXIoKSkgeworICAg ICAgICBpZiAoIVtzZWxmIF9hbnlQREZUYWdzRm91bmRJbk1lbnU6bWVudV0pIHsKKyAgICAgICAg ICAgIFttZW51IGFkZEl0ZW06W05TTWVudUl0ZW0gc2VwYXJhdG9ySXRlbV1dOworICAgICAgICAg ICAgTlNFbnVtZXJhdG9yICplID0gW2l0ZW1zIG9iamVjdEVudW1lcmF0b3JdOworICAgICAgICAg ICAgTlNNZW51SXRlbSAqbWVudUl0ZW07CisgICAgICAgICAgICB3aGlsZSAoKG1lbnVJdGVtID0g W2UgbmV4dE9iamVjdF0pICE9IG5pbCkgeworICAgICAgICAgICAgICAgIC8vIGNvcHkgbWVudUl0 ZW0gc2luY2UgYSBnaXZlbiBtZW51SXRlbSBjYW4gYmUgaW4gb25seSBvbmUgbWVudSBhdCBhIHRp bWUsIGFuZCB3ZSBkb24ndAorICAgICAgICAgICAgICAgIC8vIHdhbnQgdG8gbWVzcyB3aXRoIHRo ZSBtZW51IHJldHVybmVkIGZyb20gUERGS2l0LgorICAgICAgICAgICAgICAgIFttZW51IGFkZEl0 ZW06W21lbnVJdGVtIGNvcHldXTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0KKyAg ICAKKyAgICByZXR1cm4gbWVudTsKIH0KIAogLSAodm9pZClfdXBkYXRlU2NhbGluZ1RvUmVmbGVj dFRleHRTaXplCg==