37106 2010-04-05 12:45:31 -0700 Turns out commit_info.committer() can be None 2010-04-06 23:46:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth commit-queue eric webkit.review.bot oldest_to_newest 208648 0 abarth 2010-04-05 12:45:31 -0700 Turns out commit_info.committer() can be None 208649 1 52558 abarth 2010-04-05 12:46:37 -0700 Created attachment 52558 Patch 208651 2 52558 eric 2010-04-05 12:49:44 -0700 Comment on attachment 52558 Patch OK. 208933 3 52558 commit-queue 2010-04-06 00:18:44 -0700 Comment on attachment 52558 Patch Rejecting patch 52558 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: itTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/webkitpy/common/checkout/commitinfo.py patching file WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py Hunk #1 succeeded at 87 with fuzz 2. patching file WebKitTools/Scripts/webkitpy/tool/bot/sheriff_unittest.py Hunk #1 FAILED at 68. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/bot/sheriff_unittest.py.rej patching file WebKitTools/Scripts/webkitpy/tool/commands/queries.py Full output: http://webkit-commit-queue.appspot.com/results/1533270 208941 4 webkit.review.bot 2010-04-06 01:14:27 -0700 http://trac.webkit.org/changeset/57132 might have broken Tiger Intel Release 209476 5 eric 2010-04-06 23:45:46 -0700 Attachment 52558 was posted by a committer and has review+, assigning to Adam Barth for commit. 52558 2010-04-05 12:46:37 -0700 2010-04-06 00:18:44 -0700 Patch bug-37106-20100405124635.patch text/plain 5035 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3MDkwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMDUgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUdXJucyBvdXQgY29tbWl0X2luZm8uY29tbWl0dGVyKCkgY2FuIGJlIE5vbmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTA2CisKKyAg ICAgICAgV2hlbiB0aGUgY29tbWl0dGVyIGlzbid0IGluIGNvbW1pdHRlcnMucHksIHRoZSBjb21t aXR0ZXIoKSBwcm9wZXJ0eSBvbgorICAgICAgICBjb21taXRfaW5mbyBjYW4gYmUgTm9uZS4gIFdl IG5lZWQgdG8gaGFuZGxlIHRoYXQgY2FzZSBncmFjZWZ1bGx5LgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY29tbWl0aW5mby5weToKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmYucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9zaGVyaWZmX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5OgorCiAyMDEwLTA0LTA1ICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIEFkZCBWaXRhbHkg UmVwZXNoa28gYXMgYSBjb21taXR0ZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9jb21taXRpbmZvLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NvbW1pdGluZm8ucHkJKHJldmlz aW9uIDU3MDg2KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvY29tbWl0aW5mby5weQkod29ya2luZyBjb3B5KQpAQCAtNTEsMTYgKzUxLDE2IEBAIGNsYXNz IENvbW1pdEluZm8ob2JqZWN0KToKICAgICAgICAgcmV0dXJuIHNlbGYuX3JldmlzaW9uCiAKICAg ICBkZWYgY29tbWl0dGVyKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5fY29tbWl0dGVyICMg U2hvdWxkIG5ldmVyIGJlIE5vbmUKKyAgICAgICAgcmV0dXJuIHNlbGYuX2NvbW1pdHRlciAgIyBO b25lIGlmIGNvbW1pdHRlciBpc24ndCBpbiBjb21taXR0ZXJzLnB5CiAKICAgICBkZWYgY29tbWl0 dGVyX2VtYWlsKHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fY29tbWl0dGVyX2VtYWlsCiAK ICAgICBkZWYgYnVnX2lkKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5fYnVnX2lkICMgTWF5 IGJlIE5vbmUKKyAgICAgICAgcmV0dXJuIHNlbGYuX2J1Z19pZCAgIyBNYXkgYmUgTm9uZQogCiAg ICAgZGVmIGF1dGhvcihzZWxmKToKLSAgICAgICAgcmV0dXJuIHNlbGYuX2F1dGhvciAjIE1heSBi ZSBOb25lCisgICAgICAgIHJldHVybiBzZWxmLl9hdXRob3IgICMgTWF5IGJlIE5vbmUKIAogICAg IGRlZiBhdXRob3JfbmFtZShzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX2F1dGhvcl9uYW1l CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmYucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVy aWZmLnB5CShyZXZpc2lvbiA1NzA4NikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9ib3Qvc2hlcmlmZi5weQkod29ya2luZyBjb3B5KQpAQCAtODcsMTMgKzg3LDEyIEBAIGNs YXNzIFNoZXJpZmYob2JqZWN0KToKICAgICBkZWYgcG9zdF9hdXRvbWF0aWNfcm9sbG91dF9wYXRj aChzZWxmLCBjb21taXRfaW5mbywgYnVpbGRlcnMpOgogICAgICAgICAjIEZvciBub3cgd2UncmUg b25seSBwb3N0aW5nIHJvbGxvdXQgcGF0Y2hlcyBmb3IgY29tbWl0LXF1ZXVlIHBhdGNoZXMuCiAg ICAgICAgIGNvbW1pdF9ib3RfZW1haWwgPSAiZXNlaWRlbEBjaHJvbWl1bS5vcmciCi0gICAgICAg IGlmIGNvbW1pdF9ib3RfZW1haWwgbm90IGluIGNvbW1pdF9pbmZvLmNvbW1pdHRlcigpLmVtYWls czoKLSAgICAgICAgICAgIHJldHVybgotICAgICAgICB0cnk6Ci0gICAgICAgICAgICBzZWxmLnBv c3Rfcm9sbG91dF9wYXRjaChjb21taXRfaW5mby5yZXZpc2lvbigpLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2VsZi5fcm9sbG91dF9yZWFzb24oYnVpbGRlcnMpKQotICAg ICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6Ci0gICAgICAgICAgICBsb2coIkZhaWxlZCB0byBj cmVhdGUtcm9sbG91dC4iKQorICAgICAgICBpZiBjb21taXRfYm90X2VtYWlsID09IGNvbW1pdF9p bmZvLmNvbW1pdHRlcl9lbWFpbCgpOgorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAg IHNlbGYucG9zdF9yb2xsb3V0X3BhdGNoKGNvbW1pdF9pbmZvLnJldmlzaW9uKCksCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fcm9sbG91dF9yZWFzb24oYnVp bGRlcnMpKQorICAgICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgorICAgICAgICAgICAg ICAgIGxvZygiRmFpbGVkIHRvIGNyZWF0ZS1yb2xsb3V0LiIpCiAKICAgICBkZWYgcG9zdF9ibGFt ZV9jb21tZW50X29uX2J1ZyhzZWxmLCBjb21taXRfaW5mbywgYnVpbGRlcnMpOgogICAgICAgICBp ZiBub3QgY29tbWl0X2luZm8uYnVnX2lkKCk6CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmX3VuaXR0ZXN0LnB5CShyZXZp c2lvbiA1NzA4NikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hl cmlmZl91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNjgsMyArNjgsMTggQEAgY2xhc3Mg U2hlcmlmZlRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAjIFNob3VsZCB0cnkgdG8g cG9zdCBhIGNvbW1lbnQgdG8gdGhlIGJ1ZywgYnV0IE1vY2tUb29sLmJ1Z3MgZG9lcyBub3RoaW5n LgogICAgICAgICBjb21taXRfaW5mby5idWdfaWQgPSBsYW1iZGE6IDEyMzQKICAgICAgICAgc2hl cmlmZi5wb3N0X2JsYW1lX2NvbW1lbnRfb25fYnVnKGNvbW1pdF9pbmZvLCBidWlsZGVycykKKwor ICAgIGRlZiB0ZXN0X3Bvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoc2VsZik6CisgICAgICAgIHNo ZXJpZmYgPSBTaGVyaWZmKE1vY2tUb29sKCksIE1vY2tTaGVyaWZmQm90KCkpCisgICAgICAgIGJ1 aWxkZXJzID0gWworICAgICAgICAgICAgQnVpbGRlcigiRm9vIiwgTm9uZSksCisgICAgICAgICAg ICBCdWlsZGVyKCJCYXIiLCBOb25lKSwKKyAgICAgICAgXQorICAgICAgICBjb21taXRfaW5mbyA9 IE1vY2soKQorICAgICAgICBjb21taXRfaW5mby5idWdfaWQgPSBsYW1iZGE6IE5vbmUKKyAgICAg ICAgY29tbWl0X2luZm8ucmV2aXNpb24gPSBsYW1iZGE6IDQzMjEKKyAgICAgICAgY29tbWl0X2lu Zm8uY29tbWl0dGVyID0gbGFtYmRhOiBOb25lCisgICAgICAgIGNvbW1pdF9pbmZvLmNvbW1pdHRl cl9lbWFpbCA9IGxhbWJkYTogImZvb0BleGFtcGxlLmNvbSIKKyAgICAgICAgY29tbWl0X2luZm8u cmV2aWV3ZXIgPSBsYW1iZGE6IE5vbmUKKyAgICAgICAgY29tbWl0X2luZm8uYXV0aG9yID0gbGFt YmRhOiBOb25lCisgICAgICAgIHNoZXJpZmYucG9zdF9hdXRvbWF0aWNfcm9sbG91dF9wYXRjaChj b21taXRfaW5mbywgYnVpbGRlcnMpCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weQkocmV2aXNpb24gNTcwODYpCisr KyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weQko d29ya2luZyBjb3B5KQpAQCAtMTI4LDcgKzEyOCw3IEBAIGNsYXNzIFdoYXRCcm9rZShBYnN0cmFj dERlY2xhcmF0aXZlQ29tbWEKICAgICAgICAgYXV0aG9yX2xpbmUgPSAiXCIlc1wiIDwlcz4iICUg KGNvbW1pdF9pbmZvLmF1dGhvcl9uYW1lKCksIGNvbW1pdF9pbmZvLmF1dGhvcl9lbWFpbCgpKQog ICAgICAgICBwcmludCAiICBBdXRob3I6ICVzIiAlIChjb21taXRfaW5mby5hdXRob3IoKSBvciBh dXRob3JfbGluZSkKICAgICAgICAgcHJpbnQgIiAgUmV2aWV3ZXI6ICVzIiAlIChjb21taXRfaW5m by5yZXZpZXdlcigpIG9yIGNvbW1pdF9pbmZvLnJldmlld2VyX3RleHQoKSkKLSAgICAgICAgcHJp bnQgIiAgQ29tbWl0dGVyOiAlcyIgJSBjb21taXRfaW5mby5jb21taXR0ZXIoKQorICAgICAgICBw cmludCAiICBDb21taXR0ZXI6ICVzIiAlIChjb21taXRfaW5mby5jb21taXR0ZXIoKSBvciBjb21t aXRfaW5mby5jb21taXR0ZXJfZW1haWwoKSkKIAogICAgICMgRklYTUU6IFRoaXMgaXMgc2xpZ2h0 bHkgZGlmZmVyZW50IGZyb20gQnVpbGRlci5ibGFtZXdvcnRoeV9yZXZpc2lvbnMKICAgICAjIGR1 ZSB0byBuZWVkaW5nIHRvIGRldGVjdCB0aGUgImhpdCB0aGUgbGltaXQiIGNhc2UgYW4gcHJpbnQg YSBzcGVjaWFsIG1lc3NhZ2UuCg==