37098 2010-04-05 10:38:51 -0700 A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot 2010-04-07 14:36:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric zmo cmarrin commit-queue dglazkov fishd kbr oliver oldest_to_newest 208555 0 eric 2010-04-05 10:38:51 -0700 fast/canvas/webgl/drawArraysOutOfBounds.html failed on Leopard Commit Bot https://bugs.webkit.org/show_bug.cgi?id=37064#c3 /tmp/layout-test-results/fast/canvas/webgl/drawArraysOutOfBounds-actual.txt 1313 PASS context.drawArrays(context.TRIANGLES, -1, 1) threw exception GL error 1282 in drawArrays. 1414 1515 Test buffer with 3 float vectors 16 PASS context.drawArrays(context.TRIANGLES, 0, 3) is undefined 16 FAIL context.drawArrays(context.TRIANGLES, 0, 3) should be undefined. Threw exception GL error 1286 in drawArrays 1717 PASS context.drawArrays(context.TRIANGLES, 3, 2) threw exception GL error 1282 in drawArrays. 1818 PASS context.drawArrays(context.TRIANGLES, 0, 10000) threw exception GL error 1282 in drawArrays. 1919 PASS context.drawArrays(context.TRIANGLES, 0, 10000000000000) threw exception GL error 1282 in drawArrays. Probably more/same driver bugs. This may need to be duped against other recent webgl failures. 209777 1 52768 zmo 2010-04-07 12:22:19 -0700 Created attachment 52768 patch We turn off stencil/antialias by default for tests that create canvas dynamically. This should tremendously reduce the probability of test failure, hopefully next to zero. The true cause of these failures are very likely a driver bug in Mac where multi-threading competition is on. We could turn them on again when this driver bug is fixed. We filed another bug for this driver bug: https://bugs.webkit.org/show_bug.cgi?id=36972 209781 2 52770 zmo 2010-04-07 12:28:51 -0700 Created attachment 52770 revised patch: fixed a typo 209805 3 52770 eric 2010-04-07 13:23:33 -0700 Comment on attachment 52770 revised patch: fixed a typo The JS change need a FIXME comment next to it with a link to one of these bugs. Also, why not just do if (!attrs) instead of checking for typeof == undefined? 209815 4 zmo 2010-04-07 13:46:31 -0700 (In reply to comment #3) > (From update of attachment 52770 [details]) > The JS change need a FIXME comment next to it with a link to one of these bugs. > I'll add it. Thanks. > Also, why not just do if (!attrs) instead of checking for typeof == undefined? The reason for using typeof==undefined instead of (!attrs) is the latter could be a intended null/0 input, whereas the former always indicates a default value situation. 209816 5 52779 zmo 2010-04-07 13:50:07 -0700 Created attachment 52779 revised patch: add a FIXME comment 209818 6 kbr 2010-04-07 13:53:41 -0700 (In reply to comment #5) > Created an attachment (id=52779) [details] > revised patch: add a FIXME comment Patch looks good. Please update the synopsis of this bug to match that in the ChangeLog. 209850 7 52779 commit-queue 2010-04-07 14:35:55 -0700 Comment on attachment 52779 revised patch: add a FIXME comment Clearing flags on attachment: 52779 Committed r57234: <http://trac.webkit.org/changeset/57234> 209851 8 commit-queue 2010-04-07 14:36:02 -0700 All reviewed patches have been landed. Closing bug. 52768 2010-04-07 12:22:19 -0700 2010-04-07 12:28:51 -0700 patch off.patch text/plain 1936 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3MjIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDcgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBIGZldyB0ZXN0cyBpbiBmYXN0L2NhbnZhcy93ZWJnbCBmYWlsZWQgcmFuZG9tbHkgb24g TGVvcGFyZCBDb21taXQgQm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNzA5OAorCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2Vz L3dlYmdsLXRlc3QuanM6IFR1cm4gb2ZmIHN0ZW5jaWwvYW50aWFsaWFzIGJ5IGRlZmF1bHQuCisg ICAgICAgIChjcmVhdGUzRENvbnRleHQpOgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Nj cmlwdC10ZXN0cy9pbmRleC12YWxpZGF0aW9uLmpzOiBCeSBkZWZhdWx0IGFudGlhbGlhcyBpcyBv ZmYuCisKIDIwMTAtMDQtMDcgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBza2lwcGluZyBmYXN0L21lZGlhL21lZGlhLWZlYXR1 cmUtd2d0LXZpZXctbW9kZS5odG1sIGZvciBDaHJvbWl1bS4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10ZXN0LmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10ZXN0LmpzCShyZXZp c2lvbiA1NzIxNikKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93 ZWJnbC10ZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC05LDYgKzksOCBAQCBmdW5jdGlvbiBnZXRT aGFkZXJTb3VyY2UoZmlsZSkgewogfQogCiBmdW5jdGlvbiBjcmVhdGUzRENvbnRleHQoYXR0cnMp IHsKKyAgICBpZiAodHlwZW9mKGF0dHJzKSA9PSAidW5kZWZpbmVkIikKKyAgICAgICAgYXR0cnMg PSB7IHN0ZW5jaWw6IGZhbHNlLCBhbnRpYWxpczogZmFsc2UgfTsKICAgICB2YXIgY2FudmFzID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiY2FudmFzIik7CiAgICAgdHJ5IHsKICAgICAgICAgcmV0 dXJuIGNhbnZhcy5nZXRDb250ZXh0KCJleHBlcmltZW50YWwtd2ViZ2wiLCBhdHRycyk7CkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9zY3JpcHQtdGVzdHMvaW5kZXgtdmFsaWRh dGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9zY3Jp cHQtdGVzdHMvaW5kZXgtdmFsaWRhdGlvbi5qcwkocmV2aXNpb24gNTcyMTYpCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9zY3JpcHQtdGVzdHMvaW5kZXgtdmFsaWRhdGlvbi5qcwko d29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDYgQEAKIGRlc2NyaXB0aW9uKCJUZXN0IG9mIGdldCBj YWxscyBhZ2FpbnN0IEdMIG9iamVjdHMgbGlrZSBnZXRCdWZmZXJQYXJhbWV0ZXIsIGV0Yy4iKTsK IAotdmFyIGdsID0gY3JlYXRlM0RDb250ZXh0KHsgYW50aWFsaWFzOiBmYWxzZSB9KTsKK3ZhciBn bCA9IGNyZWF0ZTNEQ29udGV4dCgpOwogdmFyIHByb2dyYW0gPSBsb2FkU3RhbmRhcmRQcm9ncmFt KGdsKTsKIAogLy8gMyB2ZXJ0aWNlcyA9PiAxIHRyaWFuZ2xlLCBpbnRlcmxlYXZlZCBkYXRhCg== 52770 2010-04-07 12:28:51 -0700 2010-04-07 13:50:07 -0700 revised patch: fixed a typo off.patch text/plain 1937 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3MjIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDcgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBIGZldyB0ZXN0cyBpbiBmYXN0L2NhbnZhcy93ZWJnbCBmYWlsZWQgcmFuZG9tbHkgb24g TGVvcGFyZCBDb21taXQgQm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNzA5OAorCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2Vz L3dlYmdsLXRlc3QuanM6IFR1cm4gb2ZmIHN0ZW5jaWwvYW50aWFsaWFzIGJ5IGRlZmF1bHQuCisg ICAgICAgIChjcmVhdGUzRENvbnRleHQpOgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Nj cmlwdC10ZXN0cy9pbmRleC12YWxpZGF0aW9uLmpzOiBCeSBkZWZhdWx0IGFudGlhbGlhcyBpcyBv ZmYuCisKIDIwMTAtMDQtMDcgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBza2lwcGluZyBmYXN0L21lZGlhL21lZGlhLWZlYXR1 cmUtd2d0LXZpZXctbW9kZS5odG1sIGZvciBDaHJvbWl1bS4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10ZXN0LmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10ZXN0LmpzCShyZXZp c2lvbiA1NzIxNikKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93 ZWJnbC10ZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC05LDYgKzksOCBAQCBmdW5jdGlvbiBnZXRT aGFkZXJTb3VyY2UoZmlsZSkgewogfQogCiBmdW5jdGlvbiBjcmVhdGUzRENvbnRleHQoYXR0cnMp IHsKKyAgICBpZiAodHlwZW9mKGF0dHJzKSA9PSAidW5kZWZpbmVkIikKKyAgICAgICAgYXR0cnMg PSB7IHN0ZW5jaWw6IGZhbHNlLCBhbnRpYWxpYXM6IGZhbHNlIH07CiAgICAgdmFyIGNhbnZhcyA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZhcyIpOwogICAgIHRyeSB7CiAgICAgICAgIHJl dHVybiBjYW52YXMuZ2V0Q29udGV4dCgiZXhwZXJpbWVudGFsLXdlYmdsIiwgYXR0cnMpOwpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZhbGlk YXRpb24uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2Ny aXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24uanMJKHJldmlzaW9uIDU3MjE2KQorKysgTGF5b3V0 VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24uanMJ KHdvcmtpbmcgY29weSkKQEAgLTEsNiArMSw2IEBACiBkZXNjcmlwdGlvbigiVGVzdCBvZiBnZXQg Y2FsbHMgYWdhaW5zdCBHTCBvYmplY3RzIGxpa2UgZ2V0QnVmZmVyUGFyYW1ldGVyLCBldGMuIik7 CiAKLXZhciBnbCA9IGNyZWF0ZTNEQ29udGV4dCh7IGFudGlhbGlhczogZmFsc2UgfSk7Cit2YXIg Z2wgPSBjcmVhdGUzRENvbnRleHQoKTsKIHZhciBwcm9ncmFtID0gbG9hZFN0YW5kYXJkUHJvZ3Jh bShnbCk7CiAKIC8vIDMgdmVydGljZXMgPT4gMSB0cmlhbmdsZSwgaW50ZXJsZWF2ZWQgZGF0YQo= 52779 2010-04-07 13:50:07 -0700 2010-04-07 14:35:55 -0700 revised patch: add a FIXME comment off.patch text/plain 2081 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3MjIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDcgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBIGZldyB0ZXN0cyBpbiBmYXN0L2NhbnZhcy93ZWJnbCBmYWlsZWQgcmFuZG9tbHkgb24g TGVvcGFyZCBDb21taXQgQm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNzA5OAorCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2Vz L3dlYmdsLXRlc3QuanM6IFR1cm4gb2ZmIHN0ZW5jaWwvYW50aWFsaWFzIGJ5IGRlZmF1bHQuCisg ICAgICAgIChjcmVhdGUzRENvbnRleHQpOgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Nj cmlwdC10ZXN0cy9pbmRleC12YWxpZGF0aW9uLmpzOiBCeSBkZWZhdWx0IGFudGlhbGlhcyBpcyBv ZmYuCisKIDIwMTAtMDQtMDcgIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBza2lwcGluZyBmYXN0L21lZGlhL21lZGlhLWZlYXR1 cmUtd2d0LXZpZXctbW9kZS5odG1sIGZvciBDaHJvbWl1bS4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10ZXN0LmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93ZWJnbC10ZXN0LmpzCShyZXZp c2lvbiA1NzIxNikKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93 ZWJnbC10ZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC05LDYgKzksMTAgQEAgZnVuY3Rpb24gZ2V0 U2hhZGVyU291cmNlKGZpbGUpIHsKIH0KIAogZnVuY3Rpb24gY3JlYXRlM0RDb250ZXh0KGF0dHJz KSB7CisgICAgLy8gRklYTUU6IHNldHRpbmcgZGVmYXVsdCBhdHRyaWJ1dGVzIGJhY2sgdG8gYWxs IHRydWUgd2hlbiB0aGUgZHJpdmVyIGJ1ZyBpcyBmaXhlZC4KKyAgICAvLyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwOTgKKyAgICBpZiAodHlwZW9mKGF0dHJzKSA9 PSAidW5kZWZpbmVkIikKKyAgICAgICAgYXR0cnMgPSB7IHN0ZW5jaWw6IGZhbHNlLCBhbnRpYWxp YXM6IGZhbHNlIH07CiAgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNh bnZhcyIpOwogICAgIHRyeSB7CiAgICAgICAgIHJldHVybiBjYW52YXMuZ2V0Q29udGV4dCgiZXhw ZXJpbWVudGFsLXdlYmdsIiwgYXR0cnMpOwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv d2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24uanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24u anMJKHJldmlzaW9uIDU3MjE2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2Ny aXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24uanMJKHdvcmtpbmcgY29weSkKQEAgLTEsNiArMSw2 IEBACiBkZXNjcmlwdGlvbigiVGVzdCBvZiBnZXQgY2FsbHMgYWdhaW5zdCBHTCBvYmplY3RzIGxp a2UgZ2V0QnVmZmVyUGFyYW1ldGVyLCBldGMuIik7CiAKLXZhciBnbCA9IGNyZWF0ZTNEQ29udGV4 dCh7IGFudGlhbGlhczogZmFsc2UgfSk7Cit2YXIgZ2wgPSBjcmVhdGUzRENvbnRleHQoKTsKIHZh ciBwcm9ncmFtID0gbG9hZFN0YW5kYXJkUHJvZ3JhbShnbCk7CiAKIC8vIDMgdmVydGljZXMgPT4g MSB0cmlhbmdsZSwgaW50ZXJsZWF2ZWQgZGF0YQo=