37088 2010-04-05 08:42:52 -0700 Fix some "explicit braces to avoid ambiguous 'else'" warnings 2010-04-05 08:55:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 1 tonikitoo tonikitoo laszlo.gombos oldest_to_newest 208489 0 tonikitoo 2010-04-05 08:42:52 -0700 it'd be good shut up some compiler warnings. ./../../../WebCore/dom/Node.cpp: In member function 'bool WebCore::Node::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>)': ../../../../WebCore/dom/Node.cpp:2614: warning: suggest explicit braces to avoid ambiguous 'else' uninitialized in this function (...) ../../../../WebCore/page/DOMWindow.cpp: In member function 'bool WebCore::DOMWindow::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::EventTarget>)': ../../../../WebCore/page/DOMWindow.cpp:1437: warning: suggest explicit braces to avoid ambiguous 'else' ../../../../WebCore/platform/UUID.cpp: In function 'WebCore::String WebCore::createCanonicalUUIDString()': 208492 1 52536 tonikitoo 2010-04-05 08:45:12 -0700 Created attachment 52536 (committed in r57077) patch 208494 2 52536 darin 2010-04-05 08:45:51 -0700 Comment on attachment 52536 (committed in r57077) patch These are braces, not parentheses. I'm happy that the compiler warnings happen to match our coding style. 208495 3 tonikitoo 2010-04-05 08:48:38 -0700 thx darin! i will fix ChangeLog before landing 52536 2010-04-05 08:45:12 -0700 2010-04-05 08:54:54 -0700 (committed in r57077) patch 0001-Missing-explicit-parathesis-for-avoid-compiler-warni.patch text/plain 2784 tonikitoo RnJvbSBkYzIwODVmNGEwYzFkYjkxMDhkZGNmNDVkMmQzODAzYzE3OWY3MDJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCA1IEFwciAyMDEwIDExOjQ0OjE3IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gTWlz c2luZyBleHBsaWNpdCBwYXJhdGhlc2lzIGZvciBhdm9pZCBjb21waWxlciB3YXJuaW5ncwogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MDg4CgpSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25pbyBHb21lcyAodG9uaWtpdG9vQHdlYmtpdC5v cmcpCgoqIGRvbS9Ob2RlLmNwcDoKKFdlYkNvcmU6Ok5vZGU6OmRpc3BhdGNoR2VuZXJpY0V2ZW50 KToKKiBwYWdlL0RPTVdpbmRvdy5jcHA6CihXZWJDb3JlOjpET01XaW5kb3c6OmRpc3BhdGNoRXZl bnQpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysK IFdlYkNvcmUvZG9tL05vZGUuY3BwICAgICAgIHwgICAgMyArKy0KIFdlYkNvcmUvcGFnZS9ET01X aW5kb3cuY3BwIHwgICAgMyArKy0KIDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDNmODBkOGMuLjhiZjI1Y2QgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MDUgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNaXNzaW5nIGV4cGxpY2l0IHBhcmF0 aGVzaXMgZm9yIGF2b2lkIGNvbXBpbGVyIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzA4OAorCisgICAgICAgICogZG9tL05vZGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZGlzcGF0Y2hHZW5lcmljRXZlbnQpOgorICAgICAg ICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6ZGlz cGF0Y2hFdmVudCk6CisKIDIwMTAtMDQtMDEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggYTk1 ZmYzOS4uZDVlMzk1ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvV2Vi Q29yZS9kb20vTm9kZS5jcHAKQEAgLTI2MTEsMTEgKzI2MTEsMTIgQEAgYm9vbCBOb2RlOjpkaXNw YXRjaEdlbmVyaWNFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVudCkKIAogI2lmIEVOQUJM RShJTlNQRUNUT1IpCiAgICAgUGFnZSogaW5zcGVjdGVkUGFnZSA9IEluc3BlY3RvclRpbWVsaW5l QWdlbnQ6Omluc3RhbmNlQ291bnQoKSA/IGRvY3VtZW50KCktPnBhZ2UoKSA6IDA7Ci0gICAgaWYg KGluc3BlY3RlZFBhZ2UpCisgICAgaWYgKGluc3BlY3RlZFBhZ2UpIHsKICAgICAgICAgaWYgKElu c3BlY3RvclRpbWVsaW5lQWdlbnQqIHRpbWVsaW5lQWdlbnQgPSBldmVudEhhc0xpc3RlbmVycyhl dmVudC0+dHlwZSgpLCB0YXJnZXRGb3JXaW5kb3dFdmVudHMsIHRoaXMsIGFuY2VzdG9ycykgPyBp bnNwZWN0ZWRQYWdlLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCkgOiAwKQogICAgICAgICAgICAg dGltZWxpbmVBZ2VudC0+d2lsbERpc3BhdGNoRXZlbnQoKmV2ZW50KTsKICAgICAgICAgZWxzZQog ICAgICAgICAgICAgaW5zcGVjdGVkUGFnZSA9IDA7CisgICAgfQogI2VuZGlmCiAKICAgICAvLyBH aXZlIHRoZSB0YXJnZXQgbm9kZSBhIGNoYW5jZSB0byBkbyBzb21lIHdvcmsgYmVmb3JlIERPTSBl dmVudCBoYW5kbGVycyBnZXQgYSBjcmFjay4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9ET01X aW5kb3cuY3BwIGIvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKaW5kZXggN2VkM2YwOC4uMDI5 ODk0MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvV2ViQ29y ZS9wYWdlL0RPTVdpbmRvdy5jcHAKQEAgLTE0MzQsMTEgKzE0MzQsMTIgQEAgYm9vbCBET01XaW5k b3c6OmRpc3BhdGNoRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gcHJwRXZlbnQsIFBhc3NSZWZQdHI8 RXZlbnRUYXJnZXQKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgUGFnZSogaW5zcGVjdGVk UGFnZSA9IEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6Omluc3RhbmNlQ291bnQoKSAmJiBmcmFtZSgp ID8gZnJhbWUoKS0+cGFnZSgpIDogMDsKLSAgICBpZiAoaW5zcGVjdGVkUGFnZSkKKyAgICBpZiAo aW5zcGVjdGVkUGFnZSkgewogICAgICAgICBpZiAoSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGlt ZWxpbmVBZ2VudCA9IGhhc0V2ZW50TGlzdGVuZXJzKGV2ZW50LT50eXBlKCkpID8gaW5zcGVjdGVk UGFnZS0+aW5zcGVjdG9yVGltZWxpbmVBZ2VudCgpIDogMCkKICAgICAgICAgICAgIHRpbWVsaW5l QWdlbnQtPndpbGxEaXNwYXRjaEV2ZW50KCpldmVudCk7CiAgICAgICAgIGVsc2UKICAgICAgICAg ICAgIGluc3BlY3RlZFBhZ2UgPSAwOworICAgIH0KICNlbmRpZgogCiAgICAgYm9vbCByZXN1bHQg PSBmaXJlRXZlbnRMaXN0ZW5lcnMoZXZlbnQuZ2V0KCkpOwotLSAKMS42LjAuNAoK