37084 2010-04-05 06:55:56 -0700 [Qt] Do not cache network connections per username. 2012-05-18 06:53:34 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 62929 79666 1 robert webkit-qt-unassigned ap kling markus ossy zarvai oldest_to_newest 208463 0 52532 robert 2010-04-05 06:55:56 -0700 Created attachment 52532 Qt Patch The fix for this in Qt is tracked at: http://bugreports.qt.nokia.com/browse/QTWEBKIT-152 I've also attached the patch here for comment. If user information is present in the Url, QNetworkAccessHttpBackend will cache the connection with a key in the format of user@hostname. This causes the following tests in QtWebKit to fail: LayoutTests/http/tests/xmlhttprequest/re-login.html LayoutTests/http/tests/xmlhttprequest/re-login-async.html The tests call the same url with user1 credentials, no credentials, user 2 credentials and no credentials. In the second and fourth calls Qt should use the most recently stored credentials. For the fourth call it currently uses user1's credentials instead of user2's. This is because it retrieves the cached connection from the third call and uses the user/pass in that connection's authenticator - which is user1's. In order to retrieve the connection with the most recently used credentials userinfo should be removed when caching the connection in QNetworkAccessCache. This will allow Qt to retrieve the connection used in the third call, in fact the same cached connection for all four calls. 208502 1 robert 2010-04-05 08:55:05 -0700 I shouldn't have raised it in Jiras QTWEBKIT. The required changes are in QtNetwork, so have raised a new one: http://bugreports.qt.nokia.com/browse/QTBUG-9619 302601 2 kling 2010-11-01 04:57:51 -0700 Closing per request from mgoetz. 302616 3 markus 2010-11-01 05:58:12 -0700 I merged the code to Qt, thanks! 333905 4 robert 2011-01-13 13:14:00 -0800 Unskip http/tests/xmlhttprequest/re-login-async.html and http/tests/xmlhttprequest/re-login.html when buildbots move to 4.8 498721 5 zarvai 2011-11-09 01:21:29 -0800 Results with r99667 (Qt 4.8.0-rc1): http/tests/xmlhttprequest/re-login-async.html passes http/tests/xmlhttprequest/re-login.html still failing 627657 6 ossy 2012-05-18 06:53:34 -0700 Fixed and unskipped. 52532 2010-04-05 06:55:56 -0700 2010-06-11 10:42:54 -0700 Qt Patch 0001-Do-not-cache-network-connections-per-username.patch text/plain 2126 robert RnJvbSBmNGI3OTg5NDllMmVjMmViODgxZDM1YWNhMDU1NGVhMDMxYzQwZmZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSG9nYW4gPHJvYmVydEB3ZWJraXQub3JnPgpEYXRl OiBNb24sIDUgQXByIDIwMTAgMTQ6Mzc6MDggKzAxMDAKU3ViamVjdDogW1BBVENIXSBEbyBub3Qg Y2FjaGUgbmV0d29yayBjb25uZWN0aW9ucyBwZXIgdXNlcm5hbWUuCgpJZiB1c2VyIGluZm9ybWF0 aW9uIGlzIHByZXNlbnQgaW4gdGhlIFVybCwgUU5ldHdvcmtBY2Nlc3NIdHRwQmFja2VuZAp3aWxs IGNhY2hlIHRoZSBjb25uZWN0aW9uIHdpdGggYSBrZXkgaW4gdGhlIGZvcm1hdCBvZiB1c2VyQGhv c3RuYW1lLgoKVGhpcyBjYXVzZXMgdGhlIGZvbGxvd2luZyB0ZXN0cyBpbiBRdFdlYktpdCB0byBm YWlsOgoKTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZS1sb2dpbi5odG1s CkxheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmUtbG9naW4tYXN5bmMuaHRt bAoKVGhlIHRlc3RzIGNhbGwgdGhlIHNhbWUgdXJsIHdpdGggdXNlcjEgY3JlZGVudGlhbHMsIG5v IGNyZWRlbnRpYWxzLAp1c2VyIDIgY3JlZGVudGlhbHMgYW5kIG5vIGNyZWRlbnRpYWxzLiBJbiB0 aGUgc2Vjb25kIGFuZCBmb3VydGggY2FsbHMKUXQgc2hvdWxkIHVzZSB0aGUgbW9zdCByZWNlbnRs eSBzdG9yZWQgY3JlZGVudGlhbHMuIEZvciB0aGUgZm91cnRoCmNhbGwgaXQgY3VycmVudGx5IHVz ZXMgdXNlcjEncyBjcmVkZW50aWFscyBpbnN0ZWFkIG9mIHVzZXIyJ3MuIFRoaXMKaXMgYmVjYXVz ZSBpdCByZXRyaWV2ZXMgdGhlIGNhY2hlZCBjb25uZWN0aW9uIGZyb20gdGhlIHRoaXJkIGNhbGwK YW5kIHVzZXMgdGhlIHVzZXIvcGFzcyBpbiB0aGF0IGNvbm5lY3Rpb24ncyBhdXRoZW50aWNhdG9y IC0gd2hpY2ggaXMKdXNlcjEncy4KCkluIG9yZGVyIHRvIHJldHJpZXZlIHRoZSBjb25uZWN0aW9u IHdpdGggdGhlIG1vc3QgcmVjZW50bHkgdXNlZApjcmVkZW50aWFscyB1c2VyaW5mbyBzaG91bGQg YmUgcmVtb3ZlZCB3aGVuIGNhY2hpbmcgdGhlIGNvbm5lY3Rpb24KaW4gUU5ldHdvcmtBY2Nlc3ND YWNoZS4gVGhpcyB3aWxsIGFsbG93IFF0IHRvIHJldHJpZXZlIHRoZSBjb25uZWN0aW9uCnVzZWQg aW4gdGhlIHRoaXJkIGNhbGwsIGluIGZhY3QgdGhlIHNhbWUgY2FjaGVkIGNvbm5lY3Rpb24gZm9y IGFsbApmb3VyIGNhbGxzLgotLS0KIHNyYy9uZXR3b3JrL2FjY2Vzcy9xbmV0d29ya2FjY2Vzc2h0 dHBiYWNrZW5kLmNwcCB8ICAgIDIgKy0KIDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9uZXR3b3JrL2FjY2Vzcy9xbmV0d29y a2FjY2Vzc2h0dHBiYWNrZW5kLmNwcCBiL3NyYy9uZXR3b3JrL2FjY2Vzcy9xbmV0d29ya2FjY2Vz c2h0dHBiYWNrZW5kLmNwcAppbmRleCA3YTQ4YzJiLi44N2E1ODMxIDEwMDY0NAotLS0gYS9zcmMv bmV0d29yay9hY2Nlc3MvcW5ldHdvcmthY2Nlc3NodHRwYmFja2VuZC5jcHAKKysrIGIvc3JjL25l dHdvcmsvYWNjZXNzL3FuZXR3b3JrYWNjZXNzaHR0cGJhY2tlbmQuY3BwCkBAIC03MSw3ICs3MSw3 IEBAIHN0YXRpYyBRQnl0ZUFycmF5IG1ha2VDYWNoZUtleShRTmV0d29ya0FjY2Vzc0h0dHBCYWNr ZW5kICpiYWNrZW5kLCBRTmV0d29ya1Byb3h5CiAgICAgUVVybCBjb3B5ID0gYmFja2VuZC0+dXJs KCk7CiAgICAgYm9vbCBpc0VuY3J5cHRlZCA9IGNvcHkuc2NoZW1lKCkudG9Mb3dlcigpID09IFFM YXRpbjFTdHJpbmcoImh0dHBzIik7CiAgICAgY29weS5zZXRQb3J0KGNvcHkucG9ydChpc0VuY3J5 cHRlZCA/IERlZmF1bHRIdHRwc1BvcnQgOiBEZWZhdWx0SHR0cFBvcnQpKTsKLSAgICByZXN1bHQg PSBjb3B5LnRvRW5jb2RlZChRVXJsOjpSZW1vdmVQYXNzd29yZCB8IFFVcmw6OlJlbW92ZVBhdGgg fAorICAgIHJlc3VsdCA9IGNvcHkudG9FbmNvZGVkKFFVcmw6OlJlbW92ZVVzZXJJbmZvIHwgUVVy bDo6UmVtb3ZlUGF0aCB8CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUVVybDo6UmVtb3Zl UXVlcnkgfCBRVXJsOjpSZW1vdmVGcmFnbWVudCk7CiAKICNpZm5kZWYgUVRfTk9fTkVUV09SS1BS T1hZCi0tIAoxLjYuMy4zCgo=