37081 2010-04-05 05:24:30 -0700 Web Inspector: [REGRESSION] platform detection in Chromium has regressed to unknown. 2010-04-05 10:42:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth eric webkit.review.bot yurys oldest_to_newest 208441 0 pfeldman 2010-04-05 05:24:30 -0700 Patch to follow. 208443 1 52527 pfeldman 2010-04-05 05:31:38 -0700 Created attachment 52527 [PATCH] Proposed fix. 208446 2 pfeldman 2010-04-05 05:38:02 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp M WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp M WebCore/inspector/InspectorFrontendHost.cpp M WebCore/inspector/InspectorFrontendHost.h M WebCore/inspector/InspectorFrontendHost.idl Committed r57069 208451 3 webkit.review.bot 2010-04-05 05:46:04 -0700 http://trac.webkit.org/changeset/57069 might have broken Chromium Linux Release 208560 4 eric 2010-04-05 10:42:55 -0700 You checkin hit https://bugs.webkit.org/show_bug.cgi?id=36779, and then the Leopard slave was lost. Sheriff bot doesn't yet understand "slave lost" but we plan to teach him that soon, bug 37099. 52527 2010-04-05 05:31:38 -0700 2010-04-05 05:32:48 -0700 [PATCH] Proposed fix. platform_port text/plain 5509 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzYwMzg2MC4uOGI2NTBhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNC0wNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNl bWlraGF0c2t5LgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtSRUdSRVNTSU9OXSBwbGF0Zm9y bSBkZXRlY3Rpb24gaW4gQ2hyb21pdW0KKyAgICAgICAgaGFzIHJlZ3Jlc3NlZCB0byB1bmtub3du LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzA4 MQorCisgICAgICAgICogYmluZGluZ3MvanMvSlNJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnBsYXRmb3Jt KToKKyAgICAgICAgKFdlYkNvcmU6OkpTSW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojpwb3J0KToKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnBsYXRmb3Jt KToKKyAgICAgICAgKFdlYkNvcmU6OlY4SW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojpwb3J0KToKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcDoKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lmg6CisgICAgICAgICogaW5zcGVjdG9yL0lu c3BlY3RvckZyb250ZW5kSG9zdC5pZGw6CisKIDIwMTAtMDQtMDQgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBSb2xsaW5nIG91 dCBjaHJvbWl1bSBjaGFuZ2VzIHI1NzAyOCBhbmQgcjU3MDMyCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTSW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcCBiL1dlYkNvcmUv YmluZGluZ3MvanMvSlNJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwCmluZGV4IDdiMDZi YWMuLjM0MGVmNDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0b3JG cm9udGVuZEhvc3RDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0 b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwCkBAIC00OSw2ICs0OSwzNCBAQCB1c2luZyBuYW1lc3Bh Y2UgSlNDOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK0pTVmFsdWUgSlNJbnNwZWN0b3JGcm9u dGVuZEhvc3Q6OnBsYXRmb3JtKEV4ZWNTdGF0ZSogZXhlY1N0YXRlLCBjb25zdCBBcmdMaXN0JikK K3sKKyNpZiBQTEFURk9STShNQUMpCisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJp bmcsIHBsYXRmb3JtLCAoIm1hYyIpKTsKKyNlbGlmIE9TKFdJTkRPV1MpCisgICAgREVGSU5FX1NU QVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHBsYXRmb3JtLCAoIndpbmRvd3MiKSk7CisjZWxpZiBP UyhMSU5VWCkKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywgcGxhdGZvcm0s ICgibGludXgiKSk7CisjZWxzZQorICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5n LCBwbGF0Zm9ybSwgKCJ1bmtub3duIikpOworI2VuZGlmCisgICAgcmV0dXJuIGpzU3RyaW5nKGV4 ZWNTdGF0ZSwgcGxhdGZvcm0pOworfQorCitKU1ZhbHVlIEpTSW5zcGVjdG9yRnJvbnRlbmRIb3N0 Ojpwb3J0KEV4ZWNTdGF0ZSogZXhlY1N0YXRlLCBjb25zdCBBcmdMaXN0JikKK3sKKyNpZiBQTEFU Rk9STShRVCkKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywgcG9ydCwgKCJx dCIpKTsKKyNlbGlmIFBMQVRGT1JNKEdUSykKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0 IFN0cmluZywgcG9ydCwgKCJndGsiKSk7CisjZWxpZiBQTEFURk9STShXWCkKKyAgICBERUZJTkVf U1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywgcG9ydCwgKCJ3eCIpKTsKKyNlbHNlCisgICAgREVG SU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHBvcnQsICgidW5rbm93biIpKTsKKyNlbmRp ZgorICAgIHJldHVybiBqc1N0cmluZyhleGVjU3RhdGUsIHBvcnQpOworfQorCiBKU1ZhbHVlIEpT SW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpzaG93Q29udGV4dE1lbnUoRXhlY1N0YXRlKiBleGVjU3Rh dGUsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCiB7CiAgICAgaWYgKGFyZ3Muc2l6ZSgpIDwgMikKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJvbnRlbmRI b3N0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJv bnRlbmRIb3N0Q3VzdG9tLmNwcAppbmRleCBiMzU0MzcxLi5jNjJmMWI2IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluc3BlY3RvckZyb250ZW5kSG9zdEN1c3RvbS5j cHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJbnNwZWN0b3JGcm9udGVuZEhv c3RDdXN0b20uY3BwCkBAIC00MCw2ICs0MCwyNCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK K3Y4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEluc3BlY3RvckZyb250ZW5kSG9zdDo6cGxhdGZvcm0o Y29uc3Qgdjg6OkFyZ3VtZW50cyYpCit7CisjaWYgZGVmaW5lZChPU19NQUNPU1gpCisgICAgcmV0 dXJuIHY4U3RyaW5nKCJtYWMiKTsKKyNlbGlmIGRlZmluZWQoT1NfTElOVVgpCisgICAgcmV0dXJu IHY4U3RyaW5nKCJsaW51eCIpOworI2VsaWYgZGVmaW5lZChPU19XSU4pCisgICAgcmV0dXJuIHY4 U3RyaW5nKCJ3aW5kb3dzIik7CisjZWxzZQorICAgIHJldHVybiB2OFN0cmluZygidW5rbm93biIp OworI2VuZGlmCit9CisKK3Y4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEluc3BlY3RvckZyb250ZW5k SG9zdDo6cG9ydChjb25zdCB2ODo6QXJndW1lbnRzJikKK3sKKyAgICByZXR1cm4gdjg6OlVuZGVm aW5lZCgpOworfQorCiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhJbnNwZWN0b3JGcm9udGVuZEhv c3Q6OnNob3dDb250ZXh0TWVudUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7 CiAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPCAyKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckZyb250ZW5kSG9zdC5jcHAKaW5kZXggMWEwYjQ4My4uODkxM2ViMyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcAorKysgYi9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCkBAIC0yMDEsMzUgKzIwMSw2IEBAIFN0 cmluZyBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmhpZGRlblBhbmVscygpCiAgICAgcmV0dXJuIG1f Y2xpZW50LT5oaWRkZW5QYW5lbHMoKTsKIH0KIAotY29uc3QgU3RyaW5nJiBJbnNwZWN0b3JGcm9u dGVuZEhvc3Q6OnBsYXRmb3JtKCkgY29uc3QKLXsKLSNpZiBQTEFURk9STShNQUMpCi0gICAgREVG SU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHBsYXRmb3JtLCAoIm1hYyIpKTsKLSNlbGlm IE9TKFdJTkRPV1MpCi0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHBsYXRm b3JtLCAoIndpbmRvd3MiKSk7Ci0jZWxpZiBPUyhMSU5VWCkKLSAgICBERUZJTkVfU1RBVElDX0xP Q0FMKGNvbnN0IFN0cmluZywgcGxhdGZvcm0sICgibGludXgiKSk7Ci0jZWxzZQotICAgIERFRklO RV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBwbGF0Zm9ybSwgKCJ1bmtub3duIikpOwotI2Vu ZGlmCi0gICAgcmV0dXJuIHBsYXRmb3JtOwotfQotCi1jb25zdCBTdHJpbmcmIEluc3BlY3RvckZy b250ZW5kSG9zdDo6cG9ydCgpIGNvbnN0Ci17Ci0jaWYgUExBVEZPUk0oUVQpCi0gICAgREVGSU5F X1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHBvcnQsICgicXQiKSk7Ci0jZWxpZiBQTEFURk9S TShHVEspCi0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHBvcnQsICgiZ3Rr IikpOwotI2VsaWYgUExBVEZPUk0oV1gpCi0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBT dHJpbmcsIHBvcnQsICgid3giKSk7Ci0jZWxzZQotICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29u c3QgU3RyaW5nLCBwb3J0LCAoInVua25vd24iKSk7Ci0jZW5kaWYKLQotICAgIHJldHVybiBwb3J0 OwotfQotCiB2b2lkIEluc3BlY3RvckZyb250ZW5kSG9zdDo6Y29weVRleHQoY29uc3QgU3RyaW5n JiB0ZXh0KQogewogICAgIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0ZWJvYXJkKCktPndyaXRlUGxh aW5UZXh0KHRleHQpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJv bnRlbmRIb3N0LmggYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaApp bmRleCA2YzM0YWNkLi42MjdjMzdkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JGcm9udGVuZEhvc3QuaAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9u dGVuZEhvc3QuaApAQCAtNzEsOCArNzEsNiBAQCBwdWJsaWM6CiAKICAgICBTdHJpbmcgbG9jYWxp emVkU3RyaW5nc1VSTCgpOwogICAgIFN0cmluZyBoaWRkZW5QYW5lbHMoKTsKLSAgICBjb25zdCBT dHJpbmcmIHBsYXRmb3JtKCkgY29uc3Q7Ci0gICAgY29uc3QgU3RyaW5nJiBwb3J0KCkgY29uc3Q7 CiAKICAgICB2b2lkIGNvcHlUZXh0KGNvbnN0IFN0cmluZyYgdGV4dCk7CiAKZGlmZiAtLWdpdCBh L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwgYi9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsCmluZGV4IDBhZWY1YzQuLjhiN2RkYTUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwK KysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbApAQCAtNDUs MTEgKzQ1LDExIEBAIG1vZHVsZSBjb3JlIHsKIAogICAgICAgICBET01TdHJpbmcgbG9jYWxpemVk U3RyaW5nc1VSTCgpOwogICAgICAgICBET01TdHJpbmcgaGlkZGVuUGFuZWxzKCk7Ci0gICAgICAg IERPTVN0cmluZyBwbGF0Zm9ybSgpOwotICAgICAgICBET01TdHJpbmcgcG9ydCgpOwogCiAgICAg ICAgIHZvaWQgY29weVRleHQoaW4gRE9NU3RyaW5nIHRleHQpOwogCiAgICAgICAgIFtDdXN0b21d IHZvaWQgc2hvd0NvbnRleHRNZW51KGluIE1vdXNlRXZlbnQgZXZlbnQsIGluIERPTU9iamVjdCBp dGVtcyk7CisgICAgICAgIFtDdXN0b21dIERPTVN0cmluZyBwbGF0Zm9ybSgpOworICAgICAgICBb Q3VzdG9tXSBET01TdHJpbmcgcG9ydCgpOwogICAgIH07CiB9Cg==