37080 2010-04-05 03:41:27 -0700 RenderProgress.cpp is missing CurrentTime.h 2010-04-05 23:59:50 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 morrita webkit-unassigned commit-queue darin oldest_to_newest 208431 0 morrita 2010-04-05 03:41:27 -0700 On Chromium port, there is a compilation error when PROGRESS_TAG enabled, because RenderProgress.h is missing CurrentTime.h. 208432 1 52524 morrita 2010-04-05 03:48:56 -0700 Created attachment 52524 v0; should be trivial 208433 2 morrita 2010-04-05 03:49:57 -0700 Qt port may include it somewhere in port specific file. 208436 3 52524 mrowe 2010-04-05 04:14:55 -0700 Comment on attachment 52524 v0; should be trivial CurrentTime.h not used within the header file. It should only be included where it’s used. 208437 4 52525 morrita 2010-04-05 04:56:28 -0700 Created attachment 52525 move inclusion to RenderProgress.cpp 208438 5 morrita 2010-04-05 04:58:23 -0700 bdash, thank you for reviewing. And you are definitely right. > CurrentTime.h not used within the header file. It should only be included > where it’s used. Fixed to move inclusion to RenderProgress.cpp I also updated the bug summary to reflect that. 208484 6 52525 darin 2010-04-05 08:35:46 -0700 Comment on attachment 52525 move inclusion to RenderProgress.cpp Doesn't the file also need to include <math.h> or <wtf/MathExtras.h>? 208834 7 morrita 2010-04-05 18:33:28 -0700 (In reply to comment #6) > (From update of attachment 52525 [details]) > Doesn't the file also need to include <math.h> or <wtf/MathExtras.h>? I'm not sure. Chromium is successfully built only with CurrentTime.h. math.h might be included somewhere else. 208925 8 52525 commit-queue 2010-04-05 23:59:46 -0700 Comment on attachment 52525 move inclusion to RenderProgress.cpp Clearing flags on attachment: 52525 Committed r57130: <http://trac.webkit.org/changeset/57130> 208926 9 commit-queue 2010-04-05 23:59:50 -0700 All reviewed patches have been landed. Closing bug. 52524 2010-04-05 03:48:56 -0700 2010-04-05 04:56:22 -0700 v0; should be trivial bug-37080-20100405194854.patch text/plain 890 morrita ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzYwMzg2MC4uYjE4NTZmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0wNSAgTU9SSVRBIEhhamlt ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW5kZXJQcm9ncmVzcy5oIGlzIG1pc3NpbmcgQ3VycmVudFRpbWUu aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwODAK KworICAgICAgICBObyBuZXcgdGVzdHMuIGp1c3QgZml4ZWQgY29tcGlsYXRpb24gZXJyb3IuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUHJvZ3Jlc3MuaDoKKworCiAyMDEwLTA0LTA0ICBQ YXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vdCByZXZp ZXdlZC4gUm9sbGluZyBvdXQgY2hyb21pdW0gY2hhbmdlcyByNTcwMjggYW5kIHI1NzAzMgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUHJvZ3Jlc3MuaCBiL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclByb2dyZXNzLmgKaW5kZXggNzY3ZWQzNy4uNTY5NmQ2OSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUHJvZ3Jlc3MuaAorKysgYi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJQcm9ncmVzcy5oCkBAIC0yMyw2ICsyMyw3IEBACiAKICNpZiBFTkFCTEUoUFJP R1JFU1NfVEFHKQogI2luY2x1ZGUgIlJlbmRlckJsb2NrLmgiCisjaW5jbHVkZSA8d3RmL0N1cnJl bnRUaW1lLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo= 52525 2010-04-05 04:56:28 -0700 2010-04-05 23:59:45 -0700 move inclusion to RenderProgress.cpp bug-37080-20100405205626.patch text/plain 911 morrita ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzYwMzg2MC4uYTM3ZmM0ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0wNSAgTU9SSVRBIEhhamlt ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW5kZXJQcm9ncmVzcy5jcHAgaXMgbWlzc2luZyBDdXJyZW50VGlt ZS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzA4 MAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4ganVzdCBmaXhlZCBjb21waWxhdGlvbiBlcnJvci4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJQcm9ncmVzcy5jcHA6CisKKwogMjAxMC0wNC0w NCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3Qg cmV2aWV3ZWQuIFJvbGxpbmcgb3V0IGNocm9taXVtIGNoYW5nZXMgcjU3MDI4IGFuZCByNTcwMzIK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclByb2dyZXNzLmNwcCBiL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclByb2dyZXNzLmNwcAppbmRleCA2ZWUwNjZkLi4wNjJmZjMyIDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQcm9ncmVzcy5jcHAKKysrIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyUHJvZ3Jlc3MuY3BwCkBAIC0yNSw2ICsyNSw3IEBACiAKICNp bmNsdWRlICJIVE1MUHJvZ3Jlc3NFbGVtZW50LmgiCiAjaW5jbHVkZSAiUmVuZGVyVGhlbWUuaCIK KyNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAo=