37056 2010-04-02 22:14:58 -0700 LayoutTests/editing/selection/move-left-right.html is slow 2010-05-05 23:27:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P4 Normal --- 0 morrita morrita eric hamaji oldest_to_newest 208218 0 morrita 2010-04-02 22:14:58 -0700 It takes over 13 secs to finish on my Mac Pro. Should be take at most a few second. 208221 1 52478 morrita 2010-04-02 22:39:44 -0700 Created attachment 52478 patch v0 208224 2 morrita 2010-04-02 22:43:39 -0700 Original test hide each test <div> after using it. The patch changes it to remove all <div>s at once when all tests done. This reduce running time 13sec -> 3.2sec. The expectation contains storange y values, which is due to Bug 37016, that is revealed by the change. But it is not bug of this test, nor bug of the code that the test exercises. 215109 3 52478 hamaji 2010-04-20 19:13:17 -0700 Comment on attachment 52478 patch v0 > The expectation contains storange y values, which is due to Bug 37016, > that is revealed by the change. But it is not bug of this test, nor bug of the > code that the test exercises. Is it easy to fix Bug 37016? If so, I'd suggest fixing it first. > - layoutTestController.dumpAsText(); > + if (window.layoutTestController) > + layoutTestController.dumpAsText(); I think we usually put dumpAsText on the toplevel so we can call this even when runTest isn't called. Anyway, this looks good! 215606 4 eric 2010-04-21 18:14:36 -0700 Attachment 52478 was posted by a committer and has review+, assigning to MORITA Hajime for commit. 215672 5 morrita 2010-04-21 20:40:45 -0700 Committed r58048: <http://trac.webkit.org/changeset/58048> 215690 6 hamaji 2010-04-21 21:46:24 -0700 You missed my comment? :) 216046 7 morrita 2010-04-22 13:18:10 -0700 Committed r58113: <http://trac.webkit.org/changeset/58113> 52478 2010-04-02 22:39:44 -0700 2010-05-05 23:27:23 -0700 patch v0 bug-37056-20100403143942.patch text/plain 4947 morrita ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MTJiYjFmLi5lMjRhM2U4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MDIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3MDU2CisgICAgICAgIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0 aW9uL21vdmUtbGVmdC1yaWdodC5odG1sIGlzIHNsb3cKKyAgICAgICAgCisgICAgICAgIFJlZHVj ZWQgc3R5bGUgY2hhbmdlIHRoYXQgd291bGQgdHJpZ2dlciByZWxheW91dC4gTm90ZSB0aGF0IFlv dQorICAgICAgICBtaWdodCBmaW5kIHRoYXQgZXhwZWN0YXRpb24gbG9va3Mgc3RvcmFuZ2UuIEl0 IGlzIGR1ZSB0byBCdWcKKyAgICAgICAgMzcwMTYuCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVj dGlvbi9tb3ZlLWxlZnQtcmlnaHQuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZWRpdGlu Zy9zZWxlY3Rpb24vbW92ZS1sZWZ0LXJpZ2h0LWV4cGVjdGVkLnR4dDoKKwogMjAxMC0wNC0wMSAg TU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9u L21vdmUtbGVmdC1yaWdodC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92 ZS1sZWZ0LXJpZ2h0Lmh0bWwKaW5kZXggZTBmYTVmNi4uNjQwMDJlZiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1sZWZ0LXJpZ2h0Lmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1sZWZ0LXJpZ2h0Lmh0bWwKQEAgLTE3LDkg KzE3LDE2IEBACiAgICAgICAgIGRpdi50ZXN0IGRpdiB7IGJvcmRlcjogMXB4IGRhc2hlZCBwaW5r OyBwYWRkaW5nOiAzcHg7IGhlaWdodDogMmVtOyB9CiAgICAgPC9zdHlsZT4KICAgICA8c2NyaXB0 PgorICAgICAgICB2YXIgbWVzc2FnZXMgPSBbXTsKKwogICAgICAgICBmdW5jdGlvbiBsb2cobWVz c2FnZSkKICAgICAgICAgewotICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNv bnNvbGUiKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtZXNzYWdlKSk7Cisg ICAgICAgICAgICBtZXNzYWdlcy5wdXNoKG1lc3NhZ2UpOworICAgICAgICB9CisKKyAgICAgICAg ZnVuY3Rpb24gZmx1c2hMb2coKQorICAgICAgICB7CisgICAgICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiY29uc29sZSIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2Rl KG1lc3NhZ2VzLmpvaW4oIiIpKSk7CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiBjYXJl dENvb3JkaW5hdGVzKCkKQEAgLTEyMSwxMiArMTI4LDEwIEBACiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KIAotICAgICAgICBvbmxvYWQgPSBmdW5jdGlvbigpCisgICAgICAgIGZ1bmN0aW9uIHJ1 blRlc3QoKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgICAgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOwogCiAgICAgICAgICAgICB2YXIgdGVzdHMgPSBkb2N1bWVudC5nZXRFbGVtZW50 c0J5Q2xhc3NOYW1lKCJ0ZXN0Iik7CiAgICAgICAgICAgICB2YXIgc2VsID0gZ2V0U2VsZWN0aW9u KCk7CkBAIC0xNjYsMTMgKzE3MSwyMiBAQAogCiAgICAgICAgICAgICAgICAgY2hlY2tSZXZlcnNl T3JkZXIocG9zaXRpb25zTW92aW5nTGVmdCwgcG9zaXRpb25zTW92aW5nUmlnaHQpOwogCi0gICAg ICAgICAgICAgICAgdGVzdHNbaV0uc3R5bGUuZGlzcGxheSA9ICJub25lIjsKICAgICAgICAgICAg IH0KKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0R3JvdXAiKS5zdHls ZS5kaXNwbGF5ID0gIm5vbmUiOwogICAgICAgICB9CiAKKyAgICAgICAgb25sb2FkID0gZnVuY3Rp b24oKSB7CisgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgIHJ1blRlc3QoKTsKKyAg ICAgICAgICAgIH0gZmluYWxseSB7CisgICAgICAgICAgICAgICAgZmx1c2hMb2coKTsKKyAgICAg ICAgICAgIH0KKyAgICAgICAgfTsKICAgICA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5PgorICAg IDxkaXYgaWQ9InRlc3RHcm91cCI+CisKICAgICA8ZGl2IGNsYXNzPSJ0ZXN0Ij4KICAgICAgICAg YWJjCiAgICAgPC9kaXY+CkBAIC0zMjksNSArMzQzLDkgQEAKICAgICA8ZGl2IGNsYXNzPSJ0ZXN0 IiBzdHlsZT0id2hpdGUtc3BhY2U6IHByZTsiPteQ15HXkjwhLS0gLS0+CiA8IS0tIC0tPteT15TX lTwvZGl2PgogCisgICAgPC9kaXY+CisKKyAgICA8L2Rpdj4KKwogICAgIDxwcmUgaWQ9ImNvbnNv bGUiPjwvcHJlPgogPC9ib2R5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtbGVmdC1yaWdodC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1sZWZ0LXJpZ2h0LWV4cGVj dGVkLnR4dAppbmRleCBkODYyMzFmLi5iYmZmN2Y0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1sZWZ0LXJpZ2h0LWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1s ZWZ0LXJpZ2h0LWV4cGVjdGVkLnR4dApAQCAtMjI5LDIyICsyMjksMjIgQEAgVGVzdCAzOCwgUlRM OgogICBNb3ZpbmcgcmlnaHQ6ICAiYmNERUYiWzUsIDQsIDMsIDJdLCAiXG4gICAgICAgIEFCQ2Ei WzEzXSwgImJjREVGIlsxXSwgIlxuICAgICAgICBBQkNhIlsxMiwgMTEsIDEwLCA5XQogVGVzdCAz OSwgTFRSOgogICBNb3ZpbmcgcmlnaHQ6ICJhYmMiWzAsIDEsIDIsIDNdLCAiZGVmIlswLCAxLCAy LCAzXQotV0FSTklORzogTW92ZWQgaW4gdGhlIHdyb25nIGRpcmVjdGlvbiBpbiBzdGVwIDQ6IGZy b20gKDY1LCA1NjkpIHRvICgwLCA2MDApLgorV0FSTklORzogTW92ZWQgaW4gdGhlIHdyb25nIGRp cmVjdGlvbiBpbiBzdGVwIDQ6IGZyb20gKDY1LCAtOTU1KSB0byAoMCwgNjAwKS4KICAgTW92aW5n IGxlZnQ6ICAiZGVmIlszLCAyLCAxLCAwXSwgImFiYyJbMywgMiwgMSwgMF0KLVdBUk5JTkc6IE1v dmVkIGluIHRoZSB3cm9uZyBkaXJlY3Rpb24gaW4gc3RlcCA0OiBmcm9tICgwLCA2MDApIHRvICg2 NSwgNTY5KS4KK1dBUk5JTkc6IE1vdmVkIGluIHRoZSB3cm9uZyBkaXJlY3Rpb24gaW4gc3RlcCA0 OiBmcm9tICgwLCA2MDApIHRvICg2NSwgLTk1NSkuCiBUZXN0IDM5LCBSVEw6CiAgIE1vdmluZyBs ZWZ0OiAiYWJjIlswLCAyLCAxLCAzXSwgImRlZiJbMCwgMiwgMSwgM10KLVdBUk5JTkc6IE1vdmVk IGluIHRoZSB3cm9uZyBkaXJlY3Rpb24gaW4gc3RlcCA0OiBmcm9tICg3NDAsIDU2OSkgdG8gKDAs IDYwMCkuCitXQVJOSU5HOiBNb3ZlZCBpbiB0aGUgd3JvbmcgZGlyZWN0aW9uIGluIHN0ZXAgNDog ZnJvbSAoNzQwLCAtOTU1KSB0byAoMCwgNjAwKS4KICAgTW92aW5nIHJpZ2h0OiAgImRlZiJbMywg MSwgMiwgMF0sICJhYmMiWzMsIDEsIDIsIDBdCi1XQVJOSU5HOiBNb3ZlZCBpbiB0aGUgd3Jvbmcg ZGlyZWN0aW9uIGluIHN0ZXAgNDogZnJvbSAoMCwgNjAwKSB0byAoNzQwLCA1NjkpLgorV0FSTklO RzogTW92ZWQgaW4gdGhlIHdyb25nIGRpcmVjdGlvbiBpbiBzdGVwIDQ6IGZyb20gKDAsIDYwMCkg dG8gKDc0MCwgLTk1NSkuCiBUZXN0IDQwLCBMVFI6CiAgIE1vdmluZyByaWdodDogIkFCQyJbMCwg MiwgMSwgM10sICJERUYiWzAsIDIsIDEsIDNdCi1XQVJOSU5HOiBNb3ZlZCBpbiB0aGUgd3Jvbmcg ZGlyZWN0aW9uIGluIHN0ZXAgNDogZnJvbSAoNjQsIDU2OSkgdG8gKDAsIDYwMCkuCitXQVJOSU5H OiBNb3ZlZCBpbiB0aGUgd3JvbmcgZGlyZWN0aW9uIGluIHN0ZXAgNDogZnJvbSAoNjQsIC0xMDA1 KSB0byAoMCwgNjAwKS4KICAgTW92aW5nIGxlZnQ6ICAiREVGIlszLCAxLCAyLCAwXSwgIkFCQyJb MywgMSwgMiwgMF0KLVdBUk5JTkc6IE1vdmVkIGluIHRoZSB3cm9uZyBkaXJlY3Rpb24gaW4gc3Rl cCA0OiBmcm9tICgwLCA2MDApIHRvICg2NCwgNTY5KS4KK1dBUk5JTkc6IE1vdmVkIGluIHRoZSB3 cm9uZyBkaXJlY3Rpb24gaW4gc3RlcCA0OiBmcm9tICgwLCA2MDApIHRvICg2NCwgLTEwMDUpLgog VGVzdCA0MCwgUlRMOgogICBNb3ZpbmcgbGVmdDogIkFCQyJbMCwgMSwgMiwgM10sICJERUYiWzAs IDEsIDIsIDNdCi1XQVJOSU5HOiBNb3ZlZCBpbiB0aGUgd3JvbmcgZGlyZWN0aW9uIGluIHN0ZXAg NDogZnJvbSAoNzQxLCA1NjkpIHRvICgwLCA2MDApLgorV0FSTklORzogTW92ZWQgaW4gdGhlIHdy b25nIGRpcmVjdGlvbiBpbiBzdGVwIDQ6IGZyb20gKDc0MSwgLTEwMDUpIHRvICgwLCA2MDApLgog ICBNb3ZpbmcgcmlnaHQ6ICAiREVGIlszLCAyLCAxLCAwXSwgIkFCQyJbMywgMiwgMSwgMF0KLVdB Uk5JTkc6IE1vdmVkIGluIHRoZSB3cm9uZyBkaXJlY3Rpb24gaW4gc3RlcCA0OiBmcm9tICgwLCA2 MDApIHRvICg3NDEsIDU2OSkuCitXQVJOSU5HOiBNb3ZlZCBpbiB0aGUgd3JvbmcgZGlyZWN0aW9u IGluIHN0ZXAgNDogZnJvbSAoMCwgNjAwKSB0byAoNzQxLCAtMTAwNSkuCiAK