37051 2010-04-02 17:04:01 -0700 commit-queue should ignore builders when landing rollouts 2010-04-02 17:15:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric levin oldest_to_newest 208156 0 abarth 2010-04-02 17:04:01 -0700 commit-queue should ignore builders when landing rollouts 208157 1 52469 abarth 2010-04-02 17:05:33 -0700 Created attachment 52469 Patch 208160 2 52469 abarth 2010-04-02 17:07:30 -0700 Comment on attachment 52469 Patch I'm impressed that you reviewed my patch in 30 seconds.. 208164 3 52469 abarth 2010-04-02 17:14:59 -0700 Comment on attachment 52469 Patch Clearing flags on attachment: 52469 Committed r57035: <http://trac.webkit.org/changeset/57035> 208165 4 abarth 2010-04-02 17:15:04 -0700 All reviewed patches have been landed. Closing bug. 52469 2010-04-02 17:05:33 -0700 2010-04-02 17:14:59 -0700 Patch bug-37051-20100402170532.patch text/plain 5843 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1N2Y3ZjUzLi45YzU5OWMwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDQt MDIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb21taXQtcXVldWUgc2hvdWxkIGlnbm9yZSBi dWlsZGVycyB3aGVuIGxhbmRpbmcgcm9sbG91dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MDUxCisKKyAgICAgICAgV2hlbiB3ZSBtb3ZlZCB0aGUg ImJ1aWxkZXJzIGFyZSByZWQiIGNoZWNrIGludG8gdGhlIG1hc3RlciBwcm9jZXNzLCB3ZQorICAg ICAgICBmb3Jnb3QgYWJvdXQgcm9sbG91dHMuICBJIHRob3VnaHQgd2UgaGFkIGEgdGVzdCBjb3Zl cmluZyB0aGlzIGNhc2UsIGJ1dAorICAgICAgICBsb29raW5nIGF0IHRoZSB0ZXN0LCBpdCB3YXMg YSBiaXQgdG9vIGxvb3NlLiAgSSBhZGRlZCBhIG5ldyB0ZXN0IGFuZAorICAgICAgICBpbnRyb2R1 Y2VkIHNvbWUgbmV3IGxvZ2dpbmcgdGVjaG5vbG9neSBpbnRvIE1vY2tUb29sIHRvIG1ha2UgdGhl IHRlc3QKKyAgICAgICAgdGlnaHRlci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9xdWV1ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL3F1ZXVlc191bml0dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvbW9ja3Rvb2wucHk6CisKIDIwMTAtMDQtMDIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5IGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQppbmRleCAw MmQ5NTZhLi5kODljNGYzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKQEAgLTIwNSw3ICsyMDUsOSBAQCBjbGFzcyBDb21t aXRRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcik6CiAK ICAgICBkZWYgX2xhbmQoc2VsZiwgcGF0Y2gsIGZpcnN0X3J1bj1GYWxzZSk6CiAgICAgICAgIHRy eToKLSAgICAgICAgICAgIGlmIG5vdCBzZWxmLl9idWlsZGVyc19hcmVfZ3JlZW4oKToKKyAgICAg ICAgICAgICMgV2UgbmVlZCB0byBjaGVjayB0aGUgYnVpbGRlcnMsIHVubGVzcyB3ZSdyZSB0cnlp bmcgdG8gbGFuZCBhCisgICAgICAgICAgICAjIHJvbGxvdXQgKGluIHdoaWNoIGNhc2UgdGhlIGJ1 aWxkZXJzIGFyZSBwcm9iYWJseSByZWQuKQorICAgICAgICAgICAgaWYgbm90IHBhdGNoLmlzX3Jv bGxvdXQoKSBhbmQgbm90IHNlbGYuX2J1aWxkZXJzX2FyZV9ncmVlbigpOgogICAgICAgICAgICAg ICAgICMgV2UgcmV0dXJuIHRydWUgaGVyZSBiZWNhdXNlIHdlIHdhbnQgdG8gcmV0dXJuIHRvIHRo ZSBtYWluCiAgICAgICAgICAgICAgICAgIyBRdWV1ZUVuZ2luZSBsb29wIGFzIHF1aWNrbHkgYXMg cG9zc2libGUuCiAgICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKQEAgLTIzMSwxMCArMjMzLDYg QEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RQYXRjaFF1ZXVlLCBTdGVwU2VxdWVuY2VFcnJv ckhhbmRsZXIpOgogICAgICAgICAgICAgICAgICMga25vdyB3ZSdyZSB0ZXN0aW5nIHRoZSBzYW1l IHJldmlzaW9uIHRoYXQgd2Ugc3VjY2Vzc2Z1bGx5CiAgICAgICAgICAgICAgICAgIyBidWlsdCBh bmQgdGVzdGVkLgogICAgICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCItLW5vLXVwZGF0ZSIpCi0g ICAgICAgICAgICBpZiBwYXRjaC5pc19yb2xsb3V0KCk6Ci0gICAgICAgICAgICAgICAgIyBXZSBu ZWVkIHRvIGlnbm9yZSB0aGUgYnVpbGRlcnMgd2hlbiBsYW5kaW5nIGEgcm9sbG91dAotICAgICAg ICAgICAgICAgICMgYmVjYXVzZSB0aGV5J3JlIHByb2JhYmx5IHJlZC4KLSAgICAgICAgICAgICAg ICBhcmdzLmFwcGVuZCgiLS1pZ25vcmUtYnVpbGRlcnMiKQogICAgICAgICAgICAgc2VsZi5ydW5f d2Via2l0X3BhdGNoKGFyZ3MpCiAgICAgICAgICAgICBzZWxmLl9kaWRfcGFzcyhwYXRjaCkKICAg ICAgICAgICAgIHJldHVybiBUcnVlCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQppbmRleCAyYzRm Yzg5Li41MzVkNGE2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkKQEAgLTQ1LDYgKzQ1LDE3 IEBAIGNsYXNzIFRlc3RSZXZpZXdRdWV1ZShBYnN0cmFjdFJldmlld1F1ZXVlKToKICAgICBuYW1l ID0gInRlc3QtcmV2aWV3LXF1ZXVlIgogCiAKK2NsYXNzIE1vY2tQYXRjaChvYmplY3QpOgorICAg IGRlZiBpc19yb2xsb3V0KHNlbGYpOgorICAgICAgICByZXR1cm4gVHJ1ZQorCisgICAgZGVmIGJ1 Z19pZChzZWxmKToKKyAgICAgICAgcmV0dXJuIDEyMzQ1CisKKyAgICBkZWYgaWQoc2VsZik6Cisg ICAgICAgIHJldHVybiA3NjU0MworCisKIGNsYXNzIEFic3RyYWN0UXVldWVUZXN0KENvbW1hbmRz VGVzdCk6CiAgICAgZGVmIF9hc3NlcnRfbG9nX3Byb2dyZXNzX291dHB1dChzZWxmLCBwYXRjaF9p ZHMsIHByb2dyZXNzX291dHB1dCk6CiAgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0 cHV0cyhzZWxmLCBUZXN0UXVldWUoKS5sb2dfcHJvZ3Jlc3MsIFtwYXRjaF9pZHNdLCBleHBlY3Rl ZF9zdGRlcnI9cHJvZ3Jlc3Nfb3V0cHV0KQpAQCAtMTEyLDcgKzEyMyw3IEBAIFdhcm5pbmcsIGF0 dGFjaG1lbnQgMTI4IG9uIGJ1ZyA0MiBoYXMgaW52YWxpZCBjb21taXR0ZXIgKG5vbi1jb21taXR0 ZXJAZXhhbXBsZS5jCiAgICAgICAgIHNlbGYuYXNzZXJ0X3F1ZXVlX291dHB1dHMoQ29tbWl0UXVl dWUoKSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAogICAgIGRlZiB0ZXN0X3Jv bGxvdXQoc2VsZik6Ci0gICAgICAgIHRvb2wgPSBNb2NrVG9vbCgpCisgICAgICAgIHRvb2wgPSBN b2NrVG9vbChsb2dfZXhlY3V0aXZlPVRydWUpCiAgICAgICAgIHRvb2wuYnVpbGRib3QubGlnaHRf dHJlZV9vbl9maXJlKCkKICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gewogICAgICAgICAgICAg ImJlZ2luX3dvcmtfcXVldWUiIDogIkNBVVRJT046IGNvbW1pdC1xdWV1ZSB3aWxsIGRpc2NhcmQg YWxsIGxvY2FsIGNoYW5nZXMgaW4gXCIlc1wiXG5SdW5uaW5nIFdlYktpdCBjb21taXQtcXVldWUu XG4iICUgTW9ja1NDTS5mYWtlX2NoZWNrb3V0X3Jvb3QsCkBAIC0xMjQsNiArMTM1LDIxIEBAIFdh cm5pbmcsIGF0dGFjaG1lbnQgMTI4IG9uIGJ1ZyA0MiBoYXMgaW52YWxpZCBjb21taXR0ZXIgKG5v bi1jb21taXR0ZXJAZXhhbXBsZS5jCiAgICAgICAgIH0KICAgICAgICAgc2VsZi5hc3NlcnRfcXVl dWVfb3V0cHV0cyhDb21taXRRdWV1ZSgpLCB0b29sPXRvb2wsIGV4cGVjdGVkX3N0ZGVycj1leHBl Y3RlZF9zdGRlcnIpCiAKKyAgICBkZWYgdGVzdF9yb2xsb3V0X2xhbmRzKHNlbGYpOgorICAgICAg ICB0b29sID0gTW9ja1Rvb2wobG9nX2V4ZWN1dGl2ZT1UcnVlKQorICAgICAgICB0b29sLmJ1aWxk Ym90LmxpZ2h0X3RyZWVfb25fZmlyZSgpCisgICAgICAgIHJvbGxvdXRfcGF0Y2ggPSBNb2NrUGF0 Y2goKQorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSB7CisgICAgICAgICAgICAiYmVnaW5fd29y a19xdWV1ZSI6ICJDQVVUSU9OOiBjb21taXQtcXVldWUgd2lsbCBkaXNjYXJkIGFsbCBsb2NhbCBj aGFuZ2VzIGluIFwiJXNcIlxuUnVubmluZyBXZWJLaXQgY29tbWl0LXF1ZXVlLlxuIiAlIE1vY2tT Q00uZmFrZV9jaGVja291dF9yb290LAorICAgICAgICAgICAgIyBGSVhNRTogVGhlIGNvbW1pdC1x dWV1ZSB3YXJucyBhYm91dCBiYWQgY29tbWl0dGVycyB0d2ljZS4gIFRoaXMgaXMgZHVlIHRvIHRo ZSBmYWN0IHRoYXQgd2UgYWNjZXNzIEF0dGFjaG1lbnQucmV2aWV3ZXIoKSB0d2ljZSBhbmQgaXQg bG9ncyBlYWNoIHRpbWUuCisgICAgICAgICAgICAibmV4dF93b3JrX2l0ZW0iOiAiIiJXYXJuaW5n LCBhdHRhY2htZW50IDEyOCBvbiBidWcgNDIgaGFzIGludmFsaWQgY29tbWl0dGVyIChub24tY29t bWl0dGVyQGV4YW1wbGUuY29tKQorV2FybmluZywgYXR0YWNobWVudCAxMjggb24gYnVnIDQyIGhh cyBpbnZhbGlkIGNvbW1pdHRlciAobm9uLWNvbW1pdHRlckBleGFtcGxlLmNvbSkKKzEgcGF0Y2gg aW4gY29tbWl0LXF1ZXVlIFsxMDZdCisiIiIsCisgICAgICAgICAgICAicHJvY2Vzc193b3JrX2l0 ZW0iOiAiTU9DSyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6IFsnZWNobycsICctLXN0YXR1cy1ob3N0 PWV4YW1wbGUuY29tJywgJ2xhbmQtYXR0YWNobWVudCcsICctLWZvcmNlLWNsZWFuJywgJy0tbm9u LWludGVyYWN0aXZlJywgJy0taWdub3JlLWJ1aWxkZXJzJywgJy0tYnVpbGQtc3R5bGU9Ym90aCcs ICctLXF1aWV0JywgJzc2NTQzJ11cbiIsCisgICAgICAgIH0KKyAgICAgICAgc2VsZi5hc3NlcnRf cXVldWVfb3V0cHV0cyhDb21taXRRdWV1ZSgpLCB0b29sPXRvb2wsIHdvcmtfaXRlbT1yb2xsb3V0 X3BhdGNoLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQorCiAKIGNsYXNzIFN0eWxl UXVldWVUZXN0KFF1ZXVlc1Rlc3QpOgogICAgIGRlZiB0ZXN0X3N0eWxlX3F1ZXVlKHNlbGYpOgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL21vY2t0b29sLnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL21vY2t0b29sLnB5CmluZGV4IGQw ZDFjZDIuLmVhYjFiMTkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9tb2NrdG9vbC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv bW9ja3Rvb2wucHkKQEAgLTQ0NSwxMSArNDQ1LDEzIEBAIGNsYXNzIE1vY2tTdGF0dXNTZXJ2ZXIo b2JqZWN0KToKIAogY2xhc3MgTW9ja1Rvb2woKToKIAotICAgIGRlZiBfX2luaXRfXyhzZWxmKToK KyAgICBkZWYgX19pbml0X18oc2VsZiwgbG9nX2V4ZWN1dGl2ZT1GYWxzZSk6CiAgICAgICAgIHNl bGYud2FrZXVwX2V2ZW50ID0gdGhyZWFkaW5nLkV2ZW50KCkKICAgICAgICAgc2VsZi5idWdzID0g TW9ja0J1Z3ppbGxhKCkKICAgICAgICAgc2VsZi5idWlsZGJvdCA9IE1vY2tCdWlsZEJvdCgpCiAg ICAgICAgIHNlbGYuZXhlY3V0aXZlID0gTW9jaygpCisgICAgICAgIGlmIGxvZ19leGVjdXRpdmU6 CisgICAgICAgICAgICBzZWxmLmV4ZWN1dGl2ZS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwgPSBsYW1i ZGEgYXJnczogbG9nKCJNT0NLIHJ1bl9hbmRfdGhyb3dfaWZfZmFpbDogJXMiICUgYXJncykKICAg ICAgICAgc2VsZi5faXJjID0gTm9uZQogICAgICAgICBzZWxmLnVzZXIgPSBNb2NrVXNlcigpCiAg ICAgICAgIHNlbGYuX3NjbSA9IE1vY2tTQ00oKQo=