37049 2010-04-02 15:31:16 -0700 Change DatabaseAuthorizer to allow all fts2 functions 2010-05-07 18:31:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 dumi dumi beidson dglazkov fishd michaeln mjs sam oldest_to_newest 208110 0 dumi 2010-04-02 15:31:16 -0700 DatabaseAuthorizer is currently disallowing some fts2 functions. We need to fix that. 208162 1 52470 dumi 2010-04-02 17:09:02 -0700 Created attachment 52470 patch 208169 2 beidson 2010-04-02 17:17:23 -0700 It seems like an awful idea to introduce such fragmented capabilities between the WebKit browsers. (Apple's Mac + Win builds don't support fts2). 208171 3 beidson 2010-04-02 17:18:18 -0700 I'm overriding darin's r+ with an r- until we discuss this more. 208173 4 beidson 2010-04-02 17:22:04 -0700 Mark pointed out that fts2 support was enabled in http://trac.webkit.org/changeset/54990 I think this change was a poor decision and needs a little more discussion. (Yes, I see that I am CC'ed on https://bugs.webkit.org/show_bug.cgi?id=34867, and am sorry to have missed this. My bad) 208175 5 dumi 2010-04-02 17:25:18 -0700 If the only problem is that not all ports support the same modules/functions, then I can abstract out this function into its own class, provide a default WebKit implementation that allows (or maybe disallows?) everything, and implement a Chromium-specific version too. Let me know how you want us to deal with this problem. 208182 6 beidson 2010-04-02 17:37:21 -0700 No, I mean, to the end user (the web path author), some SQL works on one platform but doesn't work on another platform. Such as FTS2. The Web SQL Database spec is already at an impass. Currently, SQLite in WebKit is pretty much the only realistic implementation of the spec. Introducing further incompatibilities (such as FTS2 in one browser, but not another) would only fragment things further. 208361 7 dglazkov 2010-04-04 08:06:01 -0700 How hard would it be to bring fts2 to Safari? 208369 8 fishd 2010-04-04 11:37:52 -0700 A few months back, Sam mentioned that there was interest in adding FTS support to Safari. Has that changed? As for this bug, how about we add an ENABLE_SQLITE_FTS2 for now so that deciding the behavior of Safari does not have to be a pre-requisite to fixing a Chrome issue. We are already shipping FTS2 in the latest stable release of Chrome. 212519 9 dumi 2010-04-14 13:10:08 -0700 Ping. Any way we could submit a quick, temporary fix to this problem so that Chromium users can use FTS2? 222746 10 dumi 2010-05-07 18:31:41 -0700 We're moving to FTS3, so this bug is obsolete. 52470 2010-04-02 17:09:02 -0700 2010-04-02 17:17:56 -0700 patch patch text/plain 1140 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzAzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDIgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBbGxvdyB0aGUgTUFUQ0ggb3BlcmF0b3Igd2hlbiB1c2luZyBmdHMyLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzA0OQorCisgICAgICAgICog c3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJh c2VBdXRob3JpemVyOjphZGRXaGl0ZWxpc3RlZEZ1bmN0aW9ucyk6CisKIDIwMTAtMDQtMDIgIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBDYXJsc29uLgpJbmRleDogV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlQXV0aG9yaXplci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlQXV0aG9yaXplci5jcHAJKHJl dmlzaW9uIDU3MDI3KQorKysgV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlQXV0aG9yaXplci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwNSw2ICsxMDUsNyBAQCB2b2lkIERhdGFiYXNlQXV0aG9yaXpl cjo6YWRkV2hpdGVsaXN0ZWRGCiAgICAgbV93aGl0ZWxpc3RlZEZ1bmN0aW9ucy5hZGQoInNuaXBw ZXQiKTsKICAgICBtX3doaXRlbGlzdGVkRnVuY3Rpb25zLmFkZCgib2Zmc2V0cyIpOwogICAgIG1f d2hpdGVsaXN0ZWRGdW5jdGlvbnMuYWRkKCJvcHRpbWl6ZSIpOworICAgIG1fd2hpdGVsaXN0ZWRG dW5jdGlvbnMuYWRkKCJtYXRjaCIpOwogCiAgICAgLy8gU1FMaXRlIElDVSBmdW5jdGlvbnMKICAg ICAvLyBsaWtlKCksIGxvd2VyKCkgYW5kIHVwcGVyKCkgYXJlIGFscmVhZHkgaW4gdGhlIGxpc3QK