37048 2010-04-02 15:30:12 -0700 transitions/cancel-transition.html crashed on Leopard Debug Bot 2010-05-17 00:34:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 REOPENED P2 Normal --- 28461 1 eric jamesr cmarrin jamesr simon.fraser oldest_to_newest 208108 0 eric 2010-04-02 15:30:12 -0700 transitions/cancel-transition.html crashed on Leopard Debug Bot http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r57025%20(12365)/transitions/cancel-transition-stderr.txt ASSERTION FAILED: newOutlineBox == renderer()->outlineBoundsForRepaint(repaintContainer, 0) (/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebCore/rendering/RenderLayer.cpp:321 void WebCore::RenderLayer::updateLayerPositions(unsigned int, WebCore::IntPoint*)) http://trac.webkit.org/browser/trunk/LayoutTests/transitions/cancel-transition.html The ASSERT was added by James Robinson: http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderLayer.cpp?annotate=blame&rev=57000#L321 208109 1 eric 2010-04-02 15:30:50 -0700 It's possible this could be related to bug 28461. 208114 2 simon.fraser 2010-04-02 15:38:09 -0700 Ah, yes, it crashes if accelerated compositing is disabled. 208116 3 simon.fraser 2010-04-02 15:47:01 -0700 Where "crash" is an assertion. We're computing a repaint rect on some animating transform whose value is time-dependent. 208123 4 jamesr 2010-04-02 16:00:26 -0700 If the ASSERT fails it means that the outline box generated using the cached offset differs from the outline box using the slow path (walking up the container hierarchy to generate the offset). If the offset is time-dependent than this makes sense, the cache offset might be correct at time X but incorrect at time X+1ms. Should I take out the ASSERT()? IMHO the cleanest solution is for all time-dependent values in animations to be fixed when painting a single frame. 208130 5 simon.fraser 2010-04-02 16:14:51 -0700 > Should I take out the ASSERT()? For now, yes. > IMHO the cleanest solution is for all time-dependent values in animations to be fixed when painting a single frame. I think this is the correct solution, yes. Let's keep this bug open to do that (or file a new one). 208139 6 52463 jamesr 2010-04-02 16:30:39 -0700 Created attachment 52463 Patch 208142 7 52463 simon.fraser 2010-04-02 16:37:18 -0700 Comment on attachment 52463 Patch I'd like to see a //FIXME comment there that references this bug. r=me 208150 8 jamesr 2010-04-02 16:52:37 -0700 Committed r57033: <http://trac.webkit.org/changeset/57033> 208151 9 jamesr 2010-04-02 16:54:10 -0700 The ASSERT() is gone but I don't feel that the underlying bug is fixed. 209484 10 eric 2010-04-06 23:46:59 -0700 Attachment 52463 was posted by a committer and has review+, assigning to James Robinson for commit. 226642 11 52463 eric 2010-05-17 00:34:56 -0700 Comment on attachment 52463 Patch Obsoleting patch since this was committed. 52463 2010-04-02 16:30:39 -0700 2010-05-17 00:34:56 -0700 Patch bug-37048-20100402163032.patch text/plain 1595 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTI1ZTJjOC4uOGQ5ZjYwNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0wMiAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBhbiBBU1NFUlQgdGhhdCBzb21ldGltZXMgZmxha2Vz IGR1ZSB0byB0aW1lIGRlcGVuZGVudCBhbmltYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzA0OAorCisgICAgICAgIFRoZSBvdXRsaW5lIHJl cGFpbnQgcmVjdGFuZ2xlIGZvciBhIGxheWVyIG1pZ2h0IGNoYW5nZSBiZXR3ZWVuIHR3byBjYWxs cworICAgICAgICBpZiB0aGVyZSBhcmUgYW5pbWF0aW9ucyBpbnZvbHZlZCwgZXZlbiBpZiBub3Ro aW5nIGluIHRoZSBET00gaGFzIGFjdHVhbGx5CisgICAgICAgIGNoYW5nZWQgYmV0d2VlbiB0aGUg Y2FsbHMuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLCBubyBuZXcgdGVzdHMuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyTGF5ZXI6OnVwZGF0ZUxheWVyUG9zaXRpb25zKToKKwogMjAxMC0wNC0wMiAgRXZhbiBT dGFkZSAgPGVzdGFkZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT ZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMTU3NmJiYS4uMzk4YzI2YSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMzE4LDcgKzMxOCw2IEBAIHZvaWQgUmVu ZGVyTGF5ZXI6OnVwZGF0ZUxheWVyUG9zaXRpb25zKFVwZGF0ZUxheWVyUG9zaXRpb25zRmxhZ3Mg ZmxhZ3MsIEludFBvaW50CiAgICAgICAgIFJlbmRlckJveE1vZGVsT2JqZWN0KiByZXBhaW50Q29u dGFpbmVyID0gcmVuZGVyZXIoKS0+Y29udGFpbmVyRm9yUmVwYWludCgpOwogICAgICAgICBJbnRS ZWN0IG5ld1JlY3QgPSByZW5kZXJlcigpLT5jbGlwcGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWludChy ZXBhaW50Q29udGFpbmVyKTsKICAgICAgICAgSW50UmVjdCBuZXdPdXRsaW5lQm94ID0gcmVuZGVy ZXIoKS0+b3V0bGluZUJvdW5kc0ZvclJlcGFpbnQocmVwYWludENvbnRhaW5lciwgY2FjaGVkT2Zm c2V0KTsKLSAgICAgICAgQVNTRVJUKG5ld091dGxpbmVCb3ggPT0gcmVuZGVyZXIoKS0+b3V0bGlu ZUJvdW5kc0ZvclJlcGFpbnQocmVwYWludENvbnRhaW5lciwgMCkpOwogICAgICAgICBpZiAoZmxh Z3MgJiBDaGVja0ZvclJlcGFpbnQpIHsKICAgICAgICAgICAgIGlmICh2aWV3ICYmICF2aWV3LT5w cmludGluZygpKSB7CiAgICAgICAgICAgICAgICAgaWYgKG1fbmVlZHNGdWxsUmVwYWludCkgewo=