37043 2010-04-02 13:55:37 -0700 Java regression tests spam stderr about being unable to set status message 2010-04-02 14:22:01 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac All RESOLVED FIXED P3 Normal --- 1 ap ap oldest_to_newest 208055 0 ap 2010-04-02 13:55:37 -0700 ------------------------ - (void)webPlugInContainerShowStatus:(NSString *)message { ... if (!_documentView) { LOG_ERROR("could not show status message (%@) because plug-in has already been destroyed", message); return; } WebView *v = [_dataSource _webView]; [[v _UIDelegateForwarder] webView:v setStatusText:message]; ------------------------ This code was added in <http://trac.webkit.org/changeset/6596>, I'm not sure why it is needed. And since then, it has degenerated into something that looks wrong (why test _documentView, and not _dataSource?) Perhaps it can be just removed. 208057 1 52449 ap 2010-04-02 13:59:44 -0700 Created attachment 52449 proposed patch 208066 2 ap 2010-04-02 14:22:01 -0700 Committed revision 57024. 52449 2010-04-02 13:59:44 -0700 2010-04-02 14:05:23 -0700 proposed patch JavaSpam.txt text/plain 1582 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NzAyMSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDIgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MDQzCisg ICAgICAgIEphdmEgcmVncmVzc2lvbiB0ZXN0cyBzcGFtIHN0ZGVyciBjb25zb2xlIGFib3V0IGJl aW5nIHVuYWJsZSB0byBzZXQgc3RhdHVzIG1lc3NhZ2UKKworICAgICAgICBXaXRoIHRoaXMgY2hh bmdlLCB0aGVyZSBpcyBzdGlsbCBzcGFtIGFib3V0ICJBdHRlbXB0IHRvIGFjY2VzcyBKYXZhU2Ny aXB0IGZyb20gZGVzdHJveWVkCisgICAgICAgIGFwcGxldCwgdHlwZSA5LiIgSSBoYXZlbid0IGlu dmVzdGlnYXRlZCBpZiB0aGF0IGluZGljYXRlcyBhIHByb2JsZW0gb3Igbm90LgorCisgICAgICAg ICogUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tOiAoLVtXZWJQbHVnaW5Db250cm9sbGVy IHdlYlBsdWdJbkNvbnRhaW5lclNob3dTdGF0dXM6XSk6CisgICAgICAgIFJlbW92ZWQgY2hlY2sg Zm9yIF9kb2N1bWVudFZpZXcuIFdlIGRvbid0IHNlZW0gdG8gY2FyZS4KKwogMjAxMC0wNC0wMSAg S2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRG1pdHJ5IFRpdG92LgpJbmRleDogV2ViS2l0L21hYy9QbHVnaW5zL1dlYlBsdWdpbkNvbnRy b2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9QbHVnaW5zL1dlYlBsdWdpbkNvbnRy b2xsZXIubW0JKHJldmlzaW9uIDU3MDE4KQorKysgV2ViS2l0L21hYy9QbHVnaW5zL1dlYlBsdWdp bkNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTM1MywxMyArMzUzLDkgQEAgLSAodm9p ZCl3ZWJQbHVnSW5Db250YWluZXJMb2FkUmVxdWVzdDooTgogCiAtICh2b2lkKXdlYlBsdWdJbkNv bnRhaW5lclNob3dTdGF0dXM6KE5TU3RyaW5nICopbWVzc2FnZQogewotICAgIGlmICghbWVzc2Fn ZSkgeworICAgIGlmICghbWVzc2FnZSkKICAgICAgICAgbWVzc2FnZSA9IEAiIjsKLSAgICB9Ci0g ICAgaWYgKCFfZG9jdW1lbnRWaWV3KSB7Ci0gICAgICAgIExPR19FUlJPUigiY291bGQgbm90IHNo b3cgc3RhdHVzIG1lc3NhZ2UgKCVAKSBiZWNhdXNlIHBsdWctaW4gaGFzIGFscmVhZHkgYmVlbiBk ZXN0cm95ZWQiLCBtZXNzYWdlKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KKwogICAgIFdlYlZp ZXcgKnYgPSBbX2RhdGFTb3VyY2UgX3dlYlZpZXddOwogICAgIFtbdiBfVUlEZWxlZ2F0ZUZvcndh cmRlcl0gd2ViVmlldzp2IHNldFN0YXR1c1RleHQ6bWVzc2FnZV07CiB9Cg==