37033 2010-04-02 11:36:57 -0700 [chromium] font fallback for generic fonts picks wrong font 2010-04-02 15:23:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned commit-queue eric oldest_to_newest 207960 0 evan 2010-04-02 11:36:57 -0700 [chromium] font fallback for generic fonts picks wrong font 207970 1 52431 evan 2010-04-02 11:45:26 -0700 Created attachment 52431 Patch 207972 2 evan 2010-04-02 11:46:23 -0700 I would like to write a test for this, but it relies on which fonts are available or not on your OS. The previous incarnation of this code landed without a test as well. 208017 3 52431 eric 2010-04-02 12:59:46 -0700 Comment on attachment 52431 Patch So i'm confused by why adding "-webkit-" makes the logic right. I don't really know what the "-webkit-" magic font family names are for? Also, is this tested? If so, how? What tests need updates? Is it not possible to test due to needing a specific system config? r- for the lack of testing or explanation thereof. 208019 4 eric 2010-04-02 13:00:51 -0700 OK. I now read the bug comment which explained lack of testing (ideally that would be in the ChangeLog). So I'm just missing the understanding of what the "-webkit-" part does... 208024 5 52441 evan 2010-04-02 13:07:46 -0700 Created attachment 52441 Patch 208025 6 52441 eric 2010-04-02 13:08:41 -0700 Comment on attachment 52441 Patch THanks. 208101 7 52441 commit-queue 2010-04-02 15:23:32 -0700 Comment on attachment 52441 Patch Clearing flags on attachment: 52441 Committed r57027: <http://trac.webkit.org/changeset/57027> 208102 8 commit-queue 2010-04-02 15:23:37 -0700 All reviewed patches have been landed. Closing bug. 52431 2010-04-02 11:45:26 -0700 2010-04-02 13:07:43 -0700 Patch bug-37033-20100402114535.patch text/plain 2770 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTkzNmM1My4uMTk0MzIzOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMC0wNC0wMiAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIGZvbnQgZmFsbGJhY2sgZm9yIGdlbmVyaWMgZm9udHMg cGlja3Mgd3JvbmcgZm9udAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzcwMzMKKworICAgICAgICBXaGVuIGEgcGFnZSBzcGVjaWZpZXMgdGhlIGdlbmVy aWMgIm1vbm9zcGFjZSIgZm9udCBhbmQgdGhlIHVzZXIncworICAgICAgICBicm93c2VyLWNvbmZp Z3VyZWQgbW9ub3NwYWNlIGZvbnQgZG9lc24ndCBleGlzdCwgd2UgcHJldmlvdXNseSByZWxpZWQK KyAgICAgICAgb24gZ2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udCB0byBldmVudHVhbGx5IHBpY2sg YSBtb25vc3BhY2UgZm9udCBmb3IgdXMuCisKKyAgICAgICAgQnV0IHRoYXQgZG9lc24ndCBxdWl0 ZSB3b3JrOiBXZWJLaXQgZmlyc3QgZmFsbHMgYmFjayB0byB0aGUgdXNlcidzCisgICAgICAgICJw cmVmZXJyZWQgc3RhbmRhcmQgZm9udCIgYmVmb3JlIGhpdHRpbmcgdGhlIGxhc3QgcmVzb3J0IGNv ZGUgcGF0aC4KKyAgICAgICAgU28gaWYgdGhlIGFib3ZlIGNvbmRpdGlvbnMgaG9sZCBidXQgdGhp cyBmb250IGV4aXN0cywgd2UnbGwgZW5kIHVwCisgICAgICAgIG5ldmVyIGhpdHRpbmcgdGhlIGxh c3QgcmVzb3J0IGNvZGVwYXRoLgorCisgICAgICAgIFRoZSBmaXggaXMgdG8gYWxsb3cgT1MtbGV2 ZWwgZm9udCBmYWxsYmFjayB3aGVuIGZpcnN0IGF0dGVtcHRpbmcgdG8KKyAgICAgICAgcmVzb2x2 ZSBtb25vc3BhY2UuICBUaGUgZXhpc3RpbmcgY29kZSB0cmllZCB0byBkbyB0aGlzLCBidXQgdGhl IGxvZ2ljCisgICAgICAgIHdhcyB3cm9uZy4gIFdlIHdvdWxkIGV2ZW50dWFsbHkgZmFsbCBiYWNr IHRvIHRoZSBjb3JyZWN0IGZvbnQgYW55d2F5CisgICAgICAgIHNvIHdlIGRpZG4ndCBub3RpY2Ug dGhlIGxvZ2ljIHdhcyB3cm9uZy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0ZvbnRDYWNoZUxpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Y3Jl YXRlRm9udFBsYXRmb3JtRGF0YSk6CisKIDIwMTAtMDQtMDEgIFZpdGFseSBSZXBlc2hrbyAgPHZp dGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hl TGludXguY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVM aW51eC5jcHAKaW5kZXggOWQ0MWFhMi4uYjM1OGRhMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51eC5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51eC5jcHAKQEAgLTEwNywxMCAr MTA3LDEwIEBAIEZvbnRQbGF0Zm9ybURhdGEqIEZvbnRDYWNoZTo6Y3JlYXRlRm9udFBsYXRmb3Jt RGF0YShjb25zdCBGb250RGVzY3JpcHRpb24mIGZvbnRECiAgICAgY29uc3QgY2hhciogbmFtZSA9 IDA7CiAgICAgQ1N0cmluZyBzOwogCi0gICAgaWYgKGZhbWlseS5sZW5ndGgoKSA9PSAwKSB7Cisg ICAgaWYgKCFmYW1pbHkubGVuZ3RoKCkgfHwgZmFtaWx5LnN0YXJ0c1dpdGgoIi13ZWJraXQtIikp IHsKICAgICAgICAgc3RhdGljIGNvbnN0IHN0cnVjdCB7Ci0gICAgICAgICAgICBGb250RGVzY3Jp cHRpb246OkdlbmVyaWNGYW1pbHlUeXBlIG1UeXBlOwotICAgICAgICAgICAgY29uc3QgY2hhciog bU5hbWU7CisgICAgICAgICAgICBGb250RGVzY3JpcHRpb246OkdlbmVyaWNGYW1pbHlUeXBlIG1f dHlwZTsKKyAgICAgICAgICAgIGNvbnN0IGNoYXIqIG1fbmFtZTsKICAgICAgICAgfSBmb250RGVz Y3JpcHRpb25zW10gPSB7CiAgICAgICAgICAgICB7IEZvbnREZXNjcmlwdGlvbjo6U2VyaWZGYW1p bHksICJzZXJpZiIgfSwKICAgICAgICAgICAgIHsgRm9udERlc2NyaXB0aW9uOjpTYW5zU2VyaWZG YW1pbHksICJzYW5zLXNlcmlmIiB9LApAQCAtMTIxLDggKzEyMSw4IEBAIEZvbnRQbGF0Zm9ybURh dGEqIEZvbnRDYWNoZTo6Y3JlYXRlRm9udFBsYXRmb3JtRGF0YShjb25zdCBGb250RGVzY3JpcHRp b24mIGZvbnRECiAKICAgICAgICAgRm9udERlc2NyaXB0aW9uOjpHZW5lcmljRmFtaWx5VHlwZSB0 eXBlID0gZm9udERlc2NyaXB0aW9uLmdlbmVyaWNGYW1pbHkoKTsKICAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IFNLX0FSUkFZX0NPVU5UKGZvbnREZXNjcmlwdGlvbnMpOyBpKyspIHsK LSAgICAgICAgICAgIGlmICh0eXBlID09IGZvbnREZXNjcmlwdGlvbnNbaV0ubVR5cGUpIHsKLSAg ICAgICAgICAgICAgICBuYW1lID0gZm9udERlc2NyaXB0aW9uc1tpXS5tTmFtZTsKKyAgICAgICAg ICAgIGlmICh0eXBlID09IGZvbnREZXNjcmlwdGlvbnNbaV0ubV90eXBlKSB7CisgICAgICAgICAg ICAgICAgbmFtZSA9IGZvbnREZXNjcmlwdGlvbnNbaV0ubV9uYW1lOwogICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICB9Cg== 52441 2010-04-02 13:07:46 -0700 2010-04-02 15:23:32 -0700 Patch bug-37033-20100402130754.patch text/plain 2353 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmU4ZDlhNC4uZTY4ZDVjNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMCBAQAorMjAxMC0wNC0wMiAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIGZvbnQgZmFsbGJhY2sgZm9yIGdlbmVyaWMgZm9udHMg cGlja3Mgd3JvbmcgZm9udAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzcwMzMKKworICAgICAgICBXaGVuIGEgcGFnZSBzcGVjaWZpZXMgdGhlIGdlbmVy aWMgIm1vbm9zcGFjZSIgZm9udCBhbmQgdGhlIHVzZXIncworICAgICAgICBicm93c2VyLWNvbmZp Z3VyZWQgbW9ub3NwYWNlIGZvbnQgZG9lc24ndCBleGlzdCwgd2UgcHJldmlvdXNseSByZWxpZWQK KyAgICAgICAgb24gZ2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udCB0byBldmVudHVhbGx5IHBpY2sg YSBtb25vc3BhY2UgZm9udCBmb3IgdXMuCisKKyAgICAgICAgQnV0IHRoYXQgZG9lc24ndCBxdWl0 ZSB3b3JrOiBXZWJLaXQgZmlyc3QgZmFsbHMgYmFjayB0byB0aGUgdXNlcidzCisgICAgICAgICJw cmVmZXJyZWQgc3RhbmRhcmQgZm9udCIgYmVmb3JlIGhpdHRpbmcgdGhlIGxhc3QgcmVzb3J0IGNv ZGUgcGF0aC4KKyAgICAgICAgU28gaWYgdGhlIGFib3ZlIGNvbmRpdGlvbnMgaG9sZCBidXQgdGhp cyBmb250IGV4aXN0cywgd2UnbGwgZW5kIHVwCisgICAgICAgIG5ldmVyIGhpdHRpbmcgdGhlIGxh c3QgcmVzb3J0IGNvZGVwYXRoLgorCisgICAgICAgIFRoZSBmaXggaXMgdG8gYWxsb3cgT1MtbGV2 ZWwgZm9udCBmYWxsYmFjayB3aGVuIGZpcnN0IGF0dGVtcHRpbmcgdG8KKyAgICAgICAgcmVzb2x2 ZSBtb25vc3BhY2UuICBUaGUgZXhpc3RpbmcgY29kZSB0cmllZCB0byBkbyB0aGlzLCBidXQgdGhl IGxvZ2ljCisgICAgICAgIHdhcyB3cm9uZy4gIFdlIHdvdWxkIGV2ZW50dWFsbHkgZmFsbCBiYWNr IHRvIHRoZSBjb3JyZWN0IGZvbnQgYW55d2F5CisgICAgICAgIHNvIHdlIGRpZG4ndCBub3RpY2Ug dGhlIGxvZ2ljIHdhcyB3cm9uZy4KKworICAgICAgICBUaGlzIGNvZGUgaXMgYWxsIGhhbmRsaW5n IGNhc2VzIHdoZXJlIHBhcnRpY3VsYXIgZm9udHMgYXJlbid0IGluc3RhbGxlZCwKKyAgICAgICAg c28gSSBjYW4ndCB0aGluayBvZiBhIHdheSB0byB0ZXN0IGl0OyBleGlzdGluZyB0ZXN0cyBzaG91 bGQgc3RpbGwgcGFzcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0Zv bnRDYWNoZUxpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Y3JlYXRlRm9u dFBsYXRmb3JtRGF0YSk6CisKIDIwMTAtMDQtMDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5n b21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IHdoZW4gYnVp bGRpbmcgLS1uby1zdmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vRm9udENhY2hlTGludXguY3BwCmluZGV4IDlkNDFhYTIuLmVjZWNkMTMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXguY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXgu Y3BwCkBAIC0xMDcsNyArMTA3LDkgQEAgRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hlOjpjcmVh dGVGb250UGxhdGZvcm1EYXRhKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm9udEQKICAgICBjb25z dCBjaGFyKiBuYW1lID0gMDsKICAgICBDU3RyaW5nIHM7CiAKLSAgICBpZiAoZmFtaWx5Lmxlbmd0 aCgpID09IDApIHsKKyAgICAvLyBJZiB3ZSdyZSBjcmVhdGluZyBhIGZhbGxiYWNrIGZvbnQgKGUu Zy4gIi13ZWJraXQtbW9ub3NwYWNlIiksIGNvbnZlcnQgdGhlIG5hbWUgaW50bworICAgIC8vIHRo ZSBmYWxsYmFjayBuYW1lIChsaWtlICJtb25vc3BhY2UiKSB0aGF0IGZvbnRjb25maWcgdW5kZXJz dGFuZHMuCisgICAgaWYgKCFmYW1pbHkubGVuZ3RoKCkgfHwgZmFtaWx5LnN0YXJ0c1dpdGgoIi13 ZWJraXQtIikpIHsKICAgICAgICAgc3RhdGljIGNvbnN0IHN0cnVjdCB7CiAgICAgICAgICAgICBG b250RGVzY3JpcHRpb246OkdlbmVyaWNGYW1pbHlUeXBlIG1UeXBlOwogICAgICAgICAgICAgY29u c3QgY2hhciogbU5hbWU7Cg==