<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37030</bug_id>
          
          <creation_ts>2010-04-02 10:43:35 -0700</creation_ts>
          <short_desc>sherrifbot should ensure that the rollout reason doesn&apos;t start with - (and fix webkit-patch upload).</short_desc>
          <delta_ts>2010-04-02 11:05:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Levin">levin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>207935</commentid>
    <comment_count>0</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-04-02 10:43:35 -0700</bug_when>
    <thetext>sherrifbot should ensure that the rollout reason doesn&apos;t start with -</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>207936</commentid>
    <comment_count>1</comment_count>
      <attachid>52423</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2010-04-02 10:46:14 -0700</bug_when>
    <thetext>Created attachment 52423
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>207939</commentid>
    <comment_count>2</comment_count>
      <attachid>52423</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-04-02 10:50:44 -0700</bug_when>
    <thetext>Comment on attachment 52423
Patch

I&apos;d prefer a test for the upload change too, but we can do that in another patch since the script is broken.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>207944</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-04-02 11:05:20 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/57011</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52423</attachid>
            <date>2010-04-02 10:46:14 -0700</date>
            <delta_ts>2010-04-02 10:50:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-37030-20100402104658.patch</filename>
            <type>text/plain</type>
            <size>4009</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCAyNTRiZjI0Li4zNDllYWYxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQt
MDIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNoZXJyaWZib3Qgc2hvdWxkIGVuc3VyZSB0
aGF0IHRoZSByb2xsb3V0IHJlYXNvbiBkb2Vzbid0IHN0YXJ0IHdpdGggLSAoYW5kIGZpeCB3ZWJr
aXQtcGF0Y2ggdXBsb2FkKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTM3MDMwCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No
ZXJpZmYucHk6IEVuc3VyZSB0aGF0IHRoZSByb2xsb3V0IHJlYXNvbiBkb2Vzbid0CisgICAgICAg
ICAgc3RhcnQgd2l0aCAtLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hl
cmlmZmlyY2JvdF91bml0dGVzdC5weTogQSB0ZXN0IHdpdGggYSByb2xsb3V0CisgICAgICAgICAg
cmVhc29uIHdoaWNoIHN0YXJ0cyB3aXRoIC0uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90
b29sL3N0ZXBzL2NyZWF0ZWJ1Zy5weTogRml4IHdlYmtpdC1wYXRjaCB1cGxvYWQuCisKIDIwMTAt
MDQtMDIgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAg
ICAgW3d4XSBCdWlsZCBmaXggZm9yIER1bXBSZW5kZXJUcmVlIGFmdGVyIGFkZGl0aW9uIG9mIGxh
eWVyVHJlZUFzVGV4dC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9ib3Qvc2hlcmlmZi5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9i
b3Qvc2hlcmlmZi5weQppbmRleCAxNmU0NWNjLi5hZDJkZTVkIDEwMDY0NAotLS0gYS9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmYucHkKKysrIGIvV2ViS2l0VG9v
bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmLnB5CkBAIC01MiwxMSArNTIsMTcg
QEAgY2xhc3MgU2hlcmlmZihvYmplY3QpOgogICAgICAgICBzZWxmLl90b29sLmlyYygpLnBvc3Qo
aXJjX21lc3NhZ2UpCiAKICAgICBkZWYgcG9zdF9yb2xsb3V0X3BhdGNoKHNlbGYsIHN2bl9yZXZp
c2lvbiwgcm9sbG91dF9yZWFzb24pOgotICAgICAgICAjIEVuc3VyZSB0aGF0IHN2bl9yZXZpc2lv
biBpcyBhIG51bWJlciAoYW5kIG5vdCBhbiBvcHRpb24gdG8gY3JlYXRlLXJvbGxvdXQpLgorICAg
ICAgICAjIEVuc3VyZSB0aGF0IHN2bl9yZXZpc2lvbiBpcyBhIG51bWJlciAoYW5kIG5vdCBhbiBv
cHRpb24gdG8KKyAgICAgICAgIyBjcmVhdGUtcm9sbG91dCkuCiAgICAgICAgIHRyeToKICAgICAg
ICAgICAgIHN2bl9yZXZpc2lvbiA9IGludChzdm5fcmV2aXNpb24pCiAgICAgICAgIGV4Y2VwdDoK
LSAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9IkludmFsaWQgc3ZuIHJldmlz
aW9uIG51bWJlciBcIiVzXCIuIiAlIHN2bl9yZXZpc2lvbikKKyAgICAgICAgICAgIHJhaXNlIFNj
cmlwdEVycm9yKG1lc3NhZ2U9IkludmFsaWQgc3ZuIHJldmlzaW9uIG51bWJlciBcIiVzXCIuIgor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJSBzdm5fcmV2aXNpb24pCisKKyAgICAgICAg
aWYgcm9sbG91dF9yZWFzb24uc3RhcnRzd2l0aCgiLSIpOgorICAgICAgICAgICAgcmFpc2UgU2Ny
aXB0RXJyb3IobWVzc2FnZT0iVGhlIHJvbGxvdXQgcmVhc29uIG1heSBub3QgYmVnaW4gIgorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIndpdGggLSAoXCIlc1wiKS4iICUgcm9sbG91dF9y
ZWFzb24pCiAKICAgICAgICAgb3V0cHV0ID0gc2VsZi5fc2hlcmlmZmJvdC5ydW5fd2Via2l0X3Bh
dGNoKFsKICAgICAgICAgICAgICJjcmVhdGUtcm9sbG91dCIsCmRpZmYgLS1naXQgYS9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHkg
Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5p
dHRlc3QucHkKaW5kZXggNGY4NzkyNy4uZjMyMTU5ZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv
U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5CisrKyBi
L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0
dGVzdC5weQpAQCAtNzMsNiArNzMsMTYgQEAgY2xhc3MgU2hlcmlmZklSQ0JvdFRlc3QodW5pdHRl
c3QuVGVzdENhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIi0tY29tcG9uZW50PVRvb2xzIDIxNjU0Il0sCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQogCisgICAgZGVm
IHRlc3Rfcm9sbG91dF9pbnZhbGlkYXRlX3JlYXNvbihzZWxmKToKKyAgICAgICAgZXhwZWN0ZWRf
c3RkZXJyID0gKCJNT0NLOiBpcmMucG9zdDogUHJlcGFyaW5nIHJvbGxvdXQgZm9yICIKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICJyMjE2NTQuLi5cbk1PQ0s6IGlyYy5wb3N0OiBGYWlsZWQg
dG8gIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgImNyZWF0ZSByb2xsb3V0IHBhdGNoOlxu
TU9DSzogaXJjLnBvc3Q6IFRoZSByb2xsb3V0IgorICAgICAgICAgICAgICAgICAgICAgICAgICAg
IiByZWFzb24gbWF5IG5vdCBiZWdpbiB3aXRoIC0gKFwiLWJhZFwiKS5cbiIpCisgICAgICAgIE91
dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBydW4sCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBhcmdzPVsicm9sbG91dCAiCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiMjE2NTQgLWJhZCJdLAorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVy
cikKKwogICAgIGRlZiB0ZXN0X3JvbGxvdXRfbm9fcmVhc29uKHNlbGYpOgogICAgICAgICBleHBl
Y3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogVXNhZ2U6IFNWTl9SRVZJ
U0lPTiBSRUFTT05cbiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNl
bGYsIHJ1biwgYXJncz1bInJvbGxvdXQgMjE2NTQiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVk
X3N0ZGVycikKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9z
dGVwcy9jcmVhdGVidWcucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl
cHMvY3JlYXRlYnVnLnB5CmluZGV4IDJkOGQyZmYuLjJmM2Q0MmMgMTAwNjQ0Ci0tLSBhL1dlYktp
dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jcmVhdGVidWcucHkKKysrIGIvV2Vi
S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NyZWF0ZWJ1Zy5weQpAQCAtNDQs
NSArNDQsNSBAQCBjbGFzcyBDcmVhdGVCdWcoQWJzdHJhY3RTdGVwKToKICAgICAgICAgICAgIHJl
dHVybgogICAgICAgICBjYyA9IHNlbGYuX29wdGlvbnMuY2MKICAgICAgICAgaWYgbm90IGNjOgot
ICAgICAgICAgICAgY2MgPSBzdGF0ZVsiYnVnX2NjIl0KKyAgICAgICAgICAgIGNjID0gc3RhdGUu
Z2V0KCJidWdfY2MiKQogICAgICAgICBzdGF0ZVsiYnVnX2lkIl0gPSBzZWxmLl90b29sLmJ1Z3Mu
Y3JlYXRlX2J1ZyhzdGF0ZVsiYnVnX3RpdGxlIl0sIHN0YXRlWyJidWdfZGVzY3JpcHRpb24iXSwg
YmxvY2tlZD1zdGF0ZS5nZXQoImJ1Z19ibG9ja2VkIiksIGNvbXBvbmVudD1zZWxmLl9vcHRpb25z
LmNvbXBvbmVudCwgY2M9Y2MpCg==
</data>
<flag name="review"
          id="35902"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>