37023 2010-04-02 07:06:38 -0700 [Qt] Expose HTMLTokenizer yielding parameters 2010-05-07 16:02:59 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All CLOSED FIXED Qt P2 Normal --- 35784 1 laszlo.gombos laszlo.gombos eric hausmann kenneth ostap73 oldest_to_newest 207849 0 laszlo.gombos 2010-04-02 07:06:38 -0700 These interfaces are useful in CPU-contained environments. Similar interface is exposed in Safari. 207850 1 52415 laszlo.gombos 2010-04-02 07:10:00 -0700 Created attachment 52415 proposed patch 207974 2 kenneth 2010-04-02 11:47:46 -0700 Laszlo should this patch be integrated in our 2.0 release branch after landing on trunk? if so, please add it as blocker. 212660 3 52415 laszlo.gombos 2010-04-14 17:08:51 -0700 Comment on attachment 52415 proposed patch Changed mind, let's use DynamicProperties instead. 218779 4 54667 laszlo.gombos 2010-04-28 20:40:14 -0700 Created attachment 54667 2nd try, using DynamicProperties 218872 5 54667 hausmann 2010-04-29 00:36:18 -0700 Comment on attachment 54667 2nd try, using DynamicProperties > Index: WebKit/qt/ChangeLog > =================================================================== > --- WebKit/qt/ChangeLog (revision 58467) > +++ WebKit/qt/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2010-04-28 Laszlo Gombos <laszlo.1.gombos@nokia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Expose HTMLTokenizer yielding parameters > + https://bugs.webkit.org/show_bug.cgi?id=37023 > + > + Enables to set TimeDelay and ChunkSize for > + HTMLTokenizer. > + > + * Api/qwebpage.cpp: > + (QWebPagePrivate::dynamicPropertyChangeEvent): > + > 2010-04-28 Laszlo Gombos <laszlo.1.gombos@nokia.com> > > Unreviewed, Qt build fix. > Index: WebKit/qt/Api/qwebpage.cpp > =================================================================== > --- WebKit/qt/Api/qwebpage.cpp (revision 58462) > +++ WebKit/qt/Api/qwebpage.cpp (working copy) > @@ -1219,6 +1219,14 @@ void QWebPagePrivate::dynamicPropertyCha > view->forceLayout(); > } > } > + else if (event->propertyName() == "HTMLTokenizerChunkSize") { > + int chunkSize = q->property("HTMLTokenizerChunkSize").toInt(); > + q->handle()->page->setCustomHTMLTokenizerChunkSize(chunkSize); > + } > + else if (event->propertyName() == "HTMLTokenizerTimeDelay") { > + double timeDelay = q->property("HTMLTokenizerTimeDelay").toDouble(); > + q->handle()->page->setCustomHTMLTokenizerTimeDelay(timeDelay); > + } > } > > void QWebPagePrivate::shortcutOverrideEvent(QKeyEvent* event) WebKit/qt/Api/qwebpage.cpp:1222 + else if (event->propertyName() == "HTMLTokenizerChunkSize") { Shouldn't the else be merged with the previous line? :) WebKit/qt/Api/qwebpage.cpp:1230 + } It would be nice to call the base implementation here, just for future proofing. 218873 6 hausmann 2010-04-29 00:36:34 -0700 Do you want this patch in the 2.0 release? 219986 7 eric 2010-05-02 19:30:48 -0700 Attachment 54667 was posted by a committer and has review+, assigning to Laszlo Gombos for commit. 220411 8 54667 laszlo.gombos 2010-05-03 18:59:17 -0700 Comment on attachment 54667 2nd try, using DynamicProperties Committed as http://trac.webkit.org/changeset/58727 with the style change pointed out by Simon. In addition prefixed the property names with _q_ as discussed in bug 38119. 220413 9 laszlo.gombos 2010-05-03 19:01:12 -0700 (In reply to comment #6) > Do you want this patch in the 2.0 release? Yes, please. 221120 10 hausmann 2010-05-05 08:21:45 -0700 <cherry-pick-for-backport: r58727> 222682 11 hausmann 2010-05-07 16:02:46 -0700 Revision r58727 cherry-picked into qtwebkit-2.0 with commit af21ac4af5aee469e8ea1334b0dc56f26d7aa180 52415 2010-04-02 07:10:00 -0700 2010-04-28 20:40:14 -0700 proposed patch 37023.patch text/plain 1543 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTcwMDApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gRXhwb3NlIEhUTUxUb2tlbml6ZXIgeWllbGRpbmcgcGFyYW1ldGVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwMjMK KworICAgICAgICBFbmFibGVzIHRvIHNldCBUaW1lRGVsYXkgYW5kIENodW5rU2l6ZSBmb3IgCisg ICAgICAgIEhUTUxUb2tlbml6ZXIuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAg ICAgICAocXRfd2VicGFnZV9zZXRDdXN0b21IVE1MVG9rZW5pemVyQ2h1bmtTaXplKToKKyAgICAg ICAgKHF0X3dlYnBhZ2Vfc2V0Q3VzdG9tSFRNTFRva2VuaXplclRpbWVEZWxheSk6CisKIDIwMTAt MDQtMDIgIFRhc3VrdSBTdXp1a2kgIDx0YXN1a3Uuc3V6dWtpQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnBhZ2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCShyZXZpc2lvbiA1 Njk5OSkKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NzAsNiArMTcwLDE4IEBAIFFTdHJpbmcgUVdFQktJVF9FWFBPUlQgcXRfd2VicGFnZV9ncm91cE4K ICAgICByZXR1cm4gcGFnZS0+aGFuZGxlKCktPnBhZ2UtPmdyb3VwTmFtZSgpOwogfQogCit2b2lk IFFXRUJLSVRfRVhQT1JUIHF0X3dlYnBhZ2Vfc2V0Q3VzdG9tSFRNTFRva2VuaXplckNodW5rU2l6 ZShRV2ViUGFnZSogcGFnZSwgaW50IGNodW5rU2l6ZSkKK3sKKyAgICBpZiAocGFnZSkKKyAgICAg ICAgcGFnZS0+aGFuZGxlKCktPnBhZ2UtPnNldEN1c3RvbUhUTUxUb2tlbml6ZXJDaHVua1NpemUo Y2h1bmtTaXplKTsKK30KKwordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF93ZWJwYWdlX3NldEN1c3Rv bUhUTUxUb2tlbml6ZXJUaW1lRGVsYXkoUVdlYlBhZ2UqIHBhZ2UsIGRvdWJsZSB0aW1lRGVsYXkp Cit7CisgICAgaWYgKHBhZ2UpCisgICAgICAgIHBhZ2UtPmhhbmRsZSgpLT5wYWdlLT5zZXRDdXN0 b21IVE1MVG9rZW5pemVyVGltZURlbGF5KHRpbWVEZWxheSk7Cit9CisKICNpZiBFTkFCTEUoSU5T UEVDVE9SKQogdm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfd2ViaW5zcGVjdG9yX2V4ZWN1dGVT Y3JpcHQoUVdlYlBhZ2UqIHBhZ2UsIGxvbmcgY2FsbElkLCBjb25zdCBRU3RyaW5nJiBzY3JpcHQp CiB7Cg== 54667 2010-04-28 20:40:14 -0700 2010-05-03 18:59:17 -0700 2nd try, using DynamicProperties 37023.patch text/plain 1482 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTg0NjcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gRXhwb3NlIEhUTUxUb2tlbml6ZXIgeWllbGRpbmcgcGFyYW1ldGVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwMjMK KworICAgICAgICBFbmFibGVzIHRvIHNldCBUaW1lRGVsYXkgYW5kIENodW5rU2l6ZSBmb3IgCisg ICAgICAgIEhUTUxUb2tlbml6ZXIuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAg ICAgICAoUVdlYlBhZ2VQcml2YXRlOjpkeW5hbWljUHJvcGVydHlDaGFuZ2VFdmVudCk6CisKIDIw MTAtMDQtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIFF0IGJ1aWxkIGZpeC4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdl YnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCShyZXZp c2lvbiA1ODQ2MikKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMjE5LDYgKzEyMTksMTQgQEAgdm9pZCBRV2ViUGFnZVByaXZhdGU6OmR5bmFtaWNQcm9w ZXJ0eUNoYQogICAgICAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKICAgICAgICAgfQogICAg IH0KKyAgICBlbHNlIGlmIChldmVudC0+cHJvcGVydHlOYW1lKCkgPT0gIkhUTUxUb2tlbml6ZXJD aHVua1NpemUiKSB7CisgICAgICAgIGludCBjaHVua1NpemUgPSBxLT5wcm9wZXJ0eSgiSFRNTFRv a2VuaXplckNodW5rU2l6ZSIpLnRvSW50KCk7CisgICAgICAgIHEtPmhhbmRsZSgpLT5wYWdlLT5z ZXRDdXN0b21IVE1MVG9rZW5pemVyQ2h1bmtTaXplKGNodW5rU2l6ZSk7CisgICAgfQorICAgIGVs c2UgaWYgKGV2ZW50LT5wcm9wZXJ0eU5hbWUoKSA9PSAiSFRNTFRva2VuaXplclRpbWVEZWxheSIp IHsKKyAgICAgICAgZG91YmxlIHRpbWVEZWxheSA9IHEtPnByb3BlcnR5KCJIVE1MVG9rZW5pemVy VGltZURlbGF5IikudG9Eb3VibGUoKTsKKyAgICAgICAgcS0+aGFuZGxlKCktPnBhZ2UtPnNldEN1 c3RvbUhUTUxUb2tlbml6ZXJUaW1lRGVsYXkodGltZURlbGF5KTsKKyAgICB9CiB9CiAKIHZvaWQg UVdlYlBhZ2VQcml2YXRlOjpzaG9ydGN1dE92ZXJyaWRlRXZlbnQoUUtleUV2ZW50KiBldmVudCkK