37011 2010-04-01 22:23:45 -0700 Position::primaryDirection() should not use its own accessor. 2010-04-02 17:38:38 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC All RESOLVED FIXED P5 Normal --- 0 morrita webkit-unassigned commit-queue oldest_to_newest 207672 0 morrita 2010-04-01 22:23:45 -0700 Position::primaryDirection() uses Position::node(), which should be replaced with accessing Position::m_anchorNode directly. This bug is to take the feedback on Bug 36948, whose patch was accidentally landed before tiny cleanup. 207674 1 52379 morrita 2010-04-01 22:28:16 -0700 Created attachment 52379 v0; small cleanup only 207719 2 52379 eric 2010-04-01 23:41:41 -0700 Comment on attachment 52379 v0; small cleanup only Why is this better? 208133 3 52379 ap 2010-04-02 16:21:06 -0700 Comment on attachment 52379 v0; small cleanup only r=me That's just the preferred style. One thing this helps with is making debugging easier - you don't need to step into accessor functions that much. 208184 4 52379 commit-queue 2010-04-02 17:38:34 -0700 Comment on attachment 52379 v0; small cleanup only Clearing flags on attachment: 52379 Committed r57037: <http://trac.webkit.org/changeset/57037> 208185 5 commit-queue 2010-04-02 17:38:38 -0700 All reviewed patches have been landed. Closing bug. 52379 2010-04-01 22:28:16 -0700 2010-04-02 17:38:34 -0700 v0; small cleanup only bug-37011-20100402142814.patch text/plain 1305 morrita ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWE1Njg1ZC4uZjYwNzZkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMC0wNC0wMSAgTU9SSVRBIEhhamlt ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzcwMTEKKyAgICAgICAgUG9zaXRpb246OnByaW1hcnlEaXJlY3Rpb24oKSBzaG91bGQgbm90IHVz ZSBpdHMgb3duIGFjY2Vzc29yLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBpcyBzbWFs bCBjbGVuYXVwIHdpdGggbm8gYmVoYXZpb3VyIGNoYW5nZS4KKworICAgICAgICAqIGRvbS9Qb3Np dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6cHJpbWFyeURpcmVjdGlvbik6 CisKKzIwMTAtMDQtMDEgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCiAKICAgICAgICAgV2ViQ29yZTo6RG9jdW1l bnQ6OnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cyBOVUxMIHBvaW50ZXIKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9u LmNwcAppbmRleCAzZjBhMGU4Li5mYTk5NGUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3Np dGlvbi5jcHAKKysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMTQzLDcgKzExNDMs NyBAQCB2b2lkIFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFmZmlu aXR5LCBUZXh0RGlyZWN0aW9uIHByaW1hcnlEaQogVGV4dERpcmVjdGlvbiBQb3NpdGlvbjo6cHJp bWFyeURpcmVjdGlvbigpIGNvbnN0CiB7CiAgICAgVGV4dERpcmVjdGlvbiBwcmltYXJ5RGlyZWN0 aW9uID0gTFRSOwotICAgIGZvciAoY29uc3QgUmVuZGVyT2JqZWN0KiByID0gbm9kZSgpLT5yZW5k ZXJlcigpOyByOyByID0gci0+cGFyZW50KCkpIHsKKyAgICBmb3IgKGNvbnN0IFJlbmRlck9iamVj dCogciA9IG1fYW5jaG9yTm9kZS0+cmVuZGVyZXIoKTsgcjsgciA9IHItPnBhcmVudCgpKSB7CiAg ICAgICAgIGlmIChyLT5pc0Jsb2NrRmxvdygpKSB7CiAgICAgICAgICAgICBwcmltYXJ5RGlyZWN0 aW9uID0gci0+c3R5bGUoKS0+ZGlyZWN0aW9uKCk7CiAgICAgICAgICAgICBicmVhazsK