37009 2010-04-01 21:53:09 -0700 The master commit-queue process should take responsibility for checking that the builders are green 2010-04-02 01:18:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 207653 0 abarth 2010-04-01 21:53:09 -0700 The master commit-queue process should take responsibility for checking that the builders are green 207655 1 52374 abarth 2010-04-01 21:53:56 -0700 Created attachment 52374 Patch 207660 2 52374 eric 2010-04-01 22:00:38 -0700 Comment on attachment 52374 Patch + "--ignore-builders", That change needs a comment to later developers that that's right, and remind them not to remove the builders_are_green check above! :) 207666 3 52376 abarth 2010-04-01 22:17:31 -0700 Created attachment 52376 Patch 207801 4 52376 abarth 2010-04-02 01:18:54 -0700 Comment on attachment 52376 Patch Clearing flags on attachment: 52376 Committed r56986: <http://trac.webkit.org/changeset/56986> 207802 5 abarth 2010-04-02 01:18:59 -0700 All reviewed patches have been landed. Closing bug. 52374 2010-04-01 21:53:56 -0700 2010-04-01 22:17:27 -0700 Patch bug-37009-20100401215354.patch text/plain 1702 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YjE0NmFmLi4zOTlmMTE3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTAtMDQt MDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWFzdGVyIGNvbW1pdC1xdWV1ZSBwcm9j ZXNzIHNob3VsZCB0YWtlIHJlc3BvbnNpYmlsaXR5IGZvciBjaGVja2luZyB0aGF0IHRoZSBidWls ZGVycyBhcmUgZ3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM3MDA5CisKKyAgICAgICAgV2UgaGFkIGEgZmFpbHVyZSB3aGVyZSB0aGUgY2hpbGQg cHJvY2VzcyBub3RpY2VkIHRoYXQgdGhlIGJ1aWxkZXJzIHdlcmUKKyAgICAgICAgcmVkLiAgV2Un dmUgYWx3YXlzIGhhZCB0aGlzIHJhY2UgY29uZGl0aW9uLCBidXQgdGhlIG5ldyBvcHRpbWlzdGlj CisgICAgICAgIGRlc2lnbiBtYWRlIGl0IGVhc2llciB0byB0cmlnZ2VyLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToKKworMjAxMC0wNC0wMSAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVy aWMgU2VpZGVsLgogCiAgICAgICAgIEltcHJvdmUgdGhlIGVycm9yIGhhbmRsaW5nIGluIHJvbGxv dXQgYSBiaXQKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9xdWV1ZXMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcXVldWVzLnB5CmluZGV4IDZjYzRhNTEuLjA5MzY0ODcgMTAwNjQ0Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQpAQCAtMjA1 LDEwICsyMDUsMTUgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RQYXRjaFF1ZXVlLCBTdGVw U2VxdWVuY2VFcnJvckhhbmRsZXIpOgogCiAgICAgZGVmIF9sYW5kKHNlbGYsIHBhdGNoLCBmaXJz dF9ydW49RmFsc2UpOgogICAgICAgICB0cnk6CisgICAgICAgICAgICBpZiBub3Qgc2VsZi5fYnVp bGRlcnNfYXJlX2dyZWVuKCk6CisgICAgICAgICAgICAgICAgIyBXZSByZXR1cm4gdHJ1ZSBoZXJl IGJlY2F1c2Ugd2Ugd2FudCB0byByZXR1cm4gdG8gdGhlIG1haW4KKyAgICAgICAgICAgICAgICAj IFF1ZXVlRW5naW5lIGxvb3AgYXMgcXVpY2tseSBhcyBwb3NzaWJsZS4KKyAgICAgICAgICAgICAg ICByZXR1cm4gVHJ1ZQogICAgICAgICAgICAgYXJncyA9IFsKICAgICAgICAgICAgICAgICAibGFu ZC1hdHRhY2htZW50IiwKICAgICAgICAgICAgICAgICAiLS1mb3JjZS1jbGVhbiIsCiAgICAgICAg ICAgICAgICAgIi0tbm9uLWludGVyYWN0aXZlIiwKKyAgICAgICAgICAgICAgICAiLS1pZ25vcmUt YnVpbGRlcnMiLAogICAgICAgICAgICAgICAgICItLWJ1aWxkLXN0eWxlPWJvdGgiLAogICAgICAg ICAgICAgICAgICItLXF1aWV0IiwKICAgICAgICAgICAgICAgICBwYXRjaC5pZCgpCg== 52376 2010-04-01 22:17:31 -0700 2010-04-02 01:18:53 -0700 Patch bug-37009-20100401221730.patch text/plain 1817 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhOWYwZDRiLi4wZDRjMWNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQt MDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWFzdGVyIGNvbW1pdC1xdWV1ZSBwcm9j ZXNzIHNob3VsZCB0YWtlIHJlc3BvbnNpYmlsaXR5IGZvciBjaGVja2luZyB0aGF0IHRoZSBidWls ZGVycyBhcmUgZ3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM3MDA5CisKKyAgICAgICAgV2UgaGFkIGEgZmFpbHVyZSB3aGVyZSB0aGUgY2hpbGQg cHJvY2VzcyBub3RpY2VkIHRoYXQgdGhlIGJ1aWxkZXJzIHdlcmUKKyAgICAgICAgcmVkLiAgV2Un dmUgYWx3YXlzIGhhZCB0aGlzIHJhY2UgY29uZGl0aW9uLCBidXQgdGhlIG5ldyBvcHRpbWlzdGlj CisgICAgICAgIGRlc2lnbiBtYWRlIGl0IGVhc2llciB0byB0cmlnZ2VyLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToKKwogMjAxMC0wNC0wMSAg S2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g QWRkIG1pc3NpbmcgbGljZW5zZSBoZWFkZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQppbmRleCA2Y2M0YTUxLi4wMmQ5NTZh IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv cXVldWVzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXMucHkKQEAgLTIwNSwxMCArMjA1LDE3IEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFic3Ry YWN0UGF0Y2hRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKToKIAogICAgIGRlZiBfbGFu ZChzZWxmLCBwYXRjaCwgZmlyc3RfcnVuPUZhbHNlKToKICAgICAgICAgdHJ5OgorICAgICAgICAg ICAgaWYgbm90IHNlbGYuX2J1aWxkZXJzX2FyZV9ncmVlbigpOgorICAgICAgICAgICAgICAgICMg V2UgcmV0dXJuIHRydWUgaGVyZSBiZWNhdXNlIHdlIHdhbnQgdG8gcmV0dXJuIHRvIHRoZSBtYWlu CisgICAgICAgICAgICAgICAgIyBRdWV1ZUVuZ2luZSBsb29wIGFzIHF1aWNrbHkgYXMgcG9zc2li bGUuCisgICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKICAgICAgICAgICAgIGFyZ3MgPSBbCiAg ICAgICAgICAgICAgICAgImxhbmQtYXR0YWNobWVudCIsCiAgICAgICAgICAgICAgICAgIi0tZm9y Y2UtY2xlYW4iLAogICAgICAgICAgICAgICAgICItLW5vbi1pbnRlcmFjdGl2ZSIsCisgICAgICAg ICAgICAgICAgIyBUaGUgbWFzdGVyIHByb2Nlc3MgaXMgcmVzcG9uc2libGUgZm9yIGNoZWNraW5n IHRoZSBzdGF0dXMKKyAgICAgICAgICAgICAgICAjIG9mIHRoZSBidWlsZGVycyAoc2VlIGFib3Zl IGNhbGwgdG8gX2J1aWxkZXJzX2FyZV9ncmVlbikuCisgICAgICAgICAgICAgICAgIi0taWdub3Jl LWJ1aWxkZXJzIiwKICAgICAgICAgICAgICAgICAiLS1idWlsZC1zdHlsZT1ib3RoIiwKICAgICAg ICAgICAgICAgICAiLS1xdWlldCIsCiAgICAgICAgICAgICAgICAgcGF0Y2guaWQoKQo=