37001 2010-04-01 18:33:16 -0700 sheriffbot rollout should verify that the svn revision is a number. 2010-04-01 18:45:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin webkit-unassigned abarth eric oldest_to_newest 207582 0 levin 2010-04-01 18:33:16 -0700 sheriffbot rollout should verify that the svn revision is a number. 207585 1 52364 levin 2010-04-01 18:37:03 -0700 Created attachment 52364 Patch 207588 2 52364 abarth 2010-04-01 18:41:03 -0700 Comment on attachment 52364 Patch This is good, but I'm about to remove the IRC post of the ScriptError. You should add it back when you land this though. Also, we should validate that the first character of reason isn't a "-". 207589 3 levin 2010-04-01 18:45:56 -0700 Committed as http://trac.webkit.org/changeset/56960 52364 2010-04-01 18:37:03 -0700 2010-04-01 18:41:02 -0700 Patch bug-37001-20100401183750.patch text/plain 4323 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkZGZiZGI5Li42YTEyMzNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MDEgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNoZXJpZmZib3Qgcm9sbG91dCBzaG91bGQg dmVyaWZ5IHRoYXQgdGhlIHN2biByZXZpc2lvbiBpcyBhIG51bWJlci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MDAxCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEucHk6IEFsbG93IGZvciB0aGUgbWVzc2Fn ZSB0byBiZSBOb25lLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlm Zi5weTogRGlkIHZlcmlmaWNhdGlvbiB0aGF0IHN2biByZXZpc2lvbgorICAgICAgICAgaXMgYSBu dW1iZXIuIEZpeGVkIHRoZSBpbXBvcnRzIChzaW5jZSB0aGUgZmlsZXMgdXNlcyBTY3JpcHRFcnJv ciBhbmQgbG9nKQorICAgICAgICAgYW5kIGEgdHlwby4gICAgICAgCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5OiBBZGRlZCBhIHRl c3QgdG8gdmVyaWZ5CisgICAgICAgICB0aGUgYmVoYXZpb3IuCisKIDIwMTAtMDQtMDEgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNl aWRlbC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9idWd6aWxsYS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWd6aWxsYS5weQppbmRleCA4NDQwODQ3Li4xOTUxYzY4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEucHkKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhLnB5CkBAIC01MSw2ICs1MSw4 IEBAIGZyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5CZWF1dGlmdWxTb3VwIGltcG9ydCBCZWF1dGlm dWxTb3VwLCBTb3VwU3RyYWluZXIKIAogCiBkZWYgcGFyc2VfYnVnX2lkKG1lc3NhZ2UpOgorICAg IGlmIG5vdCBtZXNzYWdlOgorICAgICAgICByZXR1cm4gTm9uZQogICAgIG1hdGNoID0gcmUuc2Vh cmNoKCJodHRwXDovL3dlYmtpdFwub3JnL2IvKD9QPGJ1Z19pZD5cZCspIiwgbWVzc2FnZSkKICAg ICBpZiBtYXRjaDoKICAgICAgICAgcmV0dXJuIGludChtYXRjaC5ncm91cCgnYnVnX2lkJykpCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmYu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmYucHkKaW5k ZXggZDc1NzkwZi4uMTZlNDVjYyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9zaGVyaWZmLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9ib3Qvc2hlcmlmZi5weQpAQCAtMjgsNiArMjgsOCBAQAogCiBmcm9tIHdlYmtpdHB5 LmNvbW1vbi5jaGVja291dC5jaGFuZ2Vsb2cgaW1wb3J0IHZpZXdfc291cmNlX3VybAogZnJvbSB3 ZWJraXRweS5jb21tb24ubmV0LmJ1Z3ppbGxhIGltcG9ydCBwYXJzZV9idWdfaWQKK2Zyb20gd2Vi a2l0cHkuY29tbW9uLnN5c3RlbS5kZXByZWNhdGVkX2xvZ2dpbmcgaW1wb3J0IGxvZworZnJvbSB3 ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgU2NyaXB0RXJyb3IKIGZyb20g d2Via2l0cHkudG9vbC5ncmFtbWFyIGltcG9ydCBqb2luX3dpdGhfc2VwYXJhdG9ycwogCiAKQEAg LTUwLDEyICs1MiwxOCBAQCBjbGFzcyBTaGVyaWZmKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3Rv b2wuaXJjKCkucG9zdChpcmNfbWVzc2FnZSkKIAogICAgIGRlZiBwb3N0X3JvbGxvdXRfcGF0Y2go c2VsZiwgc3ZuX3JldmlzaW9uLCByb2xsb3V0X3JlYXNvbik6CisgICAgICAgICMgRW5zdXJlIHRo YXQgc3ZuX3JldmlzaW9uIGlzIGEgbnVtYmVyIChhbmQgbm90IGFuIG9wdGlvbiB0byBjcmVhdGUt cm9sbG91dCkuCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHN2bl9yZXZpc2lvbiA9IGludChz dm5fcmV2aXNpb24pCisgICAgICAgIGV4Y2VwdDoKKyAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVy cm9yKG1lc3NhZ2U9IkludmFsaWQgc3ZuIHJldmlzaW9uIG51bWJlciBcIiVzXCIuIiAlIHN2bl9y ZXZpc2lvbikKKwogICAgICAgICBvdXRwdXQgPSBzZWxmLl9zaGVyaWZmYm90LnJ1bl93ZWJraXRf cGF0Y2goWwogICAgICAgICAgICAgImNyZWF0ZS1yb2xsb3V0IiwKICAgICAgICAgICAgICItLWZv cmNlLWNsZWFuIiwKICAgICAgICAgICAgICMgSW4gcHJpbmNpcGxlLCB3ZSBzaG91bGQgcGFzcyAt LW5vbi1pbnRlcmFjdGl2ZSBoZXJlLCBidXQgaXQKICAgICAgICAgICAgICMgdHVybnMgb3V0IHRo YXQgY3JlYXRlLXJvbGxvdXQgZG9lc24ndCBuZWVkIGl0IHlldC4gIFdlIGNhbid0Ci0gICAgICAg ICAgICAjIHBhc3MgaXQgcHJvcGh5bGFjdGljYWxseSBiZWNhdXNlIHdlIHJlamVjdCB1bnJlY29u Z2l6ZWQgY29tbWFuZAorICAgICAgICAgICAgIyBwYXNzIGl0IHByb3BoeWxhY3RpY2FsbHkgYmVj YXVzZSB3ZSByZWplY3QgdW5yZWNvZ25pemVkIGNvbW1hbmQKICAgICAgICAgICAgICMgbGluZSBz d2l0Y2hlcy4KICAgICAgICAgICAgICItLXBhcmVudC1jb21tYW5kPXNoZXJpZmYtYm90IiwKICAg ICAgICAgICAgIHN2bl9yZXZpc2lvbiwKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5weQppbmRl eCBiZDNmOTlhLi44MzFiZGM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5CkBAIC02 NCw2ICs2NCwxNiBAQCBjbGFzcyBTaGVyaWZmSVJDQm90VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6 CiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogVXNhZ2U6IFNWTl9S RVZJU0lPTiBSRUFTT05cbiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRz KHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgYmFuYW5hcyJdLCBleHBlY3RlZF9zdGRlcnI9ZXhw ZWN0ZWRfc3RkZXJyKQogCisgICAgZGVmIHRlc3Rfcm9sbG91dF9pbnZhbGlkYXRlX3JldmlzaW9u KHNlbGYpOgorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAoIk1PQ0s6IGlyYy5wb3N0OiBQcmVw YXJpbmcgcm9sbG91dCBmb3IgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgInItLWNvbXBv bmVudD1Ub29scy4uLlxuTU9DSzogaXJjLnBvc3Q6IEZhaWxlZCB0byAiCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAiY3JlYXRlIHJvbGxvdXQgcGF0Y2g6XG5NT0NLOiBpcmMucG9zdDogSW52 YWxpZCBzdm4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAiIHJldmlzaW9uIG51bWJlciBc Ii0tY29tcG9uZW50PVRvb2xzXCIuXG4iKQorICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0 X291dHB1dHMoc2VsZiwgcnVuLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYXJncz1bInJvbGxvdXQgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIi0tY29tcG9uZW50PVRvb2xzIDIxNjU0Il0sCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQorCiAg ICAgZGVmIHRlc3Rfcm9sbG91dF9ub19yZWFzb24oc2VsZik6CiAgICAgICAgIGV4cGVjdGVkX3N0 ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogVXNhZ2U6IFNWTl9SRVZJU0lPTiBSRUFTT05cbiIKICAg ICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJv bGxvdXQgMjE2NTQiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikK