36997 2010-04-01 17:45:20 -0700 LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html should not use a new-style cookie 2010-06-11 10:42:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW InRadar P2 Normal --- 16699 1 ddkilzer webkit-unassigned abarth eric jchaffraix oldest_to_newest 207547 0 ddkilzer 2010-04-01 17:45:20 -0700 * SUMMARY LayoutTests/http/tests/cookies/double-quoted-value-with-semi-colon.html uses a "Version=1", new-style cookie (as specified in <http://www.ietf.org/rfc/rfc2109.txt>). However, the cookie testing code doesn't support this type of cookie yet, so it should be changed back to an original-style cookie. 207549 1 ddkilzer 2010-04-01 17:46:12 -0700 I filed Bug 36998 to add support for testing RFC-2109-style cookies. 207554 2 52359 ddkilzer 2010-04-01 17:51:39 -0700 Created attachment 52359 Patch v1 207591 3 ddkilzer 2010-04-01 18:52:49 -0700 <rdar://problem/7767948> 207723 4 eric 2010-04-01 23:46:07 -0700 Adam says this test is wrong. I've CC'd him and he can explain why. 207727 5 abarth 2010-04-01 23:51:52 -0700 This cookie isn't correct according to the new cookie spec: https://datatracker.ietf.org/doc/draft-ietf-httpstate-cookie/ Quoted cookie values were a fantasy invented by 2109 to cause pain in the world. 207888 6 52359 abarth 2010-04-02 09:43:55 -0700 Comment on attachment 52359 Patch v1 The line of code should read: cookiesShouldBe('disorder="477beccb;richard";Path=/', 'disorder="477beccb'); I'd rather we tested non-esoteric properties of cookies before testing this particular case (which is wrong in CFNetwork). 208312 7 ddkilzer 2010-04-03 16:50:17 -0700 Perhaps we should simply remove the test. Is there a related test in your test suite? I've updated Bug 36998 for importing your cookie test suite rather than writing tests for RFC 2109. 52359 2010-04-01 17:51:39 -0700 2010-06-11 10:42:44 -0700 Patch v1 bug-36997-20100401175138.patch text/plain 1529 ddkilzer ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmY2Y2YjJlLi43OGEwOGNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MDEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi8zNjk5Nz4gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL2RvdWJs ZS1xdW90ZWQtdmFsdWUtd2l0aC1zZW1pLWNvbG9uLmh0bWwgc2hvdWxkIG5vdCB1c2UgYSBuZXct c3R5bGUgY29va2llCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBodHRwL3Rlc3RzL2Nvb2tpZXMvc2NyaXB0LXRlc3RzL2RvdWJsZS1xdW90ZWQtdmFs dWUtd2l0aC1zZW1pLWNvbG9uLmpzOgorICAgICAgICBSZW1vdmVkICJWZXJzaW9uPTE7IiBmcm9t IHRoZSBjb29raWUgc28gdGhhdCB3ZSBzdG9wIHNldHRpbmcgYW4KKyAgICAgICAgUkZDLTIxMDkt c3R5bGUgY29va2llIHdoZW4gdGVzdGluZy4gIEFkZGluZyBzdXBwb3J0IGZvciB0ZXN0aW5nCisg ICAgICAgIHRoYXQgdHlwZSBvZiBjb29raWUgaXMgY292ZXJlZCBieSBCdWcgMzY5OTguCisKIDIw MTAtMDMtMjcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Jl IHVwZGF0ZWQgcmVzdWx0cyBmb3IgcjU2NjczLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9jb29raWVzL3NjcmlwdC10ZXN0cy9kb3VibGUtcXVvdGVkLXZhbHVlLXdpdGgtc2Vt aS1jb2xvbi5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9zY3JpcHQtdGVzdHMv ZG91YmxlLXF1b3RlZC12YWx1ZS13aXRoLXNlbWktY29sb24uanMKaW5kZXggOTAyOTg3NS4uNjlh MmY1YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL3NjcmlwdC10 ZXN0cy9kb3VibGUtcXVvdGVkLXZhbHVlLXdpdGgtc2VtaS1jb2xvbi5qcworKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2Nvb2tpZXMvc2NyaXB0LXRlc3RzL2RvdWJsZS1xdW90ZWQtdmFsdWUt d2l0aC1zZW1pLWNvbG9uLmpzCkBAIC01LDcgKzUsNyBAQCBkZXNjcmlwdGlvbigKIGNsZWFyQWxs Q29va2llcygpOwogCiBkZWJ1ZygiQ2hlY2sgdGhhdCBzZXR0aW5nIGEgY29va2llIHdpdGggYSBz ZW1pLWNvbG9uIGluIGEgZHVvYmxlLXF1b3RlZCB2YWx1ZSB3b3JrcyIpOwotY29va2llc1Nob3Vs ZEJlKCdkaXNvcmRlcj0iNDc3YmVjY2I7cmljaGFyZCI7VmVyc2lvbj0xO1BhdGg9LycsICdkaXNv cmRlcj0iNDc3YmVjY2I7cmljaGFyZCInKTsKK2Nvb2tpZXNTaG91bGRCZSgnZGlzb3JkZXI9IjQ3 N2JlY2NiO3JpY2hhcmQiO1BhdGg9LycsICdkaXNvcmRlcj0iNDc3YmVjY2I7cmljaGFyZCInKTsK IGNsZWFyQ29va2llcygpOwogCiBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=