36994 2010-04-01 17:25:03 -0700 Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements 2010-04-02 10:41:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser benjamin mitz oldest_to_newest 207526 0 simon.fraser 2010-04-01 17:25:03 -0700 FrameView::scrollPositionChanged() does some widget updating, and compositing layer updating that is unnecessary if there are no fixed position elements. And, thanks to bug 33150, we know if the FrameView contains fixed position objects. 207551 1 52358 simon.fraser 2010-04-01 17:47:34 -0700 Created attachment 52358 Patch 207602 2 52358 darin 2010-04-01 19:45:03 -0700 Comment on attachment 52358 Patch > + bool hasFixedObjects() const { return m_fixedObjectCount > 0; } Since this is used only inside the class, can we make the function private? Members generally should be as private as possible. Or maybe just say && m_fixedObjectCount at the call site? r=me 207933 3 simon.fraser 2010-04-02 10:41:23 -0700 http://trac.webkit.org/changeset/57009 52358 2010-04-01 17:47:34 -0700 2010-04-01 19:45:03 -0700 Patch bug-36994-20100401174733.patch text/plain 2013 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODRiZDVmNC4uYTYxZjMxMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wNC0wMSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBdm9pZCBkb2luZyB3b3JrIGluIEZyYW1lVmlldzo6c2Nyb2xs UG9zaXRpb25DaGFuZ2VkKCkgaWYgdGhlcmUgYXJlIG5vIGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjk5NAor ICAgICAgICAKKyAgICAgICAgcjU1ODkwIGFkZGVkIGtub3dsZWRnZSB0byBGcmFtZVZpZXcgYWJv dXQgd2hldGhlciBpdCBjb250YWlucyBhbnkgZml4ZWQtcG9zaXRpb24gZWxlbWVudHMuIFdlIGNh bgorICAgICAgICB1c2UgdGhpcyB0byBhdm9pZCB1cGRhdGluZyB3aWRnZXQgcG9zaXRpb25zLCBh bmQgY29tcG9zaXRpbmcgbGF5ZXIgcG9zaXRpb25zIHdoZW4gcG9zc2libGUuCisKKyAgICAgICAg KiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnNjcm9s bFBvc2l0aW9uQ2hhbmdlZCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lVmlldzo6aGFzRml4ZWRPYmplY3RzKToKKworMjAxMC0wNC0wMSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBObyByZXZpZXcu CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgY2FzdHMgdGhhdCBJIGluZGVuZGVkIHRvIHJlbW92ZSBi ZWZvcmUgY29tbWl0dGluZyByNTY5NDguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcCBiL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGYzODVlMDIuLjg5OTQ1 MzEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xMDY3LDggKzEwNjcsNyBAQCB2b2lkIEZyYW1lVmlldzo6 c2Nyb2xsUG9zaXRpb25DaGFuZ2VkKCkKIAogICAgIC8vIEZvciBmaXhlZCBwb3NpdGlvbiBlbGVt ZW50cywgdXBkYXRlIHdpZGdldCBwb3NpdGlvbnMgYW5kIGNvbXBvc2l0aW5nIGxheWVycyBhZnRl ciBzY3JvbGxpbmcsCiAgICAgLy8gYnV0IG9ubHkgaWYgd2UncmUgbm90IGluc2lkZSBvZiBsYXlv dXQuCi0gICAgLy8gRklYTUU6IHdlIGNvdWxkIHNraXAgdGhpcyBpZiB3ZSBrbmV3IHRoZSBwYWdl IGhhZCBubyBmaXhlZCBwb3NpdGlvbiBlbGVtZW50cy4KLSAgICBpZiAoIW1fbmVzdGVkTGF5b3V0 Q291bnQpIHsKKyAgICBpZiAoIW1fbmVzdGVkTGF5b3V0Q291bnQgJiYgaGFzRml4ZWRPYmplY3Rz KCkpIHsKICAgICAgICAgaWYgKFJlbmRlclZpZXcqIHJvb3QgPSBtX2ZyYW1lLT5jb250ZW50UmVu ZGVyZXIoKSkgewogICAgICAgICAgICAgcm9vdC0+dXBkYXRlV2lkZ2V0UG9zaXRpb25zKCk7CiAj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5oIGIvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCmluZGV4IDczNzFkMTMuLmYy MWI4NGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTE1NCw2ICsxNTQsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lk IGFkZEZpeGVkT2JqZWN0KCk7CiAgICAgdm9pZCByZW1vdmVGaXhlZE9iamVjdCgpOworICAgIGJv b2wgaGFzRml4ZWRPYmplY3RzKCkgY29uc3QgeyByZXR1cm4gbV9maXhlZE9iamVjdENvdW50ID4g MDsgfQogCiAgICAgdm9pZCBiZWdpbkRlZmVycmVkUmVwYWludHMoKTsKICAgICB2b2lkIGVuZERl ZmVycmVkUmVwYWludHMoKTsK