36985 2010-04-01 15:59:16 -0700 webkit-patch can incorrectly think the working directory is modified 2010-04-01 16:49:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned webkit.review.bot oldest_to_newest 207453 0 ojan 2010-04-01 15:59:16 -0700 webkit-patch can incorrectly think the working directory is modified 207456 1 52346 ojan 2010-04-01 16:00:39 -0700 Created attachment 52346 Patch 207460 2 52346 eric 2010-04-01 16:03:11 -0700 Comment on attachment 52346 Patch I think git svn needs this too! git svn rebase seems to fail to "you need to update" commonly even when I don't need to. We need to test this though. 207462 3 webkit.review.bot 2010-04-01 16:05:45 -0700 Attachment 52346 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 207491 4 52352 ojan 2010-04-01 16:46:47 -0700 Created attachment 52352 Patch 207495 5 ojan 2010-04-01 16:49:23 -0700 Committed r56950: <http://trac.webkit.org/changeset/56950> 52346 2010-04-01 16:00:39 -0700 2010-04-01 16:46:44 -0700 Patch bug-36985-20100401160038.patch text/plain 1510 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4ZWM4NWM4Li4wMWM0MGUwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MDEgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggY2FuIGluY29ycmVjdGx5 IHRoaW5rIHRoZSB3b3JraW5nIGRpcmVjdG9yeSBpcyBtb2RpZmllZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5ODUKKworCUlmIGEgZmlsZSdzIG1v ZGlmaWNhdGlvbiB0aW1lIGlzIG1vZGlmaWVkLCBidXQgdGhlIGNvbnRlbnRzIGFyZSBub3QsCisg ICAgICAgIHRoZW4gZGlmZi1pbmRleCB3aWxsIHRoaW5rIHRoZSBmaWxlIGhhcyBiZWVuIG1vZGlm aWVkIHVubGVzcyB5b3UgZG8KKyAgICAgICAgc29tZSBjcmF6eSB1cGRhdGUtaW5kZXggY2FsbC4g SW5zdGVhZCwgY2FsbCBkaWZmIC0tbmFtZS1vbmx5LCB3aGljaAorICAgICAgICBoYXMgdGhlIGlu ZGV4IHVwZGF0ZSBidWlsdGluLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y2hlY2tvdXQvc2NtLnB5OgorCiAyMDEwLTA0LTAxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBvbmx5IGlnbm9yaW5nIGNoYXR0eSBzdHlsZSBl cnJvcnMuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j aGVja291dC9zY20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9zY20ucHkKaW5kZXggNmU3YTg5ZS4uMWUwNjcxNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQpAQCAtMzk1LDcgKzM5 NSw3IEBAIGNsYXNzIEdpdChTQ00pOgogICAgICAgICByZXR1cm4gb3MucGF0aC5leGlzdHMob3Mu cGF0aC5qb2luKHNlbGYuY2hlY2tvdXRfcm9vdCwgJy5naXQvcmViYXNlLWFwcGx5JykpCiAKICAg ICBkZWYgd29ya2luZ19kaXJlY3RvcnlfaXNfY2xlYW4oc2VsZik6Ci0gICAgICAgIHJldHVybiBy dW5fY29tbWFuZChbJ2dpdCcsICdkaWZmLWluZGV4JywgJ0hFQUQnXSkgPT0gIiIKKyAgICAgICAg cmV0dXJuIHJ1bl9jb21tYW5kKFsnZ2l0JywgJ2RpZmYnLCAnSEVBRCcsICctLW5hbWUtb25seSdd KSA9PSAiIgogCiAgICAgZGVmIGNsZWFuX3dvcmtpbmdfZGlyZWN0b3J5KHNlbGYpOgogICAgICAg ICAjIENvdWxkIHJ1biBnaXQgY2xlYW4gaGVyZSB0b28sIGJ1dCB0aGF0IHdvdWxkbid0IG1hdGNo IHdvcmtpbmdfZGlyZWN0b3J5X2lzX2NsZWFuCg== 52352 2010-04-01 16:46:47 -0700 2010-04-01 16:48:27 -0700 Patch bug-36985-20100401164646.patch text/plain 1780 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZGEzY2U1Li5kNTg5N2FjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDQt MDEgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggY2FuIGluY29ycmVjdGx5 IHRoaW5rIHRoZSB3b3JraW5nIGRpcmVjdG9yeSBpcyBtb2RpZmllZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5ODUKKworICAgICAgICBJZiBhIGZp bGUncyBtb2RpZmljYXRpb24gdGltZSBpcyBtb2RpZmllZCwgYnV0IHRoZSBjb250ZW50cyBhcmUg bm90LAorICAgICAgICB0aGVuIGRpZmYtaW5kZXggd2lsbCB0aGluayB0aGUgZmlsZSBoYXMgYmVl biBtb2RpZmllZCB1bmxlc3MgeW91IGRvCisgICAgICAgIHNvbWUgY3JhenkgdXBkYXRlLWluZGV4 IGNhbGwuIEluc3RlYWQsIGNhbGwgZGlmZiAtLW5hbWUtb25seSwgd2hpY2gKKyAgICAgICAgaGFz IHRoZSBpbmRleCB1cGRhdGUgYnVpbHRpbi4KKworICAgICAgICBUcmllZCB0byB3cml0ZSBhIHRl c3QsIGJ1dCBjb3VsZCBub3QgcmVwcm9kdWNlIHRoaXMgaW4gYSB1bml0dGVzdC4KKyAgICAgICAg VG8gdGVzdCBtYW51YWxseToKKyAgICAgICAgICAgIHRvdWNoIGZpbGUtaW4tcmVwbworICAgICAg ICAgICAgZ2l0IGRpZmYtaW5kZXggSEVBRAorICAgICAgICAgICAgZ2l0IGRpZmYgSEVBRCAtLW5h bWUtb25seQorCisgICAgICAgIFRoZSBkaWZmLWluZGV4IGNhbGwgaW5jb3JyZWN0bHkgc2hvd3Mg ZmlsZS1pbi1yZXBvIGFzIG1vZGlmaWVkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vY2hlY2tvdXQvc2NtLnB5OgorCiAyMDEwLTA0LTAxICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkKaW5k ZXggNmU3YTg5ZS4uMWUwNjcxNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQpAQCAtMzk1LDcgKzM5NSw3IEBAIGNsYXNzIEdp dChTQ00pOgogICAgICAgICByZXR1cm4gb3MucGF0aC5leGlzdHMob3MucGF0aC5qb2luKHNlbGYu Y2hlY2tvdXRfcm9vdCwgJy5naXQvcmViYXNlLWFwcGx5JykpCiAKICAgICBkZWYgd29ya2luZ19k aXJlY3RvcnlfaXNfY2xlYW4oc2VsZik6Ci0gICAgICAgIHJldHVybiBydW5fY29tbWFuZChbJ2dp dCcsICdkaWZmLWluZGV4JywgJ0hFQUQnXSkgPT0gIiIKKyAgICAgICAgcmV0dXJuIHJ1bl9jb21t YW5kKFsnZ2l0JywgJ2RpZmYnLCAnSEVBRCcsICctLW5hbWUtb25seSddKSA9PSAiIgogCiAgICAg ZGVmIGNsZWFuX3dvcmtpbmdfZGlyZWN0b3J5KHNlbGYpOgogICAgICAgICAjIENvdWxkIHJ1biBn aXQgY2xlYW4gaGVyZSB0b28sIGJ1dCB0aGF0IHdvdWxkbid0IG1hdGNoIHdvcmtpbmdfZGlyZWN0 b3J5X2lzX2NsZWFuCg==