36982 2010-04-01 14:20:36 -0700 [Chromium]: FindInPage issue with scrollbars not updated on frame pages 2010-04-01 18:25:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 finnur.webkit webkit-unassigned commit-queue dglazkov eric fishd webkit.review.bot oldest_to_newest 207403 0 finnur.webkit 2010-04-01 14:20:36 -0700 With Chromium, executing a FindInPage on multi-frame pages doesn't always update tickmarks on scrollbars for the subframes (sometimes it works, sometimes partially, sometimes not a all). There is a reduction here (comment 23): http://code.google.com/p/chromium/issues/detail?id=13551#c23 Turns out the Invalidate function is calling invalidateRect on the View and is specifying a rect that's in window coordinates, whereas the invalidateRect expects frame coordinates. Patch coming. 207405 1 52335 finnur.webkit 2010-04-01 14:26:17 -0700 Created attachment 52335 Proposed patch for fixing the paint problem 207406 2 webkit.review.bot 2010-04-01 14:28:42 -0700 Attachment 52335 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebFrameImpl.cpp:1966: frame_rect is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1977: frame_rect is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 207408 3 52336 finnur.webkit 2010-04-01 14:33:20 -0700 Created attachment 52336 Now with style issue fixed 207410 4 webkit.review.bot 2010-04-01 14:34:08 -0700 Attachment 52336 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/ChangeLog:5: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 207420 5 52341 finnur.webkit 2010-04-01 14:46:09 -0700 Created attachment 52341 Changed CRLF to LF to appease the style gods :) 207431 6 52341 eric 2010-04-01 15:02:04 -0700 Comment on attachment 52341 Changed CRLF to LF to appease the style gods :) I don't know what Chromium's policy on testing this sort of thing is. I assume a manual test would be possible, but I'm not sure there is an automated way to test this. Or maybe there is? I'm not the expert on this code, but this looks sane. 207578 7 52341 commit-queue 2010-04-01 18:25:10 -0700 Comment on attachment 52341 Changed CRLF to LF to appease the style gods :) Clearing flags on attachment: 52341 Committed r56958: <http://trac.webkit.org/changeset/56958> 207579 8 commit-queue 2010-04-01 18:25:16 -0700 All reviewed patches have been landed. Closing bug. 52335 2010-04-01 14:26:17 -0700 2010-04-01 14:33:20 -0700 Proposed patch for fixing the paint problem find_paint_fix.patch text/plain 1978 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTY5MzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDEgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpbmRJblBhZ2Ug b24gbXVsdGktZnJhbWUgcGFnZXMgd2Fzbid0IGFsd2F5cyB1cGRhdGluZworICAgICAgICB0aWNr bWFya3Mgb24gc2Nyb2xsYmFycyBmb3IgdGhlIHN1YmZyYW1lcy4gSXQgd2FzIGNhbGxpbmcgaW52 YWxpZGF0ZVJlY3QKKyAgICAgICAgb24gdGhlIFZpZXcgYW5kIHNwZWNpZnlpbmcgYSByZWN0IHRo YXQncyBpbiB3aW5kb3cgY29vcmRpbmF0ZXMsIHdoZXJlYXMKKyAgICAgICAgdGhlIGludmFsaWRh dGVSZWN0IGV4cGVjdHMgZnJhbWUgY29vcmRpbmF0ZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTgyCisgICAgICAgIAorICAgICAgICAqIHNy Yy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmludmFs aWRhdGVBcmVhKToKKwogMjAxMC0wNC0wMSAgRmlubnVyIFRob3Jhcmluc3NvbiAgPGZpbm51ci53 ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDU2OTM3KQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTYzLDYgKzE5NjMsOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEoQXJl YVRvCiAgICAgICAgIGlmICgoYXJlYSAmIEludmFsaWRhdGVDb250ZW50QXJlYSkgPT0gSW52YWxp ZGF0ZUNvbnRlbnRBcmVhKSB7CiAgICAgICAgICAgICBJbnRSZWN0IGNvbnRlbnRBcmVhKAogICAg ICAgICAgICAgICAgIHZpZXctPngoKSwgdmlldy0+eSgpLCB2aWV3LT52aXNpYmxlV2lkdGgoKSwg dmlldy0+dmlzaWJsZUhlaWdodCgpKTsKKyAgICAgICAgICAgIEludFJlY3QgZnJhbWVfcmVjdCA9 IHZpZXctPmZyYW1lUmVjdCgpOworICAgICAgICAgICAgY29udGVudEFyZWEubW92ZSgtZnJhbWVf cmVjdC50b3BMZWZ0KCkueCgpLCAtZnJhbWVfcmVjdC50b3BMZWZ0KCkueSgpKTsKICAgICAgICAg ICAgIHZpZXctPmludmFsaWRhdGVSZWN0KGNvbnRlbnRBcmVhKTsKICAgICAgICAgfQogCkBAIC0x OTcyLDYgKzE5NzQsOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEoQXJlYVRv CiAgICAgICAgICAgICAgICAgdmlldy0+eCgpICsgdmlldy0+dmlzaWJsZVdpZHRoKCksIHZpZXct PnkoKSwKICAgICAgICAgICAgICAgICBTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKS0+c2Ny b2xsYmFyVGhpY2tuZXNzKCksCiAgICAgICAgICAgICAgICAgdmlldy0+dmlzaWJsZUhlaWdodCgp KTsKKyAgICAgICAgICAgIEludFJlY3QgZnJhbWVfcmVjdCA9IHZpZXctPmZyYW1lUmVjdCgpOwor ICAgICAgICAgICAgc2Nyb2xsQmFyVmVydC5tb3ZlKC1mcmFtZV9yZWN0LnRvcExlZnQoKS54KCks IC1mcmFtZV9yZWN0LnRvcExlZnQoKS55KCkpOwogICAgICAgICAgICAgdmlldy0+aW52YWxpZGF0 ZVJlY3Qoc2Nyb2xsQmFyVmVydCk7CiAgICAgICAgIH0KICAgICB9Cg== 52336 2010-04-01 14:33:20 -0700 2010-04-01 14:46:09 -0700 Now with style issue fixed find_paint_fix.patch text/plain 1975 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTY5MzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDEgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpbmRJblBhZ2Ug b24gbXVsdGktZnJhbWUgcGFnZXMgd2Fzbid0IGFsd2F5cyB1cGRhdGluZw0KKyAgICAgICAgdGlj a21hcmtzIG9uIHNjcm9sbGJhcnMgZm9yIHRoZSBzdWJmcmFtZXMuIEl0IHdhcyBjYWxsaW5nIGlu dmFsaWRhdGVSZWN0DQorICAgICAgICBvbiB0aGUgVmlldyBhbmQgc3BlY2lmeWluZyBhIHJlY3Qg dGhhdCdzIGluIHdpbmRvdyBjb29yZGluYXRlcywgd2hlcmVhcw0KKyAgICAgICAgdGhlIGludmFs aWRhdGVSZWN0IGV4cGVjdHMgZnJhbWUgY29vcmRpbmF0ZXMuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTgyCisgICAgICAgIAorICAgICAgICAq IHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6Omlu dmFsaWRhdGVBcmVhKToKKwogMjAxMC0wNC0wMSAgRmlubnVyIFRob3Jhcmluc3NvbiAgPGZpbm51 ci53ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv di4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDU2OTM3 KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xOTYzLDYgKzE5NjMsOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEo QXJlYVRvCiAgICAgICAgIGlmICgoYXJlYSAmIEludmFsaWRhdGVDb250ZW50QXJlYSkgPT0gSW52 YWxpZGF0ZUNvbnRlbnRBcmVhKSB7CiAgICAgICAgICAgICBJbnRSZWN0IGNvbnRlbnRBcmVhKAog ICAgICAgICAgICAgICAgIHZpZXctPngoKSwgdmlldy0+eSgpLCB2aWV3LT52aXNpYmxlV2lkdGgo KSwgdmlldy0+dmlzaWJsZUhlaWdodCgpKTsKKyAgICAgICAgICAgIEludFJlY3QgZnJhbWVSZWN0 ID0gdmlldy0+ZnJhbWVSZWN0KCk7CisgICAgICAgICAgICBjb250ZW50QXJlYS5tb3ZlKC1mcmFt ZVJlY3QudG9wTGVmdCgpLngoKSwgLWZyYW1lUmVjdC50b3BMZWZ0KCkueSgpKTsKICAgICAgICAg ICAgIHZpZXctPmludmFsaWRhdGVSZWN0KGNvbnRlbnRBcmVhKTsKICAgICAgICAgfQogCkBAIC0x OTcyLDYgKzE5NzQsOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEoQXJlYVRv CiAgICAgICAgICAgICAgICAgdmlldy0+eCgpICsgdmlldy0+dmlzaWJsZVdpZHRoKCksIHZpZXct PnkoKSwKICAgICAgICAgICAgICAgICBTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKS0+c2Ny b2xsYmFyVGhpY2tuZXNzKCksCiAgICAgICAgICAgICAgICAgdmlldy0+dmlzaWJsZUhlaWdodCgp KTsKKyAgICAgICAgICAgIEludFJlY3QgZnJhbWVSZWN0ID0gdmlldy0+ZnJhbWVSZWN0KCk7Cisg ICAgICAgICAgICBzY3JvbGxCYXJWZXJ0Lm1vdmUoLWZyYW1lUmVjdC50b3BMZWZ0KCkueCgpLCAt ZnJhbWVSZWN0LnRvcExlZnQoKS55KCkpOwogICAgICAgICAgICAgdmlldy0+aW52YWxpZGF0ZVJl Y3Qoc2Nyb2xsQmFyVmVydCk7CiAgICAgICAgIH0KICAgICB9Cg== 52341 2010-04-01 14:46:09 -0700 2010-04-01 18:25:10 -0700 Changed CRLF to LF to appease the style gods :) find_paint_fix.patch text/plain 1972 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTY5MzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDEgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpbmRJblBhZ2Ug b24gbXVsdGktZnJhbWUgcGFnZXMgd2Fzbid0IGFsd2F5cyB1cGRhdGluZworICAgICAgICB0aWNr bWFya3Mgb24gc2Nyb2xsYmFycyBmb3IgdGhlIHN1YmZyYW1lcy4gSXQgd2FzIGNhbGxpbmcgaW52 YWxpZGF0ZVJlY3QKKyAgICAgICAgb24gdGhlIFZpZXcgYW5kIHNwZWNpZnlpbmcgYSByZWN0IHRo YXQncyBpbiB3aW5kb3cgY29vcmRpbmF0ZXMsIHdoZXJlYXMKKyAgICAgICAgdGhlIGludmFsaWRh dGVSZWN0IGV4cGVjdHMgZnJhbWUgY29vcmRpbmF0ZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTgyCisgICAgICAgIAorICAgICAgICAqIHNy Yy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmludmFs aWRhdGVBcmVhKToKKwogMjAxMC0wNC0wMSAgRmlubnVyIFRob3Jhcmluc3NvbiAgPGZpbm51ci53 ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDU2OTM3KQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTYzLDYgKzE5NjMsOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEoQXJl YVRvCiAgICAgICAgIGlmICgoYXJlYSAmIEludmFsaWRhdGVDb250ZW50QXJlYSkgPT0gSW52YWxp ZGF0ZUNvbnRlbnRBcmVhKSB7CiAgICAgICAgICAgICBJbnRSZWN0IGNvbnRlbnRBcmVhKAogICAg ICAgICAgICAgICAgIHZpZXctPngoKSwgdmlldy0+eSgpLCB2aWV3LT52aXNpYmxlV2lkdGgoKSwg dmlldy0+dmlzaWJsZUhlaWdodCgpKTsKKyAgICAgICAgICAgIEludFJlY3QgZnJhbWVSZWN0ID0g dmlldy0+ZnJhbWVSZWN0KCk7CisgICAgICAgICAgICBjb250ZW50QXJlYS5tb3ZlKC1mcmFtZVJl Y3QudG9wTGVmdCgpLngoKSwgLWZyYW1lUmVjdC50b3BMZWZ0KCkueSgpKTsKICAgICAgICAgICAg IHZpZXctPmludmFsaWRhdGVSZWN0KGNvbnRlbnRBcmVhKTsKICAgICAgICAgfQogCkBAIC0xOTcy LDYgKzE5NzQsOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEoQXJlYVRvCiAg ICAgICAgICAgICAgICAgdmlldy0+eCgpICsgdmlldy0+dmlzaWJsZVdpZHRoKCksIHZpZXctPnko KSwKICAgICAgICAgICAgICAgICBTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKS0+c2Nyb2xs YmFyVGhpY2tuZXNzKCksCiAgICAgICAgICAgICAgICAgdmlldy0+dmlzaWJsZUhlaWdodCgpKTsK KyAgICAgICAgICAgIEludFJlY3QgZnJhbWVSZWN0ID0gdmlldy0+ZnJhbWVSZWN0KCk7CisgICAg ICAgICAgICBzY3JvbGxCYXJWZXJ0Lm1vdmUoLWZyYW1lUmVjdC50b3BMZWZ0KCkueCgpLCAtZnJh bWVSZWN0LnRvcExlZnQoKS55KCkpOwogICAgICAgICAgICAgdmlldy0+aW52YWxpZGF0ZVJlY3Qo c2Nyb2xsQmFyVmVydCk7CiAgICAgICAgIH0KICAgICB9Cg==