36977 2010-04-01 12:35:04 -0700 aria-label doesn't work on image map area 2010-04-07 00:04:50 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 37006 1 cfleizach cfleizach abarth bdakin eric oldest_to_newest 207316 0 cfleizach 2010-04-01 12:35:04 -0700 @aria-label value should be recognized as the label, but it's only determined from @alt 207319 1 52322 cfleizach 2010-04-01 12:38:10 -0700 Created attachment 52322 patch 207322 2 cfleizach 2010-04-01 12:46:50 -0700 http://trac.webkit.org/changeset/56930 207637 3 eric 2010-04-01 21:33:15 -0700 This test looks to be very flaky judging by bug 37005. 207641 4 abarth 2010-04-01 21:39:04 -0700 Committed r56965: <http://trac.webkit.org/changeset/56965> 207642 5 abarth 2010-04-01 21:40:04 -0700 Rolled out because this caused aria-liveregions-notifications to become very flaky (or at least that's our best guess). 207647 6 cfleizach 2010-04-01 21:45:59 -0700 i have a hard time believing this test is causing flakiness. 207649 7 abarth 2010-04-01 21:48:16 -0700 You're welcome to look at the buildbot logs. It's the only accessibility related change near when the test started to become flaky. We might well be wrong, in which case we can roll it back in. 209246 8 cfleizach 2010-04-06 14:29:37 -0700 re-added patch now that leopard release is not running aria-live-region-notification test, which failed last time this was added. that test is the flaky one, and this patch does not affect that code path. so no reason to stop legitimate development http://trac.webkit.org/changeset/57167 209406 9 eric 2010-04-06 19:30:33 -0700 This test failed on Snow Leopard again just now: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57184%20(5687)/platform/mac/accessibility/aria-liveregions-notifications-diffs.txt Sorry for commenting on 3 bugs, not sure which one is actually the active one. 209419 10 cfleizach 2010-04-06 20:31:47 -0700 i'll see if i can make a less flaky test tonite (In reply to comment #9) > This test failed on Snow Leopard again just now: > http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57184%20(5687)/platform/mac/accessibility/aria-liveregions-notifications-diffs.txt > > Sorry for commenting on 3 bugs, not sure which one is actually the active one. 209494 11 abarth 2010-04-07 00:04:50 -0700 (In reply to comment #8) > re-added patch now that leopard release is not running > aria-live-region-notification test, which failed last time this was added. that > test is the flaky one, and this patch does not affect that code path. so no > reason to stop legitimate development There is some interaction between your patch and that test because without your patch the test passes consistently but with your patch, the test fails intermittently. Perhaps we should try to understand the interaction before disabling tests? 52322 2010-04-01 12:38:10 -0700 2010-04-01 21:40:14 -0700 patch patch.txt text/plain 4310 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjkyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMDEgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMzY5NzcgLSBhcmlhLWxhYmVsIGRvZXNuJ3Qgd29yayBvbiBpbWFnZSBtYXAgYXJlYQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5NzcKKwor ICAgICAgICBUZXN0OiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmVhLXdpdGgtYXJpYS1s YWJlbC5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlJbWFnZU1h cExpbmsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eUltYWdlTWFwTGluazo6 YWNjZXNzaWJpbGl0eURlc2NyaXB0aW9uKToKKwogMjAxMC0wNC0wMSAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0 ZWluLgpJbmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlJbWFnZU1hcExp bmsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 SW1hZ2VNYXBMaW5rLmNwcAkocmV2aXNpb24gNTY5MTkpCisrKyBXZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eUltYWdlTWFwTGluay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw2 ICsxMDMsOSBAQCBTdHJpbmcgQWNjZXNzaWJpbGl0eUltYWdlTWFwTGluazo6YWNjZXNzCiAgICAg aWYgKCFtX2FyZWFFbGVtZW50KQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKKyAgICBjb25z dCBBdG9taWNTdHJpbmcmIGFyaWFMYWJlbCA9IG1fYXJlYUVsZW1lbnQtPmdldEF0dHJpYnV0ZShh cmlhX2xhYmVsQXR0cik7CisgICAgaWYgKCFhcmlhTGFiZWwuaXNFbXB0eSgpKQorICAgICAgICBy ZXR1cm4gYXJpYUxhYmVsOwogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgYWx0ID0gbV9hcmVhRWxl bWVudC0+Z2V0QXR0cmlidXRlKGFsdEF0dHIpOwogICAgIGlmICghYWx0LmlzRW1wdHkoKSkKICAg ICAgICAgcmV0dXJuIGFsdDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2OTI5KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDEg IENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMzY5NzcgLSBhcmlhLWxhYmVsIGRv ZXNuJ3Qgd29yayBvbiBpbWFnZSBtYXAgYXJlYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5NzcKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L2FyZWEtd2l0aC1hcmlhLWxhYmVsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJlYS13aXRoLWFyaWEtbGFiZWwuaHRt bDogQWRkZWQuCisKIDIwMTAtMDQtMDEgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmVhLXdpdGgtYXJpYS1sYWJlbC1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vz c2liaWxpdHkvYXJlYS13aXRoLWFyaWEtbGFiZWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJlYS13aXRoLWFyaWEt bGFiZWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEyIEBACisgCitUaGlz IHRlc3RzIHRoYXQgYXJpYS1sYWJlbCB3b3JrcyBvbiBhcmVhIGVsZW1lbnRzLgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1 c2VkRWxlbWVudC5kZXNjcmlwdGlvbiBpcyAnQVhEZXNjcmlwdGlvbjogUHJldmlvdXMnCitQQVNT IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50LmRlc2NyaXB0aW9uIGlzICdB WERlc2NyaXB0aW9uOiBOZXh0JworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitU RVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmls aXR5L2FyZWEtd2l0aC1hcmlhLWxhYmVsLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJlYS13aXRoLWFyaWEtbGFiZWwuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyZWEt d2l0aC1hcmlhLWxhYmVsLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzkgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQ+Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g ZmFsc2U7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+CisK KzxtYXAgbmFtZT0iZm9yd2FyZGJhY2t3YXJkIj4KKwk8YXJlYSBpZD0iYnRuX3ByZXYiIHJvbGU9 ImJ1dHRvbiIgYWx0PSIiIHRhYmluZGV4PSIwIiBhcmlhLWxhYmVsPSJQcmV2aW91cyIgc2hhcGU9 InJlY3QiIGNvb3Jkcz0iMiwzNSwyMSw0NyIgaHJlZj0iIyI+CisJPGFyZWEgaWQ9ImJ0bl9uZXh0 IiByb2xlPSJidXR0b24iIGFsdD0iIiB0YWJpbmRleD0iMCIgYXJpYS1sYWJlbD0iTmV4dCIgc2hh cGU9InJlY3QiIGNvb3Jkcz0iNTYsMzUsNzUsNDciIGhyZWY9IiMiPgorPC9tYXA+Cis8aW1nIGlk PSJmYiIgc3JjPSIjIiBib3JkZXI9IjEiIHdpZHRoPSI3NiIgaGVpZ2h0PSI3NiIgdXNlbWFwPSIj Zm9yd2FyZGJhY2t3YXJkIiBhbHQ9IiI+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRp diBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhp cyB0ZXN0cyB0aGF0IGFyaWEtbGFiZWwgd29ya3Mgb24gYXJlYSBlbGVtZW50cy4iKTsKKworICAg IGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKworICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiYnRuX3ByZXYiKS5mb2N1cygpOworICAgICAgICBzaG91bGRCZSgi YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuZGVzY3JpcHRpb24iLCAiJ0FY RGVzY3JpcHRpb246IFByZXZpb3VzJyIpOworCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJidG5fbmV4dCIpLmZvY3VzKCk7CisgICAgICAgIHNob3VsZEJlKCJhY2Nlc3NpYmlsaXR5 Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5kZXNjcmlwdGlvbiIsICInQVhEZXNjcmlwdGlvbjog TmV4dCciKTsKKyAgICB9CisKKyAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3Jp cHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBv c3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=