36976 2010-04-01 12:13:52 -0700 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled 2010-04-01 14:00:20 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap darin oldest_to_newest 207301 0 ap 2010-04-01 12:13:52 -0700 If JavaScript is disabled then loading a page that contains the Silverlight plug-in will cause Safari to crash. * STEPS TO REPRODUCE 1. Disable JavaScript. 2. Load <http://feralpixel.com/default.htm#/Algorithms/A13.xaml>. * RESULTS Crash. 207323 1 52323 ap 2010-04-01 12:48:24 -0700 Created attachment 52323 proposed fix 207324 2 ap 2010-04-01 12:48:43 -0700 <rdar://problem/7817498> 207327 3 52323 oliver 2010-04-01 12:51:03 -0700 Comment on attachment 52323 proposed fix r=me 207334 4 52323 darin 2010-04-01 12:58:36 -0700 Comment on attachment 52323 proposed fix > + (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(), > + because the latter fails with an assertion when looking up 0 or -1. Why doesn't find() fail with an assertion looking up 0 or -1? Makes no sense to me that it would not. 207337 5 ap 2010-04-01 13:00:01 -0700 Committed <http://trac.webkit.org/changeset/56932>. 207345 6 ap 2010-04-01 13:14:06 -0700 That's because find() has an early return if m_table is null, and get() doesn't. You are right, the first part of this change is incorrect. 207352 7 52326 ap 2010-04-01 13:26:01 -0700 Created attachment 52326 more fixes 207373 8 52326 darin 2010-04-01 13:54:50 -0700 Comment on attachment 52326 more fixes r=me 207390 9 ap 2010-04-01 14:00:20 -0700 Follow-up committed <http://trac.webkit.org/changeset/56935>. 52323 2010-04-01 12:48:24 -0700 2010-04-01 12:58:36 -0700 proposed fix PluginDisabledJS.txt text/plain 2345 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjkyOSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDEgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTc2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODE3NDk4PgorICAgICAgICBSRUdSRVNTSU9OKHI1NDc4 Myk6IFNpbHZlcmxpZ2h0IHBsdWctaW4gY2F1c2VzIFNhZmFyaSB0byBjcmFzaCBpZiBKYXZhU2Ny aXB0IGlzIGRpc2FibGVkCisKKyAgICAgICAgKiBQbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdp bkluc3RhbmNlUHJveHkubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luSW5zdGFu Y2VQcm94eTo6TG9jYWxPYmplY3RNYXA6OmdldCk6IFVzZSBmaW5kKCkgaW5zdGVhZCBvZiBnZXQo KSwKKyAgICAgICAgYmVjYXVzZSB0aGUgbGF0dGVyIGZhaWxzIHdpdGggYW4gYXNzZXJ0aW9uIHdo ZW4gbG9va2luZyB1cCAwIG9yIC0xLgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbklu c3RhbmNlUHJveHk6OkxvY2FsT2JqZWN0TWFwOjpmb3JnZXQpOiBCZSBwcmVwYXJlZCBmb3IgdW5l eHBlY3RlZAorICAgICAgICBvYmplY3QgSURzIGNvbWluZyBmcm9tIHBsdWctaW4gaG9zdC4KKwog MjAxMC0wMy0zMSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViS2l0L21hYy9QbHVnaW5zL0hv c3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHkubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHkubW0JKHJldmlz aW9uIDU2OTI0KQorKysgV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbklu c3RhbmNlUHJveHkubW0JKHdvcmtpbmcgY29weSkKQEAgLTExNyw3ICsxMTcsMTEgQEAgaW5saW5l IGJvb2wgTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5OgogCiBpbmxpbmUgSlNDOjpKU09iamVj dCogTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5OjpMb2NhbE9iamVjdE1hcDo6Z2V0KHVpbnQz Ml90IG9iamVjdElEKSBjb25zdAogewotICAgIHJldHVybiBtX2lkVG9KU09iamVjdE1hcC5nZXQo b2JqZWN0SUQpOworICAgIEhhc2hNYXA8dWludDMyX3QsIEpTQzo6UHJvdGVjdGVkUHRyPEpTQzo6 SlNPYmplY3Q+ID46OmNvbnN0X2l0ZXJhdG9yIGl0ZXIgPSBtX2lkVG9KU09iamVjdE1hcC5maW5k KG9iamVjdElEKTsKKyAgICBpZiAoaXRlciA9PSBtX2lkVG9KU09iamVjdE1hcC5lbmQoKSkKKyAg ICAgICAgcmV0dXJuIDA7CisKKyAgICByZXR1cm4gaXRlci0+c2Vjb25kLmdldCgpOwogfQogCiB1 aW50MzJfdCBOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk6OkxvY2FsT2JqZWN0TWFwOjppZEZv ck9iamVjdChKU09iamVjdCogb2JqZWN0KQpAQCAtMTgwLDcgKzE4NCwxMCBAQCB2b2lkIE5ldHNj YXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6TG9jYWxPCiBib29sIE5ldHNjYXBlUGx1Z2luSW5zdGFu Y2VQcm94eTo6TG9jYWxPYmplY3RNYXA6OmZvcmdldCh1aW50MzJfdCBvYmplY3RJRCkKIHsKICAg ICBIYXNoTWFwPHVpbnQzMl90LCBKU0M6OlByb3RlY3RlZFB0cjxKU0M6OkpTT2JqZWN0PiA+Ojpp dGVyYXRvciBpdGVyID0gbV9pZFRvSlNPYmplY3RNYXAuZmluZChvYmplY3RJRCk7Ci0gICAgQVNT RVJUKGl0ZXIgIT0gbV9pZFRvSlNPYmplY3RNYXAuZW5kKCkpOworICAgIGlmIChpdGVyID09IG1f aWRUb0pTT2JqZWN0TWFwLmVuZCgpKSB7CisgICAgICAgIExPR19FUlJPUigiTmV0c2NhcGVQbHVn aW5JbnN0YW5jZVByb3h5OjpMb2NhbE9iamVjdE1hcDo6Zm9yZ2V0OiBsb2NhbCBvYmplY3QgJXUg ZG9lc24ndCBleGlzdC4iLCBvYmplY3RJRCk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0K IAogICAgIEhhc2hNYXA8SlNDOjpKU09iamVjdCosIHBhaXI8dWludDMyX3QsIHVpbnQzMl90PiA+ OjppdGVyYXRvciBySXRlciA9IG1fanNPYmplY3RUb0lETWFwLmZpbmQoaXRlci0+c2Vjb25kLmdl dCgpKTsKIAo= 52326 2010-04-01 13:26:01 -0700 2010-04-01 13:54:50 -0700 more fixes PluginDisabledJS.txt text/plain 2560 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjkzNCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMDEgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTc2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODE3NDk4PgorICAgICAgICBSRUdSRVNTSU9OKHI1NDc4 Myk6IFNpbHZlcmxpZ2h0IHBsdWctaW4gY2F1c2VzIFNhZmFyaSB0byBjcmFzaCBpZiBKYXZhU2Ny aXB0IGlzIGRpc2FibGVkCisKKyAgICAgICAgKiBQbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdp bkluc3RhbmNlUHJveHkubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luSW5zdGFu Y2VQcm94eTo6TG9jYWxPYmplY3RNYXA6OmdldCk6IFRoZSBIYXNoVGFibGUgYXNzZXJ0aW9ucyBh cmVuJ3QKKyAgICAgICAgdGhlcmUgdG8gY2F0Y2ggcG90ZW50aWFsIGZ1dHVyZSBhdHRlbXB0cyB0 byBzdG9yZSBlbXB0eS9kZWxldGVkIHZhbHVlcyBiZWZvcmUgdGhlc2UgaGFwcGVuIC0KKyAgICAg ICAgaXQncyBhY3R1YWxseSB3cm9uZyB0byB0cnkgdG8gbG9vayB1cCB0aGVzZSB2YWx1ZXMuIEFk ZGVkIGFuIGVhcmx5IHJldHVybi4KKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5JbnN0 YW5jZVByb3h5OjpMb2NhbE9iamVjdE1hcDo6Zm9yZ2V0KTogRGl0dG8uCisKIDIwMTAtMDQtMDEg IENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNpbW9uIEZyYXNlci4KSW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQ bHVnaW5JbnN0YW5jZVByb3h5Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9I b3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5Lm1tCShyZXZpc2lvbiA1NjkzMikKKysr IFdlYktpdC9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5Lm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsMTEgKzExNywxMCBAQCBpbmxpbmUgYm9vbCBOZXRzY2Fw ZVBsdWdpbkluc3RhbmNlUHJveHk6CiAKIGlubGluZSBKU0M6OkpTT2JqZWN0KiBOZXRzY2FwZVBs dWdpbkluc3RhbmNlUHJveHk6OkxvY2FsT2JqZWN0TWFwOjpnZXQodWludDMyX3Qgb2JqZWN0SUQp IGNvbnN0CiB7Ci0gICAgSGFzaE1hcDx1aW50MzJfdCwgSlNDOjpQcm90ZWN0ZWRQdHI8SlNDOjpK U09iamVjdD4gPjo6Y29uc3RfaXRlcmF0b3IgaXRlciA9IG1faWRUb0pTT2JqZWN0TWFwLmZpbmQo b2JqZWN0SUQpOwotICAgIGlmIChpdGVyID09IG1faWRUb0pTT2JqZWN0TWFwLmVuZCgpKQorICAg IGlmIChvYmplY3RJRCA9PSBIYXNoVHJhaXRzPHVpbnQzMl90Pjo6ZW1wdHlWYWx1ZSgpIHx8IEhh c2hUcmFpdHM8dWludDMyX3Q+Ojppc0RlbGV0ZWRWYWx1ZShvYmplY3RJRCkpCiAgICAgICAgIHJl dHVybiAwOwogCi0gICAgcmV0dXJuIGl0ZXItPnNlY29uZC5nZXQoKTsKKyAgICByZXR1cm4gbV9p ZFRvSlNPYmplY3RNYXAuZ2V0KG9iamVjdElEKTsKIH0KIAogdWludDMyX3QgTmV0c2NhcGVQbHVn aW5JbnN0YW5jZVByb3h5OjpMb2NhbE9iamVjdE1hcDo6aWRGb3JPYmplY3QoSlNPYmplY3QqIG9i amVjdCkKQEAgLTE4Myw2ICsxODIsMTEgQEAgdm9pZCBOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJv eHk6OkxvY2FsTwogCiBib29sIE5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6TG9jYWxPYmpl Y3RNYXA6OmZvcmdldCh1aW50MzJfdCBvYmplY3RJRCkKIHsKKyAgICBpZiAob2JqZWN0SUQgPT0g SGFzaFRyYWl0czx1aW50MzJfdD46OmVtcHR5VmFsdWUoKSB8fCBIYXNoVHJhaXRzPHVpbnQzMl90 Pjo6aXNEZWxldGVkVmFsdWUob2JqZWN0SUQpKSB7CisgICAgICAgIExPR19FUlJPUigiTmV0c2Nh cGVQbHVnaW5JbnN0YW5jZVByb3h5OjpMb2NhbE9iamVjdE1hcDo6Zm9yZ2V0OiBsb2NhbCBvYmpl Y3QgaWQgJXUgaXMgbm90IHZhbGlkLiIsIG9iamVjdElEKTsKKyAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfQorCiAgICAgSGFzaE1hcDx1aW50MzJfdCwgSlNDOjpQcm90ZWN0ZWRQdHI8SlNDOjpK U09iamVjdD4gPjo6aXRlcmF0b3IgaXRlciA9IG1faWRUb0pTT2JqZWN0TWFwLmZpbmQob2JqZWN0 SUQpOwogICAgIGlmIChpdGVyID09IG1faWRUb0pTT2JqZWN0TWFwLmVuZCgpKSB7CiAgICAgICAg IExPR19FUlJPUigiTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5OjpMb2NhbE9iamVjdE1hcDo6 Zm9yZ2V0OiBsb2NhbCBvYmplY3QgJXUgZG9lc24ndCBleGlzdC4iLCBvYmplY3RJRCk7Cg==