36971 2010-04-01 10:37:57 -0700 [Qt]Add -Wextra warning level to the QtWebKit build 2010-04-02 00:22:50 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue kenneth sfalken oldest_to_newest 207239 0 laszlo.gombos 2010-04-01 10:37:57 -0700 QtWebKit should follow mac's lead to turn on -Wextra for QtWebKit build. 207246 1 kenneth 2010-04-01 10:47:46 -0700 I fully agree 207248 2 52312 laszlo.gombos 2010-04-01 10:49:15 -0700 Created attachment 52312 proposed patch New warnings introduced - I propose to address these in a separate patch as these warnings are not specific to the Qt port webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: In function 'bool pluginRemoveProperty(NPObject*, void*)': webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1005: warning: no return statement in function returning non-void webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: In function 'bool pluginEnumerate(NPObject*, void***, uint32_t*)': webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1009: warning: no return statement in function returning non-void webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: In function 'bool plugininConstruct(NPObject*, const NPVariant*, uint32_t, NPVariant*)': webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1013: warning: no return statement in function returning non-void 207253 3 52312 commit-queue 2010-04-01 11:05:52 -0700 Comment on attachment 52312 proposed patch Clearing flags on attachment: 52312 Committed r56923: <http://trac.webkit.org/changeset/56923> 207254 4 commit-queue 2010-04-01 11:05:59 -0700 All reviewed patches have been landed. Closing bug. 207748 5 52390 sfalken 2010-04-02 00:14:25 -0700 Created attachment 52390 Patch 207752 6 sfalken 2010-04-02 00:16:39 -0700 Ignore my patch in this bug - webkit-patch attached it to the wrong bug. 207760 7 52390 eric 2010-04-02 00:22:25 -0700 Comment on attachment 52390 Patch Sorry for the trouble steve! We believe to have fixed this in bug 36477 which was landed earlier today. 207761 8 52312 eric 2010-04-02 00:22:50 -0700 Comment on attachment 52312 proposed patch Leaving this un-marked. Laszlo can re-mark for review if needed. 52312 2010-04-01 10:49:15 -0700 2010-04-02 00:22:50 -0700 proposed patch 36971.patch text/plain 1349 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU2OTIx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQt MDEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1BZGQgLVdleHRyYSB3 YXJuaW5nIGxldmVsIHRvIHRoZSBRdFdlYktpdCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5NzEKKworICAgICAgICAqIFdlYktpdC5wcmk6 CisKIDIwMTAtMDQtMDEgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBj b2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJ bmRleDogV2ViS2l0LnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQucHJpCShyZXZpc2lvbiA1Njg0 OCkKKysrIFdlYktpdC5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTUxLDcgKzUxLDcgQEAgQkFTRV9E SVIgPSAkJFBXRAogSU5DTFVERVBBVEggKz0gJCRPVVRQVVRfRElSL2luY2x1ZGUvUXRXZWJLaXQK IAogQ09ORklHIC09IHdhcm5fb24KLSotZysrKjpRTUFLRV9DWFhGTEFHUyArPSAtV2FsbCAtV3Jl dHVybi10eXBlIC1mbm8tc3RyaWN0LWFsaWFzaW5nIC1XY2FzdC1hbGlnbiAtV2NoYXItc3Vic2Ny aXB0cyAtV2Zvcm1hdC1zZWN1cml0eSAtV3JldHVybi10eXBlIC1Xbm8tdW51c2VkLXBhcmFtZXRl ciAtV25vLXNpZ24tY29tcGFyZSAtV25vLXN3aXRjaCAtV25vLXN3aXRjaC1lbnVtIC1XdW5kZWYg LVdtaXNzaW5nLW5vcmV0dXJuIC1XaW5pdC1zZWxmCisqLWcrKyo6UU1BS0VfQ1hYRkxBR1MgKz0g LVdhbGwgLVdleHRyYSAtV3JldHVybi10eXBlIC1mbm8tc3RyaWN0LWFsaWFzaW5nIC1XY2FzdC1h bGlnbiAtV2NoYXItc3Vic2NyaXB0cyAtV2Zvcm1hdC1zZWN1cml0eSAtV3JldHVybi10eXBlIC1X bm8tdW51c2VkLXBhcmFtZXRlciAtV25vLXNpZ24tY29tcGFyZSAtV25vLXN3aXRjaCAtV25vLXN3 aXRjaC1lbnVtIC1XdW5kZWYgLVdtaXNzaW5nLW5vcmV0dXJuIC1XaW5pdC1zZWxmCiAKICMgRW5h YmxlIEdOVSBjb21waWxlciBleHRlbnNpb25zIHRvIHRoZSBBUk0gY29tcGlsZXIgZm9yIGFsbCBR dCBwb3J0cyB1c2luZyBSVkNUCiBzeW1iaWFufCotYXJtY2Mgewo= 52390 2010-04-02 00:14:25 -0700 2010-04-02 00:22:25 -0700 Patch bug-36971-20100402001421.patch text/plain 2085 sfalken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Njk3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMDQtMDIgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEYXRhYmFzZSBjb2RlIGZhbHNlbHkgcmV0dXJucyBlcnJvcnMgZHVlIHRvIGVycmFudCBwb2lu dGVyIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNzAxNAorCisgICAgICAgIHI1Njk0MyBpbnRyb2R1Y2VkIGEgY2hlY2sgdG8gc2VlIGlmIHRo ZXJlIHdlcmUgYW55IHVucHJvY2Vzc2VkCisgICAgICAgIFNRTCBjb21tYW5kcyBhZnRlciBjYWxs aW5nIHNxbGl0ZTNfcHJlcGFyZTE2X3YyLgorCisgICAgICAgIEFjY2Vzc2luZyB0aGUgcmVtYWlu aW5nIGRhdGEgdmlhIHBvaW50ZXIgd2Fzbid0IHBvc3NpYmxlIHNpbmNlCisgICAgICAgIHRoZSBx dWVyeSBzdHJpbmcgaXMgZGVhbGxvY2F0ZWQgaW1tZWRpYXRlbHkgYWZ0ZXIgdGhlCisgICAgICAg IHF1ZXJ5IHJ1bnMuIFRoZSBTdHJpbmcgcmV0dXJuZWQgZnJvbSBzdHJpcHBlZFdoaXRlU3BhY2UK KyAgICAgICAgZ29lcyBvdXQgb2Ygc2NvcGUgYXQgdGhhdCBwb2ludC4KKworICAgICAgICBGaXgg aXMgdG8gc3RvcmUgdGhlIHN0cmlwcGVkV2hpdGVTcGFjZSBpbiBhIHRlbXBvcmFyeSBTdHJpbmcK KyAgICAgICAgc28gd2UgY2FuIGFjY2VzcyBpdCB2aWEgY2hhcmFjdGVyIHB0ciBsYXRlciBpbiB0 aGUgZnVuY3Rpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNRTGl0ZVN0YXRlbWVudDo6cHJlcGFyZSk6CisKIDIwMTAt MDQtMDEgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVT dGF0ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0 YXRlbWVudC5jcHAJKHJldmlzaW9uIDU2OTc1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FM aXRlU3RhdGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMsNyArNjMsOCBAQCBpbnQgU1FM aXRlU3RhdGVtZW50OjpwcmVwYXJlKCkKICAgICBBU1NFUlQoIW1faXNQcmVwYXJlZCk7CiAgICAg Y29uc3Qgdm9pZCogdGFpbDsKICAgICBMT0coU1FMRGF0YWJhc2UsICJTUUwgLSBwcmVwYXJlIC0g JXMiLCBtX3F1ZXJ5LmFzY2lpKCkuZGF0YSgpKTsKLSAgICBpbnQgZXJyb3IgPSBzcWxpdGUzX3By ZXBhcmUxNl92MihtX2RhdGFiYXNlLnNxbGl0ZTNIYW5kbGUoKSwgbV9xdWVyeS5zdHJpcFdoaXRl U3BhY2UoKS5jaGFyYWN0ZXJzV2l0aE51bGxUZXJtaW5hdGlvbigpLCAtMSwgJm1fc3RhdGVtZW50 LCAmdGFpbCk7CisgICAgU3RyaW5nIHN0cmlwcGVkUXVlcnkgPSBtX3F1ZXJ5LnN0cmlwV2hpdGVT cGFjZSgpOworICAgIGludCBlcnJvciA9IHNxbGl0ZTNfcHJlcGFyZTE2X3YyKG1fZGF0YWJhc2Uu c3FsaXRlM0hhbmRsZSgpLCBzdHJpcHBlZFF1ZXJ5LmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0 aW9uKCksIC0xLCAmbV9zdGF0ZW1lbnQsICZ0YWlsKTsKICAgICBpZiAoZXJyb3IgIT0gU1FMSVRF X09LKQogICAgICAgICBMT0coU1FMRGF0YWJhc2UsICJzcWxpdGUzX3ByZXBhcmUxNiBmYWlsZWQg KCVpKVxuJXNcbiVzIiwgZXJyb3IsIG1fcXVlcnkuYXNjaWkoKS5kYXRhKCksIHNxbGl0ZTNfZXJy bXNnKG1fZGF0YWJhc2Uuc3FsaXRlM0hhbmRsZSgpKSk7CiAgICAgY29uc3QgVUNoYXIqIGNoID0g c3RhdGljX2Nhc3Q8Y29uc3QgVUNoYXIqPih0YWlsKTsK