36963 2010-04-01 08:48:11 -0700 [GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR 2010-04-29 12:42:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned eric webkit.review.bot oldest_to_newest 207179 0 gustavo 2010-04-01 08:48:11 -0700 While playing with cursors, I found out that if I set a cursor to a window that hosts a WebKitWebView, it will be disregarded. Also, even if it is set explicitely on the WebKitWebView widget, it will go back to being the white pointer after it has changed into something else, and back. It should likely not use GDK_LEFT_PTR explicitely. 207181 1 52300 gustavo 2010-04-01 08:52:08 -0700 Created attachment 52300 This is not a joke. 207183 2 webkit.review.bot 2010-04-01 08:57:25 -0700 Attachment 52300 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/gtk/CursorGtk.cpp:93: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 207464 3 eric 2010-04-01 16:08:28 -0700 What about when a website specifies pointer cursor over a specific region? Won't this change cause those sites to break? 214118 4 gustavo 2010-04-19 11:26:44 -0700 (In reply to comment #3) > What about when a website specifies pointer cursor over a specific region? > Won't this change cause those sites to break? It should not. What the change does is make sure that when the web site requests 'pointer', that the cursor will become whatever the user (or the application) has chosen the pointer cursor to be, so I believe that is the correct behaviour. 215859 5 54056 gustavo 2010-04-22 06:44:37 -0700 Created attachment 54056 remove assert, as discussed with xan 215862 6 webkit.review.bot 2010-04-22 06:49:55 -0700 Attachment 54056 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/gtk/CursorGtk.cpp:92: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 217742 7 54056 xan.lopez 2010-04-27 09:52:05 -0700 Comment on attachment 54056 remove assert, as discussed with xan r=me 219143 8 gustavo 2010-04-29 12:42:25 -0700 Landed as r58531. 52300 2010-04-01 08:52:08 -0700 2010-04-22 06:44:37 -0700 This is not a joke. 0001-2010-04-01-Gustavo-Noronha-Silva-gustavo.noronhaolla.patch text/plain 2008 gustavo RnJvbSAwYTU3MDA3NmY5MzE2OWZhMjFkZjFjYjgwNmI1MzEyNTQ1ZGEzMzBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFRodSwgMSBBcHIgMjAxMCAxMjo1MDo1OSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDQtMDEgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYW9sbGFib3Jh LmNvLnVrPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW0dU S10gcG9pbnRlckN1cnNvciBzaG91bGQgdXNlIHRoZSBkZWZhdWx0IGN1cnNvciBzZXQgZm9yIHRo ZSB3aW5kb3csIG5vdCBHREtfTEVGVF9QVFIKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzY5NjMKCiAgICAgICAgVXNlIHRoZSBkZWZhdWx0IGN1cnNvciBp bnN0ZWFkIG9mIGhhcmQtY29kaW5nIGxlZnQgcG9pbnRlci4KCiAgICAgICAgKiBwbGF0Zm9ybS9n dGsvQ3Vyc29yR3RrLmNwcDoKICAgICAgICAoV2ViQ29yZTo6Q3Vyc29yOjpDdXJzb3IpOgogICAg ICAgIChXZWJDb3JlOjpwb2ludGVyQ3Vyc29yKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9D dXJzb3JHdGsuY3BwIHwgICAgNyArKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMWYxY2NjLi5kYTFiYTMxIDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDEwLTA0LTAxICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFvbGxhYm9y YS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbR1RLXSBwb2ludGVyQ3Vyc29yIHNob3VsZCB1c2UgdGhlIGRlZmF1bHQgY3Vyc29yIHNldCBm b3IgdGhlIHdpbmRvdywgbm90IEdES19MRUZUX1BUUgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5NjMKKworICAgICAgICBVc2UgdGhlIGRlZmF1bHQg Y3Vyc29yIGluc3RlYWQgb2YgaGFyZC1jb2RpbmcgbGVmdCBwb2ludGVyLgorCisgICAgICAgICog cGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDdXJzb3I6OkN1 cnNvcik6CisgICAgICAgIChXZWJDb3JlOjpwb2ludGVyQ3Vyc29yKToKKwogMjAxMC0wMy0zMSAg SmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBOYXRlIENoYXBpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1cnNvckd0 ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwCmluZGV4IDFjNjY5ZjMu LjFjMjcyYTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ3Vyc29yR3RrLmNwcApAQCAtODksMTIgKzg5LDE1 IEBAIEN1cnNvcjo6Q3Vyc29yKEdka0N1cnNvciogYykKIHsKICAgICBtX2ltcGwgPSBjOwogICAg IEFTU0VSVChjKTsKLSAgICBnZGtfY3Vyc29yX3JlZihjKTsKKworICAgIC8vIFRoZSBHZGtDdXJz b3IgbWF5IGJlIE5VTEwgLSB0aGUgZGVmYXVsdCBjdXJzb3IgZm9yIHRoZSB3aW5kb3cuCisgICAg aWYgKGMpCisgICAgICAgIGdka19jdXJzb3JfcmVmKGMpOwogfQogCiBjb25zdCBDdXJzb3ImIHBv aW50ZXJDdXJzb3IoKQogewotICAgIHN0YXRpYyBDdXJzb3IgYyA9IGdka19jdXJzb3JfbmV3KEdE S19MRUZUX1BUUik7CisgICAgc3RhdGljIEN1cnNvciBjID0gMDsKICAgICByZXR1cm4gYzsKIH0K IAotLSAKMS43LjAKCg== 54056 2010-04-22 06:44:37 -0700 2010-04-27 09:52:05 -0700 remove assert, as discussed with xan 0001-2010-04-01-Gustavo-Noronha-Silva-gustavo.noronhaolla.patch text/plain 2041 gustavo RnJvbSA4NDY3OTA5NDQ4MDk3YjdjZDE4MGFmMTI2NTZmYjM2Y2Q4NWYwYjIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFRodSwgMSBBcHIgMjAxMCAxMjo1MDo1OSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDQtMDEgR3VzdGF2byBOb3JvbmhhIFNpbHZhIDxndXN0YXZvLm5vcm9uaGFvbGxhYm9yYS5j by51az4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtHVEtd IHBvaW50ZXJDdXJzb3Igc2hvdWxkIHVzZSB0aGUgZGVmYXVsdCBjdXJzb3Igc2V0IGZvciB0aGUg d2luZG93LCBub3QgR0RLX0xFRlRfUFRSCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM2OTYzCgogICAgICAgIFVzZSB0aGUgZGVmYXVsdCBjdXJzb3IgaW5z dGVhZCBvZiBoYXJkLWNvZGluZyBsZWZ0IHBvaW50ZXIuCgogICAgICAgICogcGxhdGZvcm0vZ3Rr L0N1cnNvckd0ay5jcHA6CiAgICAgICAgKFdlYkNvcmU6OkN1cnNvcjo6Q3Vyc29yKToKICAgICAg ICAoV2ViQ29yZTo6cG9pbnRlckN1cnNvcik6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ3Vy c29yR3RrLmNwcCB8ICAgIDggKysrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGE2NjE3ODUuLmU4OGE1ZjUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTAtMDQtMDEgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYW9sbGFib3Jh LmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHVEtdIHBvaW50ZXJDdXJzb3Igc2hvdWxkIHVzZSB0aGUgZGVmYXVsdCBjdXJzb3Igc2V0IGZv ciB0aGUgd2luZG93LCBub3QgR0RLX0xFRlRfUFRSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjk2MworCisgICAgICAgIFVzZSB0aGUgZGVmYXVsdCBj dXJzb3IgaW5zdGVhZCBvZiBoYXJkLWNvZGluZyBsZWZ0IHBvaW50ZXIuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvQ3Vyc29yR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cnNvcjo6Q3Vy c29yKToKKyAgICAgICAgKFdlYkNvcmU6OnBvaW50ZXJDdXJzb3IpOgorCiAyMDEwLTA0LTIyICBH dXN0YXZvIFN2ZXJ6dXQgQmFyYmllcmkgIDxiYXJiaWVyaUBwcm9mdXNpb24ubW9iaT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvQ3Vyc29yR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAK aW5kZXggMWM2NjlmMy4uNzA1YzJhZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv Q3Vyc29yR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwCkBA IC04OCwxMyArODgsMTUgQEAgQ3Vyc29yOjpDdXJzb3IoR2RrQ3Vyc29yKiBjKQogICAgIDogbV9p bXBsKGMpCiB7CiAgICAgbV9pbXBsID0gYzsKLSAgICBBU1NFUlQoYyk7Ci0gICAgZ2RrX2N1cnNv cl9yZWYoYyk7CisKKyAgICAvLyBUaGUgR2RrQ3Vyc29yIG1heSBiZSBOVUxMIC0gdGhlIGRlZmF1 bHQgY3Vyc29yIGZvciB0aGUgd2luZG93LgorICAgIGlmIChjKQorICAgICAgICBnZGtfY3Vyc29y X3JlZihjKTsKIH0KIAogY29uc3QgQ3Vyc29yJiBwb2ludGVyQ3Vyc29yKCkKIHsKLSAgICBzdGF0 aWMgQ3Vyc29yIGMgPSBnZGtfY3Vyc29yX25ldyhHREtfTEVGVF9QVFIpOworICAgIHN0YXRpYyBD dXJzb3IgYyA9IDA7CiAgICAgcmV0dXJuIGM7CiB9CiAKLS0gCjEuNy4wLjMKCg==