36958 2010-04-01 07:23:55 -0700 webkitpy: unit test the networktransaction log messages 2010-04-02 01:31:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek abarth cjerdonek eric hamaji oldest_to_newest 207138 0 cjerdonek 2010-04-01 07:23:55 -0700 The networktransaction.py log messages need to be unit-tested. The purpose of this report is to be a mini-tutorial on how to unit-test log messages -- now that Python logging has been enabled for webkit-patch. 207144 1 52293 cjerdonek 2010-04-01 07:39:00 -0700 Created attachment 52293 Proposed patch Hi guys, this is all there is to it! Note that the tearDown() method also asserts that the array of remaining log messages is empty. This checks that there are no unanticipated log messages you *didn't* want to be present. We get this extra check for free since it's in the tearDown(). (Shinichiro, you've already seen this pattern a number of times, so let's let Adam or Eric review it so we know at least one of them gets a chance to see it. Thanks!) 207199 2 52293 abarth 2010-04-01 09:18:34 -0700 Comment on attachment 52293 Proposed patch Nice, but can we put the setUp and tearDown code into a base class so we don't have to copy/paste it all the time? 207266 3 eric 2010-04-01 11:20:15 -0700 I think it looks nice. :) 207430 4 cjerdonek 2010-04-01 15:01:18 -0700 (In reply to comment #2) > (From update of attachment 52293 [details]) > Nice, but can we put the setUp and tearDown code into a base class so we don't > have to copy/paste it all the time? Yeah, certainly. It crossed my mind, too. It might be a bit heavy for just a couple lines of code, but since Python supports multiple inheritance, I guess we don't risk it presenting a problem down the road should we ever need another base class. (I've never actually needed to use multiple inheritance in Python before.) 207772 5 52397 cjerdonek 2010-04-02 00:35:01 -0700 Created attachment 52397 Proposed patch 2 Changed the patch to use a base class. It seems possible that we could run into multiple inheritance issues down the road with this change after all. This is because it seems that the base class I created needs to itself inherit from unittest.TestCase (as opposed to the calling class inheriting from both this base class and unittest.TestCase). Otherwise, the setUp() and tearDown() methods of the base class don't seem to get fired. If we ever needed to inherit from unittest.TestCase twice in this way, I'm not sure whether unittest will know to call the setUp() and tearDown() methods of both of the unittest.TestCase super classes. 207776 6 52397 abarth 2010-04-02 00:38:39 -0700 Comment on attachment 52397 Proposed patch 2 Yeah, we can deal with the inheritance issues if they come up. We've used this pattern before and been happy with it. Thanks for the patch. 207809 7 52397 cjerdonek 2010-04-02 01:31:48 -0700 Comment on attachment 52397 Proposed patch 2 Clearing flags on attachment: 52397 Committed r56988: <http://trac.webkit.org/changeset/56988> 207810 8 cjerdonek 2010-04-02 01:31:55 -0700 All reviewed patches have been landed. Closing bug. 52293 2010-04-01 07:39:00 -0700 2010-04-02 00:35:01 -0700 Proposed patch _patch-36958-1.diff text/plain 2285 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiNDE4ZjU5Li4yNTA1MDE3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQt MDEgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5pdC10ZXN0IG5ldHdvcmt0cmFu c2FjdGlvbi5weSdzIGxvZyBtZXNzYWdlcy4gIFRoZSBwdXJwb3NlIG9mCisgICAgICAgIHRoaXMg cGF0Y2ggaXMgdG8gYmUgYSBtaW5pLXR1dG9yaWFsIG9uIGhvdyB0byB1bml0LXRlc3QgUHl0aG9u CisgICAgICAgIGxvZ2dpbmcucHkgbWVzc2FnZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTU4CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0aW9uX3VuaXR0ZXN0LnB5OgorICAgICAgICAg IC0gVW5pdC10ZXN0ZWQgdGhlIGxvZyBtZXNzYWdlcyBpbiB0ZXN0X3JldHJ5KCkuCisKIDIwMTAt MDQtMDEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlci1z dGFtcGVkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0aW9uX3VuaXR0ZXN0LnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L25ldHdvcmt0cmFuc2FjdGlvbl91bml0 dGVzdC5weQppbmRleCA3MmZhN2RkLi5iM2M5MGViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0aW9uX3VuaXR0ZXN0LnB5 CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9uZXR3b3JrdHJh bnNhY3Rpb25fdW5pdHRlc3QucHkKQEAgLTI5LDExICsyOSwxOSBAQAogaW1wb3J0IHVuaXR0ZXN0 CiAKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5uZXR3b3JrdHJhbnNhY3Rpb24gaW1wb3J0IE5l dHdvcmtUcmFuc2FjdGlvbiwgTmV0d29ya1RpbWVvdXQKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5 c3RlbS5sb2d0ZXN0aW5nIGltcG9ydCBMb2dUZXN0aW5nCiBmcm9tIHdlYmtpdHB5LnRoaXJkcGFy dHkuYXV0b2luc3RhbGxlZC5tZWNoYW5pemUgaW1wb3J0IEhUVFBFcnJvcgogCisKIGNsYXNzIE5l dHdvcmtUcmFuc2FjdGlvblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGV4Y2VwdGlvbiA9 IEV4Y2VwdGlvbigiVGVzdCBleGNlcHRpb24iKQogCisgICAgZGVmIHNldFVwKHNlbGYpOgorICAg ICAgICBzZWxmLl9sb2cgPSBMb2dUZXN0aW5nLnNldFVwKHNlbGYpCisKKyAgICBkZWYgdGVhckRv d24oc2VsZik6CisgICAgICAgIHNlbGYuX2xvZy50ZWFyRG93bigpCisKICAgICBkZWYgdGVzdF9z dWNjZXNzKHNlbGYpOgogICAgICAgICB0cmFuc2FjdGlvbiA9IE5ldHdvcmtUcmFuc2FjdGlvbigp CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwodHJhbnNhY3Rpb24ucnVuKGxhbWJkYTogNDIpLCA0 MikKQEAgLTY1LDYgKzczLDEwIEBAIGNsYXNzIE5ldHdvcmtUcmFuc2FjdGlvblRlc3QodW5pdHRl c3QuVGVzdENhc2UpOgogICAgICAgICB0cmFuc2FjdGlvbiA9IE5ldHdvcmtUcmFuc2FjdGlvbihp bml0aWFsX2JhY2tvZmZfc2Vjb25kcz0wKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHRyYW5z YWN0aW9uLnJ1bihsYW1iZGE6IHNlbGYuX3JhaXNlX2h0dHBfZXJyb3IoKSksIDQyKQogICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuX3J1bl9jb3VudCwgMykKKyAgICAgICAgc2VsZi5fbG9n LmFzc2VydE1lc3NhZ2VzKFsnV0FSTklORzogUmVjZWl2ZWQgSFRUUCBzdGF0dXMgNTAwIGZyb20g JworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdzZXJ2ZXIuICBSZXRyeWluZyBp biAwIHNlY29uZHMuLi5cbicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1dB Uk5JTkc6IFJlY2VpdmVkIEhUVFAgc3RhdHVzIDUwMCBmcm9tICcKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnc2VydmVyLiAgUmV0cnlpbmcgaW4gMC4wIHNlY29uZHMuLi5cbidd KQogCiAgICAgZGVmIHRlc3RfdGltZW91dChzZWxmKToKICAgICAgICAgc2VsZi5fcnVuX2NvdW50 ID0gMAo= 52397 2010-04-02 00:35:01 -0700 2010-04-02 01:31:48 -0700 Proposed patch 2 _patch-36952-2.diff text/plain 5794 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjZDE2NzZmLi4wMTJlMzE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDQt MDIgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5pdC10ZXN0IG5ldHdvcmt0cmFu c2FjdGlvbi5weSdzIGxvZyBtZXNzYWdlcywgYW5kIGFkZCBhIGJhc2UKKyAgICAgICAgY2xhc3Mg dG8gbWFrZSB1bml0LXRlc3RpbmcgbG9nIG1lc3NhZ2VzIGV2ZW4gZWFzaWVyLgorICAgICAgICAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTU4CisK KyAgICAgICAgVGhlIHB1cnBvc2Ugb2YgdGhpcyBwYXRjaCBpcyBhbHNvIHRvIHByb3ZpZGUgYSBt aW5pLXR1dG9yaWFsIG9uCisgICAgICAgIGhvdyB0byB1bml0LXRlc3QgUHl0aG9uIGxvZ2dpbmcu cHkgbWVzc2FnZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvbmV0 d29ya3RyYW5zYWN0aW9uX3VuaXR0ZXN0LnB5OgorICAgICAgICAgIC0gVW5pdC10ZXN0ZWQgdGhl IGxvZyBtZXNzYWdlcyBpbiB0ZXN0X3JldHJ5KCkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vbG9ndGVzdGluZy5weToKKyAgICAgICAgICAtIEFkanVzdGVkIHRo ZSBMb2dUZXN0aW5nIGNsYXNzIGJ5IG1vdmluZyB0aGUgY29kZSB0aGF0IGNsZWFycworICAgICAg ICAgICAgdGhlIGFycmF5IG9mIGxvZyBtZXNzYWdlcyBpbnRvIGEgZmluYWxseSBibG9jay4gIFRo aXMgcHJldmVudHMKKyAgICAgICAgICAgIHJlZHVuZGFudCBBc3NlcnRpb25FcnJvcnMgZnJvbSBn ZXR0aW5nIHJlbmRlcmVkIHRvIHRoZSBzY3JlZW4KKyAgICAgICAgICAgIHdoaWxlIHJ1bm5pbmcg dW5pdCB0ZXN0cy4KKyAgICAgICAgICAtIEFkZGVkIGEgTG9nZ2luZ1Rlc3RDYXNlIGNsYXNzIHNv IHRoZSBzZXRVcCgpIGFuZCB0ZWFyRG93bigpCisgICAgICAgICAgICBtZXRob2RzIGRvIG5vdCBu ZWVkIHRvIGJlIGltcGxlbWVudGVkIGluIG9yZGVyIHRvIHRlc3QgbG9nZ2luZy4KKyAgICAgICAg ICAgIFJhdGhlciwgVGVzdENhc2UgY2xhc3NlcyBjYW4gc2ltcGx5IGluaGVyaXQgZnJvbSB0aGlz IGNsYXNzLgorCiAyMDEwLTA0LTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0aW9uX3VuaXR0ZXN0 LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L25ldHdvcmt0cmFu c2FjdGlvbl91bml0dGVzdC5weQppbmRleCA3MmZhN2RkLi5jZDA3MDJiIDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0aW9u X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9uZXR3b3JrdHJhbnNhY3Rpb25fdW5pdHRlc3QucHkKQEAgLTI5LDkgKzI5LDExIEBACiBpbXBv cnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJraXRweS5jb21tb24ubmV0Lm5ldHdvcmt0cmFuc2FjdGlv biBpbXBvcnQgTmV0d29ya1RyYW5zYWN0aW9uLCBOZXR3b3JrVGltZW91dAorZnJvbSB3ZWJraXRw eS5jb21tb24uc3lzdGVtLmxvZ3Rlc3RpbmcgaW1wb3J0IExvZ2dpbmdUZXN0Q2FzZQogZnJvbSB3 ZWJraXRweS50aGlyZHBhcnR5LmF1dG9pbnN0YWxsZWQubWVjaGFuaXplIGltcG9ydCBIVFRQRXJy b3IKIAotY2xhc3MgTmV0d29ya1RyYW5zYWN0aW9uVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CisK K2NsYXNzIE5ldHdvcmtUcmFuc2FjdGlvblRlc3QoTG9nZ2luZ1Rlc3RDYXNlKToKICAgICBleGNl cHRpb24gPSBFeGNlcHRpb24oIlRlc3QgZXhjZXB0aW9uIikKIAogICAgIGRlZiB0ZXN0X3N1Y2Nl c3Moc2VsZik6CkBAIC02NSw2ICs2NywxMCBAQCBjbGFzcyBOZXR3b3JrVHJhbnNhY3Rpb25UZXN0 KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgdHJhbnNhY3Rpb24gPSBOZXR3b3JrVHJhbnNh Y3Rpb24oaW5pdGlhbF9iYWNrb2ZmX3NlY29uZHM9MCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bCh0cmFuc2FjdGlvbi5ydW4obGFtYmRhOiBzZWxmLl9yYWlzZV9odHRwX2Vycm9yKCkpLCA0MikK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxmLl9ydW5fY291bnQsIDMpCisgICAgICAgIHNl bGYuYXNzZXJ0TG9nKFsnV0FSTklORzogUmVjZWl2ZWQgSFRUUCBzdGF0dXMgNTAwIGZyb20gc2Vy dmVyLiAgJworICAgICAgICAgICAgICAgICAgICAgICAgJ1JldHJ5aW5nIGluIDAgc2Vjb25kcy4u LlxuJywKKyAgICAgICAgICAgICAgICAgICAgICAgICdXQVJOSU5HOiBSZWNlaXZlZCBIVFRQIHN0 YXR1cyA1MDAgZnJvbSBzZXJ2ZXIuICAnCisgICAgICAgICAgICAgICAgICAgICAgICAnUmV0cnlp bmcgaW4gMC4wIHNlY29uZHMuLi5cbiddKQogCiAgICAgZGVmIHRlc3RfdGltZW91dChzZWxmKToK ICAgICAgICAgc2VsZi5fcnVuX2NvdW50ID0gMApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2xvZ3Rlc3RpbmcucHkgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vbG9ndGVzdGluZy5weQppbmRleCBlZmU5NWZl Li4yZmYyMTdkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vbG9ndGVzdGluZy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vbG9ndGVzdGluZy5weQpAQCAtMjUsMTMgKzI1LDE0IEBACiBQcm92aWRl cyBzdXBwb3J0IGZvciB1bml0LXRlc3RpbmcgbWVzc2FnZXMgbG9nZ2VkIHVzaW5nIHRoZSBidWls dC1pbgogbG9nZ2luZyBtb2R1bGUuCiAKLVVzZSB0aGUgTG9nVGVzdGluZyBjbGFzcyBmb3IgYmFz aWMgdGVzdGluZyBuZWVkcy4gIEZvciBtb3JlIGFkdmFuY2VkCi1uZWVkcyAoZS5nLiB1bml0LXRl c3RpbmcgbWV0aG9kcyB0aGF0IGNvbmZpZ3VyZSBsb2dnaW5nKSwgc2VlIHRoZQotVGVzdExvZ1N0 cmVhbSBjbGFzcy4KK0luaGVyaXQgZnJvbSB0aGUgTG9nZ2luZ1Rlc3RDYXNlIGNsYXNzIGZvciBi YXNpYyB0ZXN0aW5nIG5lZWRzLiAgRm9yCittb3JlIGFkdmFuY2VkIG5lZWRzIChlLmcuIHVuaXQt dGVzdGluZyBtZXRob2RzIHRoYXQgY29uZmlndXJlIGxvZ2dpbmcpLAorc2VlIHRoZSBUZXN0TG9n U3RyZWFtIGNsYXNzLCBhbmQgcGVyaGFwcyBhbHNvIHRoZSBMb2dUZXN0aW5nIGNsYXNzLgogCiAi IiIKIAogaW1wb3J0IGxvZ2dpbmcKK2ltcG9ydCB1bml0dGVzdAogCiAKIGNsYXNzIFRlc3RMb2dT dHJlYW0ob2JqZWN0KToKQEAgLTE4OCw4ICsxODksNTggQEAgY2xhc3MgTG9nVGVzdGluZyhvYmpl Y3QpOgogICAgIGRlZiBhc3NlcnRNZXNzYWdlcyhzZWxmLCBtZXNzYWdlcyk6CiAgICAgICAgICIi IkFzc2VydCB0aGUgY3VycmVudCBhcnJheSBvZiBsb2cgbWVzc2FnZXMsIGFuZCBjbGVhciBpdHMg Y29udGVudHMuCiAKLSAgICAgICAgbWVzc2FnZXM6IEEgbGlzdCBvZiBsb2cgbWVzc2FnZSBzdHJp bmdzLgorICAgICAgICBBcmdzOgorICAgICAgICAgIG1lc3NhZ2VzOiBBIGxpc3Qgb2YgbG9nIG1l c3NhZ2Ugc3RyaW5ncy4KKworICAgICAgICAiIiIKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAg c2VsZi5fdGVzdF9zdHJlYW0uYXNzZXJ0TWVzc2FnZXMobWVzc2FnZXMpCisgICAgICAgIGZpbmFs bHk6CisgICAgICAgICAgICAjIFdlIHdhbnQgdG8gY2xlYXIgdGhlIGFycmF5IG9mIG1lc3NhZ2Vz IGV2ZW4gaW4gdGhlIGNhc2Ugb2YKKyAgICAgICAgICAgICMgYW4gRXhjZXB0aW9uIChlLmcuIGFu IEFzc2VydGlvbkVycm9yKS4gIE90aGVyd2lzZSwgYW5vdGhlcgorICAgICAgICAgICAgIyBBc3Nl cnRpb25FcnJvciBjYW4gb2NjdXIgaW4gdGhlIHRlYXJEb3duKCkgYmVjYXVzZSB0aGUKKyAgICAg ICAgICAgICMgYXJyYXkgbWlnaHQgbm90IGhhdmUgZ290dGVuIGVtcHRpZWQuCisgICAgICAgICAg ICBzZWxmLl90ZXN0X3N0cmVhbS5tZXNzYWdlcyA9IFtdCisKKworIyBUaGlzIGNsYXNzIG5lZWRz IHRvIGluaGVyaXQgZnJvbSB1bml0dGVzdC5UZXN0Q2FzZS4gIE90aGVyd2lzZSwgdGhlCisjIHNl dFVwKCkgYW5kIHRlYXJEb3duKCkgbWV0aG9kcyB3aWxsIG5vdCBnZXQgZmlyZWQgZm9yIHRlc3Qg Y2FzZSBjbGFzc2VzCisjIHRoYXQgaW5oZXJpdCBmcm9tIHRoaXMgY2xhc3MgLS0gZXZlbiBpZiB0 aGUgY2xhc3MgaW5oZXJpdHMgZnJvbSAqYm90aCoKKyMgdW5pdHRlc3QuVGVzdENhc2UgYW5kIExv Z2dpbmdUZXN0Q2FzZS4KK2NsYXNzIExvZ2dpbmdUZXN0Q2FzZSh1bml0dGVzdC5UZXN0Q2FzZSk6 CisKKyAgICAiIiJTdXBwb3J0cyBlbmQtdG8tZW5kIHVuaXQtdGVzdGluZyBvZiBsb2cgbWVzc2Fn ZXMuCisKKyAgICAgICAgU2FtcGxlIHVzYWdlOgorCisgICAgICAgICAgY2xhc3MgU2FtcGxlVGVz dChMb2dnaW5nVGVzdENhc2UpOgorCisgICAgICAgICAgICAgIGRlZiB0ZXN0X2xvZ2dpbmdfaW5f c29tZV9tZXRob2Qoc2VsZik6CisgICAgICAgICAgICAgICAgICBjYWxsX3NvbWVfbWV0aG9kKCkg ICMgQ29udGFpbnMgY2FsbHMgdG8gX2xvZy5pbmZvKCksIGV0Yy4KKworICAgICAgICAgICAgICAg ICAgIyBDaGVjayB0aGUgcmVzdWx0aW5nIGxvZyBtZXNzYWdlcy4KKyAgICAgICAgICAgICAgICAg IHNlbGYuYXNzZXJ0TG9nKFsiSU5GTzogZXhwZWN0ZWQgbWVzc2FnZSAjMSIsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIldBUk5JTkc6IGV4cGVjdGVkIG1lc3NhZ2UgIzIiXSkK KworICAgICIiIgorCisgICAgZGVmIHNldFVwKHNlbGYpOgorICAgICAgICBzZWxmLl9sb2cgPSBM b2dUZXN0aW5nLnNldFVwKHNlbGYpCisKKyAgICBkZWYgdGVhckRvd24oc2VsZik6CisgICAgICAg IHNlbGYuX2xvZy50ZWFyRG93bigpCisKKyAgICAjIEZJWE1FOiBBZGQgYSBjbGVhck1lc3NhZ2Vz KCkgbWV0aG9kIGZvciBjYXNlcyB3aGVyZSB0aGUgY2FsbGVyCisgICAgIyAgICAgICAgZGVsaWJl cmF0ZWx5IGRvZXNuJ3Qgd2FudCB0byBhc3NlcnQgZXZlcnkgbWVzc2FnZS4KKworICAgICMgU2Vl IHRoZSBjb2RlIGNvbW1lbnRzIHByZWNlZGluZyBMb2dUZXN0aW5nLmFzc2VydE1lc3NhZ2VzKCkg Zm9yCisgICAgIyBhbiBleHBsYW5hdGlvbiBvZiB3aHkgd2UgY2xlYXIgdGhlIGFycmF5IG9mIG1l c3NhZ2VzIGFmdGVyCisgICAgIyBhc3NlcnRpbmcgaXRzIGNvbnRlbnRzLgorICAgIGRlZiBhc3Nl cnRMb2coc2VsZiwgbWVzc2FnZXMpOgorICAgICAgICAiIiJBc3NlcnQgdGhlIGN1cnJlbnQgYXJy YXkgb2YgbG9nIG1lc3NhZ2VzLCBhbmQgY2xlYXIgaXRzIGNvbnRlbnRzLgorCisgICAgICAgIEFy Z3M6CisgICAgICAgICAgbWVzc2FnZXM6IEEgbGlzdCBvZiBsb2cgbWVzc2FnZSBzdHJpbmdzLgog CiAgICAgICAgICIiIgotICAgICAgICBzZWxmLl90ZXN0X3N0cmVhbS5hc3NlcnRNZXNzYWdlcyht ZXNzYWdlcykKLSAgICAgICAgc2VsZi5fdGVzdF9zdHJlYW0ubWVzc2FnZXMgPSBbXQorICAgICAg ICBzZWxmLl9sb2cuYXNzZXJ0TWVzc2FnZXMobWVzc2FnZXMpCg==