36916 2010-03-31 18:26:16 -0700 Make the EWS go faster by being optimistic 2010-03-31 18:43:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric oldest_to_newest 206870 0 abarth 2010-03-31 18:26:16 -0700 Make the EWS go faster by being optimistic 206871 1 52230 abarth 2010-03-31 18:26:59 -0700 Created attachment 52230 Patch 206872 2 52230 eric 2010-03-31 18:29:55 -0700 Comment on attachment 52230 Patch This is fantastic. Adam promises he's get rid of the copy paste. :) Are you sure you caught all of these? - def _review_patch(self, patch): + def review_patch(self, patch): 206874 3 52230 abarth 2010-03-31 18:31:16 -0700 Comment on attachment 52230 Patch Global grep says yes. 206877 4 52230 commit-queue 2010-03-31 18:43:53 -0700 Comment on attachment 52230 Patch Clearing flags on attachment: 52230 Committed r56884: <http://trac.webkit.org/changeset/56884> 206878 5 commit-queue 2010-03-31 18:43:57 -0700 All reviewed patches have been landed. Closing bug. 52230 2010-03-31 18:26:59 -0700 2010-03-31 18:43:52 -0700 Patch bug-36916-20100331182658.patch text/plain 5008 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3OTk0NmNiLi5kNzUzYTFjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMt MzEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBFV1MgZ28gZmFzdGVyIGJ5IGJl aW5nIG9wdGltaXN0aWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2OTE2CisKKyAgICAgICAgSGF2ZSB0aGUgRVdTIGJlIG9wdGltaXN0aWMgdGhhdCBh IHBhdGNoIHdpbGwgY29ycmVjdGx5IGJ1aWxkLiAgVGhpcworICAgICAgICBzaG91bGQgc3BlZWQg dXAgdGhlIGNvbW1vbiBjYXNlIGJ5IG5vdCByZXF1aXJpbmcgdHdvIGJ1aWxkcyBmb3IgZXZlcnkK KyAgICAgICAgcGF0Y2guCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9xdWV1ZXMucHk6CisKIDIwMTAtMDMtMzEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5n c3lzdGVtLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vh cmx5d2FybmluZ3N5c3RlbS5weQppbmRleCBkZmRjYTM2Li43OWU4YjA1IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lz dGVtLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9l YXJseXdhcm5pbmdzeXN0ZW0ucHkKQEAgLTQzLDMwICs0Myw0OSBAQCBjbGFzcyBBYnN0cmFjdEVh cmx5V2FybmluZ1N5c3RlbShBYnN0cmFjdFJldmlld1F1ZXVlKToKICAgICAgICAgc2VsZi5wb3J0 ID0gV2ViS2l0UG9ydC5wb3J0KHNlbGYucG9ydF9uYW1lKQogCiAgICAgZGVmIHNob3VsZF9wcm9j ZWVkX3dpdGhfd29ya19pdGVtKHNlbGYsIHBhdGNoKToKKyAgICAgICAgcmV0dXJuIFRydWUKKwor ICAgIGRlZiBfY2FuX2J1aWxkKHNlbGYpOgogICAgICAgICB0cnk6CiAgICAgICAgICAgICBzZWxm LnJ1bl93ZWJraXRfcGF0Y2goWwogICAgICAgICAgICAgICAgICJidWlsZCIsCiAgICAgICAgICAg ICAgICAgc2VsZi5wb3J0LmZsYWcoKSwKICAgICAgICAgICAgICAgICAiLS1idWlsZC1zdHlsZT0l cyIgJSBzZWxmLl9idWlsZF9zdHlsZSwKICAgICAgICAgICAgICAgICAiLS1mb3JjZS1jbGVhbiIs CisgICAgICAgICAgICAgICAgIi0tbm8tdXBkYXRlIiwKICAgICAgICAgICAgICAgICAiLS1xdWll dCJdKQotICAgICAgICAgICAgc2VsZi5fdXBkYXRlX3N0YXR1cygiQnVpbGRpbmciLCBwYXRjaCkK KyAgICAgICAgICAgIHJldHVybiBUcnVlCiAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToK ICAgICAgICAgICAgIHNlbGYuX3VwZGF0ZV9zdGF0dXMoIlVuYWJsZSB0byBwZXJmb3JtIGEgYnVp bGQiKQogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAgIHJldHVybiBUcnVlCiAKLSAg ICBkZWYgX3Jldmlld19wYXRjaChzZWxmLCBwYXRjaCk6Ci0gICAgICAgIHNlbGYucnVuX3dlYmtp dF9wYXRjaChbCi0gICAgICAgICAgICAiYnVpbGQtYXR0YWNobWVudCIsCi0gICAgICAgICAgICBz ZWxmLnBvcnQuZmxhZygpLAotICAgICAgICAgICAgIi0tYnVpbGQtc3R5bGU9JXMiICUgc2VsZi5f YnVpbGRfc3R5bGUsCi0gICAgICAgICAgICAiLS1mb3JjZS1jbGVhbiIsCi0gICAgICAgICAgICAi LS1xdWlldCIsCi0gICAgICAgICAgICAiLS1ub24taW50ZXJhY3RpdmUiLAotICAgICAgICAgICAg Ii0tcGFyZW50LWNvbW1hbmQ9JXMiICUgc2VsZi5uYW1lLAotICAgICAgICAgICAgIi0tbm8tdXBk YXRlIiwKLSAgICAgICAgICAgIHBhdGNoLmlkKCldKQorICAgIGRlZiBfYnVpbGQoc2VsZiwgcGF0 Y2gsIGZpcnN0X3J1bj1GYWxzZSk6CisgICAgICAgIHRyeToKKyAgICAgICAgICAgIGFyZ3MgPSBb CisgICAgICAgICAgICAgICAgImJ1aWxkLWF0dGFjaG1lbnQiLAorICAgICAgICAgICAgICAgIHNl bGYucG9ydC5mbGFnKCksCisgICAgICAgICAgICAgICAgIi0tYnVpbGQtc3R5bGU9JXMiICUgc2Vs Zi5fYnVpbGRfc3R5bGUsCisgICAgICAgICAgICAgICAgIi0tZm9yY2UtY2xlYW4iLAorICAgICAg ICAgICAgICAgICItLXF1aWV0IiwKKyAgICAgICAgICAgICAgICAiLS1ub24taW50ZXJhY3RpdmUi LAorICAgICAgICAgICAgICAgIHBhdGNoLmlkKCldCisgICAgICAgICAgICBpZiBub3QgZmlyc3Rf cnVuOgorICAgICAgICAgICAgICAgICMgU2VlIGNvbW1pdC1xdWV1ZSBmb3IgYW4gZXhwbGFuYXRp b24gb2Ygd2hhdCB3ZSdyZSBkb2luZyBoZXJlLgorICAgICAgICAgICAgICAgIGFyZ3MuYXBwZW5k KCItLW5vLXVwZGF0ZSIpCisgICAgICAgICAgICAgICAgYXJncy5hcHBlbmQoIi0tcGFyZW50LWNv bW1hbmQ9JXMiICUgc2VsZi5uYW1lKQorICAgICAgICAgICAgc2VsZi5ydW5fd2Via2l0X3BhdGNo KGFyZ3MpCisgICAgICAgICAgICByZXR1cm4gVHJ1ZQorICAgICAgICBleGNlcHQgU2NyaXB0RXJy b3IsIGU6CisgICAgICAgICAgICBpZiBmaXJzdF9ydW46CisgICAgICAgICAgICAgICAgcmV0dXJu IEZhbHNlCisgICAgICAgICAgICByYWlzZQorCisgICAgZGVmIHJldmlld19wYXRjaChzZWxmLCBw YXRjaCk6CisgICAgICAgIGlmIG5vdCBzZWxmLl9idWlsZChwYXRjaCwgZmlyc3RfcnVuPVRydWUp OgorICAgICAgICAgICAgaWYgbm90IHNlbGYuX2Nhbl9idWlsZCgpOgorICAgICAgICAgICAgICAg IHJldHVybiBGYWxzZQorICAgICAgICAgICAgc2VsZi5fYnVpbGQoKQorICAgICAgICByZXR1cm4g VHJ1ZQogCiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIGhhbmRsZV9zY3JpcHRfZXJyb3IoY2xz LCB0b29sLCBzdGF0ZSwgc2NyaXB0X2Vycm9yKToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CmluZGV4IGQ5OWRiYWQuLmQ5Yzgy NzEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL3F1ZXVlcy5weQpAQCAtMjM1LDcgKzIzNSw3IEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFic3Ry YWN0UGF0Y2hRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKToKICAgICAgICAgICAgIGlm IGZpcnN0X3J1bjoKICAgICAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgICAgIHNl bGYuX2RpZF9mYWlsKHBhdGNoKQotICAgICAgICAgICAgcmFpc2UgZQorICAgICAgICAgICAgcmFp c2UKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBwYXRjaCk6CiAgICAgICAgIHNl bGYuX2NjX3dhdGNoZXJzKHBhdGNoLmJ1Z19pZCgpKQpAQCAtMjc0LDcgKzI3NCw3IEBAIGNsYXNz IEFic3RyYWN0UmV2aWV3UXVldWUoQWJzdHJhY3RQYXRjaFF1ZXVlLCBQZXJzaXN0ZW50UGF0Y2hD b2xsZWN0aW9uRGVsZWdhdGUsCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIG9wdGlvbnM9Tm9uZSk6 CiAgICAgICAgIEFic3RyYWN0UGF0Y2hRdWV1ZS5fX2luaXRfXyhzZWxmLCBvcHRpb25zKQogCi0g ICAgZGVmIF9yZXZpZXdfcGF0Y2goc2VsZiwgcGF0Y2gpOgorICAgIGRlZiByZXZpZXdfcGF0Y2go c2VsZiwgcGF0Y2gpOgogICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xh c3NlcyBtdXN0IGltcGxlbWVudCIKIAogICAgICMgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbkRl bGVnYXRlIG1ldGhvZHMKQEAgLTMwOCw4ICszMDgsOCBAQCBjbGFzcyBBYnN0cmFjdFJldmlld1F1 ZXVlKEFic3RyYWN0UGF0Y2hRdWV1ZSwgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbkRlbGVnYXRl LAogCiAgICAgZGVmIHByb2Nlc3Nfd29ya19pdGVtKHNlbGYsIHBhdGNoKToKICAgICAgICAgdHJ5 OgotICAgICAgICAgICAgc2VsZi5fcmV2aWV3X3BhdGNoKHBhdGNoKQotICAgICAgICAgICAgc2Vs Zi5fZGlkX3Bhc3MocGF0Y2gpCisgICAgICAgICAgICBpZiBzZWxmLnJldmlld19wYXRjaChwYXRj aCk6CisgICAgICAgICAgICAgICAgc2VsZi5fZGlkX3Bhc3MocGF0Y2gpCiAgICAgICAgIGV4Y2Vw dCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIGlmIGUuZXhpdF9jb2RlICE9IFF1ZXVlRW5n aW5lLmhhbmRsZWRfZXJyb3JfY29kZToKICAgICAgICAgICAgICAgICBzZWxmLl9kaWRfZmFpbChw YXRjaCkKQEAgLTMzNCw4ICszMzQsOSBAQCBjbGFzcyBTdHlsZVF1ZXVlKEFic3RyYWN0UmV2aWV3 UXVldWUpOgogICAgICAgICBzZWxmLl91cGRhdGVfc3RhdHVzKCJDaGVja2luZyBzdHlsZSIsIHBh dGNoKQogICAgICAgICByZXR1cm4gVHJ1ZQogCi0gICAgZGVmIF9yZXZpZXdfcGF0Y2goc2VsZiwg cGF0Y2gpOgorICAgIGRlZiByZXZpZXdfcGF0Y2goc2VsZiwgcGF0Y2gpOgogICAgICAgICBzZWxm LnJ1bl93ZWJraXRfcGF0Y2goWyJjaGVjay1zdHlsZSIsICItLWZvcmNlLWNsZWFuIiwgIi0tbm9u LWludGVyYWN0aXZlIiwgIi0tcGFyZW50LWNvbW1hbmQ9c3R5bGUtcXVldWUiLCBwYXRjaC5pZCgp XSkKKyAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBoYW5k bGVfc2NyaXB0X2Vycm9yKGNscywgdG9vbCwgc3RhdGUsIHNjcmlwdF9lcnJvcik6Cg==