36907 2010-03-31 16:23:33 -0700 [Chromium] WebFrame should have a method to execute script and return the evaluated value 2010-04-01 23:36:34 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jcampan jcampan abarth commit-queue dglazkov eric fishd oldest_to_newest 206797 0 jcampan 2010-03-31 16:23:33 -0700 In the Chromium API, the WebFrame class should have a method that executes some JavaScript and returns the value it evaluates to. 206806 1 52221 jcampan 2010-03-31 16:31:43 -0700 Created attachment 52221 Adding a method to WebFrame to evaluate a JS expression. 207457 2 eric 2010-04-01 16:00:58 -0700 Seems like a good idea to me, but Adam, Dimitry or Darin are better reviewers for this sort of change. 207472 3 52221 fishd 2010-04-01 16:27:49 -0700 Comment on attachment 52221 Adding a method to WebFrame to evaluate a JS expression. > Index: WebKit/chromium/public/WebFrame.h ... > namespace v8 { > class Context; > +template <class T> class Handle; > template <class T> class Local; > +class Value; > + > } nit: please change the above to: namespace v8 { class Context; class Value; template <class T> class Handle; template <class T> class Local; } with that, R=me 207483 4 52350 jcampan 2010-04-01 16:39:52 -0700 Created attachment 52350 Fixing class name order 207555 5 52350 levin 2010-04-01 17:51:49 -0700 Comment on attachment 52350 Fixing class name order Based on Darin's previous r+ and validating that the requested change was done. 207573 6 abarth 2010-04-01 18:20:30 -0700 I take it we don't have a ScriptController in the WebKit API. :) 207689 7 52350 commit-queue 2010-04-01 23:09:14 -0700 Comment on attachment 52350 Fixing class name order Clearing flags on attachment: 52350 Committed r56972: <http://trac.webkit.org/changeset/56972> 207690 8 commit-queue 2010-04-01 23:09:19 -0700 All reviewed patches have been landed. Closing bug. 207714 9 fishd 2010-04-01 23:36:34 -0700 (In reply to comment #6) > I take it we don't have a ScriptController in the WebKit API. :) Well, we do have WebScriptController, but it only has static functions. It is used for registering V8 extensions and performing some other operations. It isn't an instantiated class in the WebKit API. We could change that if it would help make things clearer. 52221 2010-03-31 16:31:43 -0700 2010-04-01 16:39:52 -0700 Adding a method to WebFrame to evaluate a JS expression. js.patch text/plain 2895 jcampan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1Njg3NSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0zMSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBtZXRob2QgdG8gV2ViRnJhbWUgdG8gZXhl Y3V0ZSBKYXZhU2NyaXB0IGFuZCBnZXQgdGhlIHZhbHVlCisgICAgICAgIGl0IGV2YWx1YXRlcyB0 by4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTA3 CisKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJ bXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpleGVjdXRlU2NyaXB0QW5k UmV0dXJuVmFsdWUpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMC0wMy0z MSAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEZpc2hlci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaA0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAkocmV2aXNpb24g NTY4NzEpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM5LDcgKzM5LDEwIEBAIHN0cnVjdCBOUE9iamVjdDsKICNpZiBXRUJLSVRfVVNJTkdf VjgKIG5hbWVzcGFjZSB2OCB7CiBjbGFzcyBDb250ZXh0OwordGVtcGxhdGUgPGNsYXNzIFQ+IGNs YXNzIEhhbmRsZTsKIHRlbXBsYXRlIDxjbGFzcyBUPiBjbGFzcyBMb2NhbDsKK2NsYXNzIFZhbHVl OworCiB9CiAjZW5kaWYKIApAQCAtMjI1LDYgKzIyOCwxMSBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIGNvbGxlY3RHYXJiYWdlKCkgPSAwOwogCiAjaWYgV0VCS0lUX1VTSU5HX1Y4CisgICAg Ly8gRXhlY3V0ZXMgc2NyaXB0IGluIHRoZSBjb250ZXh0IG9mIHRoZSBjdXJyZW50IHBhZ2UgYW5k IHJldHVybnMgdGhlIHZhbHVlCisgICAgLy8gdGhhdCB0aGUgc2NyaXB0IGV2YWx1YXRlZCB0by4K KyAgICB2aXJ0dWFsIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBleGVjdXRlU2NyaXB0QW5kUmV0dXJu VmFsdWUoCisgICAgICAgIGNvbnN0IFdlYlNjcmlwdFNvdXJjZSYpID0gMDsKKwogICAgIC8vIFJl dHVybnMgdGhlIFY4IGNvbnRleHQgZm9yIHRoaXMgZnJhbWUsIG9yIGFuIGVtcHR5IGhhbmRsZSBp ZiB0aGVyZQogICAgIC8vIGlzIG5vbmUuCiAgICAgdmlydHVhbCB2ODo6TG9jYWw8djg6OkNvbnRl eHQ+IG1haW5Xb3JsZFNjcmlwdENvbnRleHQoKSBjb25zdCA9IDA7CkluZGV4OiBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDU2ODcxKQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NzksNiArNzc5LDEz IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpjb2xsZWN0R2FyYmFnZSgpCiB9CiAKICNpZiBVU0UoVjgp Cit2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gV2ViRnJhbWVJbXBsOjpleGVjdXRlU2NyaXB0QW5kUmV0 dXJuVmFsdWUoCisgICAgY29uc3QgV2ViU2NyaXB0U291cmNlJiBzb3VyY2UpCit7CisgICAgcmV0 dXJuIG1fZnJhbWUtPnNjcmlwdCgpLT5leGVjdXRlU2NyaXB0KAorICAgICAgICBTY3JpcHRTb3Vy Y2VDb2RlKHNvdXJjZS5jb2RlLCBzb3VyY2UudXJsLCBzb3VyY2Uuc3RhcnRMaW5lKSkudjhWYWx1 ZSgpOworfQorCiAvLyBSZXR1cm5zIHRoZSBWOCBjb250ZXh0IGZvciB0aGlzIGZyYW1lLCBvciBh biBlbXB0eSBoYW5kbGUgaWYgdGhlcmUgaXMgbm9uZS4KIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4g V2ViRnJhbWVJbXBsOjptYWluV29ybGRTY3JpcHRDb250ZXh0KCkgY29uc3QKIHsKSW5kZXg6IFdl YktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCShyZXZpc2lvbiA1Njg3MSkKKysrIFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMSw2ICsxMDEs OCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGFkZE1lc3NhZ2VUb0NvbnNvbGUoY29uc3Qg V2ViQ29uc29sZU1lc3NhZ2UmKTsKICAgICB2aXJ0dWFsIHZvaWQgY29sbGVjdEdhcmJhZ2UoKTsK ICNpZiBXRUJLSVRfVVNJTkdfVjgKKyAgICB2aXJ0dWFsIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBl eGVjdXRlU2NyaXB0QW5kUmV0dXJuVmFsdWUoCisgICAgICAgIGNvbnN0IFdlYlNjcmlwdFNvdXJj ZSYpOwogICAgIHZpcnR1YWwgdjg6OkxvY2FsPHY4OjpDb250ZXh0PiBtYWluV29ybGRTY3JpcHRD b250ZXh0KCkgY29uc3Q7CiAjZW5kaWYKICAgICB2aXJ0dWFsIGJvb2wgaW5zZXJ0U3R5bGVUZXh0 KGNvbnN0IFdlYlN0cmluZyYgY3NzLCBjb25zdCBXZWJTdHJpbmcmIGlkKTsK 52350 2010-04-01 16:39:52 -0700 2010-04-01 23:09:14 -0700 Fixing class name order js.patch text/plain 2890 jcampan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1Njg3NSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0zMSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBtZXRob2QgdG8gV2ViRnJhbWUgdG8gZXhl Y3V0ZSBKYXZhU2NyaXB0IGFuZCBnZXQgdGhlIHZhbHVlCisgICAgICAgIGl0IGV2YWx1YXRlcyB0 by4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2OTA3 CisKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJ bXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpleGVjdXRlU2NyaXB0QW5k UmV0dXJuVmFsdWUpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMC0wMy0z MSAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEZpc2hlci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaA0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAkocmV2aXNpb24g NTY4NzEpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM5LDYgKzM5LDggQEAgc3RydWN0IE5QT2JqZWN0OwogI2lmIFdFQktJVF9VU0lOR19W OAogbmFtZXNwYWNlIHY4IHsKIGNsYXNzIENvbnRleHQ7CitjbGFzcyBWYWx1ZTsKK3RlbXBsYXRl IDxjbGFzcyBUPiBjbGFzcyBIYW5kbGU7CiB0ZW1wbGF0ZSA8Y2xhc3MgVD4gY2xhc3MgTG9jYWw7 CiB9CiAjZW5kaWYKQEAgLTIyNSw2ICsyMjcsMTEgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9p ZCBjb2xsZWN0R2FyYmFnZSgpID0gMDsKIAogI2lmIFdFQktJVF9VU0lOR19WOAorICAgIC8vIEV4 ZWN1dGVzIHNjcmlwdCBpbiB0aGUgY29udGV4dCBvZiB0aGUgY3VycmVudCBwYWdlIGFuZCByZXR1 cm5zIHRoZSB2YWx1ZQorICAgIC8vIHRoYXQgdGhlIHNjcmlwdCBldmFsdWF0ZWQgdG8uCisgICAg dmlydHVhbCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZXhlY3V0ZVNjcmlwdEFuZFJldHVyblZhbHVl KAorICAgICAgICBjb25zdCBXZWJTY3JpcHRTb3VyY2UmKSA9IDA7CisKICAgICAvLyBSZXR1cm5z IHRoZSBWOCBjb250ZXh0IGZvciB0aGlzIGZyYW1lLCBvciBhbiBlbXB0eSBoYW5kbGUgaWYgdGhl cmUKICAgICAvLyBpcyBub25lLgogICAgIHZpcnR1YWwgdjg6OkxvY2FsPHY4OjpDb250ZXh0PiBt YWluV29ybGRTY3JpcHRDb250ZXh0KCkgY29uc3QgPSAwOwpJbmRleDogV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lvbiA1Njg3MSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzc5LDYgKzc3OSwxMyBAQCB2 b2lkIFdlYkZyYW1lSW1wbDo6Y29sbGVjdEdhcmJhZ2UoKQogfQogCiAjaWYgVVNFKFY4KQordjg6 OkhhbmRsZTx2ODo6VmFsdWU+IFdlYkZyYW1lSW1wbDo6ZXhlY3V0ZVNjcmlwdEFuZFJldHVyblZh bHVlKAorICAgIGNvbnN0IFdlYlNjcmlwdFNvdXJjZSYgc291cmNlKQoreworICAgIHJldHVybiBt X2ZyYW1lLT5zY3JpcHQoKS0+ZXhlY3V0ZVNjcmlwdCgKKyAgICAgICAgU2NyaXB0U291cmNlQ29k ZShzb3VyY2UuY29kZSwgc291cmNlLnVybCwgc291cmNlLnN0YXJ0TGluZSkpLnY4VmFsdWUoKTsK K30KKwogLy8gUmV0dXJucyB0aGUgVjggY29udGV4dCBmb3IgdGhpcyBmcmFtZSwgb3IgYW4gZW1w dHkgaGFuZGxlIGlmIHRoZXJlIGlzIG5vbmUuCiB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IFdlYkZy YW1lSW1wbDo6bWFpbldvcmxkU2NyaXB0Q29udGV4dCgpIGNvbnN0CiB7CkluZGV4OiBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuaAkocmV2aXNpb24gNTY4NzEpCisrKyBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsNiArMTAxLDggQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBhZGRNZXNzYWdlVG9Db25zb2xlKGNvbnN0IFdlYkNv bnNvbGVNZXNzYWdlJik7CiAgICAgdmlydHVhbCB2b2lkIGNvbGxlY3RHYXJiYWdlKCk7CiAjaWYg V0VCS0lUX1VTSU5HX1Y4CisgICAgdmlydHVhbCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZXhlY3V0 ZVNjcmlwdEFuZFJldHVyblZhbHVlKAorICAgICAgICBjb25zdCBXZWJTY3JpcHRTb3VyY2UmKTsK ICAgICB2aXJ0dWFsIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gbWFpbldvcmxkU2NyaXB0Q29udGV4 dCgpIGNvbnN0OwogI2VuZGlmCiAgICAgdmlydHVhbCBib29sIGluc2VydFN0eWxlVGV4dChjb25z dCBXZWJTdHJpbmcmIGNzcywgY29uc3QgV2ViU3RyaW5nJiBpZCk7Cg==