36897 2010-03-31 12:09:19 -0700 REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com) 2010-03-31 13:12:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap eric mitz oldest_to_newest 206627 0 ap 2010-03-31 12:09:19 -0700 1. Visit boxofficemojo.com 2. Scroll the page vertically Results: The tops of the Flash ads at the top and along the right side of the page are clipped out. This happens when using the version of Flash that currently ships with Mac OS X. <rdar://problem/7804018> 206652 1 52197 ap 2010-03-31 12:40:31 -0700 Created attachment 52197 proposed fix 206655 2 52197 mitz 2010-03-31 12:42:58 -0700 Comment on attachment 52197 proposed fix Thanks for fixing this! > + IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so storing it in frame view coordinates, and not clipped to window. I would say “content view coordinates”. r=me 206657 3 eric 2010-03-31 12:44:10 -0700 Attachment 52197 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1612107 206658 4 52197 darin 2010-03-31 12:44:21 -0700 Comment on attachment 52197 proposed fix > +#include "CString.h" Please don't add this. Or you could state why you need to add it. > - IntRect m_windowClipRect; > + IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so storing it in frame view coordinates, and not clipped to window. I would say "it is stored" rather than "storing it" here. 206663 5 ap 2010-03-31 12:49:18 -0700 Committed <http://trac.webkit.org/changeset/56858>. 206671 6 52197 simon.fraser 2010-03-31 13:06:25 -0700 Comment on attachment 52197 proposed fix > Index: WebCore/rendering/RenderWidget.cpp > +#include "CString.h" Was this an intentional part of the change? 206679 7 ap 2010-03-31 13:12:45 -0700 Addressed additional review comments in <http://trac.webkit.org/changeset/56859>. 52197 2010-03-31 12:40:31 -0700 2010-03-31 13:06:25 -0700 proposed fix ScrolledPlugin.txt text/plain 6399 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Njg1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDMtMzEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2ODk3CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83ODA0MDE4PiBSRUdSRVNTSU9OIChyNTY0MjkpOiBGbGFzaCBhZHMgYXJl IGNsaXBwZWQgd2hlbiBtYWluIHBhZ2UgaXMgc2Nyb2xsZWQgKGJveG9mZmljZW1vam8uY29tKQor CisgICAgICAgICogbWFudWFsLXRlc3RzL3BsdWdpbi1pbi1pZnJhbWUtc2Nyb2xsLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIG1hbnVhbC10ZXN0cy9yZXNvdXJjZXMvcGx1Z2luLWluLWlmcmFtZS1z Y3JvbGwtaWZyYW1lLmh0bWw6IEFkZGVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcldp ZGdldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJXaWRnZXQ6OnNldFdpZGdldEdlb21l dHJ5KTogVGhpcyBtZXRob2QgaXNuJ3QgY2FsbGVkIHdoZW4gYW4gaWZyYW1lIGNvbnRhaW5pbmcK KyAgICAgICAgdGhlIHdpZGdldCBtb3Zlcywgc28gd2Ugc2hvdWxkIHN0b3JlIGEgdmFsdWUgdGhh dCBpcyBub3QgZGVwZW5kZW50IG9uIGN1cnJlbnQgc2Nyb2xsIG9mZnNldC4KKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlcldpZGdldDo6d2luZG93Q2xpcFJlY3QpOiBBcHBseSBzY3JvbGwgb2Zmc2V0 IGFuZCB3aW5kb3cgY2xpcCBub3cuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyV2lkZ2V0 Lmg6IFJlbmFtZWQgbV93aW5kb3dDbGlwUmVjdCB0byBtX2NsaXBSZWN0LCBiZWNhdXNlIGl0IGlz IG5vIGxvbmdlcgorICAgICAgICBpbiB3aW5kb3cgY29vcmRpbmF0ZXMuCisKKyAgICAgICAgKiBX ZWJDb3JlLmJhc2UuZXhwOiBFeHBvcnQgUmVuZGVyV2lkZ2V0Ojp3aW5kb3dDbGlwUmVjdCgpLCBz aW5jZSBpdCdzIG5vIGxvbmdlciBpbmxpbmUuCisKIDIwMTAtMDMtMzEgIEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFudHRpIEtvaXZpc3RvLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5iYXNlLmV4cAkocmV2aXNpb24gNTY3OTQpCisrKyBXZWJD b3JlL1dlYkNvcmUuYmFzZS5leHAJKHdvcmtpbmcgY29weSkKQEAgLTgzNyw2ICs4MzcsNyBAQCBf X1pOSzdXZWJDb3JlMTJJY29uRGF0YWJhc2UyNHNob3VsZFN0b3BUCiBfX1pOSzdXZWJDb3JlMTJJ Y29uRGF0YWJhc2U5aXNFbmFibGVkRXYKIF9fWk5LN1dlYkNvcmUxMlJlbmRlck9iamVjdDE0ZW5j bG9zaW5nTGF5ZXJFdgogX19aTks3V2ViQ29yZTEyUmVuZGVyT2JqZWN0MTVsb2NhbFRvQWJzb2x1 dGVFTlNfMTBGbG9hdFBvaW50RWJiCitfX1pOSzdXZWJDb3JlMTJSZW5kZXJXaWRnZXQxNHdpbmRv d0NsaXBSZWN0RXYKIF9fWk5LN1dlYkNvcmUxMlNoYXJlZEJ1ZmZlcjRkYXRhRXYKIF9fWk5LN1dl YkNvcmUxMlNoYXJlZEJ1ZmZlcjRzaXplRXYKIF9fWk5LN1dlYkNvcmUxMlRleHRFbmNvZGluZzZk ZWNvZGVFUEtjbWJSYgpJbmRleDogV2ViQ29yZS9tYW51YWwtdGVzdHMvcGx1Z2luLWluLWlmcmFt ZS1zY3JvbGwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9wbHVnaW4t aW4taWZyYW1lLXNjcm9sbC5odG1sCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVz dHMvcGx1Z2luLWluLWlmcmFtZS1zY3JvbGwuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3 IEBACis8cD5UaGlzIHRlc3QgcmVxdWlyZXMgdGhhdCBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBi ZSBkaXNhYmxlZC4gUGxlYXNlIHNjcm9sbCBkb3duIHRvIHRoZSBib3R0b20uPC9wPgorPHA+Qm90 aCBzcXVhcmVzIHNob3VsZCBiZSBvcmFuZ2UsIHdpdGggbm8gcmVkIHZpc2libGUgYXQgYW55IHRp bWUuPC9wPgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9wbHVnaW4taW4taWZyYW1lLXNjcm9sbC1p ZnJhbWUuaHRtbCIgd2lkdGg9IjMwMCIgaGVpZ2h0PSIzMDAiIG1hcmdpbndpZHRoPSIwIiBtYXJn aW5oZWlnaHQ9IjAiIGZyYW1lYm9yZGVyPSIwIiBzY3JvbGxpbmc9Im5vIiBzdHlsZT0iYm9yZGVy OjFweCI+PC9pZnJhbWU+CisKKzxkaXYgc3R5bGU9ImhlaWdodDoxMDAwcHgiPiZuYnNwOzwvZGl2 PgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9wbHVnaW4taW4taWZyYW1lLXNjcm9sbC1pZnJhbWUu aHRtbCIgd2lkdGg9IjMwMCIgaGVpZ2h0PSIzMDAiIG1hcmdpbndpZHRoPSIwIiBtYXJnaW5oZWln aHQ9IjAiIGZyYW1lYm9yZGVyPSIwIiBzY3JvbGxpbmc9Im5vIiBzdHlsZT0iYm9yZGVyOjFweCI+ PC9pZnJhbWU+Cis8ZGl2IHN0eWxlPSJoZWlnaHQ6MTAwMHB4Ij4mbmJzcDs8L2Rpdj4KSW5kZXg6 IFdlYkNvcmUvbWFudWFsLXRlc3RzL3Jlc291cmNlcy9wbHVnaW4taW4taWZyYW1lLXNjcm9sbC1p ZnJhbWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9yZXNvdXJjZXMv cGx1Z2luLWluLWlmcmFtZS1zY3JvbGwtaWZyYW1lLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJD b3JlL21hbnVhbC10ZXN0cy9yZXNvdXJjZXMvcGx1Z2luLWluLWlmcmFtZS1zY3JvbGwtaWZyYW1l Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorPG9iamVjdCB0eXBlPSJ2aWRlby9x dWlja3RpbWUiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7IHdpZHRoOiAyOThweDsgaGVp Z2h0OiAyOThweDsgYm9yZGVyOnNvbGlkIDFweCI+CisgICAgPHBhcmFtIG5hbWU9InNyYyIgdmFs dWU9Im9yYW5nZS5tb3YiPgorICAgIDxwYXJhbSBuYW1lPSJjb250cm9sbGVyIiB2YWx1ZT0iZmFs c2UiPgorICAgIDxwYXJhbSBuYW1lPSJhdXRvcGxheSIgdmFsdWU9ImZhbHNlIj4KKyAgICA8cGFy YW0gbmFtZT0ic2NhbGUiIHZhbHVlPSJ0b2ZpdCI+Cis8L29iamVjdD4KSW5kZXg6IFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyV2lkZ2V0LmNwcAkocmV2aXNpb24gNTY3OTQpCisrKyBXZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJXaWRnZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAq IENvcHlyaWdodCAoQykgMTk5OSBMYXJzIEtub2xsIChrbm9sbEBrZGUub3JnKQogICogQ29weXJp Z2h0IChDKSAyMDAwIERpcmsgTXVlbGxlciAobXVlbGxlckBrZGUub3JnKQotICogQ29weXJpZ2h0 IChDKSAyMDA0LCAyMDA2LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAwNCwgMjAwNiwgMjAwOSwgMjAxMCBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBj YW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBv ZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTI1LDYgKzI1LDcgQEAKIAogI2lu Y2x1ZGUgIkFYT2JqZWN0Q2FjaGUuaCIKICNpbmNsdWRlICJBbmltYXRpb25Db250cm9sbGVyLmgi CisjaW5jbHVkZSAiQ1N0cmluZy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2lu Y2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJSZW5kZXJWaWV3LmgiCkBAIC0xNTQs MTQgKzE1NSwxNCBAQCBib29sIFJlbmRlcldpZGdldDo6c2V0V2lkZ2V0R2VvbWV0cnkoY29uCiAg ICAgaWYgKCFub2RlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIEludFJlY3Qgd2lu ZG93Q2xpcFJlY3QgPSBtX2ZyYW1lVmlldyA/IG1fZnJhbWVWaWV3LT53aW5kb3dDbGlwUmVjdEZv ckxheWVyKGVuY2xvc2luZ0xheWVyKCksIHRydWUpIDogSW50UmVjdCgpOwotICAgIGJvb2wgY2xp cENoYW5nZWQgPSBtX3dpbmRvd0NsaXBSZWN0ICE9IHdpbmRvd0NsaXBSZWN0OworICAgIEludFJl Y3QgY2xpcFJlY3QgPSBlbmNsb3NpbmdMYXllcigpLT5jaGlsZHJlbkNsaXBSZWN0KCk7CisgICAg Ym9vbCBjbGlwQ2hhbmdlZCA9IG1fY2xpcFJlY3QgIT0gY2xpcFJlY3Q7CiAgICAgYm9vbCBib3Vu ZHNDaGFuZ2VkID0gbV93aWRnZXQtPmZyYW1lUmVjdCgpICE9IGZyYW1lOwogCiAgICAgaWYgKCFi b3VuZHNDaGFuZ2VkICYmICFjbGlwQ2hhbmdlZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0g ICAgbV93aW5kb3dDbGlwUmVjdCA9IHdpbmRvd0NsaXBSZWN0OworICAgIG1fY2xpcFJlY3QgPSBj bGlwUmVjdDsKIAogICAgIFJlbmRlcldpZGdldFByb3RlY3RvciBwcm90ZWN0b3IodGhpcyk7CiAg ICAgUmVmUHRyPE5vZGU+IHByb3RlY3RlZE5vZGUobm9kZSgpKTsKQEAgLTM0MSw2ICszNDIsMTQg QEAgdm9pZCBSZW5kZXJXaWRnZXQ6OndpZGdldFBvc2l0aW9uc1VwZGF0ZQogICAgIG1fd2lkZ2V0 LT53aWRnZXRQb3NpdGlvbnNVcGRhdGVkKCk7CiB9CiAKK0ludFJlY3QgUmVuZGVyV2lkZ2V0Ojp3 aW5kb3dDbGlwUmVjdCgpIGNvbnN0Cit7CisgICAgaWYgKCFtX2ZyYW1lVmlldykKKyAgICAgICAg cmV0dXJuIEludFJlY3QoKTsKKworICAgIHJldHVybiBpbnRlcnNlY3Rpb24obV9mcmFtZVZpZXct PmNvbnRlbnRzVG9XaW5kb3cobV9jbGlwUmVjdCksIG1fZnJhbWVWaWV3LT53aW5kb3dDbGlwUmVj dCgpKTsKK30KKwogdm9pZCBSZW5kZXJXaWRnZXQ6OnNldFNlbGVjdGlvblN0YXRlKFNlbGVjdGlv blN0YXRlIHN0YXRlKQogewogICAgIGlmIChzZWxlY3Rpb25TdGF0ZSgpICE9IHN0YXRlKSB7Cklu ZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuaAkocmV2aXNpb24gNTY3OTQpCisrKyBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDYgQEAK IC8qCiAgKiBDb3B5cmlnaHQgKEMpIDE5OTkgTGFycyBLbm9sbCAoa25vbGxAa2RlLm9yZykKLSAq IENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIwMDYsIDIwMDksIDIw MTAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRoaXMgbGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlm eSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBA IC00MCw3ICs0MCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgdXBkYXRlV2lkZ2V0UG9zaXRpb24o KTsKICAgICB2b2lkIHdpZGdldFBvc2l0aW9uc1VwZGF0ZWQoKTsKLSAgICBJbnRSZWN0IHdpbmRv d0NsaXBSZWN0KCkgY29uc3QgeyByZXR1cm4gbV93aW5kb3dDbGlwUmVjdDsgfQorICAgIEludFJl Y3Qgd2luZG93Q2xpcFJlY3QoKSBjb25zdDsKIAogICAgIHZvaWQgc2hvd1N1YnN0aXR1dGVJbWFn ZShQYXNzUmVmUHRyPEltYWdlPik7CiAKQEAgLTc0LDcgKzc0LDcgQEAgcHJpdmF0ZToKICAgICBS ZWZQdHI8V2lkZ2V0PiBtX3dpZGdldDsKICAgICBSZWZQdHI8SW1hZ2U+IG1fc3Vic3RpdHV0ZUlt YWdlOwogICAgIEZyYW1lVmlldyogbV9mcmFtZVZpZXc7Ci0gICAgSW50UmVjdCBtX3dpbmRvd0Ns aXBSZWN0OworICAgIEludFJlY3QgbV9jbGlwUmVjdDsgLy8gVGhlIHJlY3RhbmdsZSBuZWVkcyB0 byByZW1haW4gY29ycmVjdCBhZnRlciBzY3JvbGxpbmcsIHNvIHN0b3JpbmcgaXQgaW4gZnJhbWUg dmlldyBjb29yZGluYXRlcywgYW5kIG5vdCBjbGlwcGVkIHRvIHdpbmRvdy4KICAgICBpbnQgbV9y ZWZDb3VudDsKIH07CiAK