36887 2010-03-31 08:52:18 -0700 [chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths 2010-03-31 12:20:04 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd abarth oldest_to_newest 206531 0 fishd 2010-03-31 08:52:18 -0700 [chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths This is what WebCore.gyp does, and since I'm working to remove direct usage of WebCore.gyp in the Chromium repository, it would be good to do the same for WebKit.gyp. That way consumers of the WebKit API do not all have to manually include Skia and NPAPI settings. 206532 1 52175 fishd 2010-03-31 08:54:37 -0700 Created attachment 52175 v1 patch 206584 2 fishd 2010-03-31 11:01:12 -0700 Landed as http://trac.webkit.org/changeset/56853 206633 3 abarth 2010-03-31 12:18:18 -0700 http://trac.webkit.org/changeset/56853 appears to have broken Leopard Intel Debug (Tests) 206637 4 fishd 2010-03-31 12:20:04 -0700 (In reply to comment #3) > http://trac.webkit.org/changeset/56853 appears to have broken Leopard Intel > Debug (Tests) That must be unrelated since this was purely a GYP change. 52175 2010-03-31 08:54:37 -0700 2010-03-31 10:40:14 -0700 v1 patch gyp_1.txt text/plain 1366 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1Njg0MSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0zMSAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gaW5jbHVkaW5nIFdlYktpdC5neXA6 d2Via2l0IHNob3VsZCBhdXRvbWF0aWNhbGx5IGFkZCBTa2lhCisgICAgICAgIGFuZCBOUEFQSSBp bmNsdWRlIHBhdGhzCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2ODg3CisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorCiAyMDEwLTAzLTMxICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cA0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCShyZXZpc2lvbiA1Njg0MSkKKysr IFdlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSwx MiBAQAogICAgICAgICAgICAgJ21zdnNfZ3VpZCc6ICc1RUNFQzlFNS04RjIzLTQ3QjYtOTNFMC1D M0IzMjhCM0JFNjUnLAogICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgICAg ICAgICAnLi4vLi4vV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDp3ZWJjb3JlJywKKyAg ICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9za2lhL3NraWEuZ3lwOnNraWEnLAor ICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L25wYXBpL25w YXBpLmd5cDpucGFwaScsCisgICAgICAgICAgICBdLAorICAgICAgICAgICAgJ2V4cG9ydF9kZXBl bmRlbnRfc2V0dGluZ3MnOiBbCisgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikv c2tpYS9za2lhLmd5cDpza2lhJywKKyAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGly KS90aGlyZF9wYXJ0eS9ucGFwaS9ucGFwaS5neXA6bnBhcGknLAogICAgICAgICAgICAgXSwKICAg ICAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCiAgICAgICAgICAgICAgICAgJ3B1YmxpYycsCg==