36886 2010-03-31 08:19:09 -0700 test-webkitpy: Have the logtesting tearDown() method check that the array of log messages is empty 2010-03-31 21:52:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek cjerdonek hamaji oldest_to_newest 206520 0 cjerdonek 2010-03-31 08:19:09 -0700 If we make the LogTesting class's tearDown() method assert that the array of log messages is empty, we'll get more mileage out of our unit tests that test log messages -- and with less code. 206533 1 52176 cjerdonek 2010-03-31 08:56:45 -0700 Created attachment 52176 Proposed patch 206944 2 52176 cjerdonek 2010-03-31 21:38:14 -0700 Comment on attachment 52176 Proposed patch cq- to commit manually 206950 3 cjerdonek 2010-03-31 21:52:37 -0700 Committed: http://trac.webkit.org/changeset/56894 52176 2010-03-31 08:56:45 -0700 2010-03-31 21:38:14 -0700 Proposed patch _patch-36886-1.diff text/plain 3340 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjNDQ1ZTIyLi5lNTA1Yzk1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDMt MzEgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHdlYWsgd2Via2l0cHkncyBsb2d0 ZXN0aW5nLkxvZ1Rlc3RpbmcgY2xhc3MgdG8gZ2V0IG1vcmUgbWlsZWFnZSBvdXQKKyAgICAgICAg b2Ygb3VyIHVuaXQgdGVzdHMgdGhhdCB0ZXN0IGxvZyBtZXNzYWdlcy4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4ODYKKworICAgICAgICBUaGlz IHBhdGNoIGFkZHMgdG8gdGhlIExvZ1Rlc3RpbmcgY2xhc3MncyB0ZWFyRG93bigpIG1ldGhvZCBh IGxpbmUKKyAgICAgICAgYXNzZXJ0aW5nIHRoYXQgdGhlIGFycmF5IG9mIHJlbWFpbmluZyBsb2cg bWVzc2FnZXMgaXMgZW1wdHkuICBUaGlzCisgICAgICAgIGVuc3VyZXMgdGhhdCBubyBleHRyYSBs b2cgbWVzc2FnZXMgYXJlIGdldHRpbmcgbG9nZ2VkIHRoYXQgdGhlIGNhbGxlcgorICAgICAgICBt aWdodCBub3QgYmUgYXdhcmUgb2Ygb3IgbWF5IGhhdmUgZm9yZ290dGVuIHRvIGNoZWNrIGZvci4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9sb2d0ZXN0aW5nLnB5 OgorICAgICAgICAgIC0gTW9kaWZpZWQgdGhlIHRlYXJEb3duKCkgbWV0aG9kIGFzIGRlc2NyaWJl ZCBhYm92ZS4KKyAgICAgICAgICAtIEFsc28gbW9kaWZpZWQgdGhlIGFzc2VydE1lc3NhZ2VzKCkg bWV0aG9kIHRvIGNsZWFyIHRoZSBhcnJheQorICAgICAgICAgICAgb2YgbG9nIG1lc3NhZ2VzIGFm dGVyIGFzc2VydGluZy4KKwogMjAxMC0wMy0zMSAgRGllZ28gR29uemFsZXogIDxkaWVnby5nb256 YWxlekBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2xvZ3Rlc3RpbmcucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vbG9ndGVzdGluZy5weQppbmRleCA0ZDlkNGY3Li5lZmU5NWZlIDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vbG9ndGVz dGluZy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v bG9ndGVzdGluZy5weQpAQCAtMTYwLDIwICsxNjAsMzYgQEAgY2xhc3MgTG9nVGVzdGluZyhvYmpl Y3QpOgogICAgICAgICByZXR1cm4gTG9nVGVzdGluZyhzdHJlYW0sIGhhbmRsZXIpCiAKICAgICBk ZWYgdGVhckRvd24oc2VsZik6Ci0gICAgICAgICIiIlJlc3RvcmUgbG9nZ2luZyB0byBpdHMgb3Jp Z2luYWwgc3RhdGUuCisgICAgICAgICIiIkFzc2VydCB0aGVyZSBhcmUgbm8gcmVtYWluaW5nIGxv ZyBtZXNzYWdlcywgYW5kIHJlc2V0IGxvZ2dpbmcuCiAKLSAgICAgICAgVGhpcyBzaG91bGQgbm9y bWFsbHkgYmUgY2FsbGVkIGluIHRoZSB0ZWFyRG93bigpIG1ldGhvZCBvZiBhCi0gICAgICAgIHVu aXR0ZXN0LlRlc3RDYXNlLiAgU2VlIHRoZSBkb2NzdHJpbmcgb2YgdGhpcyBjbGFzcyBmb3IgbW9y ZQotICAgICAgICBkZXRhaWxzLgorICAgICAgICBUaGlzIG1ldGhvZCBhc3NlcnRzIHRoYXQgdGhl cmUgYXJlIG5vIG1vcmUgbWVzc2FnZXMgaW4gdGhlIGFycmF5IG9mCisgICAgICAgIGxvZyBtZXNz YWdlcywgYW5kIHRoZW4gcmVzdG9yZXMgbG9nZ2luZyB0byBpdHMgb3JpZ2luYWwgc3RhdGUuCisg ICAgICAgIFRoaXMgbWV0aG9kIHNob3VsZCBub3JtYWxseSBiZSBjYWxsZWQgaW4gdGhlIHRlYXJE b3duKCkgbWV0aG9kIG9mIGEKKyAgICAgICAgdW5pdHRlc3QuVGVzdENhc2UuICBTZWUgdGhlIGRv Y3N0cmluZyBvZiB0aGlzIGNsYXNzIGZvciBtb3JlIGRldGFpbHMuCiAKICAgICAgICAgIiIiCisg ICAgICAgIHNlbGYuYXNzZXJ0TWVzc2FnZXMoW10pCiAgICAgICAgIGxvZ2dlciA9IExvZ1Rlc3Rp bmcuX2dldExvZ2dlcigpCiAgICAgICAgIGxvZ2dlci5yZW1vdmVIYW5kbGVyKHNlbGYuX2hhbmRs ZXIpCiAKKyAgICAjIEZJWE1FOiBBZGQgYSBjbGVhck1lc3NhZ2VzKCkgbWV0aG9kIGZvciBjYXNl cyB3aGVyZSB0aGUgY2FsbGVyCisgICAgIyAgICAgICAgZGVsaWJlcmF0ZWx5IGRvZXNuJ3Qgd2Fu dCB0byBhc3NlcnQgZXZlcnkgbWVzc2FnZS4KKworICAgICMgV2UgY2xlYXIgdGhlIGxvZyBtZXNz YWdlcyBhZnRlciBhc3NlcnRpbmcgc2luY2UgdGhleSBhcmUgbm8gbG9uZ2VyCisgICAgIyBuZWVk ZWQgYWZ0ZXIgYXNzZXJ0aW5nLiAgVGhpcyBzZXJ2ZXMgdHdvIHB1cnBvc2VzOiAoMSkgaXQgc2lt cGxpZmllcworICAgICMgdGhlIGNhbGxpbmcgY29kZSB3aGVuIHdlIHdhbnQgdG8gY2hlY2sgbXVs dGlwbGUgbG9nZ2luZyBjYWxscyBpbiBhCisgICAgIyBzaW5nbGUgdGVzdCBtZXRob2QsIGFuZCAo MikgaXQgbGV0cyB1cyBjaGVjayBpbiB0aGUgdGVhckRvd24oKSBtZXRob2QKKyAgICAjIHRoYXQg dGhlcmUgYXJlIG5vIHJlbWFpbmluZyBsb2cgbWVzc2FnZXMgdG8gYmUgYXNzZXJ0ZWQuCisgICAg IworICAgICMgVGhlIGxhdHRlciBlbnN1cmVzIHRoYXQgbm8gZXh0cmEgbG9nIG1lc3NhZ2VzIGFy ZSBnZXR0aW5nIGxvZ2dlZCB0aGF0CisgICAgIyB0aGUgY2FsbGVyIG1pZ2h0IG5vdCBiZSBhd2Fy ZSBvZiBvciBtYXkgaGF2ZSBmb3Jnb3R0ZW4gdG8gY2hlY2sgZm9yLgorICAgICMgVGhpcyBnZXRz IHVzIGEgYml0IG1vcmUgbWlsZWFnZSBvdXQgb2Ygb3VyIHRlc3RzIHdpdGhvdXQgd3JpdGluZyBh bnkKKyAgICAjIGFkZGl0aW9uYWwgY29kZS4KICAgICBkZWYgYXNzZXJ0TWVzc2FnZXMoc2VsZiwg bWVzc2FnZXMpOgotICAgICAgICAiIiJBc3NlcnQgdGhhdCB0aGUgZ2l2ZW4gbWVzc2FnZXMgbWF0 Y2ggdGhlIGxvZ2dlZCBtZXNzYWdlcy4KKyAgICAgICAgIiIiQXNzZXJ0IHRoZSBjdXJyZW50IGFy cmF5IG9mIGxvZyBtZXNzYWdlcywgYW5kIGNsZWFyIGl0cyBjb250ZW50cy4KIAogICAgICAgICBt ZXNzYWdlczogQSBsaXN0IG9mIGxvZyBtZXNzYWdlIHN0cmluZ3MuCiAKICAgICAgICAgIiIiCiAg ICAgICAgIHNlbGYuX3Rlc3Rfc3RyZWFtLmFzc2VydE1lc3NhZ2VzKG1lc3NhZ2VzKQorICAgICAg ICBzZWxmLl90ZXN0X3N0cmVhbS5tZXNzYWdlcyA9IFtdCg==