36885 2010-03-31 07:52:29 -0700 Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell 2010-03-31 09:01:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 206504 0 apavlov 2010-03-31 07:52:29 -0700 Chromium test shell crashes on inspector/audits-panel-functional.html (which works fine during pure WebKit test runs). 206509 1 52167 apavlov 2010-03-31 08:00:53 -0700 Created attachment 52167 [PATCH] Suggested solution 206518 2 52167 pfeldman 2010-03-31 08:15:30 -0700 Comment on attachment 52167 [PATCH] Suggested solution > + setTimeout(function() {evaluateInWebInspector("frontend_runAudits", callback)}, 0); > } This is a hack. > + testController.waitUntilDone(); Every wait should have notify. To fix your problem, do not call layoutTestController's notifyDone upon first return from the front-end. 206521 3 52171 apavlov 2010-03-31 08:20:51 -0700 Created attachment 52171 [PATCH] Comments addressed 206525 4 52173 apavlov 2010-03-31 08:29:26 -0700 Created attachment 52173 [PATCH] CRASH expectation removed 206536 5 52173 commit-queue 2010-03-31 09:01:43 -0700 Comment on attachment 52173 [PATCH] CRASH expectation removed Clearing flags on attachment: 52173 Committed r56843: <http://trac.webkit.org/changeset/56843> 206537 6 commit-queue 2010-03-31 09:01:48 -0700 All reviewed patches have been landed. Closing bug. 52167 2010-03-31 08:00:53 -0700 2010-03-31 08:20:51 -0700 [PATCH] Suggested solution crashfix.patch text/plain 2084 apavlov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyZjc0NjlhLi44NDE0NzU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMt MzEgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hy b21pdW1dIGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rpb25hbC5odG1sIGNyYXNoZXMgdGVz dF9zaGVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzY4ODUKKworICAgICAgICAqIGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rpb25hbC5odG1s OgorCiAyMDEwLTAzLTMxICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2F1ZGl0cy1wYW5lbC1mdW5jdGlvbmFsLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv YXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwuaHRtbAppbmRleCBmNmUzNjA4Li5iMjI2ZDFhIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwuaHRt bApAQCAtMjMsNyArMjMsNyBAQCBmdW5jdGlvbiBkb2l0KCkKICAgICAgICAgb3V0cHV0LnRleHRD b250ZW50ID0gcmVzdWx0OwogICAgICAgICBub3RpZnlEb25lKCk7CiAgICAgfQotICAgIGV2YWx1 YXRlSW5XZWJJbnNwZWN0b3IoImZyb250ZW5kX3J1bkF1ZGl0cyIsIGNhbGxiYWNrKTsKKyAgICBz ZXRUaW1lb3V0KGZ1bmN0aW9uKCkge2V2YWx1YXRlSW5XZWJJbnNwZWN0b3IoImZyb250ZW5kX3J1 bkF1ZGl0cyIsIGNhbGxiYWNrKX0sIDApOwogfQogCiAKQEAgLTMxLDEzICszMSwxMiBAQCBmdW5j dGlvbiBkb2l0KCkKIAogZnVuY3Rpb24gZnJvbnRlbmRfcnVuQXVkaXRzKHRlc3RDb250cm9sbGVy KQogeworICAgIHRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKICAgICBpZiAoIVdlYklu c3BlY3Rvci5wYW5lbHMucmVzb3VyY2VzLnJlc291cmNlVHJhY2tpbmdFbmFibGVkKSB7CiAgICAg ICAgIEluc3BlY3RvckJhY2tlbmQuZW5hYmxlUmVzb3VyY2VUcmFja2luZyhmYWxzZSk7Ci0gICAg ICAgIHRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoW10pOwogICAgICAgICByZXR1cm47CiAgICAg fQogCi0gICAgdGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogICAgIFdlYkluc3BlY3Rv ci5BdWRpdFJ1bGVSZXN1bHQucmVzb3VyY2VEb21haW4gPSBmdW5jdGlvbigpIHsKICAgICAgICAg cmV0dXJuICJbZG9tYWluXSI7CiAgICAgfTsKQEAgLTU3LDcgKzU2LDcgQEAgZnVuY3Rpb24gZnJv bnRlbmRfcnVuQXVkaXRzKHRlc3RDb250cm9sbGVyKQogICAgICAgICAgICAgfQogICAgICAgICAg ICAgdmFyIG91dHB1dCA9IFtdOwogICAgICAgICAgICAgZnJvbnRlbmRfY29sbGVjdFRleHRDb250 ZW50KFdlYkluc3BlY3Rvci5wYW5lbHMuYXVkaXRzLnZpc2libGVWaWV3LmVsZW1lbnQsIDAsIG91 dHB1dCk7Ci0gICAgICAgICAgICAvLyBBdm9pZCBpbmZsdWVuY2luZyB0ZXN0cyB0aGF0IHJlcXVp cmVkIHJlc291cmNlIHRyYWNraW5nIHRvIGJlIGRpc2FibGVkLgorICAgICAgICAgICAgLy8gQXZv aWQgaW5mbHVlbmNpbmcgdGVzdHMgdGhhdCByZXF1aXJlIHJlc291cmNlIHRyYWNraW5nIHRvIGJl IGRpc2FibGVkLgogICAgICAgICAgICAgSW5zcGVjdG9yQmFja2VuZC5kaXNhYmxlUmVzb3VyY2VU cmFja2luZyhmYWxzZSk7CiAgICAgICAgICAgICB0ZXN0Q29udHJvbGxlci5ydW5BZnRlclBlbmRp bmdEaXNwYXRjaGVzKGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgICAgIHRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUob3V0cHV0LmpvaW4oIlxuIikpOwo= 52171 2010-03-31 08:20:51 -0700 2010-03-31 08:29:26 -0700 [PATCH] Comments addressed crashfix.patch text/plain 1952 apavlov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyZjc0NjlhLi44NDE0NzU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMt MzEgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hy b21pdW1dIGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rpb25hbC5odG1sIGNyYXNoZXMgdGVz dF9zaGVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzY4ODUKKworICAgICAgICAqIGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rpb25hbC5odG1s OgorCiAyMDEwLTAzLTMxICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2F1ZGl0cy1wYW5lbC1mdW5jdGlvbmFsLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv YXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwuaHRtbAppbmRleCBmNmUzNjA4Li5mNDU1ZWI5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwuaHRt bApAQCAtMTksNiArMTksOCBAQCBmdW5jdGlvbiBkb2l0KCkKIHsKICAgICBmdW5jdGlvbiBjYWxs YmFjayhyZXN1bHQpCiAgICAgeworICAgICAgICBpZiAocmVzdWx0ID09PSAicmVmcmVzaGluZyIp CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIHZhciBvdXRwdXQgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgib3V0cHV0UHJlIik7CiAgICAgICAgIG91dHB1dC50ZXh0Q29udGVudCA9IHJl c3VsdDsKICAgICAgICAgbm90aWZ5RG9uZSgpOwpAQCAtMzMsOCArMzUsNyBAQCBmdW5jdGlvbiBm cm9udGVuZF9ydW5BdWRpdHModGVzdENvbnRyb2xsZXIpCiB7CiAgICAgaWYgKCFXZWJJbnNwZWN0 b3IucGFuZWxzLnJlc291cmNlcy5yZXNvdXJjZVRyYWNraW5nRW5hYmxlZCkgewogICAgICAgICBJ bnNwZWN0b3JCYWNrZW5kLmVuYWJsZVJlc291cmNlVHJhY2tpbmcoZmFsc2UpOwotICAgICAgICB0 ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKFtdKTsKLSAgICAgICAgcmV0dXJuOworICAgICAgICBy ZXR1cm4gInJlZnJlc2hpbmciOwogICAgIH0KIAogICAgIHRlc3RDb250cm9sbGVyLndhaXRVbnRp bERvbmUoKTsKQEAgLTU3LDcgKzU4LDcgQEAgZnVuY3Rpb24gZnJvbnRlbmRfcnVuQXVkaXRzKHRl c3RDb250cm9sbGVyKQogICAgICAgICAgICAgfQogICAgICAgICAgICAgdmFyIG91dHB1dCA9IFtd OwogICAgICAgICAgICAgZnJvbnRlbmRfY29sbGVjdFRleHRDb250ZW50KFdlYkluc3BlY3Rvci5w YW5lbHMuYXVkaXRzLnZpc2libGVWaWV3LmVsZW1lbnQsIDAsIG91dHB1dCk7Ci0gICAgICAgICAg ICAvLyBBdm9pZCBpbmZsdWVuY2luZyB0ZXN0cyB0aGF0IHJlcXVpcmVkIHJlc291cmNlIHRyYWNr aW5nIHRvIGJlIGRpc2FibGVkLgorICAgICAgICAgICAgLy8gQXZvaWQgaW5mbHVlbmNpbmcgdGVz dHMgdGhhdCByZXF1aXJlIHJlc291cmNlIHRyYWNraW5nIHRvIGJlIGRpc2FibGVkLgogICAgICAg ICAgICAgSW5zcGVjdG9yQmFja2VuZC5kaXNhYmxlUmVzb3VyY2VUcmFja2luZyhmYWxzZSk7CiAg ICAgICAgICAgICB0ZXN0Q29udHJvbGxlci5ydW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKGZ1bmN0 aW9uKCkgewogICAgICAgICAgICAgICAgIHRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUob3V0cHV0 LmpvaW4oIlxuIikpOwo= 52173 2010-03-31 08:29:26 -0700 2010-03-31 09:01:43 -0700 [PATCH] CRASH expectation removed crashfix.patch text/plain 2707 apavlov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyZjc0NjlhLi5jYjIzZTcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MzEgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY3Jhc2gKKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rp b25hbC5odG1sIGNyYXNoZXMgdGVzdF9zaGVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4ODUKKworICAgICAgICAqIGluc3BlY3Rvci9hdWRpdHMt cGFuZWwtZnVuY3Rpb25hbC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0wMy0zMSAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2luc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rpb25hbC5odG1sIGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2F1ZGl0cy1wYW5lbC1mdW5jdGlvbmFsLmh0bWwKaW5kZXggZjZlMzYw OC4uZjQ1NWViOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2F1ZGl0cy1wYW5l bC1mdW5jdGlvbmFsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2F1ZGl0cy1wYW5l bC1mdW5jdGlvbmFsLmh0bWwKQEAgLTE5LDYgKzE5LDggQEAgZnVuY3Rpb24gZG9pdCgpCiB7CiAg ICAgZnVuY3Rpb24gY2FsbGJhY2socmVzdWx0KQogICAgIHsKKyAgICAgICAgaWYgKHJlc3VsdCA9 PT0gInJlZnJlc2hpbmciKQorICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB2YXIgb3V0cHV0 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm91dHB1dFByZSIpOwogICAgICAgICBvdXRwdXQu dGV4dENvbnRlbnQgPSByZXN1bHQ7CiAgICAgICAgIG5vdGlmeURvbmUoKTsKQEAgLTMzLDggKzM1 LDcgQEAgZnVuY3Rpb24gZnJvbnRlbmRfcnVuQXVkaXRzKHRlc3RDb250cm9sbGVyKQogewogICAg IGlmICghV2ViSW5zcGVjdG9yLnBhbmVscy5yZXNvdXJjZXMucmVzb3VyY2VUcmFja2luZ0VuYWJs ZWQpIHsKICAgICAgICAgSW5zcGVjdG9yQmFja2VuZC5lbmFibGVSZXNvdXJjZVRyYWNraW5nKGZh bHNlKTsKLSAgICAgICAgdGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZShbXSk7Ci0gICAgICAgIHJl dHVybjsKKyAgICAgICAgcmV0dXJuICJyZWZyZXNoaW5nIjsKICAgICB9CiAKICAgICB0ZXN0Q29u dHJvbGxlci53YWl0VW50aWxEb25lKCk7CkBAIC01Nyw3ICs1OCw3IEBAIGZ1bmN0aW9uIGZyb250 ZW5kX3J1bkF1ZGl0cyh0ZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IHZhciBvdXRwdXQgPSBbXTsKICAgICAgICAgICAgIGZyb250ZW5kX2NvbGxlY3RUZXh0Q29udGVu dChXZWJJbnNwZWN0b3IucGFuZWxzLmF1ZGl0cy52aXNpYmxlVmlldy5lbGVtZW50LCAwLCBvdXRw dXQpOwotICAgICAgICAgICAgLy8gQXZvaWQgaW5mbHVlbmNpbmcgdGVzdHMgdGhhdCByZXF1aXJl ZCByZXNvdXJjZSB0cmFja2luZyB0byBiZSBkaXNhYmxlZC4KKyAgICAgICAgICAgIC8vIEF2b2lk IGluZmx1ZW5jaW5nIHRlc3RzIHRoYXQgcmVxdWlyZSByZXNvdXJjZSB0cmFja2luZyB0byBiZSBk aXNhYmxlZC4KICAgICAgICAgICAgIEluc3BlY3RvckJhY2tlbmQuZGlzYWJsZVJlc291cmNlVHJh Y2tpbmcoZmFsc2UpOwogICAgICAgICAgICAgdGVzdENvbnRyb2xsZXIucnVuQWZ0ZXJQZW5kaW5n RGlzcGF0Y2hlcyhmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICB0ZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKG91dHB1dC5qb2luKCJcbiIpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCAyZmFlZGZiLi5hOTAyNjY2 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0 aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0CkBAIC0yODEyLDYgKzI4MTIsMyBAQCBCVUdXSzM2ODA3IFdJTiA6IGh0dHAvdGVz dHMvaW5zcGVjdG9yLWVuYWJsZWQvY29uc29sZS1sb2ctYmVmb3JlLWZyYW1lLW5hdmlnYXRpbwog Ly8gQ2F1c2VkIGJ5IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzU2Nzk1CiAvLyBU aGlzIGlzIGEgbmV3IHRlc3QgYnV0IGZhaWxzIGluIENocm9taXVtIGJlY2F1c2Ugb2YgYSBtaXNz aW5nIEFQSS4KIEJVRzM5OTA0IDogc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1wb2ludHMuaHRtbCA9 IFRFWFQgVElNRU9VVAotCi0vLyBDYXVzZWQgYnkgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvNTY3NzkKLUJVRzM5OTI3IFdJTiA6IGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rp b25hbC5odG1sID0gQ1JBU0ggUEFTUyBURVhUCg==