36877 2010-03-31 02:23:10 -0700 Web inspector will only display cookies for (file|http[s]?) resources 2010-03-31 07:45:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 mnissler webkit-unassigned commit-queue jorlow pfeldman oldest_to_newest 206428 0 mnissler 2010-03-31 02:23:10 -0700 Currently, web inspector explicitly filters the resource URLs it will display cookies for to only include file, http and https URLs. Thus, when using the inspector on some other resource (e.g. a chrome extension), it won't display any cookies even if there are some. 206432 1 52146 mnissler 2010-03-31 02:33:02 -0700 Created attachment 52146 Patch 206461 2 52146 pfeldman 2010-03-31 04:55:42 -0700 Comment on attachment 52146 Patch > + this._addCookieDomain(match[2] ? match[2] : ""); > } I think you can simplify it even further due to (match[2] ? match[2] : "") === match[2] 206471 3 52154 mnissler 2010-03-31 06:07:28 -0700 Created attachment 52154 patch 206472 4 mnissler 2010-03-31 06:08:50 -0700 (In reply to comment #2) > I think you can simplify it even further due to > > (match[2] ? match[2] : "") === match[2] Considering that a successful match of the regex always gives us a defined match[2], that's correct. Didn't think of that, thanks.(In reply to comment #2) 206496 5 52154 commit-queue 2010-03-31 07:45:36 -0700 Comment on attachment 52154 patch Clearing flags on attachment: 52154 Committed r56840: <http://trac.webkit.org/changeset/56840> 206497 6 commit-queue 2010-03-31 07:45:41 -0700 All reviewed patches have been landed. Closing bug. 52146 2010-03-31 02:33:02 -0700 2010-03-31 06:07:22 -0700 Patch bug-36877-20100331113300.patch text/plain 3154 mnissler ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmU5NmQ0OS4uOGQ4NTJkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMy0zMSAgTWF0dGlhcyBOaXNz bGVyICA8bW5pc3NsZXJAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBbGxvdyBnZW5lcmljIHJlc291cmNlIFVSTHMgZm9yIGNvb2tp ZSBoYW5kbGluZyBpbiB0aGUgaW5zcGVjdG9yLiBUaGlzCisgICAgICAgIGVuYWJsZXMgZGlzcGxh eSBvZiBhbGwgY29va2llcywgbm90IG9ubHkgdGhvc2UgdGhhdCBhcmUgYXNzb2NpYXRlZAorICAg ICAgICB3aXRoIHJlc291cmNlcyBhY2Nlc3NlZCB0aHJvdWdoIGh0dHAsIGh0dHBzIG9yIGZpbGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjg3Nwor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJdGVtc1ZpZXcuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ29va2llSXRlbXNWaWV3LnByb3RvdHlwZS5fZmlsdGVyQ29va2ll c0ZvckRvbWFpbik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5Db29raWVzLmNvb2tpZU1hdGNoZXNSZXNvdXJjZVVSTCk6 CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IudXBkYXRlUmVzb3VyY2UpOgorCiAyMDEwLTAzLTMwICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBkZWZpbmUg c3RhdGljIHZhcmlhYmxlcyB3aXRoIERFRklORV9TVEFUSUNfTE9DQUwgbWFjcm8KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJdGVtc1ZpZXcuanMgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29va2llSXRlbXNWaWV3LmpzCmluZGV4IGI1Njc0Yjgu LjFiYWY0YTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJ dGVtc1ZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nvb2tpZUl0ZW1z Vmlldy5qcwpAQCAtMTIyLDcgKzEyMiw3IEBAIFdlYkluc3BlY3Rvci5Db29raWVJdGVtc1ZpZXcu cHJvdG90eXBlID0gewogCiAgICAgICAgIGZvciAodmFyIGlkIGluIFdlYkluc3BlY3Rvci5yZXNv dXJjZXMpIHsKICAgICAgICAgICAgIHZhciByZXNvdXJjZSA9IFdlYkluc3BlY3Rvci5yZXNvdXJj ZXNbaWRdOwotICAgICAgICAgICAgdmFyIG1hdGNoID0gcmVzb3VyY2UuZG9jdW1lbnRVUkwubWF0 Y2goV2ViSW5zcGVjdG9yLlVSTFJlZ0V4cCk7CisgICAgICAgICAgICB2YXIgbWF0Y2ggPSByZXNv dXJjZS5kb2N1bWVudFVSTC5tYXRjaChXZWJJbnNwZWN0b3IuR2VuZXJpY1VSTFJlZ0V4cCk7CiAg ICAgICAgICAgICBpZiAobWF0Y2ggJiYgbWF0Y2hbMl0gPT09IHRoaXMuX2Nvb2tpZURvbWFpbikK ICAgICAgICAgICAgICAgICByZXNvdXJjZVVSTHNGb3JEb2N1bWVudFVSTC5wdXNoKHJlc291cmNl LnVybCk7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9ET01BZ2VudC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcwpp bmRleCBlYzhiN2VkLi40NmZmMGJmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRE9NQWdlbnQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFn ZW50LmpzCkBAIC00NTUsNyArNDU1LDcgQEAgV2ViSW5zcGVjdG9yLkNvb2tpZXMuYnVpbGRDb29r aWVzRnJvbVN0cmluZyA9IGZ1bmN0aW9uKHJhd0Nvb2tpZVN0cmluZykKIAogV2ViSW5zcGVjdG9y LkNvb2tpZXMuY29va2llTWF0Y2hlc1Jlc291cmNlVVJMID0gZnVuY3Rpb24oY29va2llLCByZXNv dXJjZVVSTCkKIHsKLSAgICB2YXIgbWF0Y2ggPSByZXNvdXJjZVVSTC5tYXRjaChXZWJJbnNwZWN0 b3IuVVJMUmVnRXhwKTsKKyAgICB2YXIgbWF0Y2ggPSByZXNvdXJjZVVSTC5tYXRjaChXZWJJbnNw ZWN0b3IuR2VuZXJpY1VSTFJlZ0V4cCk7CiAgICAgaWYgKCFtYXRjaCkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIC8vIFNlZSBXZWJJbnNwZWN0b3IuVVJMUmVnRXhwIGZvciBkZWZpbml0aW9u cyBvZiB0aGUgZ3JvdXAgaW5kZXggY29uc3RhbnRzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMKaW5kZXggYWIxNGE1Zi4uZjFiZWNmNiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0xMDk0LDExICsxMDk0LDEwIEBAIFdlYkluc3Bl Y3Rvci51cGRhdGVSZXNvdXJjZSA9IGZ1bmN0aW9uKGlkZW50aWZpZXIsIHBheWxvYWQpCiAgICAg ICAgIGlmIChyZXNvdXJjZS5tYWluUmVzb3VyY2UpCiAgICAgICAgICAgICB0aGlzLm1haW5SZXNv dXJjZSA9IHJlc291cmNlOwogCi0gICAgICAgIHZhciBtYXRjaCA9IHBheWxvYWQuZG9jdW1lbnRV UkwubWF0Y2goV2ViSW5zcGVjdG9yLlVSTFJlZ0V4cCk7CisgICAgICAgIHZhciBtYXRjaCA9IHBh eWxvYWQuZG9jdW1lbnRVUkwubWF0Y2goV2ViSW5zcGVjdG9yLkdlbmVyaWNVUkxSZWdFeHApOwog ICAgICAgICBpZiAobWF0Y2gpIHsKICAgICAgICAgICAgIHZhciBwcm90b2NvbCA9IG1hdGNoWzFd LnRvTG93ZXJDYXNlKCk7Ci0gICAgICAgICAgICBpZiAocHJvdG9jb2wuaW5kZXhPZigiaHR0cCIp ID09PSAwIHx8IHByb3RvY29sID09PSAiZmlsZSIpCi0gICAgICAgICAgICAgICAgdGhpcy5fYWRk Q29va2llRG9tYWluKHByb3RvY29sID09PSAiZmlsZSIgPyAiIiA6IG1hdGNoWzJdKTsKKyAgICAg ICAgICAgIHRoaXMuX2FkZENvb2tpZURvbWFpbihtYXRjaFsyXSA/IG1hdGNoWzJdIDogIiIpOwog ICAgICAgICB9CiAgICAgfQogCg== 52154 2010-03-31 06:07:28 -0700 2010-03-31 07:45:36 -0700 patch bug-36877-20100331150726.patch text/plain 3138 mnissler ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmU5NmQ0OS4uOGQ4NTJkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMy0zMSAgTWF0dGlhcyBOaXNz bGVyICA8bW5pc3NsZXJAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBbGxvdyBnZW5lcmljIHJlc291cmNlIFVSTHMgZm9yIGNvb2tp ZSBoYW5kbGluZyBpbiB0aGUgaW5zcGVjdG9yLiBUaGlzCisgICAgICAgIGVuYWJsZXMgZGlzcGxh eSBvZiBhbGwgY29va2llcywgbm90IG9ubHkgdGhvc2UgdGhhdCBhcmUgYXNzb2NpYXRlZAorICAg ICAgICB3aXRoIHJlc291cmNlcyBhY2Nlc3NlZCB0aHJvdWdoIGh0dHAsIGh0dHBzIG9yIGZpbGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjg3Nwor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJdGVtc1ZpZXcuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ29va2llSXRlbXNWaWV3LnByb3RvdHlwZS5fZmlsdGVyQ29va2ll c0ZvckRvbWFpbik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5Db29raWVzLmNvb2tpZU1hdGNoZXNSZXNvdXJjZVVSTCk6 CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IudXBkYXRlUmVzb3VyY2UpOgorCiAyMDEwLTAzLTMwICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBkZWZpbmUg c3RhdGljIHZhcmlhYmxlcyB3aXRoIERFRklORV9TVEFUSUNfTE9DQUwgbWFjcm8KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJdGVtc1ZpZXcuanMgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29va2llSXRlbXNWaWV3LmpzCmluZGV4IGI1Njc0Yjgu LjFiYWY0YTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJ dGVtc1ZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nvb2tpZUl0ZW1z Vmlldy5qcwpAQCAtMTIyLDcgKzEyMiw3IEBAIFdlYkluc3BlY3Rvci5Db29raWVJdGVtc1ZpZXcu cHJvdG90eXBlID0gewogCiAgICAgICAgIGZvciAodmFyIGlkIGluIFdlYkluc3BlY3Rvci5yZXNv dXJjZXMpIHsKICAgICAgICAgICAgIHZhciByZXNvdXJjZSA9IFdlYkluc3BlY3Rvci5yZXNvdXJj ZXNbaWRdOwotICAgICAgICAgICAgdmFyIG1hdGNoID0gcmVzb3VyY2UuZG9jdW1lbnRVUkwubWF0 Y2goV2ViSW5zcGVjdG9yLlVSTFJlZ0V4cCk7CisgICAgICAgICAgICB2YXIgbWF0Y2ggPSByZXNv dXJjZS5kb2N1bWVudFVSTC5tYXRjaChXZWJJbnNwZWN0b3IuR2VuZXJpY1VSTFJlZ0V4cCk7CiAg ICAgICAgICAgICBpZiAobWF0Y2ggJiYgbWF0Y2hbMl0gPT09IHRoaXMuX2Nvb2tpZURvbWFpbikK ICAgICAgICAgICAgICAgICByZXNvdXJjZVVSTHNGb3JEb2N1bWVudFVSTC5wdXNoKHJlc291cmNl LnVybCk7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9ET01BZ2VudC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcwpp bmRleCBlYzhiN2VkLi40NmZmMGJmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRE9NQWdlbnQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFn ZW50LmpzCkBAIC00NTUsNyArNDU1LDcgQEAgV2ViSW5zcGVjdG9yLkNvb2tpZXMuYnVpbGRDb29r aWVzRnJvbVN0cmluZyA9IGZ1bmN0aW9uKHJhd0Nvb2tpZVN0cmluZykKIAogV2ViSW5zcGVjdG9y LkNvb2tpZXMuY29va2llTWF0Y2hlc1Jlc291cmNlVVJMID0gZnVuY3Rpb24oY29va2llLCByZXNv dXJjZVVSTCkKIHsKLSAgICB2YXIgbWF0Y2ggPSByZXNvdXJjZVVSTC5tYXRjaChXZWJJbnNwZWN0 b3IuVVJMUmVnRXhwKTsKKyAgICB2YXIgbWF0Y2ggPSByZXNvdXJjZVVSTC5tYXRjaChXZWJJbnNw ZWN0b3IuR2VuZXJpY1VSTFJlZ0V4cCk7CiAgICAgaWYgKCFtYXRjaCkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIC8vIFNlZSBXZWJJbnNwZWN0b3IuVVJMUmVnRXhwIGZvciBkZWZpbml0aW9u cyBvZiB0aGUgZ3JvdXAgaW5kZXggY29uc3RhbnRzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMKaW5kZXggYWIxNGE1Zi4uMzU5ZGEzZSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0xMDk0LDExICsxMDk0LDEwIEBAIFdlYkluc3Bl Y3Rvci51cGRhdGVSZXNvdXJjZSA9IGZ1bmN0aW9uKGlkZW50aWZpZXIsIHBheWxvYWQpCiAgICAg ICAgIGlmIChyZXNvdXJjZS5tYWluUmVzb3VyY2UpCiAgICAgICAgICAgICB0aGlzLm1haW5SZXNv dXJjZSA9IHJlc291cmNlOwogCi0gICAgICAgIHZhciBtYXRjaCA9IHBheWxvYWQuZG9jdW1lbnRV UkwubWF0Y2goV2ViSW5zcGVjdG9yLlVSTFJlZ0V4cCk7CisgICAgICAgIHZhciBtYXRjaCA9IHBh eWxvYWQuZG9jdW1lbnRVUkwubWF0Y2goV2ViSW5zcGVjdG9yLkdlbmVyaWNVUkxSZWdFeHApOwog ICAgICAgICBpZiAobWF0Y2gpIHsKICAgICAgICAgICAgIHZhciBwcm90b2NvbCA9IG1hdGNoWzFd LnRvTG93ZXJDYXNlKCk7Ci0gICAgICAgICAgICBpZiAocHJvdG9jb2wuaW5kZXhPZigiaHR0cCIp ID09PSAwIHx8IHByb3RvY29sID09PSAiZmlsZSIpCi0gICAgICAgICAgICAgICAgdGhpcy5fYWRk Q29va2llRG9tYWluKHByb3RvY29sID09PSAiZmlsZSIgPyAiIiA6IG1hdGNoWzJdKTsKKyAgICAg ICAgICAgIHRoaXMuX2FkZENvb2tpZURvbWFpbihtYXRjaFsyXSk7CiAgICAgICAgIH0KICAgICB9 CiAK