36875 2010-03-31 01:35:42 -0700 Add a Builder.force_build method 2010-03-31 19:36:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric oldest_to_newest 206409 0 abarth 2010-03-31 01:35:42 -0700 Add a Builder.force_build method 206410 1 52141 abarth 2010-03-31 01:36:35 -0700 Created attachment 52141 Patch 206606 2 52141 eric 2010-03-31 11:27:14 -0700 Comment on attachment 52141 Patch We should probably require more arguments in the force_build method. Like reason. And allow an optional revision. But this is better than what we have now. :) 206711 3 52141 commit-queue 2010-03-31 13:57:52 -0700 Comment on attachment 52141 Patch Clearing flags on attachment: 52141 Committed r56866: <http://trac.webkit.org/changeset/56866> 206712 4 commit-queue 2010-03-31 13:57:56 -0700 All reviewed patches have been landed. Closing bug. 52141 2010-03-31 01:36:35 -0700 2010-03-31 13:57:52 -0700 Patch bug-36875-20100331013633.patch text/plain 2377 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1M2ExYmQ0Li5jMGQ1OGE0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MzEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBCdWlsZGVyLmZvcmNlX2J1aWxkIG1l dGhvZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4 NzUKKworICAgICAgICBXZSBwbGFuIHRvIGV2ZW50dWFsbHkgdXNlIHRoaXMgaW4gU2hlcmlmZkJv dCB0byBicmVhayBkZWFkbG9ja3MgY3JlYXRlZAorICAgICAgICBieSBmbGFreSB0ZXN0cy4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC5weToKKwogMjAx MC0wMy0zMSAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgdGVzdCBmaXggZm9yIHI1NjgwOS4KZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC5weQppbmRleCAwMzgyNTE5Li4w ZDU4NDdmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVpbGRib3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v bmV0L2J1aWxkYm90LnB5CkBAIC0zNyw2ICszNyw3IEBAIGltcG9ydCB4bWxycGNsaWIKICMgSW1w b3J0IFdlYktpdC1zcGVjaWZpYyBtb2R1bGVzLgogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVt LmRlcHJlY2F0ZWRfbG9nZ2luZyBpbXBvcnQgbG9nCiAKK2Zyb20gd2Via2l0cHkudGhpcmRwYXJ0 eS5hdXRvaW5zdGFsbGVkIGltcG9ydCBCcm93c2VyCiAjIFdlYktpdCBpbmNsdWRlcyBhIGJ1aWx0 IGNvcHkgb2YgQmVhdXRpZnVsU291cCBpbiBTY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkKICMg c28gdGhpcyBpbXBvcnQgc2hvdWxkIGFsd2F5cyBzdWNjZWVkLgogZnJvbSB3ZWJraXRweS50aGly ZHBhcnR5LkJlYXV0aWZ1bFNvdXAgaW1wb3J0IEJlYXV0aWZ1bFNvdXAKQEAgLTQ4LDYgKzQ5LDgg QEAgY2xhc3MgQnVpbGRlcihvYmplY3QpOgogICAgICAgICBzZWxmLl9idWlsZGJvdCA9IGJ1aWxk Ym90CiAgICAgICAgIHNlbGYuX2J1aWxkc19jYWNoZSA9IHt9CiAgICAgICAgIHNlbGYuX3Jldmlz aW9uX3RvX2J1aWxkX251bWJlciA9IE5vbmUKKyAgICAgICAgc2VsZi5fYnJvd3NlciA9IEJyb3dz ZXIoKQorICAgICAgICBzZWxmLl9icm93c2VyLnNldF9oYW5kbGVfcm9ib3RzKEZhbHNlKSAjIFRo ZSBidWlsZGVyIHBhZ2VzIGFyZSBleGNsdWRlZCBieSByb2JvdHMudHh0CiAKICAgICBkZWYgbmFt ZShzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX25hbWUKQEAgLTgzLDYgKzg2LDE5IEBAIGNs YXNzIEJ1aWxkZXIob2JqZWN0KToKICAgICAgICAgc2VsZi5fYnVpbGRzX2NhY2hlW2J1aWxkX251 bWJlcl0gPSBidWlsZAogICAgICAgICByZXR1cm4gYnVpbGQKIAorICAgIGRlZiBmb3JjZV9idWls ZChzZWxmLCB1c2VybmFtZT0id2Via2l0LXBhdGNoIiwgY29tbWVudHM9Tm9uZSk6CisgICAgICAg IGRlZiBwcmVkaWNhdGUoZm9ybSk6CisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAg cmV0dXJuIGZvcm0uZmluZF9jb250cm9sKCJ1c2VybmFtZSIpCisgICAgICAgICAgICBleGNlcHQg RXhjZXB0aW9uLCBlOgorICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQorICAgICAgICBzZWxm Ll9icm93c2VyLm9wZW4oc2VsZi51cmwoKSkKKyAgICAgICAgc2VsZi5fYnJvd3Nlci5zZWxlY3Rf Zm9ybShwcmVkaWNhdGU9cHJlZGljYXRlKQorICAgICAgICBzZWxmLl9icm93c2VyWyJ1c2VybmFt ZSJdID0gdXNlcm5hbWUKKyAgICAgICAgaWYgY29tbWVudHM6CisgICAgICAgICAgICBzZWxmLl9i cm93c2VyWyJjb21tZW50cyJdID0gY29tbWVudHMKKyAgICAgICAgcmV0dXJuIHNlbGYuX2Jyb3dz ZXIuc3VibWl0KCkKKwogICAgIGZpbGVfbmFtZV9yZWdleHAgPSByZS5jb21waWxlKHIicig/UDxy ZXZpc2lvbj5cZCspIFwoKD9QPGJ1aWxkX251bWJlcj5cZCspXCkiKQogICAgIGRlZiBfcmV2aXNp b25fYW5kX2J1aWxkX2Zvcl9maWxlbmFtZShzZWxmLCBmaWxlbmFtZSk6CiAgICAgICAgICMgRXhh bXBsZTogInI0NzQ4MyAoMSkvIiBvciAicjQ3NDgzICgxKS56aXAiCg==