36862 2010-03-30 16:17:25 -0700 Notifications should not resolve an empty icon parameter as a relative URL 2010-04-05 16:55:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg johnnyg commit-queue oldest_to_newest 206242 0 johnnyg 2010-03-30 16:17:25 -0700 Currently if a notification is created with empty icon parameter, the URL will be resolved relative to the current document URL, whereas it should remain empty. 206243 1 johnnyg 2010-03-30 16:17:45 -0700 Also, this was a recent regression. 206256 2 52099 johnnyg 2010-03-30 16:41:09 -0700 Created attachment 52099 Patch 207321 3 52099 dimich 2010-04-01 12:41:07 -0700 Comment on attachment 52099 Patch > Index: WebCore/ChangeLog > + > + No new tests, code is disabled in WebKit. This looks like something that has to be covered by a test. Especially if this is a recent regression, as you say in the bug. The ENABLE_NOTIFICATIONS is enabled in Chromium, so perhaps there is a way to have a test running at least in chromium port? Removing r? for now, feel free to flip back if there is a test or if it is plain impossible to have one. 208152 4 52468 johnnyg 2010-04-02 16:58:37 -0700 Created attachment 52468 Patch 208154 5 johnnyg 2010-04-02 17:01:58 -0700 Okay, I'm adding a test for this. All the notifications tests are disabled on all platforms pending patches to add the necessary hooks in DumpRenderTree/test_shell, so I'll add this one disabled as well. I have the testing hooks mostly done and can push that through soon, but since this is a regression it would be nice if we could land it with the placeholder test for now. 208187 6 52468 commit-queue 2010-04-02 17:43:47 -0700 Comment on attachment 52468 Patch Rejecting patch 52468 from commit-queue. johnnyg@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 208795 7 52468 commit-queue 2010-04-05 16:55:05 -0700 Comment on attachment 52468 Patch Clearing flags on attachment: 52468 Committed r57103: <http://trac.webkit.org/changeset/57103> 208796 8 commit-queue 2010-04-05 16:55:09 -0700 All reviewed patches have been landed. Closing bug. 52099 2010-03-30 16:41:09 -0700 2010-04-02 16:58:35 -0700 Patch bug-36862-20100330164107.patch text/plain 1214 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjgxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMzAgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90 aWZpY2F0aW9ucyBzaG91bGQgbm90IHJlc29sdmUgYW4gZW1wdHkgaWNvbiBwYXJhbWV0ZXIgYXMg YSByZWxhdGl2ZSBVUkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2ODYyCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb2RlIGlzIGRpc2FibGVkIGlu IFdlYktpdC4KKworICAgICAgICAqIG5vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvbjo6Tm90aWZpY2F0aW9uKToKKwogMjAxMC0wMy0z MCAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlv bi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5j cHAJKHJldmlzaW9uIDU2ODEyKQorKysgV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlv bi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0LDcgKzc0LDggQEAgTm90aWZpY2F0aW9uOjpOb3Rp ZmljYXRpb24oY29uc3QgTm90aWZpYwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9p Y29uVVJMID0gY29udGV4dC0+Y29tcGxldGVVUkwoY29udGVudHMuaWNvbigpKTsKKyAgICBpZiAo IWNvbnRlbnRzLmljb24oKS5pc0VtcHR5KCkpCisgICAgICAgIG1faWNvblVSTCA9IGNvbnRleHQt PmNvbXBsZXRlVVJMKGNvbnRlbnRzLmljb24oKSk7CiAgICAgaWYgKCFtX2ljb25VUkwuaXNFbXB0 eSgpICYmICFtX2ljb25VUkwuaXNWYWxpZCgpKSB7CiAgICAgICAgIGVjID0gU1lOVEFYX0VSUjsK ICAgICAgICAgcmV0dXJuOwo= 52468 2010-04-02 16:58:37 -0700 2010-04-05 16:55:04 -0700 Patch bug-36862-20100402165836.patch text/plain 3548 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzAzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDIgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90 aWZpY2F0aW9ucyBzaG91bGQgbm90IHJlc29sdmUgYW4gZW1wdHkgaWNvbiBwYXJhbWV0ZXIgYXMg YSByZWxhdGl2ZSBVUkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2ODYyCisKKyAgICAgICAgKiBub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb246Ok5vdGlmaWNhdGlvbik6CisKIDIwMTAt MDQtMDIgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBDYXJsc29uLgpJbmRleDogV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNh dGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlv bi5jcHAJKHJldmlzaW9uIDU2ODEyKQorKysgV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNh dGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0LDcgKzc0LDggQEAgTm90aWZpY2F0aW9uOjpO b3RpZmljYXRpb24oY29uc3QgTm90aWZpYwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAg bV9pY29uVVJMID0gY29udGV4dC0+Y29tcGxldGVVUkwoY29udGVudHMuaWNvbigpKTsKKyAgICBp ZiAoIWNvbnRlbnRzLmljb24oKS5pc0VtcHR5KCkpCisgICAgICAgIG1faWNvblVSTCA9IGNvbnRl eHQtPmNvbXBsZXRlVVJMKGNvbnRlbnRzLmljb24oKSk7CiAgICAgaWYgKCFtX2ljb25VUkwuaXNF bXB0eSgpICYmICFtX2ljb25VUkwuaXNWYWxpZCgpKSB7CiAgICAgICAgIGVjID0gU1lOVEFYX0VS UjsKICAgICAgICAgcmV0dXJuOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTcwMzEpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0w MiAgSm9obiBHcmVnZyAgPGpvaG5ueWdAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3RpZmljYXRpb25zIHNob3VsZCBub3QgcmVz b2x2ZSBhbiBlbXB0eSBpY29uIHBhcmFtZXRlciBhcyBhIHJlbGF0aXZlIFVSTAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4NjIKKworICAgICAgICAq IGZhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLW5vLWljb24tZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1uby1pY29u Lmh0bWwtZGlzYWJsZWQ6IEFkZGVkLgorCiAyMDEwLTA0LTAyICBBbmRyZXcgU2NoZXJrdXMgIDxz Y2hlcmt1c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29u IGFuZCBFcmljIFNlaWRlbC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9u b3RpZmljYXRpb25zLW5vLWljb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLW5vLWljb24tZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNh dGlvbnMtbm8taWNvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAor REVTS1RPUCBOT1RJRklDQVRJT046IGljb24gLCB0aXRsZSBOZXcgRS1tYWlsLCB0ZXh0IE1lZXQg bWUgdG9uaWdodCBhdCA4IQorU2VuZGluZyBub3RpZmljYXRpb25zIHdpdGggcGVybWlzc2lvbi4u LgorCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25z LW5vLWljb24uaHRtbC1kaXNhYmxlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L25v dGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1uby1pY29uLmh0bWwtZGlzYWJsZWQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1uby1p Y29uLmh0bWwtZGlzYWJsZWQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCI+CisgICAgICAgIGZ1bmN0aW9uIGxvZyhtZXNzYWdlKQorICAgICAgICB7CisgICAgICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MICs9IG1lc3NhZ2Ug KyAiPGJyPiI7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3Rz KCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikgeworICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmdyYW50RGVza3RvcE5v dGlmaWNhdGlvblBlcm1pc3Npb24oImZpbGU6Ly8iKTsKKyAgICAgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAg IGlmICghd2luZG93LndlYmtpdE5vdGlmaWNhdGlvbnMpIHsKKyAgICAgICAgICAgICAgICBsb2co IkZBSUw6IE5vIHdlYmtpdE5vdGlmaWNhdGlvbnMgaW50ZXJmYWNlISIpOworICAgICAgICAgICAg fQorICAgICAgICAgICAgCisgICAgICAgICAgICB2YXIgTSA9IHdpbmRvdy53ZWJraXROb3RpZmlj YXRpb25zLmNyZWF0ZU5vdGlmaWNhdGlvbigiIiwgIk5ldyBFLW1haWwiLCAiTWVldCBtZSB0b25p Z2h0IGF0IDghIik7CisgICAgICAgICAgICBNLnNob3coKTsKKyAgICAgICAgfQorICAgIDwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD5TZW5kaW5nIG5vdGlmaWNhdGlvbnMgd2l0aCBwZXJt aXNzaW9uLi4uPC9wPgorICAgIAorICAgIAorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQi PgorcnVuVGVzdHMoKTsKKzwvc2NyaXB0PgorCis8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorPC9i b2R5PgorPC9odG1sPgo=