36858 2010-03-30 15:46:11 -0700 Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33) 2010-04-17 11:44:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar, Regression P2 Normal --- 1 enrica enrica ap commit-queue eric mitz oldest_to_newest 206222 0 enrica 2010-03-30 15:46:11 -0700 Fails to handle properly characters with multiple glyphs. Repro steps: 1. Go to http://www.mozilla.org/editor/midasdemo/ 2. Type thai characters คำ Expected: The caret is placed next to the second character. Actual: The caret disappears. 206225 1 52093 enrica 2010-03-30 15:55:20 -0700 Created attachment 52093 Patch 206230 2 52093 darin 2010-03-30 16:06:12 -0700 Comment on attachment 52093 Patch > + Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33) You probably should not put the character itself in the change log. People might not open it in the right way to view UTF-8 characters. We usually stick to ASCII for the change log itself. r=me 206761 3 eric 2010-03-31 15:29:28 -0700 This appears to have caused fast/text/multiglyph-characters.html to fail on Tiger. 206981 4 52093 eric 2010-03-31 23:33:45 -0700 Comment on attachment 52093 Patch Looks like this was landed in http://trac.webkit.org/changeset/56813. I'll leave this open since Tiger is currently broken, but otherwise it could be closed. 207530 5 eric 2010-04-01 17:29:25 -0700 Should I check in the failing results for Tiger? 207740 6 52386 eric 2010-04-02 00:09:43 -0700 Created attachment 52386 Patch 207742 7 52386 eric 2010-04-02 00:10:58 -0700 Comment on attachment 52386 Patch I've prepared a checkin with the failing result for tiger pulled from the Tiger bot. Please let me know if this is not what's desired. Either way we need to make the Tiger bot green again so we can catch any subsequent regressions. 207899 8 52386 commit-queue 2010-04-02 10:01:53 -0700 Comment on attachment 52386 Patch Clearing flags on attachment: 52386 Committed r57006: <http://trac.webkit.org/changeset/57006> 207900 9 commit-queue 2010-04-02 10:01:58 -0700 All reviewed patches have been landed. Closing bug. 213637 10 ddkilzer 2010-04-17 11:44:40 -0700 <rdar://problem/7693772> 52093 2010-03-30 15:55:20 -0700 2010-03-31 23:33:45 -0700 Patch bug7810749.txt text/plain 4664 enrica SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjgxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMtMzAgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bmNvcnJlY3QgaW5zZXJ0aW9uIHBvc2l0aW9uIGFmdGVyIHR5cGluZyAn4LizJyAoVEhBSSBDSEFS QUNURVIgU0FSQSBBTSA9IDBFMzMpCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODEwNzQ5Pgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4NTgKKwor ICAgICAgICBUZXN0OiBmYXN0L3RleHQvbXVsdGlnbHlwaC1jaGFyYWN0ZXJzLmh0bWwKKworICAg ICAgICBDaGFyYWN0ZXJzIHdpdGggbXVsdGlwbGUgZ2x5cGggd2VyZSBub3Qgc3VwcG9ydGVkIGNv cnJlY3RseS4KKyAgICAgICAgQ29tcHV0aW5nIHRoZSBhZHZhbmNlIHdpZHRoIHdhcyBwcm9kdWNp bmcgYSBkaXZpc2lvbiBieSB6ZXJvLgorICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv bXBsZXhUZXh0Q29udHJvbGxlcjo6YWR2YW5jZSk6CisKIDIwMTAtMDMtMzAgIENocmlzIEV2YW5z ICA8Y2V2YW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRo LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxleFRleHRDb250cm9s bGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21w bGV4VGV4dENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA1NjgxMCkKKysrIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM5NCw3ICszOTQsMTIgQEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmFkdmFuY2Uo dW5zaQogICAgICAgICAgICAgLy8gRklYTUU6IEluc3RlYWQgb2YgZGl2aWRpbmcgdGhlIGdseXBo J3MgYWR2YW5jZSBlcXVpYWxseSBiZXR3ZWVuIHRoZSBjaGFyYWN0ZXJzLCB0aGlzCiAgICAgICAg ICAgICAvLyBjb3VsZCB1c2UgdGhlIGdseXBoJ3MgImxpZ2F0dXJlIGNhcmV0cyIuIEhvd2V2ZXIs IHRoZXJlIGlzIG5vIENvcmUgVGV4dCBBUEkgdG8gZ2V0IHRoZQogICAgICAgICAgICAgLy8gbGln YXR1cmUgY2FyZXRzLgotICAgICAgICAgICAgbV9ydW5XaWR0aFNvRmFyICs9IGFkanVzdGVkQWR2 YW5jZS53aWR0aCAqIChtX2NoYXJhY3RlckluQ3VycmVudEdseXBoIC0gb2xkQ2hhcmFjdGVySW5D dXJyZW50R2x5cGgpIC8gKGdseXBoRW5kT2Zmc2V0IC0gZ2x5cGhTdGFydE9mZnNldCk7CisgICAg ICAgICAgICBpZiAoZ2x5cGhTdGFydE9mZnNldCA9PSBnbHlwaEVuZE9mZnNldCkgeworICAgICAg ICAgICAgICAgIC8vIFdoZW4gdGhlcmUgYXJlIG11bHRpcGxlIGdseXBocyBwZXIgY2hhcmFjdGVy IHdlIG5lZWQgdG8gYWR2YW5jZSBieSB0aGUgZnVsbCB3aWR0aCBvZiB0aGUgZ2x5cGguCisgICAg ICAgICAgICAgICAgQVNTRVJUKG1fY2hhcmFjdGVySW5DdXJyZW50R2x5cGggPT0gb2xkQ2hhcmFj dGVySW5DdXJyZW50R2x5cGgpOworICAgICAgICAgICAgICAgIG1fcnVuV2lkdGhTb0ZhciArPSBh ZGp1c3RlZEFkdmFuY2Uud2lkdGg7CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAg ICBtX3J1bldpZHRoU29GYXIgKz0gYWRqdXN0ZWRBZHZhbmNlLndpZHRoICogKG1fY2hhcmFjdGVy SW5DdXJyZW50R2x5cGggLSBvbGRDaGFyYWN0ZXJJbkN1cnJlbnRHbHlwaCkgLyAoZ2x5cGhFbmRP ZmZzZXQgLSBnbHlwaFN0YXJ0T2Zmc2V0KTsKIAogICAgICAgICAgICAgaWYgKGdseXBoRW5kT2Zm c2V0ICsgY29tcGxleFRleHRSdW4uc3RyaW5nTG9jYXRpb24oKSA+IG1fY3VycmVudENoYXJhY3Rl cikKICAgICAgICAgICAgICAgICByZXR1cm47CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NjgxMikKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisy MDEwLTAzLTMwICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5jb3JyZWN0IGluc2VydGlv biBwb3NpdGlvbiBhZnRlciB0eXBpbmcgJ+C4sycgKFRIQUkgQ0hBUkFDVEVSIFNBUkEgQU0gPSAw RTMzKQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzgxMDc0OT4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2ODU4CisKKyAgICAgICAgKiBmYXN0L3Rl eHQvbXVsdGlnbHlwaC1jaGFyYWN0ZXJzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC90ZXh0L211bHRpZ2x5cGgtY2hhcmFjdGVycy5odG1sOiBBZGRlZC4KKwogMjAxMC0wMy0z MCAgQ2hyaXMgRXZhbnMgIDxjZXZhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gQmFydGguCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvbXVsdGlnbHlwaC1j aGFyYWN0ZXJzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3Rl eHQvbXVsdGlnbHlwaC1jaGFyYWN0ZXJzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvdGV4dC9tdWx0aWdseXBoLWNoYXJhY3RlcnMtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKK1RoaXMgdGVzdHMgdGV4dCB3aXRoIGNoYXJhY3Rl cnMgdGhhdCBoYXZlIG11bHRpcGxlIGdseXBocy4KKworW+C4hOC4s+C4nF0KK1vguITguLNdCitQ QVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvbXVsdGlnbHlwaC1jaGFyYWN0ZXJzLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0L211bHRpZ2x5cGgtY2hhcmFj dGVycy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L211bHRpZ2x5 cGgtY2hhcmFjdGVycy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI3IEBACis8cD4KKyAg ICBUaGlzIHRlc3RzIHRleHQgd2l0aCBjaGFyYWN0ZXJzIHRoYXQgaGF2ZSBtdWx0aXBsZSBnbHlw aHMuCis8L3A+Cis8ZGl2IGlkPSJ0YXJnZXQiIHN0eWxlPSJmb250LXNpemU6IDQ4cHg7Ij48c3Bh bj5bPC9zcGFuPiYjeDBFMDQ7JiN4MEUzMzsmI3gwRTFDOzxzcGFuPl08L3NwYW4+PC9kaXY+Cis8 ZGl2IGlkPSJyZWZlcmVuY2UiIHN0eWxlPSJmb250LXNpemU6IDQ4cHg7Ij48c3Bhbj5bPC9zcGFu PiYjeDBFMDQ7JiN4MEUzMzs8c3Bhbj5dPC9zcGFuPjwvZGl2PgorPHAgaWQ9InJlc3VsdCI+VGVz dCBkaWQgbm90IHJ1bjwvcD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisg ICAgdmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsKKworICAg IHZhciB0ZXh0Tm9kZVRhcmdldCA9IHRhcmdldC5maXJzdENoaWxkLm5leHRTaWJsaW5nOworICAg IHZhciByYW5nZSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7CisgICAgcmFuZ2Uuc2V0U3RhcnQo dGV4dE5vZGVUYXJnZXQsIDApOworICAgIHJhbmdlLnNldEVuZCh0ZXh0Tm9kZVRhcmdldCwgMik7 CisgICAgdmFyIHRhcmdldFdpZHRoID0gcmFuZ2UuZ2V0Q2xpZW50UmVjdHMoKVswXS53aWR0aDsK KworICAgIHZhciByZWZlcmVuY2UgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVmZXJlbmNl Iik7CisgICAgdmFyIHRleHROb2RlUmVmZXJlbmNlID0gcmVmZXJlbmNlLmZpcnN0Q2hpbGQubmV4 dFNpYmxpbmc7CisgICAgcmFuZ2Uuc2V0U3RhcnQodGV4dE5vZGVSZWZlcmVuY2UsIDApCisgICAg cmFuZ2Uuc2V0RW5kKHRleHROb2RlUmVmZXJlbmNlLCAyKTsKKyAgICAKKyAgICB2YXIgcmVmZXJl bmNlV2lkdGggPSByYW5nZS5nZXRDbGllbnRSZWN0cygpWzBdLndpZHRoOworCisgICAgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9IHRhcmdldFdpZHRoID09PSBy ZWZlcmVuY2VXaWR0aCA/ICJQQVNTIiA6ICJGQUlMOiB3aWR0aCB3YXMgIiArIHRhcmdldFdpZHRo ICsgIiBpbnN0ZWFkIG9mICIgKyByZWZlcmVuY2VXaWR0aDsKKzwvc2NyaXB0Pgo= 52386 2010-04-02 00:09:43 -0700 2010-04-02 10:01:53 -0700 Patch bug-36858-20100402000942.patch text/plain 1133 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MzMxMTY5Li42MDVhMWVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MDIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY29ycmVjdCBpbnNlcnRpb24gcG9zaXRpb24g YWZ0ZXIgdHlwaW5nICfguLMnIChUSEFJIENIQVJBQ1RFUiBTQVJBIEFNID0gMEUzMykKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2ODU4CisKKyAgICAg ICAgQWRkIGZhaWxpbmcgcmVzdWx0cyBmb3IgVGlnZXIgdG8gbWFrZSB0aGUgVGlnZXIgYm90IGdy ZWVuLgorICAgICAgICBXZSBtYXkgd2lzaCB0byBhY3R1YWxseSBmaXggVGlnZXIgYXQgc29tZSBw b2ludC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy10aWdlci9mYXN0L3RleHQvbXVsdGlnbHlw aC1jaGFyYWN0ZXJzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTAtMDQtMDEgIE1PUklUQSBI YWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtdGlnZXIvZmFzdC90 ZXh0L211bHRpZ2x5cGgtY2hhcmFjdGVycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtdGlnZXIvZmFzdC90ZXh0L211bHRpZ2x5cGgtY2hhcmFjdGVycy1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMzgwNWE3MgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9mYXN0L3RleHQvbXVsdGln bHlwaC1jaGFyYWN0ZXJzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK1RoaXMgdGVzdHMg dGV4dCB3aXRoIGNoYXJhY3RlcnMgdGhhdCBoYXZlIG11bHRpcGxlIGdseXBocy4KKworW+C4hOC4 s+C4nF0KK1vguITguLNdCitGQUlMOiB3aWR0aCB3YXMgNTYgaW5zdGVhZCBvZiA1Nwo=