36852 2010-03-30 14:14:21 -0700 webkit-patch what-broke throws exception 2010-04-02 11:51:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth hamaji oldest_to_newest 206176 0 eric 2010-03-30 14:14:21 -0700 webkit-patch what-broke throws exception missing import of StringIO in api.py 206179 1 52081 eric 2010-03-30 14:16:38 -0700 Created attachment 52081 Patch 206180 2 eric 2010-03-30 14:17:13 -0700 This is probably what caused sheriffbot to fail to report the recent break from ap. 206187 3 52081 abarth 2010-03-30 14:27:59 -0700 Comment on attachment 52081 Patch thanks 206191 4 eric 2010-03-30 14:44:53 -0700 Committed r56809: <http://trac.webkit.org/changeset/56809> 206378 5 hamaji 2010-03-31 00:15:00 -0700 Committed r56828: <http://trac.webkit.org/changeset/56828> 206379 6 eric 2010-03-31 00:16:15 -0700 Thanks! 206381 7 hamaji 2010-03-31 00:20:46 -0700 (In reply to comment #6) > Thanks! No problem. Ah, I thought it is 4am in your timezone so I didn't ask a review. It turned out the clock in my office was broken... 206388 8 eric 2010-03-31 00:26:38 -0700 Oh, reviews are never necessary for "build" fixes like this one. Thanks again for cleaning up my mess! 206408 9 hamaji 2010-03-31 01:35:11 -0700 (In reply to comment #8) > Oh, reviews are never necessary for "build" fixes like this one. Thanks again > for cleaning up my mess! Yeah, usually I land trivial fixes without reviews. But in this case, I wasn't 100% sure if my fix meets your intention so I wanted ask you to check if possible. Anyway, we fixed our clocks, too :) 52081 2010-03-30 14:16:38 -0700 2010-04-02 11:51:50 -0700 Patch bug-36852-20100330141637.patch text/plain 4279 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwOGU5Yjc3Li44ZGIxMTRjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MzAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCB3aGF0LWJyb2tlIHRocm93 cyBleGNlcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM2ODUyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9h cGkucHk6IEFkZCBtaXNzaW5nIGltcG9ydCBTdHJpbmdJTy4KKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5pdHRlc3QucHk6IFRlc3QgdGhlIGZ1bmN0aW9u IHdoaWNoIHByZXZpb3VzbHkgdGhyZXcgYW5kIGV4Y2VwdGlvbi4KKwogMjAxMC0wMy0zMCAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y2hlY2tvdXQvYXBpLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hl Y2tvdXQvYXBpLnB5CmluZGV4IDJlZGZlMTguLmExM2MzZDEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2FwaS5weQorKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkKQEAgLTI4LDYgKzI4 LDcgQEAKIAogaW1wb3J0IG9zCiBpbXBvcnQgc3VicHJvY2VzcworaW1wb3J0IFN0cmluZ0lPCiAK IGZyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0LmNoYW5nZWxvZyBpbXBvcnQgQ2hhbmdlTG9n CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5jaGVja291dC5jb21taXRpbmZvIGltcG9ydCBDb21taXRJ bmZvCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9hcGlfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jaGVja291dC9hcGlfdW5pdHRlc3QucHkKaW5kZXggYjQxM2ZiYi4uMDNiNTMyYSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpX3Vu aXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L2FwaV91bml0dGVzdC5weQpAQCAtNDMsOCArNDMsNyBAQCBkZWYgd3JpdGVfaW50b19maWxl X2F0X3BhdGgoZmlsZV9wYXRoLCBjb250ZW50cyk6CiAgICAgbmV3X2ZpbGUuY2xvc2UoKQogCiAK LWNsYXNzIENvbW1pdE1lc3NhZ2VGb3JUaGlzQ29tbWl0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6 Ci0gICAgY2hhbmdlbG9nMSA9ICIiIjIwMTAtMDMtMjUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJr aXQub3JnPgorX2NoYW5nZWxvZzFlbnRyeTEgPSAiIiIyMDEwLTAzLTI1ICBFcmljIFNlaWRlbCAg PGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCB0byB1bi1i cmVhayB3ZWJraXQtcGF0Y2ggbGFuZC4KIApAQCAtNTIsOCArNTEsOCBAQCBjbGFzcyBDb21taXRN ZXNzYWdlRm9yVGhpc0NvbW1pdFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2MjkKIAogICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2FwaS5weTogaW1wb3J0IHNjbS5Db21taXRN ZXNzYWdlCi0KLTIwMTAtMDMtMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKyIi IgorX2NoYW5nZWxvZzFlbnRyeTIgPSAiIiIyMDEwLTAzLTI1ICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCiAKQEAgLTYy LDcgKzYxLDggQEAgY2xhc3MgQ29tbWl0TWVzc2FnZUZvclRoaXNDb21taXRUZXN0KHVuaXR0ZXN0 LlRlc3RDYXNlKToKIAogICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0 L2FwaS5weToKICIiIgotICAgIGNoYW5nZWxvZzIgPSAiIiIyMDEwLTAzLTI1ICBFcmljIFNlaWRl bCAgPGVyaWNAd2Via2l0Lm9yZz4KK19jaGFuZ2Vsb2cxID0gIlxuIi5qb2luKFtfY2hhbmdlbG9n MWVudHJ5MSwgX2NoYW5nZWxvZzFlbnRyeTJdKQorX2NoYW5nZWxvZzIgPSAiIiIyMDEwLTAzLTI1 ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeCB0byB1bi1icmVhayB3ZWJraXQtcGF0Y2ggbGFuZC4KIApAQCAtNzcsNiArNzcsNyBA QCBjbGFzcyBDb21taXRNZXNzYWdlRm9yVGhpc0NvbW1pdFRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgogICAgICAgICBGaWxsZXIgY2hhbmdlLgogIiIiCiAKK2NsYXNzIENvbW1pdE1lc3NhZ2VGb3JU aGlzQ29tbWl0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZXhwZWN0ZWRfY29tbWl0X21l c3NhZ2UgPSAiIiIyMDEwLTAzLTI1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCB0byB1bi1icmVhayB3ZWJraXQtcGF0Y2ggbGFu ZC4KQEAgLTk4LDggKzk5LDggQEAgY2xhc3MgQ29tbWl0TWVzc2FnZUZvclRoaXNDb21taXRUZXN0 KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi50ZW1wX2RpciA9IHRlbXBmaWxlLm1r ZHRlbXAoc3VmZml4PSJjaGFuZ2Vsb2dzIikKICAgICAgICAgc2VsZi5vbGRfY3dkID0gb3MuZ2V0 Y3dkKCkKICAgICAgICAgb3MuY2hkaXIoc2VsZi50ZW1wX2RpcikKLSAgICAgICAgd3JpdGVfaW50 b19maWxlX2F0X3BhdGgoIkNoYW5nZUxvZzEiLCBzZWxmLmNoYW5nZWxvZzEpCi0gICAgICAgIHdy aXRlX2ludG9fZmlsZV9hdF9wYXRoKCJDaGFuZ2VMb2cyIiwgc2VsZi5jaGFuZ2Vsb2cyKQorICAg ICAgICB3cml0ZV9pbnRvX2ZpbGVfYXRfcGF0aCgiQ2hhbmdlTG9nMSIsIF9jaGFuZ2Vsb2cxKQor ICAgICAgICB3cml0ZV9pbnRvX2ZpbGVfYXRfcGF0aCgiQ2hhbmdlTG9nMiIsIF9jaGFuZ2Vsb2cy KQogCiAgICAgZGVmIHRlYXJEb3duKHNlbGYpOgogICAgICAgICBzaHV0aWwucm10cmVlKHNlbGYu dGVtcF9kaXIsIGlnbm9yZV9lcnJvcnM9VHJ1ZSkKQEAgLTExNCwzICsxMTUsMTYgQEAgY2xhc3Mg Q29tbWl0TWVzc2FnZUZvclRoaXNDb21taXRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAg ICAgZXhwZWN0ZWRfc3RkZXJyID0gIlBhcnNpbmcgQ2hhbmdlTG9nOiBDaGFuZ2VMb2cxXG5QYXJz aW5nIENoYW5nZUxvZzogQ2hhbmdlTG9nMlxuIgogICAgICAgICBjb21taXRfbWVzc2FnZSA9IG91 dHB1dC5hc3NlcnRfb3V0cHV0cyhzZWxmLCBjaGVja291dC5jb21taXRfbWVzc2FnZV9mb3JfdGhp c19jb21taXQsIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoY29tbWl0X21lc3NhZ2UubWVzc2FnZSgpLCBzZWxmLmV4cGVjdGVkX2NvbW1p dF9tZXNzYWdlKQorCisKK2NsYXNzIENoZWNrb3V0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6Cisg ICAgZGVmIHRlc3RfbGF0ZXN0X2VudHJ5X2Zvcl9jaGFuZ2Vsb2dfYXRfcmV2aXNpb24oc2VsZik6 CisgICAgICAgIHNjbSA9IE1vY2soKQorICAgICAgICBkZWYgbW9ja19jb250ZW50c19hdF9yZXZp c2lvbihjaGFuZ2Vsb2dfcGF0aCwgcmV2aXNpb24pOgorICAgICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChjaGFuZ2Vsb2dfcGF0aCwgImZvbyIpCisgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFs KHJldmlzaW9uLCAiYmFyIikKKyAgICAgICAgICAgIHJldHVybiBfY2hhbmdlbG9nMQorICAgICAg ICBzY20uY29udGVudHNfYXRfcmV2aXNpb24gPSBtb2NrX2NvbnRlbnRzX2F0X3JldmlzaW9uCisg ICAgICAgIGNoZWNrb3V0ID0gQ2hlY2tvdXQoc2NtKQorICAgICAgICBlbnRyeSA9IGNoZWNrb3V0 Ll9sYXRlc3RfZW50cnlfZm9yX2NoYW5nZWxvZ19hdF9yZXZpc2lvbigiZm9vIiwgImJhciIpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZW50cnkuY29udGVudHMoKSwgX2NoYW5nZWxvZzFlbnRy eTEpCg==