36834 2010-03-30 10:17:57 -0700 Web Inspector: Do not send empty matching rules for pseudo elements to frontend. 2010-03-30 10:33:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 206055 0 pfeldman 2010-03-30 10:17:57 -0700 A small optimization. 206058 1 52052 pfeldman 2010-03-30 10:22:58 -0700 Created attachment 52052 [PATCH] Proposed change. 206063 2 pfeldman 2010-03-30 10:33:39 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/chromium/test_expectations.txt M WebCore/ChangeLog M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/front-end/StylesSidebarPane.js Committed r56798 52052 2010-03-30 10:22:58 -0700 2010-03-30 10:28:36 -0700 [PATCH] Proposed change. empty_pseudo text/plain 4501 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMTViMGUzLi5kNWNiYjFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MzAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IHNlbmQgZW1wdHkgbWF0Y2hpbmcgcnVsZXMgZm9yIHBzZXVkbyBlbGVtZW50cyB0byBmcm9udGVu ZC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4 MzQKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoK KwogMjAxMC0wMy0zMCAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGUzZGI2NjcuLmRjZTk2NjYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQKQEAgLTI4NDgsNSArMjg0OCw0IEBAIEJVRzM5NDg1IDogZmFzdC9ldmVudHMvb25iZWZv cmV1bmxvYWQtZm9jdXNlZC1pZnJhbWUuaHRtbCA9IFRJTUVPVVQKIC8vIE5lZWQgcmViYXNlbGlu ZS4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjQ2MQogQlVH X0hBTUFKSSA6IGZhc3QvcmVwYWludC9vdmVyZmxvdy1zY3JvbGwtYm9keS1hcHBlYXIuaHRtbCA9 IElNQUdFK1RFWFQgSU1BR0UKIEJVR1dLMzY4MDcgV0lOIDogaHR0cC90ZXN0cy9pbnNwZWN0b3It ZW5hYmxlZC9jb25zb2xlLWxvZy1iZWZvcmUtZnJhbWUtbmF2aWdhdGlvbi5odG1sID0gVEVYVAot QlVHV0szNjgwNiBXSU4gOiBpbnNwZWN0b3IvZWxlbWVudHMtcGFuZWwtc3R5bGVzLmh0bWwgPSBU RVhUCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggMjFjYjE2YS4uN2MzOGUyMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0zMCAgUGF2ZWwg RmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBEbyBub3Qgc2VuZCBlbXB0 eSBtYXRjaGluZyBydWxlcyBmb3IgcHNldWRvIGVsZW1lbnRzIHRvIGZyb250ZW5kLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjgzNAorCisgICAg ICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckRPTUFnZW50OjpidWlsZEFycmF5Rm9yUHNldWRvRWxlbWVudHMpOgorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlLl91cGRhdGUpOgorCiAyMDEw LTAzLTMwICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRE9NQWdlbnQuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuY3BwCmluZGV4IDRlYWQ4YzcuLjYxNTdmMzIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JET01BZ2VudC5jcHAKQEAgLTg4MSw5ICs4ODEsMTIgQEAgU2NyaXB0QXJyYXkgSW5zcGVjdG9y RE9NQWdlbnQ6OmJ1aWxkQXJyYXlGb3JQc2V1ZG9FbGVtZW50cyhFbGVtZW50KiBlbGVtZW50LCBi b28KIAogICAgIGZvciAoUHNldWRvSWQgcHNldWRvSWQgPSBGSVJTVF9QVUJMSUNfUFNFVURPSUQ7 IHBzZXVkb0lkIDwgQUZURVJfTEFTVF9JTlRFUk5BTF9QU0VVRE9JRDsgcHNldWRvSWQgPSBzdGF0 aWNfY2FzdDxQc2V1ZG9JZD4ocHNldWRvSWQgKyAxKSkgewogICAgICAgICBSZWZQdHI8Q1NTUnVs ZUxpc3Q+IG1hdGNoZWRSdWxlcyA9IHNlbGVjdG9yLT5wc2V1ZG9TdHlsZVJ1bGVzRm9yRWxlbWVu dChlbGVtZW50LCBwc2V1ZG9JZCwgYXV0aG9yT25seSk7Ci0gICAgICAgIFNjcmlwdEFycmF5IG1h dGNoZWRBcnJheSA9IGJ1aWxkQXJyYXlGb3JDU1NSdWxlcyhtYXRjaGVkUnVsZXMuZ2V0KCkpOwot ICAgICAgICBzdGF0aWNfY2FzdDxTY3JpcHRPYmplY3Q+KG1hdGNoZWRBcnJheSkuc2V0KCJwc2V1 ZG9JZCIsIHN0YXRpY19jYXN0PGludD4ocHNldWRvSWQpKTsKLSAgICAgICAgcmVzdWx0LnNldChj b3VudGVyKyssIG1hdGNoZWRBcnJheSk7CisgICAgICAgIGlmIChtYXRjaGVkUnVsZXMgJiYgbWF0 Y2hlZFJ1bGVzLT5sZW5ndGgoKSkgeworICAgICAgICAgICAgU2NyaXB0T2JqZWN0IHBzZXVkb1N0 eWxlcyA9IG1fZnJvbnRlbmQtPm5ld1NjcmlwdE9iamVjdCgpOworICAgICAgICAgICAgcHNldWRv U3R5bGVzLnNldCgicHNldWRvSWQiLCBzdGF0aWNfY2FzdDxpbnQ+KHBzZXVkb0lkKSk7CisgICAg ICAgICAgICBwc2V1ZG9TdHlsZXMuc2V0KCJydWxlcyIsIGJ1aWxkQXJyYXlGb3JDU1NSdWxlcyht YXRjaGVkUnVsZXMuZ2V0KCkpKTsKKyAgICAgICAgICAgIHJlc3VsdC5zZXQoY291bnRlcisrLCBw c2V1ZG9TdHlsZXMpOworICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiByZXN1bHQ7CiB9CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUu anMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5k ZXggMGRhYzY0MS4uOWM3NTkyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAtMTY0LDE3ICsxNjQsMTYgQEAgV2ViSW5zcGVjdG9y LlN0eWxlc1NpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKIAogICAgICAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBzdHlsZXMucHNldWRvRWxlbWVudHMubGVuZ3RoOyArK2kpIHsKICAgICAgICAg ICAgICAgICB2YXIgcHNldWRvRWxlbWVudENTU1J1bGVzID0gc3R5bGVzLnBzZXVkb0VsZW1lbnRz W2ldOwotICAgICAgICAgICAgICAgIGlmICghcHNldWRvRWxlbWVudENTU1J1bGVzLmxlbmd0aCkK LSAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICAgICAgc3R5 bGVSdWxlcyA9IFtdOwogICAgICAgICAgICAgICAgIHZhciBwc2V1ZG9JZCA9IHBzZXVkb0VsZW1l bnRDU1NSdWxlcy5wc2V1ZG9JZDsKKwogICAgICAgICAgICAgICAgIHZhciBlbnRyeSA9IHsgaXNT dHlsZVNlcGFyYXRvcjogdHJ1ZSwgcHNldWRvSWQ6IHBzZXVkb0lkIH07CiAgICAgICAgICAgICAg ICAgc3R5bGVSdWxlcy5wdXNoKGVudHJ5KTsKIAogICAgICAgICAgICAgICAgIC8vIEFkZCBydWxl cyBpbiByZXZlcnNlIG9yZGVyIHRvIG1hdGNoIHRoZSBjYXNjYWRlIG9yZGVyLgotICAgICAgICAg ICAgICAgIGZvciAodmFyIGogPSBwc2V1ZG9FbGVtZW50Q1NTUnVsZXMubGVuZ3RoIC0gMTsgaiA+ PSAwOyAtLWopIHsKLSAgICAgICAgICAgICAgICAgICAgdmFyIHJ1bGUgPSBXZWJJbnNwZWN0b3Iu Q1NTU3R5bGVEZWNsYXJhdGlvbi5wYXJzZVJ1bGUocHNldWRvRWxlbWVudENTU1J1bGVzW2pdKTsK KyAgICAgICAgICAgICAgICBmb3IgKHZhciBqID0gcHNldWRvRWxlbWVudENTU1J1bGVzLnJ1bGVz Lmxlbmd0aCAtIDE7IGogPj0gMDsgLS1qKSB7CisgICAgICAgICAgICAgICAgICAgIHZhciBydWxl ID0gV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb24ucGFyc2VSdWxlKHBzZXVkb0VsZW1l bnRDU1NSdWxlcy5ydWxlc1tqXSk7CiAgICAgICAgICAgICAgICAgICAgIHN0eWxlUnVsZXMucHVz aCh7IHN0eWxlOiBydWxlLnN0eWxlLCBzZWxlY3RvclRleHQ6IHJ1bGUuc2VsZWN0b3JUZXh0LCBw YXJlbnRTdHlsZVNoZWV0OiBydWxlLnBhcmVudFN0eWxlU2hlZXQsIHJ1bGU6IHJ1bGUgfSk7CiAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIHVzZWRQcm9wZXJ0aWVzID0ge307Cg==