36826 2010-03-30 08:00:32 -0700 [Qt] QtWebkit.pc is broken 2010-06-01 07:35:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux CLOSED FIXED Qt, QtTriaged P2 Critical --- 35784 1 fabo jturcotte debfx hausmann jturcotte laszlo.gombos rclbelem oldest_to_newest 206010 0 fabo 2010-03-30 08:00:32 -0700 QtWebKit.pc is broken. See libdir and Libs.private values: libdir=${prefi/usr/lib Libs.private: -L../JavaScriptCore -L/usr/X11/usr/lib -L/u/usr/lib -ljscore -lXrender -lsqlite3 -lphonon -lQtXmlPatterns -lQtGui -lQtNetwork -lQtCore -lpthread -lXext -lX11 -lm Same code is used to generate the pkgconfig file on Qt 4.6.2 but is not reproducible with QtWebKit from Qt 4.6.2 source code. 206011 1 52039 fabo 2010-03-30 08:01:49 -0700 Created attachment 52039 broken pkgconfig file 206077 2 52055 jturcotte 2010-03-30 11:02:25 -0700 Created attachment 52055 Patch that might help Can you try with this patch in trunk? 206522 3 jturcotte 2010-03-31 08:22:35 -0700 (In reply to comment #2) > Created an attachment (id=52055) [details] > Patch that might help > > Can you try with this patch in trunk? Sorry it won't work, against what I thought, LIBS_PRIVATE is only available for static library targets. By looking at pkg-config's documentation, Libs.private is used when the application would link QtWebKit statically, which we want to drop support to be able to build JavaScriptCore as a static library to use aggressive optimization exclusively for it. What exactly is the problem at the end? Do you need static linking against QtWebKit? Can you omit the Libs.private line when generating the .pc file? 208406 4 fabo 2010-04-05 00:26:49 -0700 some values are truncated. see libdir value: "${prefi/usr/lib" it should be "${prefix}/lib" instead of "${prefi/usr/lib". same for Libs.private, see "-L/usr/X11/usr/lib" and "-L/u/usr/lib" strings. it should be "-L/usr/lib/X11" and "-L/usr/lib". That's the problem. 208408 5 52519 fabo 2010-04-05 00:30:04 -0700 Created attachment 52519 correct QtWebKit.pc generated from Qt source correct QtWebKit.pc generated from Qt 4.6.2 source 232176 6 debfx 2010-05-30 04:30:01 -0700 *** Bug 39573 has been marked as a duplicate of this bug. *** 232177 7 debfx 2010-05-30 04:33:26 -0700 From my duplicate bug report: The following commands in WebCore/WebCore.pro can corrupt QtWebKit.pc: lib_replace.match = $$DESTDIR lib_replace.replace = $$[QT_INSTALL_LIBS] QMAKE_PKGCONFIG_INSTALL_REPLACE += lib_replace The problem is that .match/.replace doesn't replace plain strings but regular expressions. If $$DESTDIR == "../lib", the resulting command is: sed -e "s,../lib,/usr/lib,g" "../lib/pkgconfig/QtWebKit.pc" >"/build/buildd/qtwebkit-4.7~beta1/debian/tmp/usr/lib/pkgconfig/QtWebKit.pc" "." matches any character so "libdir=${prefix}/lib" is being replaced by "libdir=${prefi/usr/lib". I'm not sure why this path replacement is needed at all. 232700 8 57532 jturcotte 2010-06-01 05:43:32 -0700 Created attachment 57532 Patch Thanks for the investigation, this patch should fix the problem. 232715 9 57532 hausmann 2010-06-01 06:26:15 -0700 Comment on attachment 57532 Patch Landing by hand 232716 10 hausmann 2010-06-01 06:26:59 -0700 Committed r60475: <http://trac.webkit.org/changeset/60475> 232717 11 hausmann 2010-06-01 06:28:26 -0700 Revision r60475 cherry-picked into qtwebkit-2.0 with commit 9a83f22bc41a2016b6bbf495bfd32b3a659038c8 232740 12 hausmann 2010-06-01 07:35:34 -0700 (In reply to comment #11) > Revision r60475 cherry-picked into qtwebkit-2.0 with commit 9a83f22bc41a2016b6bbf495bfd32b3a659038c8 Sorry, the correct sha1 in 19f3a076250e739dde943683f5b3abd44ff916be 52039 2010-03-30 08:01:49 -0700 2010-06-01 03:32:31 -0700 broken pkgconfig file QtWebKit.pc text/plain 704 fabo cHJlZml4PS91c3IKZXhlY19wcmVmaXg9JHtwcmVmaXh9CmxpYmRpcj0ke3ByZWZpL3Vzci9saWIK aW5jbHVkZWRpcj0ke3ByZWZpeH0vaW5jbHVkZS9xdDQvUXRXZWJLaXQKcXRfY29uZmlnPWluY2x1 ZGVfc291cmNlX2RpciBsZXggeWFjYyB1aWMgcmVzb3VyY2VzIHF0IHJlbGVhc2UgaW5jcmVtZW50 YWwgbGlua19wcmwgZXhjZXB0aW9ucyBub19tb2NkZXBlbmQgcmVsZWFzZSBzdGwgcXRfbm9fZnJh bWV3b3JrIGJ1aWxkaW5nLWxpYnMgZGVwZW5kX2luY2x1ZGVwYXRoIHN0YW5kYWxvbmVfcGFja2Fn ZSBkZXBlbmRfaW5jbHVkZXBhdGggeDExIGxpbmtfcGtnY29uZmlnIGNyZWF0ZV9wYyBjcmVhdGVf cHJsIHgxMWxpYiB4MTFpbmMgbW9jIHRocmVhZCBkbGwKCk5hbWU6IFF0d2Via2l0CkRlc2NyaXB0 aW9uOiBRdHdlYmtpdCBMaWJyYXJ5ClZlcnNpb246IDQuNi4yCkxpYnM6IC1MJHtsaWJkaXJ9IC1s UXRXZWJLaXQgCkxpYnMucHJpdmF0ZTogLUwuLi9KYXZhU2NyaXB0Q29yZSAtTC91c3IvWDExL3Vz ci9saWIgLUwvdS91c3IvbGliICAtbGpzY29yZSAtbFhyZW5kZXIgLWxzcWxpdGUzIC1scGhvbm9u IC1sUXRYbWxQYXR0ZXJucyAtbFF0R3VpIC1sUXROZXR3b3JrIC1sUXRDb3JlIC1scHRocmVhZCAt bFhleHQgLWxYMTEgLWxtICAKQ2ZsYWdzOiAgLUkke2luY2x1ZGVkaXJ9ClJlcXVpcmVzOiBRdENv cmUgUXRHdWkgUXROZXR3b3JrCgo= 52055 2010-03-30 11:02:25 -0700 2010-06-01 05:43:32 -0700 Patch that might help jscore_libsprivate.patch text/plain 1635 jturcotte ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmMWIwYTU0Li4zM2IxNWIyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTAtMDMtMzAgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh LmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIFVzZSBMSUJTX1BSSVZBVEUgb24gTGludXggdG8gbGluayBKYXZhU2NyaXB0Q29yZSBpbiBR dFdlYktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzY4MjYKKworICAgICAgICBUaGlzIGZpeGVzIHBrZy1jb25maWcgc3VwcG9ydC4KKworICAgICAg ICAqIEphdmFTY3JpcHRDb3JlLnByaToKKworMjAxMC0wMy0zMCAgSm9jZWx5biBUdXJjb3R0ZSAg PGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IG5vYm9k eSwgYnVpbGQgYnJlYWsuCiAKICAgICAgICAgW1F0XSBGaXggYnVpbGQgYnJlYWsgb24gUXQgTWFj LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpIGIvSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCmluZGV4IDFhZDAyNTEuLmExYWE0YzAgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQorKysgYi9KYXZhU2NyaXB0 Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKQEAgLTY3LDExICs2NywxNiBAQCBkZWZpbmVUZXN0KGFk ZEphdmFTY3JpcHRDb3JlTGliKSB7CiAgICAgICAgIExJQlMgKz0gLWwkJEpBVkFTQ1JJUFRDT1JF X1RBUkdFVAogICAgIH0gZWxzZTpzeW1iaWFuIHsKICAgICAgICAgTElCUyArPSAtbCQke0pBVkFT Q1JJUFRDT1JFX1RBUkdFVH0ubGliCi0gICAgfSBlbHNlIHsKKyAgICB9IGVsc2U6d2luMzItZysr IHsKICAgICAgICAgIyBNYWtlIHN1cmUganNjb3JlIHdpbGwgYmUgZWFybHkgaW4gdGhlIGxpc3Qg b2YgbGlicmFyaWVzIHRvIHdvcmthcm91bmQgYSBidWcgaW4gTWluR1cKICAgICAgICAgIyB0aGF0 IGNhbid0IHJlc29sdmUgc3ltYm9scyBmcm9tIFF0Q29yZSBpZiBsaWJqc2NvcmUgY29tZXMgYWZ0 ZXIuCisgICAgICAgICMgTElCU19QUklWQVRFIGNhbm5vdCBiZSB1c2VkIGJlY2F1c2UgaXRzIGNv bnRlbnQgaXMgcGxhY2VkIGFmdGVyIExJQlMgY29udGVudC4KICAgICAgICAgUU1BS0VfTElCRElS ID0gJCRwYXRoVG9KYXZhU2NyaXB0Q29yZU91dHB1dCAkJFFNQUtFX0xJQkRJUgogICAgICAgICBM SUJTICs9IC1sJCRKQVZBU0NSSVBUQ09SRV9UQVJHRVQKKyAgICB9IGVsc2UgeworICAgICAgICAj IFVzZSBMSUJTX1BSSVZBVEUgb24gbGludXggdG8gZW5zdXJlIHRoYXQganNjb3JlIGRvZXNuJ3Qg c2hvdyB1cCBpbiBwa2ctY29uZmlnCisgICAgICAgIExJQlNfUFJJVkFURSArPSAtTCQkcGF0aFRv SmF2YVNjcmlwdENvcmVPdXRwdXQKKyAgICAgICAgTElCU19QUklWQVRFICs9IC1sJCRKQVZBU0NS SVBUQ09SRV9UQVJHRVQKICAgICB9CiAKICAgICB3aW4zMi0qIHsK 52519 2010-04-05 00:30:04 -0700 2010-06-01 03:32:51 -0700 correct QtWebKit.pc generated from Qt source QtWebKit.pc text/plain 1065 fabo cHJlZml4PS91c3IKZXhlY19wcmVmaXg9JHtwcmVmaXh9CmxpYmRpcj0ke3ByZWZpeH0vbGliCmlu Y2x1ZGVkaXI9JHtwcmVmaXh9L2luY2x1ZGUvcXQ0L1F0V2ViS2l0CnF0X2NvbmZpZz1sZXggeWFj YyB1aWMgcmVzb3VyY2VzIHF0IHJlbGVhc2UgaW5jcmVtZW50YWwgbGlua19wcmwgZXhjZXB0aW9u cyBub19tb2NkZXBlbmQgcmVsZWFzZSBzdGwgcXRfbm9fZnJhbWV3b3JrIHN5c3RlbS1zcWxpdGUg cmVsZWFzZSBzaGFyZWQgZGxsIGxhcmdlZmlsZSBzdGwgcHJlY29tcGlsZV9oZWFkZXIgbW14IDNk bm93IHNzZSBzc2UyIGR5bGliIGNyZWF0ZV9wcmwgbGlua19wcmwgZGVwZW5kX2luY2x1ZGVwYXRo IFFURElSX2J1aWxkIG5vc3RyaXAgdXNlX2xpYm15c3FsY2xpZW50X3IgYnVpbGRpbmctbGlicyBk ZXBlbmRfaW5jbHVkZXBhdGggcXRfaW5zdGFsbF9oZWFkZXJzIHF0IHdhcm5fb24gZGVwZW5kX2lu Y2x1ZGVwYXRoIHFtYWtlX2NhY2hlIHRhcmdldF9xdCBoaWRlX3N5bWJvbHMgY3JlYXRlX2xpYnRv b2wgY3JlYXRlX3BjIGV4cGxpY2l0bGliIHgxMSBsaW5rX3BrZ2NvbmZpZyB4MTFsaWIgeDExaW5j IG1vYyB0aHJlYWQgc2hhcmVkIGRsbAptb2NfbG9jYXRpb249L3Vzci9iaW4vbW9jLXF0NAp1aWNf bG9jYXRpb249L3Vzci9iaW4vdWljLXF0NAoKTmFtZTogUXR3ZWJraXQKRGVzY3JpcHRpb246IFF0 d2Via2l0IExpYnJhcnkKVmVyc2lvbjogNC42LjIKTGliczogLUwke2xpYmRpcn0gLWxRdFdlYktp dCAKTGlicy5wcml2YXRlOiAtTC91c3IvbGliIC1ML3Vzci9YMTFSNi9saWI2NCAgLWxzcWxpdGUz IC1scGhvbm9uIC1ML3Vzci9saWIgLWxRdERCdXMgLWxRdFhtbCAtTC91c3IvWDExUjYvbGliNjQg LWxRdFhtbFBhdHRlcm5zIC1sUXRHdWkgLWxRdE5ldHdvcmsgLWxRdENvcmUgLWxmb250Y29uZmln IC1scHRocmVhZCAtbFhyZW5kZXIgLWxmb250Y29uZmlnIC1sZnJlZXR5cGUgLWxYZXh0IC1sWDEx IC1sbSAgCkNmbGFnczogLURRVF9TSEFSRUQgLUkvdXNyL2luY2x1ZGUvcXQ0IC1JJHtpbmNsdWRl ZGlyfQpSZXF1aXJlczogUXRDb3JlIFF0R3VpIFF0TmV0d29yawoK 57532 2010-06-01 05:43:32 -0700 2010-06-01 06:26:15 -0700 Patch qtwebkit_pc_install.patch text/plain 1101 jturcotte ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDAwOWFiYS4uY2Q5NDBkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wMSAgSm9jZWx5biBUdXJj b3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IGEgUXRXZWJLaXQucGMgY29ycnVw dGlvbiBwcm9ibGVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzY4MjYKKworICAgICAgICBUaGUgcHJvYmxlbSBvY2N1cnMgd2hpbGUgaW5zdGFsbGlu ZyBRdFdlYktpdCBmcm9tIHRydW5rCisgICAgICAgIG9yIGEgc291cmNlIHBhY2thZ2UuCisKKyAg ICAgICAgKiBXZWJDb3JlLnBybzoKKwogMjAxMC0wNi0wMSAgQW50b24gTXVoaW4gIDxhbnRvbm1A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KaW5kZXggNjZi OWMwYS4uNGNjMmRhZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBybworKysgYi9XZWJD b3JlL1dlYkNvcmUucHJvCkBAIC0zMDEwLDcgKzMwMTAsNyBAQCBIRUFERVJTICs9ICQkV0VCS0lU X0FQSV9IRUFERVJTCiAgICAgICAgIFFNQUtFX1BLR0NPTkZJR19MSUJESVIgPSAkJHRhcmdldC5w YXRoCiAgICAgICAgIFFNQUtFX1BLR0NPTkZJR19JTkNESVIgPSAkJGhlYWRlcnMucGF0aAogICAg ICAgICBRTUFLRV9QS0dDT05GSUdfREVTVERJUiA9IHBrZ2NvbmZpZwotICAgICAgICBsaWJfcmVw bGFjZS5tYXRjaCA9ICQkREVTVERJUgorICAgICAgICBsaWJfcmVwbGFjZS5tYXRjaCA9ICQkcmVf ZXNjYXBlKCQkREVTVERJUikKICAgICAgICAgbGliX3JlcGxhY2UucmVwbGFjZSA9ICQkW1FUX0lO U1RBTExfTElCU10KICAgICAgICAgUU1BS0VfUEtHQ09ORklHX0lOU1RBTExfUkVQTEFDRSArPSBs aWJfcmVwbGFjZQogICAgIH0K