36821 2010-03-30 06:51:51 -0700 Web Inspector: Audits: bad CSS selector results in exception inside evaluated code 2010-03-30 08:40:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 205978 0 apavlov 2010-03-30 06:51:51 -0700 When an weird CSS selector is present in the page styles (e.g. "fb:foo-bar" on techcrunch.com), an exception is logged into the console and the audits fail to terminate, thus leaving the Audits panel in an inconsistent state. 206000 1 52037 apavlov 2010-03-30 07:30:25 -0700 Created attachment 52037 [PATCH] Suggested solution 206018 2 52037 commit-queue 2010-03-30 08:40:33 -0700 Comment on attachment 52037 [PATCH] Suggested solution Clearing flags on attachment: 52037 Committed r56792: <http://trac.webkit.org/changeset/56792> 206019 3 commit-queue 2010-03-30 08:40:37 -0700 All reviewed patches have been landed. Closing bug. 52037 2010-03-30 07:30:25 -0700 2010-03-30 08:40:33 -0700 [PATCH] Suggested solution auditstyles.patch text/plain 1694 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTIxYmQ5NC4uY2U2ZjNjZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0zMCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0czogYmFkIENTUyBzZWxl Y3RvciByZXN1bHRzIGluIGV4Y2VwdGlvbiBpbnNpZGUgZXZhbHVhdGVkIGNvZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2ODIxCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuQXVkaXRSdWxlcy5VbnVzZWRDc3NSdWxlLnByb3RvdHlwZS5kb1J1bi5ldmFsQ2FsbGJhY2su cm91dGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5VbnVzZWRDc3NSdWxl LnByb3RvdHlwZS5kb1J1bi5ldmFsQ2FsbGJhY2spOgorCiAyMDEwLTAzLTMwICBMYXN6bG8gR29t Ym9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXZpZCBLaWx6ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVk aXRSdWxlcy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzCmlu ZGV4IDg4ZTc2NjguLjUwYmI5MmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9BdWRpdFJ1bGVzLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRp dFJ1bGVzLmpzCkBAIC0zNDgsOSArMzQ4LDEzIEBAIFdlYkluc3BlY3Rvci5BdWRpdFJ1bGVzLlVu dXNlZENzc1J1bGUucHJvdG90eXBlID0gewogICAgICAgICAgICAgewogICAgICAgICAgICAgICAg IHZhciByZXN1bHQgPSB7fTsKICAgICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHNl bGVjdG9yQXJyYXkubGVuZ3RoOyArK2kpIHsKLSAgICAgICAgICAgICAgICAgICAgdmFyIG5vZGVz ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbChzZWxlY3RvckFycmF5W2ldKTsKLSAgICAgICAg ICAgICAgICAgICAgaWYgKG5vZGVzICYmIG5vZGVzLmxlbmd0aCkKLSAgICAgICAgICAgICAgICAg ICAgICAgIHJlc3VsdFtzZWxlY3RvckFycmF5W2ldXSA9IHRydWU7CisgICAgICAgICAgICAgICAg ICAgIHRyeSB7CisgICAgICAgICAgICAgICAgICAgICAgICB2YXIgbm9kZXMgPSBkb2N1bWVudC5x dWVyeVNlbGVjdG9yQWxsKHNlbGVjdG9yQXJyYXlbaV0pOworICAgICAgICAgICAgICAgICAgICAg ICAgaWYgKG5vZGVzICYmIG5vZGVzLmxlbmd0aCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICByZXN1bHRbc2VsZWN0b3JBcnJheVtpXV0gPSB0cnVlOworICAgICAgICAgICAgICAgICAgICB9 IGNhdGNoKGUpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIGlnbm9yZSBhbmQgbWFyayBh cyB1bnVzZWQKKyAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgICAgICAgICAgfQo=