36816 2010-03-30 05:23:53 -0700 Uninitalised members in BytecodeGenerator and CallLinkInfo 2010-04-03 18:17:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 kbalazs webkit-unassigned commit-queue laszlo.gombos oldest_to_newest 205957 0 kbalazs 2010-03-30 05:23:53 -0700 Valgrind shows me 2 uninitalised value problem: Conditional jump or move depends on uninitialised value(s) at 0x51BBB60: cti_vm_lazyLinkCall (JITStubs.cpp:1679) by 0x51B0102: JSC::TrampolineStructure::TrampolineStructure() (JITStubs.h:76) by 0x5173A5C: JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*, JSC::JSValue*) (JITCode.h:77) ... Conditional jump or move depends on uninitialized value(s) at 0x513E0DF: JSC::BytecodeGenerator::createArgumentsIfNecessary() (BytecodeGenerator.cpp:1391) by 0x5147EE7: JSC::BytecodeGenerator::emitPushNewScope(JSC::RegisterID*, JSC::Identifier const&, JSC::RegisterID*) BytecodeGenerator.cpp:1882) by 0x5154205: JSC::TryNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) (NodesCodegen.cpp:1890) ... These are caused by incomplete member initializer lists. I think the second could be dangerous. Fortunately we can solve it by an easy fix. 205958 1 52025 kbalazs 2010-03-30 05:34:39 -0700 Created attachment 52025 proposed patch 206093 2 52025 darin 2010-03-30 11:52:37 -0700 Comment on attachment 52025 proposed patch Why does this need to be changed? Is there a symptom to having these uninitialized? Are they ever used uninitialized? 206218 3 kbalazs 2010-03-30 15:40:57 -0700 The backtraces above shows exactly where are they used uninitialized. 208314 4 52025 oliver 2010-04-03 18:04:00 -0700 Comment on attachment 52025 proposed patch r=me 208315 5 52025 commit-queue 2010-04-03 18:17:19 -0700 Comment on attachment 52025 proposed patch Clearing flags on attachment: 52025 Committed r57054: <http://trac.webkit.org/changeset/57054> 208316 6 commit-queue 2010-04-03 18:17:24 -0700 All reviewed patches have been landed. Closing bug. 52025 2010-03-30 05:34:39 -0700 2010-04-03 18:17:19 -0700 proposed patch uninitalised.diff text/plain 1762 kbalazs ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBhMzliYWE4Li5hZDE1NDUyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTAtMDMtMzAgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB1bmluaXRh bGlzZWQgbWVtYmVycyBpbiBDYWxsTGlua0luZm8gYW5kIEJ5dGVjb2RlR2VuZXJhdG9yLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjgxNgorCisg ICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2Nr OjpDb2RlQmxvY2spOgorICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAo SlNDOjpDYWxsTGlua0luZm86OkNhbGxMaW5rSW5mbyk6CisKIDIwMTAtMDMtMjIgIEplZHJ6ZWog Tm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwIGIvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJs b2NrLmNwcAppbmRleCAxZjA5MGE0Li43NmY3ZDVkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0Nv ZGVCbG9jay5jcHAKQEAgLTEzMjEsNiArMTMyMSw3IEBAIENvZGVCbG9jazo6Q29kZUJsb2NrKFNj cmlwdEV4ZWN1dGFibGUqIG93bmVyRXhlY3V0YWJsZSwgQ29kZVR5cGUgY29kZVR5cGUsIFBhc3NS CiAjZW5kaWYKICAgICAsIG1fbmVlZHNGdWxsU2NvcGVDaGFpbihvd25lckV4ZWN1dGFibGUtPm5l ZWRzQWN0aXZhdGlvbigpKQogICAgICwgbV91c2VzRXZhbChvd25lckV4ZWN1dGFibGUtPnVzZXNF dmFsKCkpCisgICAgLCBtX3VzZXNBcmd1bWVudHMoZmFsc2UpCiAgICAgLCBtX2lzTnVtZXJpY0Nv bXBhcmVGdW5jdGlvbihmYWxzZSkKICAgICAsIG1fY29kZVR5cGUoY29kZVR5cGUpCiAgICAgLCBt X3NvdXJjZShzb3VyY2VQcm92aWRlcikKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL0NvZGVCbG9jay5oIGIvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKaW5k ZXggZDkyZGM5ZC4uZmIwNmYzNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv Q29kZUJsb2NrLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKQEAg LTEwMiw5ICsxMDIsMTEgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgc3RydWN0IENhbGxMaW5rSW5m byB7CiAgICAgICAgIENhbGxMaW5rSW5mbygpCiAgICAgICAgICAgICA6IGNhbGxlZSgwKQorICAg ICAgICAgICAgLCBwb3NpdGlvbigwKQorICAgICAgICAgICAgLCBoYXNTZWVuU2hvdWxkUmVwYXRj aCgwKQogICAgICAgICB7CiAgICAgICAgIH0KLSAgICAKKwogICAgICAgICB1bnNpZ25lZCBieXRl Y29kZUluZGV4OwogICAgICAgICBDb2RlTG9jYXRpb25OZWFyQ2FsbCBjYWxsUmV0dXJuTG9jYXRp b247CiAgICAgICAgIENvZGVMb2NhdGlvbkRhdGFMYWJlbFB0ciBob3RQYXRoQmVnaW47Cg==