36810 2010-03-30 01:18:31 -0700 tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual 2010-04-06 02:21:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All CLOSED FIXED P2 Normal --- 35784 1 benjamin benjamin commit-queue hausmann oldest_to_newest 205896 0 benjamin 2010-03-30 01:18:31 -0700 As far as I know, this method only makes sense for RenderBoxes. It could be implemented there directly. That could clean the code of RenderObject a bit, and avoid a useless virtual function call in the layout path. 205897 1 52011 benjamin 2010-03-30 01:20:58 -0700 Created attachment 52011 Move the function to RenderBox 206435 2 52011 commit-queue 2010-03-31 02:50:08 -0700 Comment on attachment 52011 Move the function to RenderBox Clearing flags on attachment: 52011 Committed r56831: <http://trac.webkit.org/changeset/56831> 206436 3 commit-queue 2010-03-31 02:50:13 -0700 All reviewed patches have been landed. Closing bug. 208950 4 hausmann 2010-04-06 02:21:03 -0700 Revision r56831 cherry-picked into qtwebkit-2.0 with commit 634142ce553d451158968753b31cd1364b1472dd 52011 2010-03-30 01:20:58 -0700 2010-03-31 02:50:08 -0700 Move the function to RenderBox 36810.patch text/plain 2326 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzhmNGU1MS4uYTg5Y2U4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0zMCAgQmVuamFtaW4gUG91 bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRyeUxheW91dERvaW5nUG9zaXRpb25lZE1vdmVt ZW50T25seSBkb2VzIG5vdCBoYXZlIHRvIGJlIGluIFJlbmRlck9iamVjdCBvciBiZSB2aXJ0dWFs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjgxMAor CisgICAgICAgIE1vdmUgdHJ5TGF5b3V0RG9pbmdQb3NpdGlvbmVkTW92ZW1lbnRPbmx5IGFzIGEg cmVndWxhciBtZXRob2Qgb2YgUmVuZGVyQm94CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy Qm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnRyeUxheW91dERvaW5nUG9zaXRp b25lZE1vdmVtZW50T25seSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgor CiAyMDEwLTAzLTI2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveC5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKaW5kZXgg OWFmMWI1Ni4uOTBhMTdhZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKQEAgLTI3MSw5ICsyNzEsOSBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHBhaW50TWFzayhQYWludEluZm8mLCBpbnQgdHgs IGludCB0eSk7CiAgICAgdmlydHVhbCB2b2lkIGltYWdlQ2hhbmdlZChXcmFwcGVkSW1hZ2VQdHIs IGNvbnN0IEludFJlY3QqID0gMCk7CiAKLSAgICAvLyBDYWxsZWQgd2hlbiBhIHBvc2l0aW9uZWQg b2JqZWN0IG1vdmVzIGJ1dCBkb2Vzbid0IGNoYW5nZSBzaXplLiAgQSBzaW1wbGlmaWVkIGxheW91 dCBpcyBkb25lCi0gICAgLy8gdGhhdCBqdXN0IHVwZGF0ZXMgdGhlIG9iamVjdCdzIHBvc2l0aW9u LgotICAgIHZpcnR1YWwgdm9pZCB0cnlMYXlvdXREb2luZ1Bvc2l0aW9uZWRNb3ZlbWVudE9ubHko KQorICAgIC8vIENhbGxlZCB3aGVuIGEgcG9zaXRpb25lZCBvYmplY3QgbW92ZXMgYnV0IGRvZXNu J3QgbmVjZXNzYXJpbHkgY2hhbmdlIHNpemUuICBBIHNpbXBsaWZpZWQgbGF5b3V0IGlzIGF0dGVt cHRlZAorICAgIC8vIHRoYXQganVzdCB1cGRhdGVzIHRoZSBvYmplY3QncyBwb3NpdGlvbi4gSWYg dGhlIHNpemUgZG9lcyBjaGFuZ2UsIHRoZSBvYmplY3QgcmVtYWlucyBkaXJ0eS4KKyAgICB2b2lk IHRyeUxheW91dERvaW5nUG9zaXRpb25lZE1vdmVtZW50T25seSgpCiAgICAgewogICAgICAgICBp bnQgb2xkV2lkdGggPSB3aWR0aCgpOwogICAgICAgICBjYWxjV2lkdGgoKTsKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmgKaW5kZXggNmUyMGMxZS4uYWE3NjQ2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmgKQEAgLTUxNSwxMCArNTE1LDYgQEAgcHVibGljOgogCiAgICAgLyogVGhpcyBmdW5jdGlv biBwZXJmb3JtcyBhIGxheW91dCBvbmx5IGlmIG9uZSBpcyBuZWVkZWQuICovCiAgICAgdm9pZCBs YXlvdXRJZk5lZWRlZCgpIHsgaWYgKG5lZWRzTGF5b3V0KCkpIGxheW91dCgpOyB9Ci0KLSAgICAv LyBDYWxsZWQgd2hlbiBhIHBvc2l0aW9uZWQgb2JqZWN0IG1vdmVzIGJ1dCBkb2Vzbid0IG5lY2Vz c2FyaWx5IGNoYW5nZSBzaXplLiAgQSBzaW1wbGlmaWVkIGxheW91dCBpcyBhdHRlbXB0ZWQKLSAg ICAvLyB0aGF0IGp1c3QgdXBkYXRlcyB0aGUgb2JqZWN0J3MgcG9zaXRpb24uIElmIHRoZSBzaXpl IGRvZXMgY2hhbmdlLCB0aGUgb2JqZWN0IHJlbWFpbnMgZGlydHkuCi0gICAgdmlydHVhbCB2b2lk IHRyeUxheW91dERvaW5nUG9zaXRpb25lZE1vdmVtZW50T25seSgpIHsgfQogICAgIAogICAgIC8v IHVzZWQgZm9yIGVsZW1lbnQgc3RhdGUgdXBkYXRlcyB0aGF0IGNhbm5vdCBiZSBmaXhlZCB3aXRo IGEKICAgICAvLyByZXBhaW50IGFuZCBkbyBub3QgbmVlZCBhIHJlbGF5b3V0Cg==