36803 2010-03-29 21:02:45 -0700 'Inline-table' workaround for <ruby> broken with ruby support 2010-03-31 21:14:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P1 Major --- 1 rolandsteiner rolandsteiner commit-queue oldest_to_newest 205830 0 rolandsteiner 2010-03-29 21:02:45 -0700 As described in the Chromium bug comment at http://code.google.com/p/chromium/issues/detail?id=27659#c3 it seems that the ruby support as implemented broke the CSS 'inline-table' workaround for ruby used by some sites (e.g., http://grammar.nihongoresources.com). 205844 1 52003 rolandsteiner 2010-03-29 22:08:24 -0700 Created attachment 52003 patch - use ruby rendering only if 'display' hasn't been altered Patch: Instantiate ruby renderers only if 'display' value is either 'inline' or 'block'. Don't use ruby renderers for other display values such as 'inline-table'. 206392 2 52003 commit-queue 2010-03-31 00:32:20 -0700 Comment on attachment 52003 patch - use ruby rendering only if 'display' hasn't been altered Rejecting patch 52003 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 2 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/ruby/ruby-inline-table.html patching file LayoutTests/platform/mac/fast/ruby/ruby-inline-table-expected.checksum patch: **** Only garbage was found in the patch input. patching file LayoutTests/platform/mac/fast/ruby/ruby-inline-table-expected.txt patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/rendering/RenderObject.cpp Full output: http://webkit-commit-queue.appspot.com/results/1581103 206941 3 rolandsteiner 2010-03-31 21:14:21 -0700 Landed as rev. 56890. 52003 2010-03-29 22:08:24 -0700 2010-03-31 00:32:20 -0700 patch - use ruby rendering only if 'display' hasn't been altered rubystyle.patch text/plain 7293 rolandsteiner ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMTQ3M2M4Li41YTdhYjUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMt MjkgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDM2ODAzIC0gJ0lu bGluZS10YWJsZScgd29ya2Fyb3VuZCBmb3IgPHJ1Ynk+IGJyb2tlbiB3aXRoIHJ1Ynkgc3VwcG9y dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY4MDMK KyAgICAgICAgCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCB0byBjb25maXJtIHRoYXQgJ2lubGlu ZS10YWJsZScgcmVuZGVyaW5nIGlzIG5vdCBhZmZlY3RlZAorICAgICAgICBieSBydWJ5IGltcGxl bWVudGF0aW9uLgorCisgICAgICAgICogZmFzdC9ydWJ5L3J1YnktaW5saW5lLXRhYmxlLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3J1YnkvcnVieS1pbmxpbmUtdGFi bGUtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0 L3J1YnkvcnVieS1pbmxpbmUtdGFibGUtZXhwZWN0ZWQucG5nOiBBZGRlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvZmFzdC9ydWJ5L3J1YnktaW5saW5lLXRhYmxlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisKIDIwMTAtMDMtMjggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+ CiAKICAgICAgICAgW0dUS10gSW1wcm92ZSByZXBvcnRpbmcgb2YgZnJhbWUgbG9hZGVyIGNhbGxi YWNrcyBpbiBEUlQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcnVieS9ydWJ5LWlubGlu ZS10YWJsZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ydWJ5L3J1YnktaW5saW5lLXRhYmxlLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2M3M2FkMAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcnVieS9ydWJ5LWlubGluZS10YWJsZS5odG1sCkBA IC0wLDAgKzEsMjYgQEAKK++7vzxoZWFkPgorCTxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CisJCS5i ZyB7IGJhY2tncm91bmQtY29sb3I6ICNGRkQ7IGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyBwYWRk aW5nOiAwLjVlbTsgbWFyZ2luOiAwLjJlbTsgfQorCisJCS8qIGNsYXNzZXMgKi8KKwkJLnJ1Ynkg eyBkaXNwbGF5OiBpbmxpbmUtdGFibGU7IHRleHQtYWxpZ246IGNlbnRlcjsgdmVydGljYWwtYWxp Z246IGJvdHRvbTsgfQorCQkucmIgeyBkaXNwbGF5OiB0YWJsZS1yb3ctZ3JvdXA7IH0KKwkJLnJ0 IHsgZGlzcGxheTogdGFibGUtaGVhZGVyLWdyb3VwOyBmb250LXNpemU6IDYwJTsgfQorCQkucnAg eyBkaXNwbGF5OiBub25lOyB9CisKKwkJLyogZWxlbWVudHMgKi8KKwkJcnVieSB7IGRpc3BsYXk6 IGlubGluZS10YWJsZTsgdGV4dC1hbGlnbjogY2VudGVyOyB2ZXJ0aWNhbC1hbGlnbjogYm90dG9t OyB9CisJCXJiIHsgZGlzcGxheTogdGFibGUtcm93LWdyb3VwOyB9CisJCXJ0IHsgZGlzcGxheTog dGFibGUtaGVhZGVyLWdyb3VwOyBmb250LXNpemU6IDYwJTsgfQorCQlycCB7IGRpc3BsYXk6IG5v bmU7IH0KKwk8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CitUZXN0IHRoYXQgJmx0O3J1YnkmZ3Q7 IHJlbmRlcmVkIGFzIGlubGluZS10YWJsZSAob3Igc29tZXN1Y2gpIGlzIG5vdCBhZmZlY3RlZCBi eSBydWJ5IHJlbmRlcmluZy4KK0JvdGggJmx0O2RpdiZndDsgYmVsb3cgc2hvdWxkIGxvb2sgdGhl IHNhbWUuIAorPGJyPgorPGJyPgorPGRpdiBjbGFzcz0iYmciPlRoaXMgaXMgc29tZSBYSFRNTDEu MSB0ZXh0IHdpdGggPHNwYW4gY2xhc3M9InJ1YnkiPjxzcGFuIGNsYXNzPSJyYiI+UnVieTwvc3Bh bj48c3BhbiBjbGFzcz0icnAiPig8L3NwYW4+PHNwYW4gY2xhc3M9InJ0Ij5ndWlkZSB0ZXh0PC9z cGFuPjxzcGFuIGNsYXNzPSJycCI+KTwvc3Bhbj48L3NwYW4+IG1hcmt1cC48L2Rpdj4KKzxicj4K KzxkaXYgY2xhc3M9ImJnIj5UaGlzIGlzIHNvbWUgWEhUTUwxLjEgdGV4dCB3aXRoIDxydWJ5Pjxy Yj5SdWJ5PC9yYj48cnA+KDwvcnA+PHJ0Pmd1aWRlIHRleHQ8L3J0PjxycD4pPC9ycD48L3J1Ynk+ IG1hcmt1cC48L2Rpdj4KKzwvYm9keT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9mYXN0L3J1YnkvcnVieS1pbmxpbmUtdGFibGUtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ydWJ5L3J1YnktaW5saW5lLXRhYmxlLWV4cGVjdGVk LmNoZWNrc3VtCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmI0OTJkMzUKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ydWJ5L3J1Ynkt aW5saW5lLXRhYmxlLWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0wLDAgKzEgQEAKK2NjOTkxYmU3Mjgw MGJiMGEwMGZmY2FmYWQ2NmRmNzJlClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcnVieS9ydWJ5LWlubGluZS10YWJs ZS1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ydWJ5L3J1Ynkt aW5saW5lLXRhYmxlLWV4cGVjdGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi5iOWUxNDgzCkJpbmFyeSBmaWxlcyAvZGV2L251bGwgYW5kIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2Zhc3QvcnVieS9ydWJ5LWlubGluZS10YWJsZS1leHBlY3RlZC5wbmcgZGlmZmVy CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ydWJ5L3J1YnktaW5s aW5lLXRhYmxlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3J1 YnkvcnVieS1pbmxpbmUtdGFibGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLmQwOWU0ZTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZmFzdC9ydWJ5L3J1YnktaW5saW5lLXRhYmxlLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDQ1IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAo MCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJC bG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0g YXQgKDgsOCkgc2l6ZSA3ODR4NTg0CisgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAo MCwwKSBzaXplIDc4NHg1NAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6 ZSA3ODJ4MzYKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA3ODI6ICJUZXN0IHRo YXQgPHJ1Ynk+IHJlbmRlcmVkIGFzIGlubGluZS10YWJsZSAob3Igc29tZXN1Y2gpIGlzIG5vdCBh ZmZlY3RlZCBieSBydWJ5IHJlbmRlcmluZy4gQm90aCA8ZGl2PiBiZWxvdyBzaG91bGQgbG9vayB0 aGUiCisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMTgpIHdpZHRoIDQwOiAic2FtZS4gIgorICAg ICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgwLDApIHNpemUgMHgwCisgICAgICAgIFJlbmRlckJSIHtC Un0gYXQgKDAsMzYpIHNpemUgMHgxOAorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDMsNTcp IHNpemUgNzc4eDQ5IFtiZ2NvbG9yPSNGRkZGRERdIFtib3JkZXI6ICgxcHggc29saWQgIzAwMDAw MCldCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoOSwyMikgc2l6ZSAyMjR4MTgKKyAg ICAgICAgICB0ZXh0IHJ1biBhdCAoOSwyMikgd2lkdGggMjI0OiAiVGhpcyBpcyBzb21lIFhIVE1M MS4xIHRleHQgd2l0aCAiCisgICAgICAgIFJlbmRlclRhYmxlIHtTUEFOfSBhdCAoMjMzLDkpIHNp emUgNDB4MzEKKyAgICAgICAgICBSZW5kZXJUYWJsZVNlY3Rpb24ge1NQQU59IGF0ICgwLDEzKSBz aXplIDQweDE4CisgICAgICAgICAgICBSZW5kZXJUYWJsZVJvdyAoYW5vbnltb3VzKSBhdCAoMCww KSBzaXplIDQweDE4CisgICAgICAgICAgICAgIFJlbmRlclRhYmxlQ2VsbCAoYW5vbnltb3VzKSBh dCAoMCwwKSBzaXplIDQweDE4IFtyPTAgYz0wIHJzPTEgY3M9MV0KKyAgICAgICAgICAgICAgICBS ZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDIsMCkgc2l6ZSAzNXgxOAorICAgICAgICAgICAgICAgICAg dGV4dCBydW4gYXQgKDIsMCkgd2lkdGggMzU6ICJSdWJ5IgorICAgICAgICAgIFJlbmRlclRhYmxl U2VjdGlvbiB7U1BBTn0gYXQgKDAsMCkgc2l6ZSA0MHgxMworICAgICAgICAgICAgUmVuZGVyVGFi bGVSb3cgKGFub255bW91cykgYXQgKDAsMCkgc2l6ZSA0MHgxMworICAgICAgICAgICAgICBSZW5k ZXJUYWJsZUNlbGwgKGFub255bW91cykgYXQgKDAsMCkgc2l6ZSA0MHgxMyBbcj0wIGM9MCBycz0x IGNzPTFdCisgICAgICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUg NDB4MTMKKyAgICAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDQwOiAiZ3Vp ZGUgdGV4dCIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgyNzMsMjIpIHNpemUgNTZ4 MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMjczLDIyKSB3aWR0aCA1NjogIiBtYXJrdXAuIgor ICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91cykgYXQgKDAsMTA5KSBzaXplIDc4NHgxOAorICAg ICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgwLDApIHNpemUgMHgxOAorICAgICAgUmVuZGVyQmxvY2sg e0RJVn0gYXQgKDMsMTMwKSBzaXplIDc3OHg0OSBbYmdjb2xvcj0jRkZGRkREXSBbYm9yZGVyOiAo MXB4IHNvbGlkICMwMDAwMDApXQorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDksMjIp IHNpemUgMjI0eDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDksMjIpIHdpZHRoIDIyNDogIlRo aXMgaXMgc29tZSBYSFRNTDEuMSB0ZXh0IHdpdGggIgorICAgICAgICBSZW5kZXJUYWJsZSB7UlVC WX0gYXQgKDIzMyw5KSBzaXplIDQweDMxCisgICAgICAgICAgUmVuZGVyVGFibGVTZWN0aW9uIHtS Qn0gYXQgKDAsMTMpIHNpemUgNDB4MTgKKyAgICAgICAgICAgIFJlbmRlclRhYmxlUm93IChhbm9u eW1vdXMpIGF0ICgwLDApIHNpemUgNDB4MTgKKyAgICAgICAgICAgICAgUmVuZGVyVGFibGVDZWxs IChhbm9ueW1vdXMpIGF0ICgwLDApIHNpemUgNDB4MTggW3I9MCBjPTAgcnM9MSBjcz0xXQorICAg ICAgICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMiwwKSBzaXplIDM1eDE4CisgICAg ICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMiwwKSB3aWR0aCAzNTogIlJ1YnkiCisgICAgICAg ICAgUmVuZGVyVGFibGVTZWN0aW9uIHtSVH0gYXQgKDAsMCkgc2l6ZSA0MHgxMworICAgICAgICAg ICAgUmVuZGVyVGFibGVSb3cgKGFub255bW91cykgYXQgKDAsMCkgc2l6ZSA0MHgxMworICAgICAg ICAgICAgICBSZW5kZXJUYWJsZUNlbGwgKGFub255bW91cykgYXQgKDAsMCkgc2l6ZSA0MHgxMyBb cj0wIGM9MCBycz0xIGNzPTFdCisgICAgICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDApIHNpemUgNDB4MTMKKyAgICAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdp ZHRoIDQwOiAiZ3VpZGUgdGV4dCIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgyNzMs MjIpIHNpemUgNTZ4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMjczLDIyKSB3aWR0aCA1Njog IiBtYXJrdXAuIgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBjYWJmZjFkLi4xNDk0MzI1IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTAzLTI5ICBS b2xhbmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAzNjgwMyAtICdJbmxpbmUt dGFibGUnIHdvcmthcm91bmQgZm9yIDxydWJ5PiBicm9rZW4gd2l0aCBydWJ5IHN1cHBvcnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2ODAzCisKKyAg ICAgICAgRG9uJ3QgdXNlIHJ1YnkgcmVuZGVyaW5nIGlmIHRoZSB1bmRlcmx5aW5nICdkaXNwbGF5 JyBwcm9wZXJ0eSBoYXMgYmVlbgorICAgICAgICBjaGFuZ2VkIGludG8gYSB2YWx1ZSBvdGhlciB0 aGFuICdpbmxpbmUnIG9yICdibG9jaycgKHN1Y2ggYXMgJ2lubGluZS10YWJsZScpLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvcnVieS9ydWJ5LWlubGluZS10YWJsZS5odG1sCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVj dDo6Y3JlYXRlT2JqZWN0KToKKwogMjAxMC0wMy0yOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFw QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdC5jcHAKaW5kZXggODIxMmRjYS4uMzIzODNmNyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCkBAIC0xMTYsNyArMTE2LDcgQEAgUmVuZGVyT2JqZWN0KiBSZW5kZXJP YmplY3Q6OmNyZWF0ZU9iamVjdChOb2RlKiBub2RlLCBSZW5kZXJTdHlsZSogc3R5bGUpCiAgICAg aWYgKG5vZGUtPmhhc1RhZ05hbWUocnVieVRhZykpIHsKICAgICAgICAgaWYgKHN0eWxlLT5kaXNw bGF5KCkgPT0gSU5MSU5FKQogICAgICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlclJ1 YnlBc0lubGluZShub2RlKTsKLSAgICAgICAgZWxzZQorICAgICAgICBlbHNlIGlmIChzdHlsZS0+ ZGlzcGxheSgpID09IEJMT0NLKQogICAgICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRl clJ1YnlBc0Jsb2NrKG5vZGUpOwogICAgIH0KICAgICAvLyB0cmVhdCA8cnQ+IGFzIHJ1YnkgdGV4 dCBPTkxZIGlmIGl0IHN0aWxsIGhhcyBpdHMgZGVmYXVsdCB0cmVhdG1lbnQgb2YgYmxvY2sK