36792 2010-03-29 16:25:39 -0700 ValidateReviewer step is draconian and un-tested 2010-03-29 16:34:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 205730 0 eric 2010-03-29 16:25:39 -0700 ValidateReviewer step is draconian and un-tested 205731 1 51981 eric 2010-03-29 16:28:07 -0700 Created attachment 51981 Patch 205732 2 51981 abarth 2010-03-29 16:29:02 -0700 Comment on attachment 51981 Patch Power to the people 205733 3 51981 eric 2010-03-29 16:34:13 -0700 Comment on attachment 51981 Patch Clearing flags on attachment: 51981 Committed r56748: <http://trac.webkit.org/changeset/56748> 205734 4 eric 2010-03-29 16:34:18 -0700 All reviewed patches have been landed. Closing bug. 51981 2010-03-29 16:28:07 -0700 2010-03-29 16:34:13 -0700 Patch bug-36792-20100329162806.patch text/plain 6810 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyYzVhODQ1Li43MGI4M2U5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDMt MjkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZhbGlkYXRlUmV2aWV3ZXIgc3RlcCBpcyBkcmFj b25pYW4gYW5kIHVuLXRlc3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzY3OTIKKworICAgICAgICBWYWxpZGF0ZVJldmlld2VyIGxvZ2ljIHdhcyBj b21tZW50ZWQgb3V0IGluCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0 LzU2NzQ0CisgICAgICAgIFRoYXQgd2FzIGEgc3ltcHRvbSBvZiB0aGUgZmFjdCB0aGF0IHZhbGlk YXRlcmV2aWV3ZXIucHkKKyAgICAgICAgaXMgdG9vIGluZmxleGlibGUgdG8gYmUgdXNlZCB3aGVu IHJlYWwgaHVtYW5zIGFyZSBkcml2aW5nIHdlYmtpdC1wYXRjaC4KKyAgICAgICAgRm9yIG5vdyB3 ZSBqdXN0IGRpc2FibGUgVmFsaWRhdGVSZXZpZXdlciB3aGVuIGh1bWFucyBhcmUgYXQgdGhlIGtl eWJvYXJkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ZhbGlkYXRl cmV2aWV3ZXIucHk6CisgICAgICAgICAtIE9ubHkgcnVuIHdoZW4gaW4gbm9uLWludGVyYWN0aXZl IG1vZGUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ZhbGlkYXRlcmV2 aWV3ZXJfdW5pdHRlc3QucHk6IEFkZGVkLgorICAgICAgICAgLSBUZXN0IG91ciB2YWxpZGF0aW9u IGxvZ2ljIHRvIG1ha2Ugc3VyZSBpdCdzIHNhbmUuCisKIDIwMTAtMDMtMjkgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBH bGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0 ZXBzL3ZhbGlkYXRlcmV2aWV3ZXIucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc3RlcHMvdmFsaWRhdGVyZXZpZXdlci5weQppbmRleCAxYTBhZWU5Li42OTA4MjUyIDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvdmFsaWRhdGVy ZXZpZXdlci5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMv dmFsaWRhdGVyZXZpZXdlci5weQpAQCAtMzQsMjAgKzM0LDMxIEBAIGZyb20gd2Via2l0cHkudG9v bC5zdGVwcy5hYnN0cmFjdHN0ZXAgaW1wb3J0IEFic3RyYWN0U3RlcAogZnJvbSB3ZWJraXRweS5j b21tb24uc3lzdGVtLmRlcHJlY2F0ZWRfbG9nZ2luZyBpbXBvcnQgZXJyb3IKIAogCisjIEZJWE1F OiBTb21lIG9mIHRoaXMgbG9naWMgc2hvdWxkIHByb2JhYmx5IGJlIHVuaWZpZWQgd2l0aCBDb21t aXR0ZXJWYWxpZGF0b3I/CiBjbGFzcyBWYWxpZGF0ZVJldmlld2VyKEFic3RyYWN0U3RlcCk6Cisg ICAgIyBGSVhNRTogVGhpcyBzaG91bGQgcHJvYmFibHkgbW92ZSBvbnRvIENoYW5nZUxvZ0VudHJ5 CisgICAgZGVmIF9oYXNfdmFsaWRfcmV2aWV3ZXIoc2VsZiwgY2hhbmdlbG9nX2VudHJ5KToKKyAg ICAgICAgaWYgY2hhbmdlbG9nX2VudHJ5LnJldmlld2VyKCk6CisgICAgICAgICAgICByZXR1cm4g VHJ1ZQorICAgICAgICBpZiByZS5zZWFyY2goInVucmV2aWV3ZWQiLCBjaGFuZ2Vsb2dfZW50cnku Y29udGVudHMoKSwgcmUuSUdOT1JFQ0FTRSk6CisgICAgICAgICAgICByZXR1cm4gVHJ1ZQorICAg ICAgICBpZiByZS5zZWFyY2goInJ1YmJlclsgLV1zdGFtcCIsIGNoYW5nZWxvZ19lbnRyeS5jb250 ZW50cygpLCByZS5JR05PUkVDQVNFKToKKyAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAg IHJldHVybiBGYWxzZQorCiAgICAgZGVmIHJ1bihzZWxmLCBzdGF0ZSk6CisgICAgICAgICMgRklY TUU6IEZvciBub3cgd2UgZGlzYWJsZSB0aGlzIGNoZWNrIHdoZW4gYSB1c2VyIGlzIGRyaXZpbmcg dGhlIHNjcmlwdAorICAgICAgICAjIHRoaXMgY2hlY2sgaXMgdG9vIGRyYWNvbmlhbiAoYW5kIHRv byBwb29ybHkgdGVzdGVkKSB0byBmb2lzdCB1cG9uIHVzZXJzLgorICAgICAgICBpZiBub3Qgc2Vs Zi5fb3B0aW9ucy5ub25faW50ZXJhY3RpdmU6CisgICAgICAgICAgICByZXR1cm4KICAgICAgICAg IyBGSVhNRTogV2Ugc2hvdWxkIGZpZ3VyZSBvdXQgaG93IHRvIGhhbmRsZSB0aGUgY3VycmVudCB3 b3JraW5nCiAgICAgICAgICMgICAgICAgIGRpcmVjdG9yeSBpc3N1ZSBtb3JlIGdsb2JhbGx5Lgog ICAgICAgICBvcy5jaGRpcihzZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpCiAgICAgICAg IGZvciBjaGFuZ2Vsb2dfcGF0aCBpbiBzZWxmLl90b29sLmNoZWNrb3V0KCkubW9kaWZpZWRfY2hh bmdlbG9ncygpOgogICAgICAgICAgICAgY2hhbmdlbG9nX2VudHJ5ID0gQ2hhbmdlTG9nKGNoYW5n ZWxvZ19wYXRoKS5sYXRlc3RfZW50cnkoKQotICAgICAgICAgICAgaWYgY2hhbmdlbG9nX2VudHJ5 LnJldmlld2VyKCk6Ci0gICAgICAgICAgICAgICAgY29udGludWUKLSAgICAgICAgICAgIGlmIHJl LnNlYXJjaCgidW5yZXZpZXdlZCIsIGNoYW5nZWxvZ19lbnRyeS5jb250ZW50cygpLCByZS5JR05P UkVDQVNFKToKLSAgICAgICAgICAgICAgICBjb250aW51ZQotICAgICAgICAgICAgaWYgcmUuc2Vh cmNoKCJydWJiZXJbIC1dc3RhbXAiLCBjaGFuZ2Vsb2dfZW50cnkuY29udGVudHMoKSwgcmUuSUdO T1JFQ0FTRSk6CisgICAgICAgICAgICBpZiBzZWxmLl9oYXNfdmFsaWRfcmV2aWV3ZXIoY2hhbmdl bG9nX2VudHJ5KToKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAgcmV2aWV3 ZXJfdGV4dCA9IGNoYW5nZWxvZ19lbnRyeS5yZXZpZXdlcl90ZXh0KCkKLSMgICAgICAgICAgICBp ZiByZXZpZXdlcl90ZXh0OgotIyAgICAgICAgICAgICAgICBsb2coIiVzIGRvZXMgbm90IGFwcGVh ciB0byBiZSBhIHZhbGlkIHJldmlld2VyIGFjY29yZGluZyB0byBjb21taXR0ZXJzLnB5LiIpCi0j ICAgICAgICAgICAgZXJyb3IoJyVzIG5laXRoZXIgbGlzdHMgYSB2YWxpZCByZXZpZXdlciBub3Ig Y29udGFpbnMgdGhlIHN0cmluZyAiVW5yZXZpZXdlZCIgb3IgIlJ1YmJlciBzdGFtcCIgKGNhc2Ug aW5zZW5zaXRpdmUpLicgJSBjaGFuZ2Vsb2dfcGF0aCkKKyAgICAgICAgICAgIGlmIHJldmlld2Vy X3RleHQ6CisgICAgICAgICAgICAgICAgbG9nKCIlcyBmb3VuZCBpbiAlcyBkb2VzIG5vdCBhcHBl YXIgdG8gYmUgYSB2YWxpZCByZXZpZXdlciBhY2NvcmRpbmcgdG8gY29tbWl0dGVycy5weS4iICUg KHJldmlld2VyX3RleHQsIGNoYW5nZWxvZ19wYXRoKSkKKyAgICAgICAgICAgIGVycm9yKCclcyBu ZWl0aGVyIGxpc3RzIGEgdmFsaWQgcmV2aWV3ZXIgbm9yIGNvbnRhaW5zIHRoZSBzdHJpbmcgIlVu cmV2aWV3ZWQiIG9yICJSdWJiZXIgc3RhbXAiIChjYXNlIGluc2Vuc2l0aXZlKS4nICUgY2hhbmdl bG9nX3BhdGgpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvdmFsaWRhdGVyZXZpZXdlcl91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9zdGVwcy92YWxpZGF0ZXJldmlld2VyX3VuaXR0ZXN0LnB5Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmNhMjIwMTgKLS0tIC9kZXYvbnVsbAorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvdmFsaWRhdGVyZXZpZXdlcl91 bml0dGVzdC5weQpAQCAtMCwwICsxLDU4IEBACisjIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGlu IHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9u LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFy ZQorIyBtZXQ6CisjCisjICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3Qg cmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAgICAqIFJlZGlzdHJpYnV0aW9u cyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l cgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVk IHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdv b2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisjIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNl ZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisjIHRoaXMgc29m dHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisjCisjIFRI SVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05U UklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElF UyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxBUiBQVVJQ T1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisjIE9X TkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJ TkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdF UyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNU SVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQUk9GSVRT OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMg VEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElU WSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5H IElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1wb3J0IHVuaXR0 ZXN0CisKK2Zyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0LmNoYW5nZWxvZyBpbXBvcnQgQ2hh bmdlTG9nRW50cnkKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGlt cG9ydCBPdXRwdXRDYXB0dXJlCitmcm9tIHdlYmtpdHB5LnRvb2wubW9ja3Rvb2wgaW1wb3J0IE1v Y2tUb29sCitmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHNfcmVmZXJlbmNlcyBpbXBvcnQgTW9jawor ZnJvbSB3ZWJraXRweS50b29sLnN0ZXBzLnZhbGlkYXRlcmV2aWV3ZXIgaW1wb3J0IFZhbGlkYXRl UmV2aWV3ZXIKKworY2xhc3MgVmFsaWRhdGVSZXZpZXdlclRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgorICAgIF9ib2lsZXJwbGF0ZV9lbnRyeSA9ICcnJzIwMDktMDgtMTkgIEVyaWMgU2VpZGVsICA8 ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJFVklFV19MSU5FCisKKyAgICAgICAgKiBTY3Jp cHRzL2J1Z3ppbGxhLXRvb2w6CisnJycKKworICAgIGRlZiBfdGVzdF9yZXZpZXdfdGV4dChzZWxm LCBzdGVwLCB0ZXh0LCBleHBlY3RlZCk6CisgICAgICAgIGNvbnRlbnRzID0gc2VsZi5fYm9pbGVy cGxhdGVfZW50cnkucmVwbGFjZSgiUkVWSUVXX0xJTkUiLCB0ZXh0KQorICAgICAgICBlbnRyeSA9 IENoYW5nZUxvZ0VudHJ5KGNvbnRlbnRzKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHN0ZXAu X2hhc192YWxpZF9yZXZpZXdlcihlbnRyeSksIGV4cGVjdGVkKQorCisgICAgZGVmIHRlc3RfaGFz X3ZhbGlkX3Jldmlld2VyKHNlbGYpOgorICAgICAgICBzdGVwID0gVmFsaWRhdGVSZXZpZXdlcihN b2NrVG9vbCgpLCBNb2NrKCkpCisgICAgICAgIHNlbGYuX3Rlc3RfcmV2aWV3X3RleHQoc3RlcCwg IlJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLiIsIFRydWUpCisgICAgICAgIHNlbGYuX3Rlc3RfcmV2 aWV3X3RleHQoc3RlcCwgIlJldmlld2VkIGJ5IEVyaWMgU2VpZGVsIiwgVHJ1ZSkgIyBOb3QgcGlj a3kgYWJvdXQgdGhlICcuJworICAgICAgICBzZWxmLl90ZXN0X3Jldmlld190ZXh0KHN0ZXAsICJS ZXZpZXdlZCBieSBFcmljLiIsIEZhbHNlKQorICAgICAgICBzZWxmLl90ZXN0X3Jldmlld190ZXh0 KHN0ZXAsICJSZXZpZXdlZCBieSBFcmljIEMgU2VpZGVsLiIsIEZhbHNlKQorICAgICAgICBzZWxm Ll90ZXN0X3Jldmlld190ZXh0KHN0ZXAsICJSdWJiZXItc3RhbXBlZCBieSBFcmljLiIsIFRydWUp CisgICAgICAgIHNlbGYuX3Rlc3RfcmV2aWV3X3RleHQoc3RlcCwgIlJ1YmJlciBzdGFtcGVkIGJ5 IEVyaWMuIiwgVHJ1ZSkKKyAgICAgICAgc2VsZi5fdGVzdF9yZXZpZXdfdGV4dChzdGVwLCAiVW5y ZXZpZXdlZCBidWlsZCBmaXguIiwgVHJ1ZSkK