36791 2010-03-29 16:12:26 -0700 Add assertions for instance proxy validity 2010-03-30 10:10:03 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 205724 0 ap 2010-03-29 16:12:26 -0700 Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw pointer to one across complicated function calls, relying on the caller to protect the reference. 205725 1 51979 ap 2010-03-29 16:13:58 -0700 Created attachment 51979 proposed patch 205726 2 webkit.review.bot 2010-03-29 16:15:46 -0700 Attachment 51979 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:75: More than one command on the same line [whitespace/newline] [4] WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:81: More than one command on the same line [whitespace/newline] [4] WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:82: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 206051 3 ap 2010-03-30 10:10:03 -0700 Committed revision 56797. 51979 2010-03-29 16:13:58 -0700 2010-03-29 17:36:19 -0700 proposed patch ProxyValidity.txt text/plain 2256 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjcyNSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMtMjkgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzkxCisg ICAgICAgIEFkZCBhc3NlcnRpb25zIGZvciBpbnN0YW5jZSBwcm94eSB2YWxpZGl0eQorCisgICAg ICAgIEFkZCBzb21lIGFzc2VydGlvbnMgdGhhdCB0aGUgaW5zdGFuY2UgcHJveHkgaGFzbid0IGJl ZW4gZGVsZXRlZC4gV2Ugc29tZXRpbWVzIGtlZXAgYSByYXcKKyAgICAgICAgcG9pbnRlciB0byBv bmUgYWNyb3NzIGNvbXBsaWNhdGVkIGZ1bmN0aW9uIGNhbGxzLCByZWx5aW5nIG9uIHRoZSBjYWxs ZXIgdG8gcHJvdGVjdCB0aGUKKyAgICAgICAgcmVmZXJlbmNlLgorCisgICAgICAgICogUGx1Z2lu cy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6 Ok5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6cmVuZGVyQ29udGV4dElEKToKKyAgICAgICAg KFdlYktpdDo6TmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5OjpwbHVnaW5WaWV3KToKKyAgICAg ICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5Ojpob3N0UHJveHkpOgorCiAy MDEwLTAzLTI2ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KSW5kZXg6IFdlYktpdC9t YWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJv eHkuaAkocmV2aXNpb24gNTY3MjUpCisrKyBXZWJLaXQvbWFjL1BsdWdpbnMvSG9zdGVkL05ldHNj YXBlUGx1Z2luSW5zdGFuY2VQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC03MiwxNCArNzIsMTQg QEAgcHVibGljOgogICAgICAgICAKICAgICAgICAgcmV0dXJuIG1fcGx1Z2luSUQ7CiAgICAgfQot ICAgIHVpbnQzMl90IHJlbmRlckNvbnRleHRJRCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVuZGVyQ29u dGV4dElEOyB9CisgICAgdWludDMyX3QgcmVuZGVyQ29udGV4dElEKCkgY29uc3QgeyBBU1NFUlQo ZmFzdE1hbGxvY1NpemUodGhpcykpOyByZXR1cm4gbV9yZW5kZXJDb250ZXh0SUQ7IH0KICAgICB2 b2lkIHNldFJlbmRlckNvbnRleHRJRCh1aW50MzJfdCByZW5kZXJDb250ZXh0SUQpIHsgbV9yZW5k ZXJDb250ZXh0SUQgPSByZW5kZXJDb250ZXh0SUQ7IH0KICAgICAKICAgICBib29sIHVzZVNvZnR3 YXJlUmVuZGVyZXIoKSBjb25zdCB7IHJldHVybiBtX3VzZVNvZnR3YXJlUmVuZGVyZXI7IH0KICAg ICB2b2lkIHNldFVzZVNvZnR3YXJlUmVuZGVyZXIoYm9vbCB1c2VTb2Z0d2FyZVJlbmRlcmVyKSB7 IG1fdXNlU29mdHdhcmVSZW5kZXJlciA9IHVzZVNvZnR3YXJlUmVuZGVyZXI7IH0KICAgICAKLSAg ICBXZWJIb3N0ZWROZXRzY2FwZVBsdWdpblZpZXcgKnBsdWdpblZpZXcoKSBjb25zdCB7IHJldHVy biBtX3BsdWdpblZpZXc7IH0KLSAgICBOZXRzY2FwZVBsdWdpbkhvc3RQcm94eSogaG9zdFByb3h5 KCkgY29uc3QgeyByZXR1cm4gbV9wbHVnaW5Ib3N0UHJveHk7IH0KKyAgICBXZWJIb3N0ZWROZXRz Y2FwZVBsdWdpblZpZXcgKnBsdWdpblZpZXcoKSBjb25zdCB7IEFTU0VSVChmYXN0TWFsbG9jU2l6 ZSh0aGlzKSk7IHJldHVybiBtX3BsdWdpblZpZXc7IH0KKyAgICBOZXRzY2FwZVBsdWdpbkhvc3RQ cm94eSogaG9zdFByb3h5KCkgY29uc3QgeyBBU1NFUlQoZmFzdE1hbGxvY1NpemUodGhpcykpOyBy ZXR1cm4gbV9wbHVnaW5Ib3N0UHJveHk7IH0KICAgICAKICAgICBib29sIGNhbmNlbFN0cmVhbUxv YWQodWludDMyX3Qgc3RyZWFtSUQsIE5QUmVhc29uKTsKICAgICB2b2lkIGRpc2Nvbm5lY3RTdHJl YW0oSG9zdGVkTmV0c2NhcGVQbHVnaW5TdHJlYW0qKTsK