36786 2010-03-29 15:02:57 -0700 sheriff-bot should comment on bugs when builders break 2010-03-29 18:16:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 205683 0 eric 2010-03-29 15:02:57 -0700 sheriff-bot should comment on bugs when builders break 205684 1 51969 eric 2010-03-29 15:09:26 -0700 Created attachment 51969 Patch 205685 2 51969 abarth 2010-03-29 15:12:03 -0700 Comment on attachment 51969 Patch okiedokes. You wrote a FIXME comment but didn't say FIXME! How are we supposed to grep for things to do? 205783 3 51969 eric 2010-03-29 18:16:00 -0700 Comment on attachment 51969 Patch Clearing flags on attachment: 51969 Committed r56755: <http://trac.webkit.org/changeset/56755> 205784 4 eric 2010-03-29 18:16:05 -0700 All reviewed patches have been landed. Closing bug. 51969 2010-03-29 15:09:26 -0700 2010-03-29 18:16:00 -0700 Patch bug-36786-20100329150924.patch text/plain 5363 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMmEzNjMzLi5jZjQ3NDU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt MjkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNoZXJpZmYtYm90IHNob3VsZCBjb21tZW50IG9u IGJ1Z3Mgd2hlbiBidWlsZGVycyBicmVhaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzY3ODYKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9zaGVyaWZmYm90LnB5OgorICAgICAgICAgLSBBZGQgYSBuZXcgX3Bvc3RfYmxh bWVfY29tbWVudF90b19idWcgYW5kIGFsbCBpdCBmcm9tIHByb2Nlc3Nfd29ya19pdGVtCisgICAg ICAgICAtIE1vdmUgY29tbWl0LXF1ZXVlIGxvZ2ljIGludG8gX3Bvc3Rfcm9sbG91dF9wYXRjaCB0 byBtYWtlIGl0cyBhcGkgbWF0Y2ggdGhlIG90aGVyIF9wb3N0IGNvbW1hbmRzLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zaGVyaWZmYm90X3VuaXR0ZXN0LnB5Ogor ICAgICAgICAgLSBUZXN0IHRoZSBuZXcgX3Bvc3RfYmxhbWVfY29tbWVudF90b19idWcgY2FsbAor CiAyMDEwLTAzLTI5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gIFVwZGF0ZSBleHBlY3RlZCByZXN1bHRzIGZvciB1bml0IHRlc3RzLgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJp ZmZib3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hl cmlmZmJvdC5weQppbmRleCA0ZmU5MTdlLi5lMmU2Yzg0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQpAQCAt NzAsNiArNzAsNyBAQCBjbGFzcyBTaGVyaWZmQm90KEFic3RyYWN0UXVldWUpOgogICAgICAgICAj IEN1cnJlbnRseSwgd2UgZG9uJ3QgaGF2ZSBhbnkgcmVhc29ucyBub3QgdG8gcHJvY2VlZCB3aXRo IHdvcmsgaXRlbXMuCiAgICAgICAgIHJldHVybiBUcnVlCiAKKyAgICAjIF9wb3N0KiBtZXRob2Rz IHNob3VsZCBtb3ZlIG9udG8gc29tZSBuZXcgY2xhc3Mgd2hlcmUgdGhleSBjYW4gc2hhcmUgbW9y ZSBsb2dpYyBhbmQgc3RhdGUuCiAgICAgZGVmIF9wb3N0X2lyY193YXJuaW5nKHNlbGYsIGNvbW1p dF9pbmZvLCBidWlsZGVycyk6CiAgICAgICAgIGlyY19uaWNrbmFtZXMgPSBzb3J0ZWQoW3BhcnR5 LmlyY19uaWNrbmFtZSBmb3IgcGFydHkgaW4gY29tbWl0X2luZm8ucmVzcG9uc2libGVfcGFydGll cygpIGlmIHBhcnR5LmlyY19uaWNrbmFtZV0pCiAgICAgICAgIGlyY19wcmVmaXggPSAiOiAiIGlm IGlyY19uaWNrbmFtZXMgZWxzZSAiIgpAQCAtODgsMjAgKzg5LDMzIEBAIGNsYXNzIFNoZXJpZmZC b3QoQWJzdHJhY3RRdWV1ZSk6CiAgICAgICAgIGJ1aWxkZXJfbmFtZXMgPSBbYnVpbGRlci5uYW1l KCkgZm9yIGJ1aWxkZXIgaW4gYnVpbGRlcnNdCiAgICAgICAgIHJldHVybiAiQ2F1c2VkIGJ1aWxk ZXJzICVzIHRvIGZhaWwuIiAlIGpvaW5fd2l0aF9zZXBhcmF0b3JzKGJ1aWxkZXJfbmFtZXMpCiAK LSAgICBkZWYgX3Bvc3Rfcm9sbG91dF9wYXRjaChzZWxmLCBzdm5fcmV2aXNpb24sIHJvbGxvdXRf cmVhc29uKToKKyAgICBkZWYgX3Bvc3Rfcm9sbG91dF9wYXRjaChzZWxmLCBjb21taXRfaW5mbywg cm9sbG91dF9yZWFzb24pOgorICAgICAgICAjIEZvciBub3cgd2UncmUgb25seSBwb3N0aW5nIHJv bGxvdXQgcGF0Y2hlcyBmb3IgY29tbWl0LXF1ZXVlJ2QgcGF0Y2hlcy4KKyAgICAgICAgY29tbWl0 X2JvdF9lbWFpbCA9ICJlc2VpZGVsQGNocm9taXVtLm9yZyIKKyAgICAgICAgaWYgY29tbWl0X2Jv dF9lbWFpbCBub3QgaW4gY29tbWl0X2luZm8uY29tbWl0dGVyKCkuZW1haWxzOgorICAgICAgICAg ICAgcmV0dXJuCisKICAgICAgICAgYXJncyA9IFsKICAgICAgICAgICAgICJjcmVhdGUtcm9sbG91 dCIsCiAgICAgICAgICAgICAiLS1mb3JjZS1jbGVhbiIsCiAgICAgICAgICAgICAiLS1ub24taW50 ZXJhY3RpdmUiLAogICAgICAgICAgICAgIi0tcGFyZW50LWNvbW1hbmQ9JXMiICUgc2VsZi5uYW1l LAotICAgICAgICAgICAgc3ZuX3JldmlzaW9uLAotICAgICAgICAgICAgcm9sbG91dF9yZWFzb24s CisgICAgICAgICAgICBjb21taXRfaW5mby5yZXZpc2lvbigpLAorICAgICAgICAgICAgc2VsZi5f cm9sbG91dF9yZWFzb24oYnVpbGRlcnMpLAogICAgICAgICBdCiAgICAgICAgIHRyeToKICAgICAg ICAgICAgIHNlbGYucnVuX3dlYmtpdF9wYXRjaChhcmdzKQogICAgICAgICBleGNlcHQ6CiAgICAg ICAgICAgICBsb2coIkZhaWxlZCB0byBjcmVhdGUtcm9sbG91dC4iKQogCisgICAgZGVmIF9wb3N0 X2JsYW1lX2NvbW1lbnRfb25fYnVnKHNlbGYsIGNvbW1pdF9pbmZvLCBidWlsZGVycyk6CisgICAg ICAgIGlmIG5vdCBjb21taXRfaW5mby5idWdfaWQoKToKKyAgICAgICAgICAgIHJldHVybgorICAg ICAgICBjb21tZW50ID0gIiVzIGFwcGVhcnMgdG8gaGF2ZSBicm9rZW4gJXMiICUgKAorICAgICAg ICAgICAgdmlld19zb3VyY2VfdXJsKGNvbW1pdF9pbmZvLnJldmlzaW9uKCkpLAorICAgICAgICAg ICAgam9pbl93aXRoX3NlcGFyYXRvcnMoW2J1aWxkZXIubmFtZSgpIGZvciBidWlsZGVyIGluIGJ1 aWxkZXJzXSkpCisgICAgICAgIHNlbGYudG9vbC5idWdzLnBvc3RfY29tbWVudF90b19idWcoY29t bWl0X2luZm8uYnVnX2lkKCksIGNvbW1lbnQpCisKICAgICBkZWYgcHJvY2Vzc193b3JrX2l0ZW0o c2VsZiwgZmFpbHVyZV9pbmZvKToKICAgICAgICAgc3ZuX3JldmlzaW9uID0gZmFpbHVyZV9pbmZv WyJzdm5fcmV2aXNpb24iXQogICAgICAgICBidWlsZGVycyA9IGZhaWx1cmVfaW5mb1siYnVpbGRl cnMiXQpAQCAtMTA5LDEyICsxMjMsOCBAQCBjbGFzcyBTaGVyaWZmQm90KEFic3RyYWN0UXVldWUp OgogICAgICAgICBzZWxmLnVwZGF0ZSgpCiAgICAgICAgIGNvbW1pdF9pbmZvID0gc2VsZi50b29s LmNoZWNrb3V0KCkuY29tbWl0X2luZm9fZm9yX3JldmlzaW9uKHN2bl9yZXZpc2lvbikKICAgICAg ICAgc2VsZi5fcG9zdF9pcmNfd2FybmluZyhjb21taXRfaW5mbywgYnVpbGRlcnMpCi0KLSAgICAg ICAgIyBGb3Igbm93IHdlJ3JlIG9ubHkgcG9zdGluZyByb2xsb3V0IHBhdGNoZXMgZm9yIGNvbW1p dC1xdWV1ZSdkIHBhdGNoZXMuCi0gICAgICAgIGNvbW1pdF9ib3RfZW1haWwgPSAiZXNlaWRlbEBj aHJvbWl1bS5vcmciCi0gICAgICAgIGlmIGNvbW1pdF9ib3RfZW1haWwgaW4gY29tbWl0X2luZm8u Y29tbWl0dGVyKCkuZW1haWxzOgotICAgICAgICAgICAgcm9sbG91dF9yZWFzb24gPSBzZWxmLl9y b2xsb3V0X3JlYXNvbihidWlsZGVycykKLSAgICAgICAgICAgIHNlbGYuX3Bvc3Rfcm9sbG91dF9w YXRjaChzZWxmLCBzdm5fcmV2aXNpb24sIHJvbGxvdXRfcmVhc29uKQorICAgICAgICBzZWxmLl9w b3N0X2JsYW1lX2NvbW1lbnRfb25fYnVnKGNvbW1pdF9pbmZvLCBidWlsZGVycykKKyAgICAgICAg c2VsZi5fcG9zdF9yb2xsb3V0X3BhdGNoKGNvbW1pdF9pbmZvLCBidWlsZGVycykKIAogICAgICAg ICBmb3IgYnVpbGRlciBpbiBidWlsZGVyczoKICAgICAgICAgICAgIHNlbGYudG9vbC5zdGF0dXNf c2VydmVyLnVwZGF0ZV9zdm5fcmV2aXNpb24oc3ZuX3JldmlzaW9uLCBidWlsZGVyLm5hbWUoKSkK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9z aGVyaWZmYm90X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3NoZXJpZmZib3RfdW5pdHRlc3QucHkKaW5kZXggY2U4OTZkNy4uMDU3NjllZiAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3No ZXJpZmZib3RfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3NoZXJpZmZib3RfdW5pdHRlc3QucHkKQEAgLTI5LDYgKzI5LDcgQEAKIGlt cG9ydCBvcwogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5uZXQuYnVpbGRib3QgaW1wb3J0IEJ1aWxk ZXIKK2Zyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5tb2NrIGltcG9ydCBNb2NrCiBmcm9tIHdlYmtp dHB5LnRvb2wuY29tbWFuZHMucXVldWVzdGVzdCBpbXBvcnQgUXVldWVzVGVzdAogZnJvbSB3ZWJr aXRweS50b29sLmNvbW1hbmRzLnNoZXJpZmZib3QgaW1wb3J0IFNoZXJpZmZCb3QKIGZyb20gd2Vi a2l0cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQgTW9ja1Rvb2wsIG1vY2tfYnVpbGRlcgpAQCAtNTUs MyArNTYsMTkgQEAgY2xhc3MgU2hlcmlmZkJvdFRlc3QoUXVldWVzVGVzdCk6CiAgICAgICAgIF0K ICAgICAgICAgcmVhc29uID0gIkNhdXNlZCBidWlsZGVycyBGb28gYW5kIEJhciB0byBmYWlsLiIK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoYm90Ll9yb2xsb3V0X3JlYXNvbihidWlsZGVycyks IHJlYXNvbikKKworICAgIGRlZiB0ZXN0X3Bvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoc2VsZik6 CisgICAgICAgIGJvdCA9IFNoZXJpZmZCb3QoKQorICAgICAgICBib3QudG9vbCA9IE1vY2tUb29s KCkKKyAgICAgICAgYnVpbGRlcnMgPSBbCisgICAgICAgICAgICBCdWlsZGVyKCJGb28iLCBOb25l KSwKKyAgICAgICAgICAgIEJ1aWxkZXIoIkJhciIsIE5vbmUpLAorICAgICAgICBdCisgICAgICAg IGNvbW1pdF9pbmZvID0gTW9jaygpCisgICAgICAgIGNvbW1pdF9pbmZvLmJ1Z19pZCA9IGxhbWJk YTpOb25lCisgICAgICAgIGNvbW1pdF9pbmZvLnJldmlzaW9uID0gbGFtYmRhOjQzMjEKKyAgICAg ICAgIyBTaG91bGQgZG8gbm90aGluZyB3aXRoIG5vIGJ1Z19pZAorICAgICAgICBib3QuX3Bvc3Rf YmxhbWVfY29tbWVudF9vbl9idWcoY29tbWl0X2luZm8sIGJ1aWxkZXJzKQorICAgICAgICAjIFNo b3VsZCB0cnkgdG8gcG9zdCBhIGNvbW1lbnQgdG8gdGhlIGJ1ZywgYnV0IE1vY2tUb29sLmJ1Z3Mg ZG9lcyBub3RoaW5nLgorICAgICAgICBjb21taXRfaW5mby5idWdfaWQgPSBsYW1iZGE6MTIzNAor ICAgICAgICBib3QuX3Bvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoY29tbWl0X2luZm8sIGJ1aWxk ZXJzKQo=