36781 2010-03-29 13:55:56 -0700 [chromium] Enable fast/events/onbeforeunload-focused-iframe.html 2010-03-31 09:53:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 creis levin commit-queue levin oldest_to_newest 205657 0 creis 2010-03-29 13:55:56 -0700 The onbeforeunload-focused-iframe.html layout test was disabled for Chromium until TestShell's LayoutTestController was updated to support it. That's been fixed, so we can enable this test now. 206219 1 52091 sswigart 2010-03-30 15:41:18 -0700 Created attachment 52091 Proposed fix 206227 2 52091 levin 2010-03-30 15:58:45 -0700 Comment on attachment 52091 Proposed fix > diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog > + * platform/chromium/test_expectations.txt: Enable test now that callShouldCloseOnWebView > + is implemented in test_shell. This is great except for the TAB here. Please get rid of it and upload and I'll r+,cq+ it for you. 206236 3 52095 sswigart 2010-03-30 16:12:43 -0700 Created attachment 52095 Proposed fix, revision 2 206425 4 52095 commit-queue 2010-03-31 02:16:31 -0700 Comment on attachment 52095 Proposed fix, revision 2 Rejecting patch 52095 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: sts/platform/chromium/test_expectations.txt A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/1618107 206542 5 52179 sswigart 2010-03-31 09:14:55 -0700 Created attachment 52179 Proposed fix, revision 3 206555 6 52179 commit-queue 2010-03-31 09:53:25 -0700 Comment on attachment 52179 Proposed fix, revision 3 Clearing flags on attachment: 52179 Committed r56848: <http://trac.webkit.org/changeset/56848> 206556 7 commit-queue 2010-03-31 09:53:30 -0700 All reviewed patches have been landed. Closing bug. 52091 2010-03-30 15:41:18 -0700 2010-03-31 09:14:55 -0700 Proposed fix new_diff text/plain 1300 sswigart ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2YjU2NDM3Li5kNDYzNmJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MzAgIFN0ZXJsaW5nIFN3aWdhcnQgIDxzc3dpZ2FydEBnb29nbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIGZh c3QvZXZlbnRzL29uYmVmb3JldW5sb2FkLWZvY3VzZWQtaWZyYW1lLmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzgxCisJCisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OiBFbmFibGUgdGVzdCBub3cg dGhhdCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcKKwlpcyBpbXBsZW1lbnRlZCBpbiB0ZXN0X3No ZWxsLgorCiAyMDEwLTAzLTMwICBBZGFtIExhbmdsZXkgIDxhZ2xAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGRjZTk2NjYuLjE2ZWUy YjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVj dGF0aW9ucy50eHQKQEAgLTI4NDMsNyArMjg0Myw2IEBAIEJVR19KQVBIRVQgV0lOIDogaHR0cC90 ZXN0cy94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC01MG1zLWRvd25sb2FkLWRpc3BhdGNo CiBCVUdfMzk0MjMgOiBzZWN1cml0eS9ibG9jay10ZXN0Lmh0bWwgPSBUSU1FT1VUCiAKIEJVR1dL MzY2NjYgOiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sID0gVEVYVAotQlVH Mzk0ODUgOiBmYXN0L2V2ZW50cy9vbmJlZm9yZXVubG9hZC1mb2N1c2VkLWlmcmFtZS5odG1sID0g VElNRU9VVAogCiAvLyBOZWVkIHJlYmFzZWxpbmUuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NjEKIEJVR19IQU1BSkkgOiBmYXN0L3JlcGFpbnQvb3ZlcmZs b3ctc2Nyb2xsLWJvZHktYXBwZWFyLmh0bWwgPSBJTUFHRStURVhUIElNQUdFCg== 52095 2010-03-30 16:12:43 -0700 2010-03-31 09:14:55 -0700 Proposed fix, revision 2 new_diff text/plain 1307 sswigart ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2YjU2NDM3Li5kNDYzNmJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MzAgIFN0ZXJsaW5nIFN3aWdhcnQgIDxzc3dpZ2FydEBnb29nbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIGZh c3QvZXZlbnRzL29uYmVmb3JldW5sb2FkLWZvY3VzZWQtaWZyYW1lLmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzgxCisJCisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OiBFbmFibGUgdGVzdCBub3cg dGhhdCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcKKyAgICAgICAgaXMgaW1wbGVtZW50ZWQgaW4g dGVzdF9zaGVsbC4KKwogMjAxMC0wMy0zMCAgQWRhbSBMYW5nbGV5ICA8YWdsQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBkY2U5NjY2 Li4xNmVlMmIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CkBAIC0yODQzLDcgKzI4NDMsNiBAQCBCVUdfSkFQSEVUIFdJTiA6 IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3QtNTBtcy1kb3dubG9hZC1k aXNwYXRjaAogQlVHXzM5NDIzIDogc2VjdXJpdHkvYmxvY2stdGVzdC5odG1sID0gVElNRU9VVAog CiBCVUdXSzM2NjY2IDogc3RvcmFnZS9vcGVuLWRhdGFiYXNlLW92ZXItcXVvdGEuaHRtbCA9IFRF WFQKLUJVRzM5NDg1IDogZmFzdC9ldmVudHMvb25iZWZvcmV1bmxvYWQtZm9jdXNlZC1pZnJhbWUu aHRtbCA9IFRJTUVPVVQKIAogLy8gTmVlZCByZWJhc2VsaW5lLiBTZWUgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NDYxCiBCVUdfSEFNQUpJIDogZmFzdC9yZXBhaW50 L292ZXJmbG93LXNjcm9sbC1ib2R5LWFwcGVhci5odG1sID0gSU1BR0UrVEVYVCBJTUFHRQo= 52179 2010-03-31 09:14:55 -0700 2010-03-31 09:53:25 -0700 Proposed fix, revision 3 new_diff.txt text/plain 1306 sswigart ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2YjU2NDM3Li5kNDYzNmJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MzAgIFN0ZXJsaW5nIFN3aWdhcnQgIDxzc3dpZ2FydEBnb29nbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIGZh c3QvZXZlbnRzL29uYmVmb3JldW5sb2FkLWZvY3VzZWQtaWZyYW1lLmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzgxCisKKyAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6IEVuYWJsZSB0ZXN0IG5vdyB0 aGF0IGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldworICAgICAgICBpcyBpbXBsZW1lbnRlZCBpbiB0 ZXN0X3NoZWxsLgorCiAyMDEwLTAzLTMwICBBZGFtIExhbmdsZXkgIDxhZ2xAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGRjZTk2NjYu LjE2ZWUyYjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKQEAgLTI4NDMsNyArMjg0Myw2IEBAIEJVR19KQVBIRVQgV0lOIDog aHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC01MG1zLWRvd25sb2FkLWRp c3BhdGNoCiBCVUdfMzk0MjMgOiBzZWN1cml0eS9ibG9jay10ZXN0Lmh0bWwgPSBUSU1FT1VUCiAK IEJVR1dLMzY2NjYgOiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utb3Zlci1xdW90YS5odG1sID0gVEVY VAotQlVHMzk0ODUgOiBmYXN0L2V2ZW50cy9vbmJlZm9yZXVubG9hZC1mb2N1c2VkLWlmcmFtZS5o dG1sID0gVElNRU9VVAogCiAvLyBOZWVkIHJlYmFzZWxpbmUuIFNlZSBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY0NjEKIEJVR19IQU1BSkkgOiBmYXN0L3JlcGFpbnQv b3ZlcmZsb3ctc2Nyb2xsLWJvZHktYXBwZWFyLmh0bWwgPSBJTUFHRStURVhUIElNQUdFCg==