<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36757</bug_id>
          
          <creation_ts>2010-03-29 08:22:54 -0700</creation_ts>
          <short_desc>[Qt] Custom user agent for user agent switcher</short_desc>
          <delta_ts>2010-04-06 02:26:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>35784</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego Gonzalez">diegohcg</reporter>
          <assigned_to name="Diego Gonzalez">diegohcg</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>hausmann</cc>
    
    <cc>kenneth</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>205450</commentid>
    <comment_count>0</comment_count>
    <who name="Diego Gonzalez">diegohcg</who>
    <bug_when>2010-03-29 08:22:54 -0700</bug_when>
    <thetext>Make possible to a add a custom user agent just editing the user agent combo
in the user agent switcher dialog. The user agent submitted will be stored as
as custom user agent</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>205454</commentid>
    <comment_count>1</comment_count>
      <attachid>51915</attachid>
    <who name="Diego Gonzalez">diegohcg</who>
    <bug_when>2010-03-29 08:36:49 -0700</bug_when>
    <thetext>Created attachment 51915
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>206483</commentid>
    <comment_count>2</comment_count>
      <attachid>51915</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-31 07:26:27 -0700</bug_when>
    <thetext>Comment on attachment 51915
Proposed patch

Clearing flags on attachment: 51915

Committed r56838: &lt;http://trac.webkit.org/changeset/56838&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>206484</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-31 07:26:32 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>208951</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-06 02:26:19 -0700</bug_when>
    <thetext>Revision r56838 cherry-picked into qtwebkit-2.0 with commit bbec5e8b5103786bb9ffa4e749136862c26487fb</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>51915</attachid>
            <date>2010-03-29 08:36:49 -0700</date>
            <delta_ts>2010-03-31 07:26:27 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>0001-Qt-Custom-user-agent-for-user-agent-switcher.diff</filename>
            <type>text/plain</type>
            <size>2697</size>
            <attacher name="Diego Gonzalez">diegohcg</attacher>
            
              <data encoding="base64">RnJvbSAwZWVkNmZmMzI4ZWM4NGNkNTQ5YTE4NWJmZGYxMWVhNTI5NDg2MGUwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ28uZ29uemFsZXpAb3BlbmJv
c3NhLm9yZz4KRGF0ZTogTW9uLCAyOSBNYXIgMjAxMCAxMTozNDoxNyAtMDQwMApTdWJqZWN0OiBb
UEFUQ0hdIFtRdF0gQ3VzdG9tIHVzZXIgYWdlbnQgZm9yIHVzZXIgYWdlbnQgc3dpdGNoZXIKIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjc1NwoKUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCgoqIFF0TGF1bmNoZXIvbWFpbi5jcHA6CihMYXVuY2hlcldpbmRvdzo6
c2hvd1VzZXJBZ2VudERpYWxvZyk6Ci0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAg
ICB8ICAgMTAgKysrKysrKysrKwogV2ViS2l0VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcCB8ICAg
MTQgKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMSBk
ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRU
b29scy9DaGFuZ2VMb2cKaW5kZXggMTIzYWQ5Mi4uMWMxYTI3NyAxMDA2NDQKLS0tIGEvV2ViS2l0
VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDEwLTAzLTI5ICBEaWVnbyBHb256YWxleiAgPGRpZWdvLmdvbnphbGV6QG9wZW5ib3Nz
YS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
W1F0XSBDdXN0b20gdXNlciBhZ2VudCBmb3IgdXNlciBhZ2VudCBzd2l0Y2hlcgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY3NTcKKworICAgICAgICAq
IFF0TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6c2hvd1VzZXJB
Z2VudERpYWxvZyk6CisKIDIwMTAtMDMtMjggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bn
bm9tZS5vcmc+CiAKICAgICAgICAgTm8gcmV2aWV3LCByb2xsaW5nIG91dCByNTY2NzkuCmRpZmYg
LS1naXQgYS9XZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwIGIvV2ViS2l0VG9vbHMvUXRM
YXVuY2hlci9tYWluLmNwcAppbmRleCA2Njc3NjM3Li5lM2QxODM3IDEwMDY0NAotLS0gYS9XZWJL
aXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCisrKyBiL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIv
bWFpbi5jcHAKQEAgLTcyNSw2ICs3MjUsMTEgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6c2hvd1Vz
ZXJBZ2VudERpYWxvZygpCiAgICAgICAgIGZpbGUuY2xvc2UoKTsKICAgICB9CiAKKyAgICBRU2V0
dGluZ3Mgc2V0dGluZ3M7CisgICAgUVN0cmluZyBjdXN0b21Vc2VyQWdlbnQgPSBzZXR0aW5ncy52
YWx1ZSgiQ3VzdG9tVXNlckFnZW50IikudG9TdHJpbmcoKTsKKyAgICBpZiAoIWl0ZW1zLmNvbnRh
aW5zKGN1c3RvbVVzZXJBZ2VudCkgJiYgIWN1c3RvbVVzZXJBZ2VudC5pc0VtcHR5KCkpCisgICAg
ICAgIGl0ZW1zIDw8IGN1c3RvbVVzZXJBZ2VudDsKKwogICAgIFFEaWFsb2cqIGRpYWxvZyA9IG5l
dyBRRGlhbG9nKHRoaXMpOwogICAgIGRpYWxvZy0+c2V0V2luZG93VGl0bGUoIkNoYW5nZSBVc2Vy
IEFnZW50Iik7CiAKQEAgLTczMywxNyArNzM4LDI0IEBAIHZvaWQgTGF1bmNoZXJXaW5kb3c6OnNo
b3dVc2VyQWdlbnREaWFsb2coKQogCiAgICAgUUNvbWJvQm94KiBjb21ibyA9IG5ldyBRQ29tYm9C
b3goZGlhbG9nKTsKICAgICBjb21iby0+c2V0TWF4aW11bVdpZHRoKHNpemUoKS53aWR0aCgpICog
MC43KTsKKyAgICBjb21iby0+c2V0RWRpdGFibGUodHJ1ZSk7CiAgICAgY29tYm8tPmluc2VydEl0
ZW1zKDAsIGl0ZW1zKTsKICAgICBsYXlvdXQtPmFkZFdpZGdldChjb21ibyk7CiAKKyAgICBpbnQg
aW5kZXggPSBjb21iby0+ZmluZFRleHQocGFnZSgpLT51c2VyQWdlbnRGb3JVcmwoUVVybCgpKSk7
CisgICAgY29tYm8tPnNldEN1cnJlbnRJbmRleChpbmRleCk7CisKICAgICBRRGlhbG9nQnV0dG9u
Qm94KiBidXR0b25Cb3ggPSBuZXcgUURpYWxvZ0J1dHRvbkJveChRRGlhbG9nQnV0dG9uQm94OjpP
awogICAgICAgICAgICAgfCBRRGlhbG9nQnV0dG9uQm94OjpDYW5jZWwsIFF0OjpIb3Jpem9udGFs
LCBkaWFsb2cpOwogICAgIGNvbm5lY3QoYnV0dG9uQm94LCBTSUdOQUwoYWNjZXB0ZWQoKSksIGRp
YWxvZywgU0xPVChhY2NlcHQoKSkpOwogICAgIGNvbm5lY3QoYnV0dG9uQm94LCBTSUdOQUwocmVq
ZWN0ZWQoKSksIGRpYWxvZywgU0xPVChyZWplY3QoKSkpOwogICAgIGxheW91dC0+YWRkV2lkZ2V0
KGJ1dHRvbkJveCk7CiAKLSAgICBpZiAoZGlhbG9nLT5leGVjKCkgJiYgIWNvbWJvLT5jdXJyZW50
VGV4dCgpLmlzRW1wdHkoKSkKKyAgICBpZiAoZGlhbG9nLT5leGVjKCkgJiYgIWNvbWJvLT5jdXJy
ZW50VGV4dCgpLmlzRW1wdHkoKSkgewogICAgICAgICBwYWdlKCktPnNldFVzZXJBZ2VudChjb21i
by0+Y3VycmVudFRleHQoKSk7CisgICAgICAgIGlmICghaXRlbXMuY29udGFpbnMoY29tYm8tPmN1
cnJlbnRUZXh0KCkpKQorICAgICAgICAgICAgc2V0dGluZ3Muc2V0VmFsdWUoIkN1c3RvbVVzZXJB
Z2VudCIsIGNvbWJvLT5jdXJyZW50VGV4dCgpKTsKKyAgICB9CiAKICAgICBkZWxldGUgZGlhbG9n
OwogfQotLSAKMS42LjMuMwoK
</data>

          </attachment>
      

    </bug>

</bugzilla>