36756 2010-03-29 07:44:22 -0700 [Qt] unit tests don't compile inside of Qt 2010-03-29 07:52:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All CLOSED FIXED Qt P2 Major --- 35784 1 hausmann hausmann oldest_to_newest 205433 0 hausmann 2010-03-29 07:44:22 -0700 The current unit tests don't compile inside of Qt. * tests.pri adds a tst prefix to all unit tests. qttest_p4.prf does the same thing, so we end up with tst_tst_qwebpage. This can be fixed by omitting the substitution for QTDIR builds. * tests.pri adds $$_PRO_FILE_PWD_/foo.cpp to SOURCES. For builds inside Qt the .pro file is separate and the sources are pulled in using VPATH. By adding $$_PRO_FILE_PWD_ to the VPATH we can use a relative name, so that for trunk builds tst_qwebpage.cpp is found in WebKit/qt/tests/qwebpage and for builds inside Qt, too, through VPATH. 205434 1 51908 hausmann 2010-03-29 07:46:08 -0700 Created attachment 51908 Patch 205435 2 hausmann 2010-03-29 07:49:34 -0700 Committed r56721: <http://trac.webkit.org/changeset/56721> 205436 3 hausmann 2010-03-29 07:52:05 -0700 Revision r56721 cherry-picked into qtwebkit-2.0 with commit d7edf81626b61240f3fe37f1742cf85d93760110 51908 2010-03-29 07:46:08 -0700 2010-03-29 07:47:41 -0700 Patch bug-36756-20100329164605.patch text/plain 1076 hausmann ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDEyNjMyYWQuLjJjMGZhZWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTAzLTI5ICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIHVuaXQgdGVzdHMgZG9uJ3QgY29t cGlsZSBpbnNpZGUgb2YgUXQKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzY3NTYKKworICAgICAgICAqIHRlc3RzL3Rlc3RzLnByaTogRG9uJ3QgZG8g dGhlIHRhcmdldCBzdWJzdGl0dXRpb24gaW5zaWRlIFF0IGFuZCBmaW5kIHRoZSBzb3VyY2VzCisg ICAgICAgIHRocm91Z2ggVlBBVEggaW5zdGVhZCBvZiByZWx5aW5nIG9uIHRoZSBsb2NhdGlvbiBv ZiB0aGUgLnBybyBmaWxlIGV4Y2x1c2l2ZWx5LgorCiAyMDEwLTAzLTI2ICBLZW5uZXRoIFJvaGRl IENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy90ZXN0cy5wcmkg Yi9XZWJLaXQvcXQvdGVzdHMvdGVzdHMucHJpCmluZGV4IDE4Nzk1MGEuLjBiZGY2ZjYgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy90ZXN0cy5wcmkKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3Rl c3RzLnByaQpAQCAtMSw4ICsxLDkgQEAKIFRFTVBMQVRFID0gYXBwCiBDT05GSUcgLT0gYXBwX2J1 bmRsZQogCi1UQVJHRVQgPSB0c3RfJCRUQVJHRVQKLVNPVVJDRVMgKz0gJCRfUFJPX0ZJTEVfUFdE Xy8kJHtUQVJHRVR9LmNwcAorVlBBVEggKz0gJCRfUFJPX0ZJTEVfUFdEXworIUNPTkZJRyhRVERJ Ul9idWlsZCk6VEFSR0VUID0gdHN0XyQkVEFSR0VUCitTT1VSQ0VTICs9ICQke1RBUkdFVH0uY3Bw CiBJTkNMVURFUEFUSCArPSBcCiAgICAgJCRQV0QgXAogICAgICQkUFdELy4uL0FwaQo=